Refactor domain transfer

This commit is contained in:
Martin Lensment 2015-03-10 15:53:51 +02:00
parent d88364a926
commit 4c4488c303
2 changed files with 19 additions and 44 deletions

View file

@ -56,25 +56,26 @@ class Epp::DomainsController < EppController
def transfer
authorize! :transfer, @domain, @password
action = params[:parsed_frame].css('transfer').first[:op]
if domain_transfer_params[:action] == 'query'
if action == 'query'
if @domain.pending_transfer
@domain_transfer = @domain.pending_transfer
else
@domain_transfer = @domain.query_transfer(domain_transfer_params, params[:parsed_frame])
@domain_transfer = @domain.query_transfer(params[:parsed_frame], current_user)
handle_errors(@domain) and return unless @domain_transfer
end
elsif domain_transfer_params[:action] == 'approve'
elsif action == 'approve'
if @domain.pending_transfer
@domain_transfer = @domain.approve_transfer(domain_transfer_params, params[:parsed_frame])
@domain_transfer = @domain.approve_transfer(params[:parsed_frame], current_user)
handle_errors(@domain) and return unless @domain_transfer
else
epp_errors << { code: '2303', msg: I18n.t('pending_transfer_was_not_found') }
handle_errors(@domain) and return
end
elsif domain_transfer_params[:action] == 'reject'
elsif action == 'reject'
if @domain.pending_transfer
@domain_transfer = @domain.reject_transfer(domain_transfer_params, params[:parsed_frame])
@domain_transfer = @domain.reject_transfer(params[:parsed_frame], current_user)
handle_errors(@domain) and return unless @domain_transfer
else
epp_errors << { code: '2303', msg: I18n.t('pending_transfer_was_not_found') }
@ -159,14 +160,6 @@ class Epp::DomainsController < EppController
requires 'name'
end
def domain_transfer_params
res = {}
res[:pw] = params[:parsed_frame].css('pw').first.try(:text)
res[:action] = params[:parsed_frame].css('transfer').first[:op]
res[:current_user] = current_user
res
end
def find_domain
domain_name = params[:parsed_frame].css('name').text.strip.downcase
@domain = Epp::Domain.find_by(name: domain_name)