Optimize contact linked status update #2477

app/models/contact.rb

@@ -260,21 +260,11 @@ class Contact < ActiveRecord::Base
     Country.new(country_code)
   end
 
-  # Find a way to use self.domains with contact
-  def domains_owned
-    Domain.where(registrant_id: id)
-  end
-
-  def relations_with_domain?
-    return true if domain_contacts.present? || domains_owned.present?
-    false
-  end
-
   # TODO: refactor, it should not allow to destroy with normal destroy,
   # no need separate method
   # should use only in transaction
   def destroy_and_clean
-    if relations_with_domain?
+    if domains_present?
       errors.add(:domains, :exist)
       return false
     end
@@ -316,14 +306,34 @@ class Contact < ActiveRecord::Base
     end
   end
 
+  # optimization under children loop, 
+  # otherwise bullet will not be happy
+  def domains_present?
+    return @domains_present if @domains_present
+    domain_contacts.present? || registrant_domains.present?
+  end
+
+  # for overwrite when doing children loop
+  def domains_present=(boolean)
+    @domains_present = boolean
+  end
+
   def manage_linked
-    if domains.present?
-      statuses << LINKED if statuses.detect { |s| s == LINKED }.blank?
+    if domains_present?
+      set_linked
     else
-      statuses.delete_if { |s| s == LINKED }
+      unset_linked
     end
   end
 
+  def set_linked
+    statuses << LINKED if statuses.detect { |s| s == LINKED }.blank?
+  end
+
+  def unset_linked
+    statuses.delete_if { |s| s == LINKED }
+  end
+
   # rubocop:disable Metrics/CyclomaticComplexity
   def manage_ok
     return unset_ok unless valid?

app/models/epp/domain.rb

@@ -16,10 +16,20 @@ class Epp::Domain < Domain
     false
   end
 
-  before_save :update_contact_status
-  def update_contact_status
-    contacts.each do |c|
-      next if c.linked?
+  before_save :link_contacts
+  def link_contacts
+    # Based on bullet report
+    unlinked_contacts = contacts.select { |c| !c.linked? } # speed up a bit
+    unlinked_contacts.each do |uc|
+      uc.domains_present = true # no need to fetch domains again
+      uc.save(validate: false)
+    end
+  end
+
+  after_destroy :unlink_contacts
+  def unlink_contacts
+    contacts.each do |c| 
+      c.domains_present = false
       c.save(validate: false)
     end
   end