From 47d143e6ccc57a887848be549d5590321ee0efc0 Mon Sep 17 00:00:00 2001 From: Alex Sherman Date: Thu, 11 Feb 2021 15:20:57 +0500 Subject: [PATCH] Undo removing serverUpdateProhibited status on domain renew --- app/models/epp/domain.rb | 1 - .../repp/v1/domains/bulk_renew_test.rb | 23 +++++++++++++++++++ 2 files changed, 23 insertions(+), 1 deletion(-) diff --git a/app/models/epp/domain.rb b/app/models/epp/domain.rb index ad96adc64..f280eb160 100644 --- a/app/models/epp/domain.rb +++ b/app/models/epp/domain.rb @@ -612,7 +612,6 @@ class Epp::Domain < Domain statuses.delete(DomainStatus::SERVER_HOLD) statuses.delete(DomainStatus::EXPIRED) - statuses.delete(DomainStatus::SERVER_UPDATE_PROHIBITED) cancel_pending_delete save diff --git a/test/integration/repp/v1/domains/bulk_renew_test.rb b/test/integration/repp/v1/domains/bulk_renew_test.rb index 4cec91914..46e2fbf7d 100644 --- a/test/integration/repp/v1/domains/bulk_renew_test.rb +++ b/test/integration/repp/v1/domains/bulk_renew_test.rb @@ -37,6 +37,29 @@ class ReppV1DomainsBulkRenewTest < ActionDispatch::IntegrationTest end end + def test_keeps_update_prohibited_status + domain = domains(:shop) + domain.update(statuses: [DomainStatus::CLIENT_UPDATE_PROHIBITED, DomainStatus::SERVER_UPDATE_PROHIBITED]) + payload = { + "domains": [ + 'shop.test' + ], + "renew_period": "1y" + } + + assert_changes -> { Domain.find_by(name: 'shop.test').valid_to } do + post "/repp/v1/domains/renew/bulk", headers: @auth_headers, params: payload + json = JSON.parse(response.body, symbolize_names: true) + + assert_response :ok + assert_equal 1000, json[:code] + assert_equal 'Command completed successfully', json[:message] + assert json[:data][:updated_domains].include? 'shop.test' + end + domain.reload + assert_equal domain.statuses, [DomainStatus::CLIENT_UPDATE_PROHIBITED, DomainStatus::SERVER_UPDATE_PROHIBITED] + end + def test_throws_error_when_domain_not_renewable payload = { "domains": [