From 438a2e05ab949ba5751851be199b733e078c9c7d Mon Sep 17 00:00:00 2001
From: Alex Sherman <yul.golem@gmail.com>
Date: Wed, 10 Jun 2020 13:27:54 +0500
Subject: [PATCH] Add test for email verification job

---
 app/jobs/verify_emails_job.rb       |  7 +++-
 test/fixtures/contacts.yml          |  8 ++++
 test/jobs/verify_emails_job_test.rb | 59 +++++++++++++++++++++++++++++
 3 files changed, 73 insertions(+), 1 deletion(-)
 create mode 100644 test/jobs/verify_emails_job_test.rb

diff --git a/app/jobs/verify_emails_job.rb b/app/jobs/verify_emails_job.rb
index 4da854870..a0d7234c5 100644
--- a/app/jobs/verify_emails_job.rb
+++ b/app/jobs/verify_emails_job.rb
@@ -2,6 +2,11 @@ class VerifyEmailsJob < Que::Job
   def run(verification_id)
     email_address_verification = run_condition(EmailAddressVerification.find(verification_id))
 
+    if email_address_verification.recently_verified?
+      destroy
+      return
+    end
+
     ActiveRecord::Base.transaction do
       email_address_verification.verify
       log_success(email_address_verification)
@@ -22,7 +27,7 @@ class VerifyEmailsJob < Que::Job
   end
 
   def logger
-    Rails.logger = Logger.new(STDOUT)
+    Rails.logger
   end
 
   def log_success(verification)
diff --git a/test/fixtures/contacts.yml b/test/fixtures/contacts.yml
index ddfbfe93f..0173d56dd 100644
--- a/test/fixtures/contacts.yml
+++ b/test/fixtures/contacts.yml
@@ -85,3 +85,11 @@ invalid:
   auth_info: any
   registrar: bestnames
   uuid: bd80c0f9-26ee-49e0-a2cb-2311d931c433
+
+invalid_email:
+  name: any
+  code: invalid_email
+  email: invalid@invalid.
+  auth_info: any
+  registrar: bestnames
+  uuid: fa8c4f51-a221-4628-b3c6-47995f4edea3
diff --git a/test/jobs/verify_emails_job_test.rb b/test/jobs/verify_emails_job_test.rb
new file mode 100644
index 000000000..f55a474db
--- /dev/null
+++ b/test/jobs/verify_emails_job_test.rb
@@ -0,0 +1,59 @@
+require "test_helper"
+
+class VerifyEmailsJobTest < ActiveSupport::TestCase
+  def setup
+    @contact = contacts(:john)
+    @invalid_contact = contacts(:invalid_email)
+    @contact_verification = @contact.email_verification
+    @invalid_contact_verification = @invalid_contact.email_verification
+
+    @default_whitelist = Truemail.configure.whitelisted_domains
+    @default_blacklist = Truemail.configure.blacklisted_domains
+    Truemail.configure.whitelisted_domains = whitelisted_domains
+    Truemail.configure.blacklisted_domains = blacklisted_domains
+  end
+
+  def teardown
+    Truemail.configure.whitelisted_domains = @default_whitelist
+    Truemail.configure.blacklisted_domains = @default_blacklist
+  end
+
+  def domain(email)
+    Mail::Address.new(email).domain
+  rescue Mail::Field::IncompleteParseError
+    nil
+  end
+
+  def whitelisted_domains
+    [domain(@contact.email)].reject(&:blank?)
+  end
+
+  def blacklisted_domains
+    [domain(@invalid_contact.email)].reject(&:blank?)
+  end
+
+  def test_job_checks_if_email_valid
+    VerifyEmailsJob.run(@contact_verification.id)
+    @contact_verification.reload
+
+    assert @contact_verification.success
+  end
+
+  def test_job_checks_does_not_run_if_recent
+    old_verified_at = Time.zone.now - 10.days
+    @contact_verification.update(success: true, verified_at: old_verified_at)
+    assert @contact_verification.recently_verified?
+
+    VerifyEmailsJob.run(@contact_verification.id)
+    @contact_verification.reload
+
+    assert_in_delta @contact_verification.verified_at.to_i, old_verified_at.to_i, 1
+  end
+
+  def test_job_checks_if_email_invalid
+    VerifyEmailsJob.run(@invalid_contact_verification.id)
+    @contact_verification.reload
+
+    refute @contact_verification.success
+  end
+end