From 42323014844e9e92eb43cb961fc2a014078fd64b Mon Sep 17 00:00:00 2001 From: Artur Beljajev Date: Thu, 25 Jan 2018 16:45:00 +0200 Subject: [PATCH] Make domain list CSV filename more user-friendly #660 --- app/controllers/registrar/domains_controller.rb | 3 ++- test/integration/registrar/domains_test.rb | 3 +++ 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/app/controllers/registrar/domains_controller.rb b/app/controllers/registrar/domains_controller.rb index 78a5b24b6..b85923a02 100644 --- a/app/controllers/registrar/domains_controller.rb +++ b/app/controllers/registrar/domains_controller.rb @@ -52,7 +52,8 @@ class Registrar end csv = Registrar::DomainListCSVPresenter.new(domains: domain_presenters, view: view_context).to_s - send_data(csv) + filename = "Domains_#{l(Time.zone.now, format: :filename)}.csv" + send_data(csv, filename: filename) end end end diff --git a/test/integration/registrar/domains_test.rb b/test/integration/registrar/domains_test.rb index c683cce86..c24560bad 100644 --- a/test/integration/registrar/domains_test.rb +++ b/test/integration/registrar/domains_test.rb @@ -6,6 +6,8 @@ class RegistrarDomainsTest < ActionDispatch::IntegrationTest end def test_downloads_domain_list_as_csv + travel_to Time.zone.parse('2010-07-05 10:30') + expected_csv = <<-CSV.strip_heredoc Domain,Transfer code,Registrant name,Registrant code,Date of expiry library.test,45118f5,Acme Ltd,acme-ltd-001,2010-07-05 @@ -15,6 +17,7 @@ class RegistrarDomainsTest < ActionDispatch::IntegrationTest visit registrar_domains_url click_button 'Download as CSV' + assert_equal 'attachment; filename="Domains_2010-07-05_10.30.csv"', response_headers['Content-Disposition'] assert_equal expected_csv, page.body end