zydronium/internetee-registry
1
0
Fork 0
mirror of https://github.com/internetee/registry.git synced 2025-08-01 07:26:22 +02:00
Code Issues Projects Releases Packages Wiki Activity

Fixed codeclimate errors

Browse source
This commit is contained in:
Sergei Tsõganov 2022-06-06 16:24:38 +03:00
parent 7c570e2916
commit 3812e398bf
2 changed files with 12 additions and 18 deletions
Download patch file Download diff file Expand all files Collapse all files

28
app/controllers/repp/v1/registrar/summary_controller.rb
View file

@ -12,7 +12,6 @@ module Repp
user_notifications = user.unread_notifications
notification = user_notifications.order('created_at DESC').take
end
render_success(data: serialize_data(registrar: registrar,
notification: notification,
notifications_count: user_notifications&.count,
@ -45,23 +44,18 @@ module Repp
# rubocop:disable Style/RescueStandardError
def notification_object(notification)
return unless notification
return unless notification&.attached_obj_type || notification&.attached_obj_id
return unless notification.attached_obj_type || notification.attached_obj_id
begin
object_by_type(notification.attached_obj_type)
.find(notification.attached_obj_id)
rescue => e
# the data model might be inconsistent; or ...
# this could happen if the registrar does not dequeue messages,
# and then the domain was deleted
# SELECT messages.id, domains.name, messages.body FROM messages LEFT OUTER
# JOIN domains ON attached_obj_id::INTEGER = domains.id
# WHERE attached_obj_type = 'Epp::Domain' AND name IS NULL;
message = 'orphan message, domain deleted, registrar should dequeue: '
Rails.logger.error message + e.to_s
end
object_by_type(notification.attached_obj_type).find(notification.attached_obj_id)
rescue => e
# the data model might be inconsistent; or ...
# this could happen if the registrar does not dequeue messages,
# and then the domain was deleted
# SELECT messages.id, domains.name, messages.body FROM messages LEFT OUTER
# JOIN domains ON attached_obj_id::INTEGER = domains.id
# WHERE attached_obj_type = 'Epp::Domain' AND name IS NULL;
message = 'orphan message, domain deleted, registrar should dequeue: '
Rails.logger.error message + e.to_s
end
# rubocop:enable Style/RescueStandardError

2
lib/serializers/repp/invoice.rb
View file

@ -37,7 +37,7 @@ module Serializers
address: invoice.seller_address, country: invoice.seller_country.name,
phone: invoice.seller_phone, url: invoice.seller_url,
email: invoice.seller_email,
contact_name: invoice.seller_contact_name,
contact_name: invoice.seller_contact_name
}
end