From 31ea0f9182c74d4c92d866883bbfb12611b1faab Mon Sep 17 00:00:00 2001
From: Martin Lensment <mlensment@gmail.com>
Date: Thu, 28 Aug 2014 14:00:08 +0300
Subject: [PATCH] Transfer authentication test

---
 spec/epp/domain_spec.rb                | 14 ++++++++------
 spec/epp/epp_helper_spec.rb            |  1 -
 spec/epp/requests/domains/transfer.xml | 15 ---------------
 spec/models/domain_spec.rb             |  2 +-
 4 files changed, 9 insertions(+), 23 deletions(-)
 delete mode 100644 spec/epp/requests/domains/transfer.xml

diff --git a/spec/epp/domain_spec.rb b/spec/epp/domain_spec.rb
index 862d1ed3a..950ec4904 100644
--- a/spec/epp/domain_spec.rb
+++ b/spec/epp/domain_spec.rb
@@ -42,7 +42,7 @@ describe 'EPP Domain', epp: true do
       end
 
       it 'transfers a domain' do
-        response = epp_request('domains/transfer.xml')
+        response = epp_request(domain_transfer_xml, :xml)
 
         d = Domain.first
         dtl = d.domain_transfers.last
@@ -59,7 +59,7 @@ describe 'EPP Domain', epp: true do
         s = Setting.find_by(code: 'transfer_wait_time')
         s.update(value: 1)
 
-        response = epp_request('domains/transfer.xml')
+        response = epp_request(domain_transfer_xml, :xml)
         trn_data = response[:parsed].css('trnData')
         d = Domain.first
 
@@ -67,25 +67,27 @@ describe 'EPP Domain', epp: true do
         expect(trn_data.css('trStatus').text).to eq('pending')
         expect(trn_data.css('reID').text).to eq('10577829')
         expect(trn_data.css('reDate').text).to eq(dtl.transfer_requested_at.to_time.utc.to_s)
+        req_time = dtl.transfer_requested_at.to_time.utc.to_s
         expect(trn_data.css('acID').text).to eq('10577829')
         expect(trn_data.css('exDate').text).to eq(d.valid_to.to_time.utc.to_s)
 
         # should return same data if pending already
-        response = epp_request('domains/transfer.xml')
+        response = epp_request(domain_transfer_xml, :xml)
         trn_data = response[:parsed].css('trnData')
         d = Domain.first
 
         expect(trn_data.css('name').text).to eq('example.ee')
         expect(trn_data.css('trStatus').text).to eq('pending')
         expect(trn_data.css('reID').text).to eq('10577829')
-        expect(trn_data.css('reDate').text).to eq(dtl.transfer_requested_at.to_time.utc.to_s)
+        expect(trn_data.css('reDate').text).to eq(req_time)
         expect(trn_data.css('acID').text).to eq('10577829')
         expect(trn_data.css('exDate').text).to eq(d.valid_to.to_time.utc.to_s)
       end
 
       it 'does not transfer with invalid pw' do
-        response = epp_request('domains/transfer.xml')
-
+        response = epp_request(domain_transfer_xml(pw: 'test'), :xml)
+        expect(response[:result_code]).to eq('2200')
+        expect(response[:msg]).to eq('Authentication error')
       end
     end
 
diff --git a/spec/epp/epp_helper_spec.rb b/spec/epp/epp_helper_spec.rb
index 61d237688..f4bcbc35f 100644
--- a/spec/epp/epp_helper_spec.rb
+++ b/spec/epp/epp_helper_spec.rb
@@ -297,7 +297,6 @@ describe 'EPP Helper', epp: true do
       generated = Nokogiri::XML(domain_transfer_xml).to_s.squish
       expect(generated).to eq(expected)
 
-
       expected = Nokogiri::XML('<?xml version="1.0" encoding="UTF-8" standalone="no"?>
         <epp xmlns="urn:ietf:params:xml:ns:epp-1.0">
           <command>
diff --git a/spec/epp/requests/domains/transfer.xml b/spec/epp/requests/domains/transfer.xml
deleted file mode 100644
index 45453f4e7..000000000
--- a/spec/epp/requests/domains/transfer.xml
+++ /dev/null
@@ -1,15 +0,0 @@
-<?xml version="1.0" encoding="UTF-8" standalone="no"?>
-<epp xmlns="urn:ietf:params:xml:ns:epp-1.0">
-  <command>
-    <transfer op="query">
-      <domain:transfer
-       xmlns:domain="urn:ietf:params:xml:ns:domain-1.0">
-        <domain:name>example.ee</domain:name>
-        <domain:authInfo>
-          <domain:pw roid="JD1234-REP">98oiewslkfkd</domain:pw>
-        </domain:authInfo>
-      </domain:transfer>
-    </transfer>
-    <clTRID>ABC-12345</clTRID>
-  </command>
-</epp>
diff --git a/spec/models/domain_spec.rb b/spec/models/domain_spec.rb
index 7259d615b..1bcd65772 100644
--- a/spec/models/domain_spec.rb
+++ b/spec/models/domain_spec.rb
@@ -46,7 +46,7 @@ describe Domain do
         name: ['is missing'],
         period: ['is not a number'],
         owner_contact: ['Registrant is missing'],
-        admin_contacts: ['Admin contact is missing'],
+        admin_contacts: ['Admin contacts count must be between 1 - infinity'],
         nameservers: ['Nameservers count must be between 1-13']
       })