zydronium/internetee-registry
1
0
Fork 0
mirror of https://github.com/internetee/registry.git synced 2025-06-11 07:04:47 +02:00
Code Issues Projects Releases Packages Wiki Activity

Fix possible doubling of contact objects after race

Browse source
This commit is contained in:
Alex Sherman 2020-06-22 15:03:48 +05:00
parent a1b39740e7
commit 2fdc487511
4 changed files with 2232 additions and 41 deletions
Download patch file Download diff file Expand all files Collapse all files

2
test/models/contact_test.rb
View file

@ -177,7 +177,7 @@ class ContactTest < ActiveSupport::TestCase
def test_linked_when_in_use_as_domain_contact
Domain.update_all(registrant_id: contacts(:william).id)
DomainContact.update_all(contact_id: @contact.id)
DomainContact.first.update(contact_id: @contact.id)
assert @contact.linked?
end

12
test/models/domain_test.rb
View file

@ -137,9 +137,9 @@ class DomainTest < ActiveSupport::TestCase
contact = contacts(:john)
domain.admin_contacts << contact
domain.admin_contacts << contact
assert domain.invalid?
assert_raise ActiveRecord::RecordNotUnique do
domain.admin_contacts << contact
end
end
def test_invalid_when_the_same_tech_contact_is_linked_twice
@ -147,9 +147,9 @@ class DomainTest < ActiveSupport::TestCase
contact = contacts(:john)
domain.tech_contacts << contact
domain.tech_contacts << contact
assert domain.invalid?
assert_raise ActiveRecord::RecordNotUnique do
domain.tech_contacts << contact
end
end
def test_validates_name_server_count_when_name_servers_are_required