zydronium/internetee-registry
1
0
Fork 0
mirror of https://github.com/internetee/registry.git synced 2025-07-20 17:55:55 +02:00
Code Issues Projects Releases Packages Wiki Activity

Migrate fabricators to factory bot factories (#626)

Browse source 
* Remove factory_girl include from dev rake task

No longer needed after 92b125b4a7

* Add missing factories

* Use FactoryBot factories instead of fabricators

* Remove all fabricators

* Remove unused method

* Remove fabrication gem

* Rename FactoryGirl to FactoryBot

https://robots.thoughtbot.com/factory_bot
This commit is contained in:
Artur Beljajev 2017-11-16 10:18:53 +02:00 • committed by Georg
parent acfe0552fc
commit 2da578a437
88 changed files with 356 additions and 610 deletions
Download patch file Download diff file Expand all files Collapse all files

32
spec/models/nameserver_spec.rb
View file

@ -21,7 +21,7 @@ describe Nameserver do
Setting.client_side_status_editing_enabled = true
Fabricate(:zone, origin: 'ee')
create(:zone, origin: 'ee')
end
context 'with invalid attribute' do
@ -36,7 +36,7 @@ describe Nameserver do
context 'with valid attributes' do
before :example do
@nameserver = Fabricate(:nameserver)
@nameserver = create(:nameserver)
end
it 'should be valid' do
@ -45,7 +45,7 @@ describe Nameserver do
end
it 'should be valid twice' do
@nameserver = Fabricate(:nameserver)
@nameserver = create(:nameserver)
@nameserver.valid?
@nameserver.errors.full_messages.should match_array([])
end
@ -62,23 +62,23 @@ describe Nameserver do
context 'with many nameservers' do
before :example do
@api_user = Fabricate(:api_user)
@domain_1 = Fabricate(:domain, nameservers: [
Fabricate(:nameserver, hostname: 'ns1.ns.ee'),
Fabricate(:nameserver, hostname: 'ns2.ns.ee'),
Fabricate(:nameserver, hostname: 'ns2.test.ee')
@api_user = create(:api_user)
@domain_1 = create(:domain, nameservers: [
create(:nameserver, hostname: 'ns1.ns.ee'),
create(:nameserver, hostname: 'ns2.ns.ee'),
create(:nameserver, hostname: 'ns2.test.ee')
], registrar: @api_user.registrar)
@domain_2 = Fabricate(:domain, nameservers: [
Fabricate(:nameserver, hostname: 'ns1.ns.ee'),
Fabricate(:nameserver, hostname: 'ns2.ns.ee'),
Fabricate(:nameserver, hostname: 'ns3.test.ee')
@domain_2 = create(:domain, nameservers: [
create(:nameserver, hostname: 'ns1.ns.ee'),
create(:nameserver, hostname: 'ns2.ns.ee'),
create(:nameserver, hostname: 'ns3.test.ee')
], registrar: @api_user.registrar)
@domain_3 = Fabricate(:domain, nameservers: [
Fabricate(:nameserver, hostname: 'ns1.ns.ee'),
Fabricate(:nameserver, hostname: 'ns2.ns.ee'),
Fabricate(:nameserver, hostname: 'ns3.test.ee')
@domain_3 = create(:domain, nameservers: [
create(:nameserver, hostname: 'ns1.ns.ee'),
create(:nameserver, hostname: 'ns2.ns.ee'),
create(:nameserver, hostname: 'ns3.test.ee')
])
end