zydronium/internetee-registry
1
0
Fork 0
mirror of https://github.com/internetee/registry.git synced 2025-07-24 03:30:33 +02:00
Code Issues Projects Releases Packages Wiki Activity

Migrate fabricators to factory bot factories (#626)

Browse source 
* Remove factory_girl include from dev rake task

No longer needed after 92b125b4a7

* Add missing factories

* Use FactoryBot factories instead of fabricators

* Remove all fabricators

* Remove unused method

* Remove fabrication gem

* Rename FactoryGirl to FactoryBot

https://robots.thoughtbot.com/factory_bot
This commit is contained in:
Artur Beljajev 2017-11-16 10:18:53 +02:00 • committed by Georg
parent acfe0552fc
commit 2da578a437
88 changed files with 356 additions and 610 deletions
Download patch file Download diff file Expand all files Collapse all files

10
spec/models/keyrelay_spec.rb
View file

@ -21,7 +21,7 @@ describe Keyrelay do
Setting.client_side_status_editing_enabled = true
Fabricate(:zone, origin: 'ee')
create(:zone, origin: 'ee')
end
context 'with invalid attribute' do
@ -49,7 +49,7 @@ describe Keyrelay do
context 'with valid attributes' do
before :example do
@keyrelay = Fabricate(:keyrelay)
@keyrelay = create(:keyrelay)
end
it 'should be valid' do
@ -58,7 +58,7 @@ describe Keyrelay do
end
it 'should be valid twice' do
@keyrelay = Fabricate(:keyrelay)
@keyrelay = create(:keyrelay)
@keyrelay.valid?
@keyrelay.errors.full_messages.should match_array([])
end
@ -79,12 +79,12 @@ describe Keyrelay do
end
it 'is in expired status' do
kr = Fabricate(:keyrelay, pa_date: Time.zone.now - 2.weeks)
kr = create(:keyrelay, pa_date: Time.zone.now - 2.weeks)
expect(kr.status).to eq('expired')
end
it 'does not accept invalid relative expiry' do
kr = Fabricate.build(:keyrelay, expiry_relative: 'adf')
kr = build(:keyrelay, expiry_relative: 'adf')
expect(kr.save).to eq(false)
expect(kr.errors[:expiry_relative].first).to eq('Expiry relative must be compatible to ISO 8601')
end