From 251231cf3fa34016981fa1b32a03f16961184e9d Mon Sep 17 00:00:00 2001 From: Priit Tark Date: Fri, 27 Mar 2015 15:37:39 +0200 Subject: [PATCH] contact generates code if custom code is empty --- app/models/epp/contact.rb | 2 +- spec/epp/contact_spec.rb | 18 ++++++++++++++++++ 2 files changed, 19 insertions(+), 1 deletion(-) diff --git a/app/models/epp/contact.rb b/app/models/epp/contact.rb index 0f51b02c0..0bcc0cf2c 100644 --- a/app/models/epp/contact.rb +++ b/app/models/epp/contact.rb @@ -42,7 +42,7 @@ class Epp::Contact < Contact return super if frame.blank? custom_code = - if frame.css('id').present? + if frame.css('id').text.present? "#{registrar.code}:#{frame.css('id').text.parameterize}" else nil diff --git a/spec/epp/contact_spec.rb b/spec/epp/contact_spec.rb index ca5edd28f..7a2c26239 100644 --- a/spec/epp/contact_spec.rb +++ b/spec/epp/contact_spec.rb @@ -145,6 +145,24 @@ describe 'EPP Contact', epp: true do Contact.last.code.should == 'registrar1:12345' end + it 'should generate server id when id is empty' do + response = create_request({ id: { value: '' } }) + + response[:msg].should == 'Command completed successfully' + response[:result_code].should == '1000' + + Contact.last.code.should_not == 'registrar1:' + end + + it 'should generate server id when id is empty' do + response = create_request + + response[:msg].should == 'Command completed successfully' + response[:result_code].should == '1000' + + Contact.last.code.should_not == 'registrar1:' + end + it 'should return parameter value policy error for org' do response = create_request({ postalInfo: { org: { value: 'should not save' } } }) response[:msg].should ==