Fix tests

app/controllers/repp/v1/base_controller.rb

@@ -59,9 +59,12 @@ module Repp
         end
       end
 
-      def render_epp_error(status = :bad_request)
+      def render_epp_error(status = :bad_request, data = {})
+        @epp_errors ||= []
+        @epp_errors << { code: 2304, msg: 'Command failed' } if data != {}
+
         render(
-          json: { code: @epp_errors[0][:code], message: @epp_errors[0][:msg] },
+          json: { code: @epp_errors[0][:code], message: @epp_errors[0][:msg], data: data },
           status: status
         )
       end

app/controllers/repp/v1/domains/contacts_controller.rb

@@ -16,12 +16,15 @@ module Repp
         end
 
         def update
-          @epp_errors << { code: '2304', msg: 'New contact must be valid' } if @new_contact.invalid?
+          @epp_errors ||= []
+          @epp_errors << { code: 2304, msg: 'New contact must be valid' } if @new_contact.invalid?
 
           if @new_contact == @current_contact
-            @epp_errors << { code: '2304', msg: 'New contact must be different from current' }
+            @epp_errors << { code: 2304, msg: 'New contact must be different from current' }
           end
 
+          return handle_errors if @epp_errors.any?
+
           affected, skipped = TechDomainContact.replace(@current_contact, @new_contact)
           data = { affected_domains: affected, skipped_domains: skipped }
           render_success(data: data)

app/controllers/repp/v1/domains_controller.rb

@@ -34,7 +34,7 @@ module Repp
         end
 
         if @errors.any?
-          render_success(data: { errors: @errors })
+          render_epp_error(:bad_request, @errors)
         else
           render_success(data: @successful)
         end
@@ -52,10 +52,11 @@ module Repp
         domain = Domain.find_by(name: domain_name)
         # rubocop:disable Style/AndOr
         add_error("#{domain_name} does not exist") and return unless domain
-        valid_transfer_code = domain.transfer_code.eql?(transfer_code)
-        add_error("#{domain_name} transfer code is wrong") and return unless valid_transfer_code
         # rubocop:enable Style/AndOr
-
+        unless domain.transfer_code.eql?(transfer_code)
+          add_error("#{domain_name} transfer code is wrong")
+          return
+        end
         domain
       end
 

app/controllers/repp/v1/registrar/nameservers_controller.rb

@@ -22,7 +22,7 @@ module Repp
 
         def hostname_params
           params.require(:data).require(%i[type id])
-          params.require(:data).require(:attributes)
+          params.require(:data).require(:attributes).require([:hostname])
 
           params.permit(data: [:type, :id, attributes: [:hostname, ipv4: [], ipv6: []]])
         end