From 1ebf7b5e212d51840342518f13ed35dd8c784ced Mon Sep 17 00:00:00 2001 From: Martin Lensment Date: Thu, 4 Sep 2014 12:01:23 +0300 Subject: [PATCH] Remove auth info changing ability --- app/helpers/epp/domains_helper.rb | 1 - app/models/domain.rb | 13 +++---------- spec/epp/domain_spec.rb | 3 ++- 3 files changed, 5 insertions(+), 12 deletions(-) diff --git a/app/helpers/epp/domains_helper.rb b/app/helpers/epp/domains_helper.rb index 3ec22e2b8..bbfb9854f 100644 --- a/app/helpers/epp/domains_helper.rb +++ b/app/helpers/epp/domains_helper.rb @@ -43,7 +43,6 @@ module Epp::DomainsHelper @domain.parse_and_attach_domain_dependencies(@ph, parsed_frame.css('add')) @domain.parse_and_detach_domain_dependencies(parsed_frame.css('rem')) @domain.parse_and_update_domain_dependencies(parsed_frame.css('chg')) - @domain.parse_and_update_domain_attributes(parsed_frame.css('chg')) if @domain.errors.any? handle_errors(@domain) diff --git a/app/models/domain.rb b/app/models/domain.rb index 4d133b463..ed55360e2 100644 --- a/app/models/domain.rb +++ b/app/models/domain.rb @@ -76,8 +76,10 @@ class Domain < ActiveRecord::Base errors.empty? end + # TODO: Find out if there are any attributes that can be changed + # if not, delete this method def parse_and_update_domain_attributes(parsed_frame) - assign_attributes(self.class.parse_update_params_from_frame(parsed_frame)) + #assign_attributes(self.class.parse_update_params_from_frame(parsed_frame)) errors.empty? end @@ -391,15 +393,6 @@ class Domain < ActiveRecord::Base res end - def parse_update_params_from_frame(parsed_frame) - ret = {} - return ret if parsed_frame.blank? - - ret[:auth_info] = parsed_frame.css('pw').try(:text) - - ret.compact - end - def check_availability(domains) domains = [domains] if domains.is_a?(String) diff --git a/spec/epp/domain_spec.rb b/spec/epp/domain_spec.rb index 56ed7a8b6..38fe2b46b 100644 --- a/spec/epp/domain_spec.rb +++ b/spec/epp/domain_spec.rb @@ -488,6 +488,7 @@ describe 'EPP Domain', epp: true do it 'updates a domain' do Fabricate(:contact, code: 'mak21') + existing_pw = Domain.first.auth_info xml_params = { chg: [ @@ -504,7 +505,7 @@ describe 'EPP Domain', epp: true do d = Domain.last expect(d.owner_contact_code).to eq('mak21') - expect(d.auth_info).to eq('2BARfoo') + expect(d.auth_info).to eq(existing_pw) end it 'does not assign invalid status to domain' do