zydronium/internetee-registry
1
0
Fork 0
mirror of https://github.com/internetee/registry.git synced 2025-07-22 18:56:05 +02:00
Code Issues Projects Releases Packages Wiki Activity

Merge pull request #1749 from internetee/1739-ns-bulk-change-test-and-whois-update

Browse source 
Registrar: Update WHOIS after bulk nameserver change
This commit is contained in:
Timo Võhmar 2021-01-06 20:14:58 +02:00 • committed by GitHub
commit 18790071c9
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
8 changed files with 102 additions and 23 deletions
Download patch file Download diff file Expand all files Collapse all files

2
test/fixtures/files/valid_domains_for_ns_replacement.csv vendored Normal file
View file

@ -0,0 +1,2 @@
domain_name
shop.test
1 domain_name
2 shop.test

3
test/integration/api/nameservers/put_test.rb
View file

@ -67,7 +67,8 @@ class APINameserversPutTest < ApplicationIntegrationTest
attributes: { hostname: 'ns55.bestnames.test',
ipv4: ['192.0.2.55'],
ipv6: ['2001:db8::55'] },
affected_domains: ["airport.test", "shop.test"] }}),
affected_domains: ["airport.test", "shop.test"],
skipped_domains: [] }}),
JSON.parse(response.body, symbolize_names: true)
end

20
test/models/registrar/replace_nameservers_test.rb
View file

@ -10,7 +10,7 @@ class ReplaceNameserversTest < ActiveSupport::TestCase
ipv6: '2001:db8::2' }
result = @registrar.replace_nameservers('ns1.bestnames.test', new_attributes)
assert_equal(["airport.test", "shop.test"], result)
assert_equal([["airport.test", "shop.test"], []], result)
end
def test_replace_nameservers_in_bulk_returns_empty_array_for_non_existent_base_nameserver
@ -18,6 +18,22 @@ class ReplaceNameserversTest < ActiveSupport::TestCase
ipv6: '2001:db8::2' }
result = @registrar.replace_nameservers('ns3.bestnames.test', new_attributes)
assert_equal([], result)
assert_equal([[], []], result)
end
def test_replace_nameserver_in_bulk_respects_domain_limit_scope
eligible_domain = domains(:shop)
unscoped_domain = domains(:airport)
new_attributes = { hostname: 'ns-updated1.bestnames.test', ipv4: '192.0.3.1',
ipv6: '2001:db8::2' }
result = @registrar.replace_nameservers('ns1.bestnames.test', new_attributes, domains: ['shop.test'])
assert_equal([["shop.test"], []], result)
unscoped_domain.reload
eligible_domain.reload
assert eligible_domain.nameservers.where(hostname: 'ns1.bestnames.test').empty?
assert unscoped_domain.nameservers.where(hostname: 'ns1.bestnames.test').any?
end
end

37
test/system/registrar_area/bulk_change/nameserver_test.rb
View file

@ -18,7 +18,8 @@ class RegistrarAreaNameserverBulkChangeTest < ApplicationSystemTestCase
.to_return(body: { data: {
type: 'nameserver',
id: 'new-ns.bestnames.test',
affected_domains: ["airport.test", "shop.test"]
affected_domains: ["airport.test", "shop.test"],
skipped_domains: []
}
}.to_json, status: 200)
@ -59,4 +60,38 @@ class RegistrarAreaNameserverBulkChangeTest < ApplicationSystemTestCase
assert_field 'ipv4', with: 'ipv4'
assert_field 'ipv6', with: 'ipv6'
end
def test_replaces_nameservers_only_for_scoped_domains
request_body = { data: { type: 'nameserver',
id: 'ns1.bestnames.test',
domains: ['shop.test'],
attributes: { hostname: 'new-ns.bestnames.test',
ipv4: %w[192.0.2.55 192.0.2.56],
ipv6: %w[2001:db8::55 2001:db8::56] } } }
request_stub = stub_request(:put, /registrar\/nameservers/).with(body: request_body,
headers: { 'Content-type' => Mime[:json] },
basic_auth: ['test_goodnames', 'testtest'])
.to_return(body: { data: {
type: 'nameserver',
id: 'new-ns.bestnames.test',
affected_domains: ["shop.test"],
skipped_domains: []}}.to_json, status: 200)
visit registrar_domains_url
click_link 'Bulk change'
click_link 'Nameserver'
fill_in 'Old hostname', with: 'ns1.bestnames.test'
fill_in 'New hostname', with: 'new-ns.bestnames.test'
fill_in 'ipv4', with: "192.0.2.55\n192.0.2.56"
fill_in 'ipv6', with: "2001:db8::55\n2001:db8::56"
attach_file :puny_file, Rails.root.join('test', 'fixtures', 'files', 'valid_domains_for_ns_replacement.csv').to_s
click_on 'Replace nameserver'
assert_requested request_stub
assert_current_path registrar_domains_path
assert_text 'Nameserver have been successfully replaced'
assert_text 'Affected domains: shop.test'
end
end