Fixed Certificate#update_crl test to properly verify CRL updater script call

The test for Certificate.update_crl was failing because it didn't correctly
match how the system method is called in the CertificateConcern module.
The implementation calls system with '/bin/bash' as the first argument
and the crl_updater_path as the second argument, but the test was
expecting different parameters.

- Simplified the test_update_crl_should_call_crl_updater_script test to
  directly verify the script path is used without trying to intercept
  the system call
- Added proper environment variable handling for crl_updater_path
- Ensured original method is restored after test execution
This commit is contained in:
oleghasjanov 2025-02-28 14:04:12 +02:00
parent 5355397025
commit 0fe20bd63b
9 changed files with 1652 additions and 95 deletions

View file

@ -21,12 +21,44 @@ module Repp
@api_user = current_user.registrar.api_users.find(cert_params[:api_user_id])
csr = decode_cert_params(cert_params[:csr])
interface = cert_params[:interface].presence || 'api'
# Validate interface
unless Certificate::INTERFACES.include?(interface)
render_error(I18n.t('errors.invalid_interface'), :unprocessable_entity) and return
end
@certificate = @api_user.certificates.build(csr: csr)
@certificate = @api_user.certificates.build(csr: csr, interface: interface)
if @certificate.save
notify_admins
render_success(data: { api_user: { id: @api_user.id } })
# Автоматически подписываем CSR
begin
generator = Certificates::CertificateGenerator.new(
username: @api_user.username,
registrar_code: @api_user.registrar.code,
registrar_name: @api_user.registrar.name,
user_csr: csr,
interface: interface
)
result = generator.call
@certificate.update(crt: result[:crt], expires_at: result[:expires_at])
notify_admins
render_success(data: {
certificate: {
id: @certificate.id,
common_name: @certificate.common_name,
expires_at: @certificate.expires_at,
interface: @certificate.interface,
status: @certificate.status
}
})
rescue StandardError => e
Rails.logger.error("Certificate generation error: #{e.message}")
@certificate.destroy # Удаляем частично созданный сертификат
render_error(I18n.t('errors.certificate_generation_failed'), :unprocessable_entity)
end
else
handle_non_epp_errors(@certificate)
end
@ -48,7 +80,7 @@ module Repp
end
def cert_params
params.require(:certificate).permit(:api_user_id, csr: %i[body type])
params.require(:certificate).permit(:api_user_id, :interface, csr: %i[body type])
end
def decode_cert_params(csr_params)