From e3faac3d446426d4b2eba53090f9fb6905acf88e Mon Sep 17 00:00:00 2001 From: Artur Beljajev Date: Thu, 11 May 2017 18:16:14 +0300 Subject: [PATCH 1/4] Set "secret_key_base" config key from Figaro #508 --- config/application.rb | 1 + config/initializers/set_secret.rb | 1 - 2 files changed, 1 insertion(+), 1 deletion(-) delete mode 100644 config/initializers/set_secret.rb diff --git a/config/application.rb b/config/application.rb index e946f5d11..a0c67526e 100644 --- a/config/application.rb +++ b/config/application.rb @@ -80,6 +80,7 @@ module Registry } config.action_view.default_form_builder = 'DefaultFormBuilder' + config.secret_key_base = Figaro.env.secret_key_base end end diff --git a/config/initializers/set_secret.rb b/config/initializers/set_secret.rb deleted file mode 100644 index ed1dbae7f..000000000 --- a/config/initializers/set_secret.rb +++ /dev/null @@ -1 +0,0 @@ -Registry::Application.config.secret_token = ENV['secret_key_base'] From a696bac3baf4af5074c482e261996791f375c5cb Mon Sep 17 00:00:00 2001 From: Artur Beljajev Date: Thu, 11 May 2017 18:16:50 +0300 Subject: [PATCH 2/4] Remove unused secrets sample #508 --- config/secrets-example.yml | 14 -------------- 1 file changed, 14 deletions(-) delete mode 100644 config/secrets-example.yml diff --git a/config/secrets-example.yml b/config/secrets-example.yml deleted file mode 100644 index d5a826251..000000000 --- a/config/secrets-example.yml +++ /dev/null @@ -1,14 +0,0 @@ -development: - secret_key_base: generate-your-secret-key-by-rake-secret - -test: - secret_key_base: generate-your-secret-key-by-rake-secret - -alpha: - secret_key_base: generate-your-secret-key-by-rake-secret - -staging: - secret_key_base: generate-your-secret-key-by-rake-secret - -production: - secret_key_base: generate-your-secret-key-by-rake-secret From 5c65aa5f2b35ce6f2f20848441a6d50c17abc4c6 Mon Sep 17 00:00:00 2001 From: Artur Beljajev Date: Fri, 12 May 2017 09:45:23 +0300 Subject: [PATCH 3/4] Remove secrets from Travis config #508 --- .travis.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.travis.yml b/.travis.yml index 8931690f5..67bf4febf 100644 --- a/.travis.yml +++ b/.travis.yml @@ -7,7 +7,6 @@ before_script: - "psql -c 'create database registry_whois_test;' -U postgres" - "psql -c 'create database registry_api_log_test;' -U postgres" - "cp config/application-example.yml config/application.yml" - - "cp config/secrets-example.yml config/secrets.yml" - "cp config/database-travis.yml config/database.yml" - "RAILS_ENV=test bundle exec rake db:setup:all" script: From 0fb8e2bde12b6863937d1b148187db13a5576d0d Mon Sep 17 00:00:00 2001 From: Artur Beljajev Date: Mon, 15 May 2017 01:49:42 +0300 Subject: [PATCH 4/4] Remove secrets-related code #508 --- .gitignore | 1 - app/models/soap/arireg.rb | 14 ++------------ config/application-example.yml | 1 - 3 files changed, 2 insertions(+), 14 deletions(-) diff --git a/.gitignore b/.gitignore index 733375212..be64af3ba 100644 --- a/.gitignore +++ b/.gitignore @@ -11,7 +11,6 @@ capybara-*.html **.orig config/initializers/secret_token.rb config/deploy.rb -config/secrets.yml config/database.yml config/application.yml config/environments/development.rb diff --git a/app/models/soap/arireg.rb b/app/models/soap/arireg.rb index 422a72dd9..98810eeda 100644 --- a/app/models/soap/arireg.rb +++ b/app/models/soap/arireg.rb @@ -61,18 +61,8 @@ module Soap def initialize if self.class.username.nil? - if Rails.application.secrets.key?(:arireg) - arireg = Rails.application.secrets[:arireg].with_indifferent_access - self.class.username = arireg[:username] - self.class.password = arireg[:password] - if self.class.wsdl.nil? # no override of config/environments/* ? - self.class.wsdl = arireg[:wsdl] - self.class.host = arireg[:host] - end - else - self.class.username = ENV['arireg_username'] - self.class.password = ENV['arireg_password'] - end + self.class.username = ENV['arireg_username'] + self.class.password = ENV['arireg_password'] end if self.class.wsdl.nil? self.class.wsdl = ENV['arireg_wsdl'] diff --git a/config/application-example.yml b/config/application-example.yml index 20b9370e1..9d68e44e8 100644 --- a/config/application-example.yml +++ b/config/application-example.yml @@ -92,7 +92,6 @@ restful_whois_url: 'https://restful-whois.example.com' # # Estonian Business Registry # -# config/secrets.yml --- arireg: {username, password} arireg_username: 'kasutaja' arireg_password: 'parool' # config/environments/production.rb --- Soap::Arireg.wsdl, Soap::Arireg.host