Fix valid_to #2741

app/models/pricelist.rb

@@ -1,7 +1,7 @@
 class Pricelist < ActiveRecord::Base
   include Versions # version/pricelist_version.rb
 
-  scope :valid, -> { where("valid_from <= ? AND valid_to >= ? OR valid_to IS NULL", Time.zone.now, Time.zone.now) }
+  scope :valid, -> { where("valid_from <= ? AND valid_to >= ? OR valid_to IS NULL", Time.zone.now.end_of_day, Time.zone.now.beginning_of_day) }
 
   monetize :price_cents
 

app/views/admin/pricelists/edit.haml

@@ -2,5 +2,13 @@
   .col-sm-6
     %h2.text-center-xs= "#{t(:edit)}: #{@pricelist.name}"
 
+- if @pricelist.persisted? && @pricelist.errors.none?
+  %hr
+  - active_pricelist = Pricelist.pricelist_for(@pricelist.category, @pricelist.operation_category, @pricelist.duration)
+  - if active_pricelist
+    = t('active_price_for_this_operation_is', price: "#{active_pricelist.price.amount.to_s} #{active_pricelist.price_currency}")
+  - else
+    = t('active_price_missing_for_this_operation')
+
 %hr
 = render 'form'

app/views/admin/pricelists/index.haml

@@ -26,7 +26,7 @@
               = sort_link(@q, 'valid_to', t(:valid_to))
             %th{class: 'col-xs-2'}
               = t(:action)
-            
+
         %tbody
           - @pricelists.each do |pricelist|
             %tr

config/locales/en.yml

@@ -877,3 +877,5 @@ en:
   api_user_not_found: 'API user not found'
   domain_already_belongs_to_the_querying_registrar: 'Domain already belongs to the querying registrar'
   notes: Notes
+  active_price_for_this_operation_is: 'Active price for this operation is %{price}'
+  active_price_missing_for_this_operation: 'Active price missing for this operation!'

spec/models/pricelist_spec.rb

@@ -160,6 +160,17 @@ describe Pricelist do
 
     Pricelist.pricelist_for('ee', 'create', '1year').price.amount.should == 1.10
 
+    Fabricate.create(:pricelist, {
+      category: 'ee',
+      operation_category: 'create',
+      duration: '1year',
+      price: 2.10,
+      valid_from: Time.zone.now.to_date,
+      valid_to: Time.zone.now.to_date
+    })
+
+    Pricelist.pricelist_for('ee', 'create', '1year').price.amount.should == 2.10
+
     Fabricate.create(:pricelist, {
       category: 'ee',
       operation_category: 'create',