diff --git a/app/models/epp/contact.rb b/app/models/epp/contact.rb
index edc828f81..262269142 100644
--- a/app/models/epp/contact.rb
+++ b/app/models/epp/contact.rb
@@ -44,16 +44,10 @@ class Epp::Contact < Contact
def check_availability(codes, reg:)
codes = [codes] if codes.is_a?(String)
- codes = codes.map { |c| c.include?(':') ? c : "#{reg}:#{c}" }
-
res = []
- codes.each do |x|
- contact = find_by_epp_code(x)
- if contact
- res << { code: contact.code, avail: 0, reason: 'in use' }
- else
- res << { code: x, avail: 1 }
- end
+ codes.map { |c| c.strip.upcase }.map { |c| c.include?(':') ? c : "#{reg}:#{c}" }.each do |x|
+ c = find_by_epp_code(x)
+ res << c ? { code: c.code, avail: 0, reason: 'in use' } : { code: x, avail: 1 }
end
res
diff --git a/test/integration/epp/contact/check/base_test.rb b/test/integration/epp/contact/check/base_test.rb
index 528d69d86..b6da6d4db 100644
--- a/test/integration/epp/contact/check/base_test.rb
+++ b/test/integration/epp/contact/check/base_test.rb
@@ -26,7 +26,7 @@ class EppContactCheckBaseTest < EppTestCase
response_xml = Nokogiri::XML(response.body)
assert_epp_response :completed_successfully
- assert_equal 'john-001', response_xml.at_xpath('//contact:id', contact: xml_schema).text
+ assert_equal "#{@contact.registrar.code}:JOHN-001".upcase, response_xml.at_xpath('//contact:id', contact: xml_schema).text
end
def test_contact_is_available
@@ -98,9 +98,61 @@ class EppContactCheckBaseTest < EppTestCase
assert_equal 3, response_xml.xpath('//contact:cd', contact: xml_schema).size
end
+ def test_check_contact_with_prefix
+ @contact.update_columns(code: "#{@contact.registrar.code}:JOHN-001".upcase)
+ assert @contact.code, "#{@contact.registrar.code}:JOHN-001".upcase
+
+ request_xml = <<-XML
+
+
+
+
+
+ TEST:JOHN-001
+
+
+
+
+ XML
+
+ post epp_check_path, params: { frame: request_xml },
+ headers: { 'HTTP_COOKIE' => 'session=api_bestnames' }
+
+ response_xml = Nokogiri::XML(response.body)
+ assert_epp_response :completed_successfully
+ assert_equal 'TEST:JOHN-001', response_xml.at_xpath('//contact:id', contact: xml_schema).text
+ assert_equal 'in use', response_xml.at_xpath('//contact:reason', contact: xml_schema).text
+ end
+
+ def test_check_contact_without_prefix
+ @contact.update_columns(code: "#{@contact.registrar.code}:JOHN-001".upcase)
+ assert @contact.code, "#{@contact.registrar.code}:JOHN-001".upcase
+
+ request_xml = <<-XML
+
+
+
+
+
+ JOHN-001
+
+
+
+
+ XML
+
+ post epp_check_path, params: { frame: request_xml },
+ headers: { 'HTTP_COOKIE' => 'session=api_bestnames' }
+
+ response_xml = Nokogiri::XML(response.body)
+ assert_epp_response :completed_successfully
+ assert_equal "#{@contact.registrar.code}:JOHN-001".upcase, response_xml.at_xpath('//contact:id', contact: xml_schema).text
+ assert_equal 'in use', response_xml.at_xpath('//contact:reason', contact: xml_schema).text
+ end
+
private
def xml_schema
'https://epp.tld.ee/schema/contact-ee-1.1.xsd'
end
-end
\ No newline at end of file
+end