zydronium/internetee-registry
1
0
Fork 0
mirror of https://github.com/internetee/registry.git synced 2025-05-17 01:47:18 +02:00
Code Issues Projects Releases Packages Wiki Activity

Updated contact ident_type logic

Browse source
This commit is contained in:
Andres Keskküla 2014-08-15 12:07:38 +03:00
parent 5fa1107e3e
commit 0a4a7f98c2
4 changed files with 7 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

1
app/helpers/epp/contacts_helper.rb
View file

@ -112,6 +112,7 @@ module Epp::ContactsHelper
contact_hash[:address_attributes] = contact_hash[:address_attributes] =
Address.extract_attributes(( @ph.try(:[], :postalInfo).try(:[], :addr) || [] ), type) Address.extract_attributes(( @ph.try(:[], :postalInfo).try(:[], :addr) || [] ), type)
end end
contact_hash[:ident_type] = ident_type unless ident_type.nil?
contact_hash contact_hash
end end

4
spec/epp/contact_spec.rb
View file

@ -31,6 +31,8 @@ describe 'EPP Contact', epp: true do
expect(Contact.count).to eq(1) expect(Contact.count).to eq(1)
expect(Contact.first.org_name).to eq('Example Inc.') expect(Contact.first.org_name).to eq('Example Inc.')
expect(Contact.first.ident).to eq '37605030299'
expect(Contact.first.ident_type).to eq 'op'
expect(Contact.first.address.street).to eq('123 Example Dr.') expect(Contact.first.address.street).to eq('123 Example Dr.')
expect(Contact.first.address.street2).to eq('Suite 100') expect(Contact.first.address.street2).to eq('Suite 100')
@ -94,6 +96,8 @@ describe 'EPP Contact', epp: true do
expect(response[:msg]).to eq('Command completed successfully') expect(response[:msg]).to eq('Command completed successfully')
expect(Contact.first.name).to eq('John Doe') expect(Contact.first.name).to eq('John Doe')
expect(Contact.first.email).to eq('jdoe@example.com') expect(Contact.first.email).to eq('jdoe@example.com')
expect(Contact.first.ident).to eq('J836954')
expect(Contact.first.ident_type).to eq('passport')
end end
it 'returns phone and email error' do it 'returns phone and email error' do

2
spec/epp/requests/contacts/update.xml
View file

@ -20,7 +20,7 @@
<contact:voice x="1234">+123.7035555555</contact:voice> <contact:voice x="1234">+123.7035555555</contact:voice>
<contact:fax>+1.7035555556</contact:fax> <contact:fax>+1.7035555556</contact:fax>
<contact:email>jdoe@example.com</contact:email> <contact:email>jdoe@example.com</contact:email>
<contact:ident type="op">37605030299</contact:ident> <contact:ident type="passport">J836954</contact:ident>
<contact:authInfo> <contact:authInfo>
<contact:pw>2fooBAR</contact:pw> <contact:pw>2fooBAR</contact:pw>
</contact:authInfo> </contact:authInfo>

2
spec/support/epp_contact_xml_builder.rb
View file

@ -58,7 +58,7 @@ module EppContactXmlBuilder
xml.tag!('contact:voice', (xml_params[:voice] || '+372.1234567')) unless xml_params[:voice] == false xml.tag!('contact:voice', (xml_params[:voice] || '+372.1234567')) unless xml_params[:voice] == false
xml.tag!('contact:fax', (xml_params[:fax] || '123123' )) unless xml_params[:fax] == false xml.tag!('contact:fax', (xml_params[:fax] || '123123' )) unless xml_params[:fax] == false
xml.tag!('contact:email', (xml_params[:email] || 'example@test.example')) unless xml_params[:email] == false xml.tag!('contact:email', (xml_params[:email] || 'example@test.example')) unless xml_params[:email] == false
xml.tag!('contact:ident', (xml_params[:ident] || '37605030299')) unless xml_params[:ident] == false xml.tag!('contact:ident', (xml_params[:ident] || '37605030299'), type: 'op') unless xml_params[:ident] == false
unless xml_params[:authInfo] == [false] unless xml_params[:authInfo] == [false]
xml.tag!('contact:authInfo') do xml.tag!('contact:authInfo') do
xml.tag!('contact:pw', xml_params[:authInfo][:pw] ) unless xml_params[:authInfo][:pw] == false xml.tag!('contact:pw', xml_params[:authInfo][:pw] ) unless xml_params[:authInfo][:pw] == false