From 057f026cc083a3dd4e1b810bb99c4ed9514811a0 Mon Sep 17 00:00:00 2001
From: Thiago Youssef <thiagodyoussef@gmail.com>
Date: Wed, 20 Jul 2022 09:49:54 -0300
Subject: [PATCH] Fix tests

---
 .../api/v1/registrant/contacts_controller.rb  |  3 ++-
 .../api/v1/registrant/contacts/update_test.rb | 20 ++++++++++++++++---
 2 files changed, 19 insertions(+), 4 deletions(-)

diff --git a/app/controllers/api/v1/registrant/contacts_controller.rb b/app/controllers/api/v1/registrant/contacts_controller.rb
index 889fa0a7a..867eaf881 100644
--- a/app/controllers/api/v1/registrant/contacts_controller.rb
+++ b/app/controllers/api/v1/registrant/contacts_controller.rb
@@ -72,7 +72,8 @@ module Api
             contact.disclosed_attributes = disclosed_attributes
           end
 
-          contact.registrant_publishable = reparsed_request_json[:registrant_publishable]
+          publishable = reparsed_request_json[:registrant_publishable]
+          contact.registrant_publishable = publishable if publishable.in? [true, false]
 
           logger.debug "Setting.address_processing is set to #{Setting.address_processing}"
 
diff --git a/test/integration/api/v1/registrant/contacts/update_test.rb b/test/integration/api/v1/registrant/contacts/update_test.rb
index 56b22c3a3..a5a4f28da 100644
--- a/test/integration/api/v1/registrant/contacts/update_test.rb
+++ b/test/integration/api/v1/registrant/contacts/update_test.rb
@@ -229,12 +229,12 @@ class RegistrantApiV1ContactUpdateTest < ActionDispatch::IntegrationTest
     assert_equal %w[phone], @contact.disclosed_attributes
   end
 
-  def test_registrant_publishable_change_when_present
+  def test_registrant_publishable_change_when_true
     @contact = contacts(:acme_ltd)
     @contact.update!(registrant_publishable: false)
 
     patch api_v1_registrant_contact_path(@contact.uuid),
-          params: { disclosed_attributes: %w[], publishable: true },
+          params: { disclosed_attributes: %w[], registrant_publishable: true },
           as: :json,
           headers: { 'HTTP_AUTHORIZATION' => auth_token }
     @contact.reload
@@ -243,6 +243,19 @@ class RegistrantApiV1ContactUpdateTest < ActionDispatch::IntegrationTest
     assert @contact.registrant_publishable
   end
 
+  def test_registrant_publishable_change_when_false
+    @contact = contacts(:acme_ltd)
+    @contact.update!(registrant_publishable: true)
+
+    patch api_v1_registrant_contact_path(@contact.uuid),
+          params: { disclosed_attributes: %w[], registrant_publishable: false },
+          as: :json,
+          headers: { 'HTTP_AUTHORIZATION' => auth_token }
+    @contact.reload
+
+    assert_response :ok
+    assert_not @contact.registrant_publishable
+  end
 
   def test_return_contact_details
     patch api_v1_registrant_contact_path(@contact.uuid), params: { name: 'new name' },
@@ -268,7 +281,8 @@ class RegistrantApiV1ContactUpdateTest < ActionDispatch::IntegrationTest
                     },
                     auth_info: @contact.auth_info,
                     statuses: @contact.statuses,
-                    disclosed_attributes: @contact.disclosed_attributes }),
+                    disclosed_attributes: @contact.disclosed_attributes,
+                    registrant_publishable: @contact.registrant_publishable }),
                  JSON.parse(response.body, symbolize_names: true)
   end