zydronium/internetee-registry
1
0
Fork 0
mirror of https://github.com/internetee/registry.git synced 2025-06-07 21:25:39 +02:00
Code Issues Projects Releases Packages Wiki Activity

REPP: Show error when invalid ident format submitted

Browse source
This commit is contained in:
Karl Erik Õunapuu 2020-11-16 16:26:59 +02:00
parent 3d0150076c
commit 03db562c77
No known key found for this signature in database
GPG key ID: C9DD647298A34764
4 changed files with 9 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

1
app/controllers/repp/v1/base_controller.rb
View file

@ -4,6 +4,7 @@ module Repp
rescue_from ActiveRecord::RecordNotFound, with: :not_found_error rescue_from ActiveRecord::RecordNotFound, with: :not_found_error
before_action :authenticate_user before_action :authenticate_user
before_action :check_ip_restriction before_action :check_ip_restriction
before_action :set_paper_trail_whodunnit
attr_reader :current_user attr_reader :current_user
rescue_from ActionController::ParameterMissing do |exception| rescue_from ActionController::ParameterMissing do |exception|

2
app/controllers/repp/v1/contacts_controller.rb
View file

@ -112,7 +112,7 @@ module Repp
end end
def contact_ident_params(required: true) def contact_ident_params(required: true)
if required || !params[:contact][:ident].nil? if required
params.require(:contact).require(:ident).require(%i[ident ident_type ident_country_code]) params.require(:contact).require(:ident).require(%i[ident ident_type ident_country_code])
params.require(:contact).require(:ident).permit(:ident, :ident_type, :ident_country_code) params.require(:contact).require(:ident).permit(:ident, :ident_type, :ident_country_code)
else else

8
app/models/actions/contact_update.rb
View file

@ -17,7 +17,7 @@ module Actions
def call def call
maybe_remove_address maybe_remove_address
maybe_update_statuses maybe_update_statuses
maybe_update_ident if ident maybe_update_ident if ident.present?
maybe_attach_legal_doc maybe_attach_legal_doc
commit commit
end end
@ -53,7 +53,11 @@ module Actions
end end
def maybe_update_ident def maybe_update_ident
return unless ident[:ident] unless ident.is_a?(Hash)
contact.add_epp_error('2308', nil, nil, I18n.t('epp.contacts.errors.valid_ident'))
@error = true
return
end
if contact.identifier.valid? if contact.identifier.valid?
submitted_ident = ::Contact::Ident.new(code: ident[:ident], submitted_ident = ::Contact::Ident.new(code: ident[:ident],

2
test/integration/repp/v1/contacts/show_test.rb
View file

@ -28,7 +28,7 @@ class ReppV1ContactsShowTest < ActionDispatch::IntegrationTest
assert_equal 1000, json[:code] assert_equal 1000, json[:code]
assert_equal 'Command completed successfully', json[:message] assert_equal 'Command completed successfully', json[:message]
assert_equal contact.code, json[:data][:code] assert_equal contact.code, json[:data][:id]
end end
def test_can_not_access_out_of_scope_contacts def test_can_not_access_out_of_scope_contacts