Merge branch 'master' into 2470-fix-phantom-statuses

Gemfile.lock

@@ -235,8 +235,8 @@ GEM
       thor (>= 0.14.0, < 2)
     globalid (0.5.2)
       activesupport (>= 5.0)
-    google-protobuf (3.19.4)
-    google-protobuf (3.19.4-x86_64-linux)
+    google-protobuf (3.21.9)
+    google-protobuf (3.21.9-x86_64-linux)
     googleapis-common-protos-types (1.3.0)
       google-protobuf (~> 3.14)
     grpc (1.41.1)
@@ -359,7 +359,7 @@ GEM
     paper_trail (13.0.0)
       activerecord (>= 5.2)
       request_store (~> 1.1)
-    pdfkit (0.8.7)
+    pdfkit (0.8.7.2)
     pg (1.4.4)
     pg_query (2.1.2)
       google-protobuf (>= 3.17.1)

app/controllers/epp/base_controller.rb

@@ -34,7 +34,7 @@ module Epp
                      code: '2502',
                      msg: Shunter.default_error_message)
       handle_errors
-      log_exception(exception)
+      log_exception(exception) unless Rails.env.test?
     end
 
     def respond_with_command_failed_error(exception)

app/controllers/repp/v1/base_controller.rb

@@ -29,7 +29,7 @@ module Repp
         render(json: @response, status: :unauthorized)
       rescue Shunter::ThrottleError => e
         @response = { code: 2502, message: Shunter.default_error_message }
-        logger.error e.to_s
+        logger.error e.to_s unless Rails.env.test?
         render(json: @response, status: :bad_request)
       ensure
         create_repp_log

app/lib/shunter/integration/throttle.rb

@@ -26,7 +26,7 @@ module Shunter
             logger.info "Request from #{throttled_user.class}/#{throttled_user.id} is coming through throttling"
             yield if block_given?
           else
-            logger.info "Too many requests from #{throttled_user.class}/#{throttled_user.id}."
+            logger.info "Too many requests from #{throttled_user.class}/#{throttled_user.id}." unless Rails.env.test?
             raise Shunter::ThrottleError
           end
         end

test/models/epp/response/result/code_test.rb

@@ -1,5 +1,11 @@
 require 'test_helper'
 
+class Hash
+  def contain?(other)
+    self.merge(other) == self
+  end
+end
+
 class EppResponseResultCodeTest < ActiveSupport::TestCase
   def test_creates_code_by_key
     key = :completed_successfully
@@ -84,10 +90,10 @@ class EppResponseResultCodeTest < ActiveSupport::TestCase
       2306 => 'Parameter value policy error',
       2308 => 'Data management policy violation',
       2400 => 'Command failed',
-      2501 => 'Authentication error; server closing connection',
-      2502 => Shunter.default_error_message
+      2501 => 'Authentication error; server closing connection'
     }
-    assert_equal descriptions, Epp::Response::Result::Code.default_descriptions
+
+    assert Epp::Response::Result::Code.default_descriptions.contain? descriptions
   end
 
   def test_equality