Move directo translations from logic to I18n

app/controllers/concerns/book_keeping.rb

@@ -92,15 +92,12 @@ module BookKeeping
   end
 
   def description_in_language(price:, yearly:)
-    en = language == 'en'
+    timeframe_string = yearly ? 'yearly' : 'monthly'
-    registration_length = if yearly
+    locale_string = ".registrars.invoice_#{timeframe_string}_product_description"
-                            en ? 'year(s)' : 'aasta(t)'
-                          else
-                            en ? 'month(s)' : 'kuu(d)'
-                          end
 
-    registration = en ? 'registration' : 'registreerimine'
+    I18n.with_locale(language == 'en' ? 'en' : 'et') do
-    ".#{price.zone_name} #{registration}: #{price.duration.to_i} #{registration_length}"
+      I18n.t(locale_string, tld: ".#{price.zone_name}", length: price.duration.to_i)
+    end
   end
 
   def prepayment_for_all(lines)

app/jobs/directo_invoice_forward_job.rb

@@ -118,10 +118,8 @@ class DirectoInvoiceForwardJob < Que::Job
     last_directo   = [Setting.directo_monthly_number_last.presence.try(:to_i),
                       min_directo].compact.max || 0
 
-    if max_directo && max_directo < (last_directo + invoice_count)
+    return true if max_directo && max_directo < (last_directo + invoice_count)
-      true
+
-    else
+    false
-      false
-    end
   end
 end

config/locales/registrars.en.yml

@@ -1,4 +1,7 @@
 en:
+  registrars:
+    invoice_yearly_product_description: '%{tld} registration: %{length} year(s)'
+    invoice_monthly_product_description: '%{tld} registration: %{length} month(s)'
   activerecord:
     errors:
       models:
@@ -8,4 +11,4 @@ en:
               forbidden: is forbidden
             vat_rate:
               present: >-
-                must be blank when a registrar is VAT-registered in the same country as registry
+                must be blank when a registrar is VAT-registered in the same country as registry

config/locales/registrars.et.yml

@@ -0,0 +1,4 @@
+et:
+  registrars:
+    invoice_yearly_product_description: '%{tld} registration: %{length} year(s)'
+    invoice_monthly_product_description: '%{tld} registration: %{length} month(s)'