From da11d9e7cba10ea2ec2b20c86114971a22c3abc4 Mon Sep 17 00:00:00 2001
From: Matt Farnsworth <matt@perfectline.co>
Date: Fri, 4 Dec 2015 15:27:42 +0200
Subject: [PATCH 1/3] Story #109367694 - add support for imported data, name
 was used

---
 app/models/concerns/versions.rb | 34 ++++++++++++++++-----------------
 1 file changed, 16 insertions(+), 18 deletions(-)

diff --git a/app/models/concerns/versions.rb b/app/models/concerns/versions.rb
index 2cbdca838..b0ac97434 100644
--- a/app/models/concerns/versions.rb
+++ b/app/models/concerns/versions.rb
@@ -22,32 +22,30 @@ module Versions
 
     def creator
       return nil if creator_str.blank?
-
-      if creator_str =~ /^\d+-AdminUser:/
-        creator = AdminUser.find_by(id: creator_str)
-      elsif creator_str =~ /^\d+-ApiUser:/
-        creator = ApiUser.find_by(id: creator_str)
-      elsif creator_str =~ /^\d+-api-/ # depricated
-        creator = ApiUser.find_by(id: creator_str)
-      end
-
+      creator = user_from_id_class_name creator_str
       creator.present? ? creator : creator_str
     end
 
     def updator
       return nil if updator_str.blank?
-
-      if updator_str =~ /^\d+-AdminUser:/
-        updator = AdminUser.find_by(id: updator_str)
-      elsif updator_str =~ /^\d+-ApiUser:/
-        updator = ApiUser.find_by(id: updator_str)
-      elsif updator_str =~ /^\d+-api-/ # depricated
-        updator = ApiUser.find_by(id: updator_str)
-      end
-
+      updator = user_from_id_class_name updator_str
       updator.present? ? updator : updator_str
     end
 
+    def user_from_id_class_name(str)
+      user = ApiUser.find_by(id: $1) if str =~ /^(\d+)-(ApiUser:|api-)/
+      unless user.present?
+        user = AdminUser.find_by(id: $1) if str =~ /^(\d+)-AdminUser:/
+        unless user.present?
+          # on import we copied Registrar name, which may eql code
+          registrar = Registrar.find_by(name: str).first
+          # assume each registrar has only one user
+          user = registrar.api_users.first if registrar
+        end
+      end
+      user
+    end
+
     # callbacks
     def touch_domain_version
       domain.try(:touch_with_version)

From 5b47f21dbe4430cc6a7d89cee117be024ef52659 Mon Sep 17 00:00:00 2001
From: Matt Farnsworth <matt@perfectline.co>
Date: Fri, 4 Dec 2015 15:38:48 +0200
Subject: [PATCH 2/3] Story 109367694 - refactor method name

---
 app/controllers/application_controller.rb | 2 +-
 app/models/epp/domain.rb                  | 2 +-
 app/models/user.rb                        | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/app/controllers/application_controller.rb b/app/controllers/application_controller.rb
index de54dafc5..5d051377d 100644
--- a/app/controllers/application_controller.rb
+++ b/app/controllers/application_controller.rb
@@ -67,7 +67,7 @@ class ApplicationController < ActionController::Base
   end
 
   def user_log_str(user)
-    user.nil? ? 'public' : user.string
+    user.nil? ? 'public' : user.id_role_username
   end
 
   def comma_support_for(parent_key, key)
diff --git a/app/models/epp/domain.rb b/app/models/epp/domain.rb
index 1a577218a..c41adc245 100644
--- a/app/models/epp/domain.rb
+++ b/app/models/epp/domain.rb
@@ -498,7 +498,7 @@ class Epp::Domain < Domain
     old_registrant_email = DomainMailer.registrant_updated_notification_for_old_registrant(id, deliver_emails)
     preclean_pendings
     user  = ApiUser.find(pending_json['current_user_id'])
-    ::PaperTrail.whodunnit = user.string # updator str should be the request originator not the approval user
+    ::PaperTrail.whodunnit = user.id_role_username # updator str should be the request originator not the approval user
     frame = Nokogiri::XML(pending_json['frame'])
     statuses.delete(DomainStatus::PENDING_UPDATE)
     yield(self) if block_given? # need to skip statuses check here
diff --git a/app/models/user.rb b/app/models/user.rb
index 5d415230c..b69e0250c 100644
--- a/app/models/user.rb
+++ b/app/models/user.rb
@@ -4,7 +4,7 @@ class User < ActiveRecord::Base
 
   attr_accessor :phone
 
-  def string
+  def id_role_username
     "#{self.id}-#{self.class}: #{self.username}"
   end
 

From 1f0e8f86e91b5e7e7661ae8e4ad3fd2814dc08d2 Mon Sep 17 00:00:00 2001
From: Matt Farnsworth <matt@perfectline.co>
Date: Fri, 4 Dec 2015 15:40:33 +0200
Subject: [PATCH 3/3] Story 109367694 - refactor method name also

---
 app/models/concerns/versions.rb | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/app/models/concerns/versions.rb b/app/models/concerns/versions.rb
index b0ac97434..ae2dabf6a 100644
--- a/app/models/concerns/versions.rb
+++ b/app/models/concerns/versions.rb
@@ -22,17 +22,17 @@ module Versions
 
     def creator
       return nil if creator_str.blank?
-      creator = user_from_id_class_name creator_str
+      creator = user_from_id_role_username creator_str
       creator.present? ? creator : creator_str
     end
 
     def updator
       return nil if updator_str.blank?
-      updator = user_from_id_class_name updator_str
+      updator = user_from_id_role_username updator_str
       updator.present? ? updator : updator_str
     end
 
-    def user_from_id_class_name(str)
+    def user_from_id_role_username(str)
       user = ApiUser.find_by(id: $1) if str =~ /^(\d+)-(ApiUser:|api-)/
       unless user.present?
         user = AdminUser.find_by(id: $1) if str =~ /^(\d+)-AdminUser:/