zydronium/internetee-epp_proxy
1
0
Fork 0
mirror of https://github.com/internetee/epp_proxy.git synced 2025-08-21 22:50:48 +02:00
Code Issues Projects Releases Packages Wiki Activity

Introduce error 2000

Browse source 
When a client sends invalid command to proxy, it should be reported as
error 2000 and sent to registry. We should sent them there regardless
This commit is contained in:
Maciej Szlosarczyk 2019-07-29 13:23:45 +03:00
parent 98483daccd
commit 203e119c2c
No known key found for this signature in database
GPG key ID: 41D62D42D3B0D765
6 changed files with 86 additions and 24 deletions
Download patch file Download diff file Expand all files Collapse all files

26
apps/epp_proxy/test/tcp_client_SUITE.erl
View file

@ -11,6 +11,7 @@
valid_command_test_case/1,
long_message_test_case/1,
invalid_command_test_case/1,
missing_command_test_case/1,
error_test_case/1]).
all() ->
@ -20,6 +21,7 @@ all() ->
valid_command_test_case,
long_message_test_case,
invalid_command_test_case,
missing_command_test_case,
error_test_case].
init_per_suite(Config) ->
@ -133,8 +135,7 @@ long_message_test_case(Config) ->
"Command completed successfully; no messages"),
ok.
%% Sending an invalid command frame should close the connection.
%% It also crashes the process.
%% Sending an invalid command frame should return a canned response.
invalid_command_test_case(Config) ->
Options = proplists:get_value(tcp_options, Config),
{ok, Socket} = gen_tcp:connect("localhost", 1180, Options, 2000),
@ -150,7 +151,26 @@ invalid_command_test_case(Config) ->
"</command>\n"
"</epp>\n">>,
ok = send_data(InvalidCommand, Socket),
{error, closed} = receive_data(Socket),
ErrorResponse = receive_data(Socket),
match_data(ErrorResponse,
"Unknown command."),
ok.
%% Sending a valid XML without command frame should return a canned response.
missing_command_test_case(Config) ->
Options = proplists:get_value(tcp_options, Config),
{ok, Socket} = gen_tcp:connect("localhost", 1180, Options, 2000),
_Data = receive_data(Socket),
ok = send_data(login_command(), Socket),
_LoginResponse = receive_data(Socket),
InvalidCommand =
<<"<?xml version=\"1.0\" encoding=\"UTF-8\" standalone=\"no\"?>\n"
"<epp xmlns=\"https://epp.tld.ee/schema/epp-ee-1.0.xsd\">\n"
"</epp>\n">>,
ok = send_data(InvalidCommand, Socket),
ErrorResponse = receive_data(Socket),
match_data(ErrorResponse,
"Unknown command."),
ok.
error_test_case(Config) ->

26
apps/epp_proxy/test/tls_client_SUITE.erl
View file

@ -11,6 +11,7 @@
valid_command_test_case/1,
long_message_test_case/1,
invalid_command_test_case/1,
missing_command_test_case/1,
error_test_case/1,
revoked_cert_test_case/1]).
@ -21,6 +22,7 @@ all() ->
valid_command_test_case,
long_message_test_case,
invalid_command_test_case,
missing_command_test_case,
error_test_case,
revoked_cert_test_case].
@ -142,8 +144,7 @@ long_message_test_case(Config) ->
"Command completed successfully; no messages"),
ok.
%% Sending an invalid command frame should close the connection.
%% It also crashes the process.
%% Sending an invalid command frame returns a canned response.
invalid_command_test_case(Config) ->
Options = proplists:get_value(ssl_options, Config),
{ok, Socket} = ssl:connect("localhost", 1443, Options, 2000),
@ -159,7 +160,26 @@ invalid_command_test_case(Config) ->
"</command>\n"
"</epp>\n">>,
ok = send_data(InvalidCommand, Socket),
{error, closed} = receive_data(Socket),
ErrorResponse = receive_data(Socket),
match_data(ErrorResponse,
"Unknown command."),
ok.
%% Sending a missing command frame should return a canned response.
missing_command_test_case(Config) ->
Options = proplists:get_value(ssl_options, Config),
{ok, Socket} = ssl:connect("localhost", 1443, Options, 2000),
_Data = receive_data(Socket),
ok = send_data(login_command(), Socket),
_LoginResponse = receive_data(Socket),
InvalidCommand =
<<"<?xml version=\"1.0\" encoding=\"UTF-8\" standalone=\"no\"?>\n"
"<epp xmlns=\"https://epp.tld.ee/schema/epp-ee-1.0.xsd\">\n"
"</epp>\n">>,
ok = send_data(InvalidCommand, Socket),
ErrorResponse = receive_data(Socket),
match_data(ErrorResponse,
"Unknown command."),
ok.
error_test_case(Config) ->