diff --git a/ChangeLog b/ChangeLog index 8776928..b97345d 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,17 +1,21 @@ RCS file: RCS/imapsync,v Working file: imapsync -head: 1.920 +head: 1.921 branch: locks: strict - gilles: 1.920 + gilles: 1.921 access list: symbolic names: keyword substitution: kv -total revisions: 920; selected revisions: 920 +total revisions: 921; selected revisions: 921 description: ---------------------------- -revision 1.920 locked by: gilles; +revision 1.921 locked by: gilles; +date: 2019/02/18 10:21:03; author: gilles; state: Exp; lines: +10 -8 +Bugfix. Errors of APPEND were not counted as missing messages on host2! +---------------------------- +revision 1.920 date: 2019/02/09 15:45:31; author: gilles; state: Exp; lines: +37 -33 Better "Extra arguments found" error message, added "or some misspelling options" ---------------------------- diff --git a/FAQ.d/FAQ.Gmail.txt b/FAQ.d/FAQ.Gmail.txt index 9990d45..ff7d108 100644 --- a/FAQ.d/FAQ.Gmail.txt +++ b/FAQ.d/FAQ.Gmail.txt @@ -1,5 +1,5 @@ #!/bin/cat -$Id: FAQ.Gmail.txt,v 1.50 2018/12/25 11:10:30 gilles Exp gilles $ +$Id: FAQ.Gmail.txt,v 1.51 2019/02/18 09:49:14 gilles Exp gilles $ This document is also available online at https://imapsync.lamiral.info/FAQ.d/ @@ -13,7 +13,9 @@ Questions answered in this FAQ are: Q. Can I use imapsync to transfer from or to Gmail accounts? -Q. Is there special configuration tips to facilitate a Gmail transfer? +Q. Even after several syncs the number of messages differs + largely between imapsync and the Gmail web interface. + What can I do? Q. How many days does it take to transfer X GB? @@ -66,9 +68,11 @@ it has to be allowed in the Gmail configuration part: -> Enable IMAP ======================================================================= -Q. Is there special configuration tips to facilitate a Gmail transfer? +Q. Even after several syncs the number of messages differs + largely between imapsync and the Gmail web interface. + What can I do? -R. Turned off "Conversation views". +R. Turned off "Conversation views" on Gmail. With "Conversation views" turned off, Gmail shows the exact message count for each folder and it matches what imapsync shows. With "Conversation views" on, a single conversation can have diff --git a/INSTALL.d/INSTALL.OnlineUI.txt b/INSTALL.d/INSTALL.OnlineUI.txt index de17bff..b8cbbd6 100644 --- a/INSTALL.d/INSTALL.OnlineUI.txt +++ b/INSTALL.d/INSTALL.OnlineUI.txt @@ -1,5 +1,5 @@ #!/bin/cat -# $Id: INSTALL.OnlineUI.txt,v 1.27 2018/11/08 14:51:09 gilles Exp gilles $ +# $Id: INSTALL.OnlineUI.txt,v 1.29 2019/02/18 09:24:18 gilles Exp gilles $ This documentation is also located online at https://imapsync.lamiral.info/INSTALL.d/ @@ -156,8 +156,9 @@ ScriptAlias /cgi-bin/ /usr/lib/cgi-bin/ Allow from all -The UI front-end file place on the server disk is -/var/www/X/imapsync_form.html +The UI front-end file place on the server disk in +this example is +/var/www/html/X/imapsync_form.html but it can be placed it anywhere on disk, the important thing is that it has to be served by the web server. @@ -177,6 +178,14 @@ imapsync directly, it is hard-coded in imapsync. In this directory will go the log files and the pid files. +Check + http://yourhost/X/imapsync_form.html +or the safer + https://yourhost/X/imapsync_form.html + +That's all for installing a /X service on Debian. + + Example on a Centos 7 server with httpd Apache: mkdir /var/www/html/X/ diff --git a/Makefile b/Makefile index bfd08eb..72c1685 100644 --- a/Makefile +++ b/Makefile @@ -1,5 +1,5 @@ -# $Id: Makefile,v 1.289 2019/02/17 15:25:37 gilles Exp gilles $ +# $Id: Makefile,v 1.290 2019/02/18 12:02:32 gilles Exp gilles $ .PHONY: help usage all doc @@ -440,6 +440,8 @@ imapsync_64bit.exe: imapsync pc_HP_DV7_p24:'Desktop/imapsync_build' ssh 'pc HP DV7'@p24 'Desktop/imapsync_build/build_exe.bat' ./W/check_win64err build_exe.bat + ssh 'pc HP DV7'@p24 'Desktop/imapsync_build/test_exe.bat' + ./W/check_win64err test_exe.bat rm -f imapsync_64bit.exe scp pc_HP_DV7_p24:'Desktop/imapsync_build/imapsync.exe' imapsync_64bit.exe (date "+%s"| tr "\n" " "; echo -n "END 64bit " $(VERSION) ": "; date) >> W/.BUILD_EXE_TIME diff --git a/README b/README index fda3ab2..c6a1602 100644 --- a/README +++ b/README @@ -5,7 +5,7 @@ NAME VERSION - This documentation refers to Imapsync $Revision: 1.920 $ + This documentation refers to Imapsync $Revision: 1.921 $ USAGE diff --git a/S/imapsync_sold_by_country.txt b/S/imapsync_sold_by_country.txt index babc065..130ab51 100644 --- a/S/imapsync_sold_by_country.txt +++ b/S/imapsync_sold_by_country.txt @@ -94,4 +94,4 @@ 609 Royaume-Uni_____________ 9.09 % 51 % 49 % 3 1302 Allemagne_______________ 19.44 % 42 % 58 % 2 1507 Etats-Unis______________ 22.50 % 22 % 78 % 1 -TOTAL = 6699 sales 316542 EUR over 96 countries on Thu Feb 14 18:27:39 CET 2019 +TOTAL = 6699 sales 316542 EUR over 96 countries on Mon Feb 18 23:52:01 CET 2019 diff --git a/VERSION b/VERSION index dda46a3..a4e8fe5 100644 --- a/VERSION +++ b/VERSION @@ -1 +1 @@ -1.920 +1.921 diff --git a/W/.BUILD_EXE_TIME b/W/.BUILD_EXE_TIME index 8d3d4b6..edc5adb 100644 --- a/W/.BUILD_EXE_TIME +++ b/W/.BUILD_EXE_TIME @@ -626,3 +626,14 @@ 1549838455 END 64bit 1.920 : dimanche 10 février 2019, 23:40:55 (UTC+0100) 1549844664 BEGIN 1.920 : lundi 11 février 2019, 01:24:24 (UTC+0100) 1549845893 END 1.920 : lundi 11 février 2019, 01:44:53 (UTC+0100) +1550487405 BEGIN 1.921 : lundi 18 février 2019, 11:56:45 (UTC+0100) +1550490170 BEGIN 1.921 : lundi 18 février 2019, 12:42:50 (UTC+0100) +1550490616 END 1.921 : lundi 18 février 2019, 12:50:16 (UTC+0100) +1550490651 BEGIN 64bit 1.921 : lundi 18 février 2019, 12:50:51 (UTC+0100) +1550490992 END 64bit 1.921 : lundi 18 février 2019, 12:56:32 (UTC+0100) +1550491431 BEGIN 64bit 1.921 : lundi 18 février 2019, 13:03:51 (UTC+0100) +1550491837 END 64bit 1.921 : lundi 18 février 2019, 13:10:37 (UTC+0100) +1550492090 BEGIN 1.921 : lundi 18 février 2019, 13:14:50 (UTC+0100) +1550493338 END 1.921 : lundi 18 février 2019, 13:35:38 (UTC+0100) +1550493338 BEGIN 64bit 1.921 : lundi 18 février 2019, 13:35:38 (UTC+0100) +1550493671 END 64bit 1.921 : lundi 18 février 2019, 13:41:11 (UTC+0100) diff --git a/W/.compok b/W/.compok index 35c0973..6d9d817 100644 --- a/W/.compok +++ b/W/.compok @@ -66,3 +66,4 @@ lundi 7 janvier 2019, 20:44:41 (UTC+0100) mercredi 6 février 2019, 14:02:24 (UTC+0100) jeudi 7 février 2019, 13:56:24 (UTC+0100) jeudi 14 février 2019, 18:27:42 (UTC+0100) +lundi 18 février 2019, 23:52:36 (UTC+0100) diff --git a/W/.tests.errors.txt b/W/.tests.errors.txt index 7d3c8c6..ef3d7a0 100644 --- a/W/.tests.errors.txt +++ b/W/.tests.errors.txt @@ -2728,3 +2728,18 @@ 2019_02_10_14_07_36 : ALL 148 TESTS SUCCESSFUL 2019_02_11_01_30_39 : ALL 1 TESTS SUCCESSFUL 2019_02_11_01_32_30 : ALL 2 TESTS SUCCESSFUL +2019_02_18_11_11_38 : ALL 1 TESTS SUCCESSFUL +2019_02_18_11_11_53 : FAILED 1/3 TESTS: ll_errors +2019_02_18_11_13_17 : ALL 1 TESTS SUCCESSFUL +2019_02_18_11_14_53 : ALL 1 TESTS SUCCESSFUL +2019_02_18_11_15_04 : FAILED 1/3 TESTS: ll_final_diff_with_errors +2019_02_18_11_15_46 : ALL 1 TESTS SUCCESSFUL +2019_02_18_11_15_46 : FAILED 1/3 TESTS: ll_final_diff_with_errors +2019_02_18_11_16_03 : ALL 1 TESTS SUCCESSFUL +2019_02_18_11_16_27 : FAILED 1/3 TESTS: ll_with_errors +2019_02_18_11_17_24 : ALL 1 TESTS SUCCESSFUL +2019_02_18_11_17_35 : FAILED 1/3 TESTS: ll_with_errors +2019_02_18_11_21_46 : ALL 1 TESTS SUCCESSFUL +2019_02_18_11_53_50 : ALL 148 TESTS SUCCESSFUL +2019_02_19_09_28_52 : ALL 1 TESTS SUCCESSFUL +2019_02_19_09_59_12 : ALL 148 TESTS SUCCESSFUL diff --git a/W/check_win64err b/W/check_win64err index ca1322d..737ad47 100755 --- a/W/check_win64err +++ b/W/check_win64err @@ -1,6 +1,6 @@ #!/bin/sh -# $Id: check_winerr,v 1.4 2016/06/30 11:10:37 gilles Exp gilles $ +# $Id: check_win64err,v 1.1 2019/02/18 12:01:21 gilles Exp gilles $ test -n "$1" || { echo usage: "$0 script.bat" && exit 1 ; } diff --git a/W/imapsync.1 b/W/imapsync.1 index e49eaad..e8f93c4 100644 --- a/W/imapsync.1 +++ b/W/imapsync.1 @@ -133,7 +133,7 @@ .\" ======================================================================== .\" .IX Title "IMAPSYNC 1" -.TH IMAPSYNC 1 "2019-02-09" "perl v5.22.1" "User Contributed Perl Documentation" +.TH IMAPSYNC 1 "2019-02-18" "perl v5.22.1" "User Contributed Perl Documentation" .\" For nroff, turn off justification. Always turn off hyphenation; it makes .\" way too many mistakes in technical documents. .if n .ad l @@ -144,7 +144,7 @@ email mailboxes between two imap servers, one way, and without duplicates. .SH "VERSION" .IX Header "VERSION" -This documentation refers to Imapsync \f(CW$Revision:\fR 1.920 $ +This documentation refers to Imapsync \f(CW$Revision:\fR 1.921 $ .SH "USAGE" .IX Header "USAGE" .Vb 5 diff --git a/W/perlcritic_1.txt b/W/perlcritic_1.txt index 28408b4..8b29f15 100644 --- a/W/perlcritic_1.txt +++ b/W/perlcritic_1.txt @@ -1,6 +1,6 @@ Code is not tidy at line 1, column 1. See page 33 of PBP. (Severity: 1) Check the spelling in your POD: NAME imapsync Email IMAP tool syncing copying migrating email mailboxes between two imap servers one way without duplicates This refers to Imapsync We sometimes need transfer from server another command is allowing incremental recursive transfers mailbox By default all folders transferred recursively meaning the whole folder hierarchy taken them flags synced too reduces amount of by not transferring given it resides already both sides Same specific headers done only Received lines this choice can be changed with useheader All preserved unread will stay read ones deleted You at any time restart later works well bad decide delete after successful good feature when since side that implies also expunge so marked host really remove empty their been Add emptyfolders obtain behavior different scenario synchronizing you just want keep copy has used deletes destroy then See foldersonly foldersbutnot adequate maintaining accounts synchronization plays independently offlineimap written Goerzen mbsync Michael Elkins ways Mandatory three each needed log into ie username password times pass passwords environment sizes selection SECURITY passfile instead give safer With your see using ps auxwwww Using like dangerous because auxwwwwe So saving protected rw best activates ssl tls encryption What detailed under known imaps closed clear connection TLS CAPABILITY list supported goes automatic detection fails protect against sniffing activities network especially directory STATUS status return everything went Otherwise exits zero LICENSE free always cover NOLIMIT License included IS text enough repeat AUTHOR Feedback very often welcome earns his writing installing configuring teaching now sold its author maintain over decades BUGS SERVERS HUGE Pay special subscribed subscribe maxage maxsize useuid usecache many migrate think little shell program Write called file.txt example containing users The separator contains Windows batch replaced nothing Welcome programming find INSTALL There specified line parameters HACKING Feel hack license permits SIMILAR HISTORY wrote enterprise basystemes paid install new losing huge old located away remote low bandwidth broken link imapcp could help had verify every was started life patch comes perl tarball precisely IMAPClient happened wonder remains at line 1, column 1. See page 148 of PBP. (Severity: 1) -Main code has high complexity score (411) at line 1, column 1. Consider refactoring. (Severity: 3) +Main code has high complexity score (412) at line 1, column 1. Consider refactoring. (Severity: 3) POD before __END__ at line 18, column 1. See pages 139,140 of PBP. (Severity: 1) Missing "REQUIRED ARGUMENTS" section in POD at line 18, column 1. See pages 133,138 of PBP. (Severity: 2) Missing "DIAGNOSTICS" section in POD at line 18, column 1. See pages 133,138 of PBP. (Severity: 2) @@ -70,875 +70,875 @@ Postfix control "if" used at line 2150, column 69. See pages 93,94 of PBP. (Se Code structure is deeply nested at line 2151, column 41. Consider refactoring. (Severity: 3) Postfix control "if" used at line 2162, column 68. See pages 93,94 of PBP. (Severity: 2) Postfix control "if" used at line 2166, column 53. See pages 93,94 of PBP. (Severity: 2) -Found "\N{SPACE}" at the end of the line at line 2203, column 26. Don't use whitespace at the end of lines. (Severity: 1) -Found "\N{SPACE}" at the end of the line at line 2206, column 1. Don't use whitespace at the end of lines. (Severity: 1) -Found "\N{SPACE}" at the end of the line at line 2268, column 1. Don't use whitespace at the end of lines. (Severity: 1) -Found "\N{SPACE}" at the end of the line at line 2276, column 52. Don't use whitespace at the end of lines. (Severity: 1) -Found "\N{SPACE}" at the end of the line at line 2286, column 1. Don't use whitespace at the end of lines. (Severity: 1) -Found "\N{SPACE}" at the end of the line at line 2292, column 76. Don't use whitespace at the end of lines. (Severity: 1) -Postfix control "if" used at line 2340, column 66. See pages 93,94 of PBP. (Severity: 2) -Postfix control "if" used at line 2341, column 41. See pages 93,94 of PBP. (Severity: 2) -Postfix control "if" used at line 2344, column 40. See pages 93,94 of PBP. (Severity: 2) -Return value of flagged function ignored - print at line 2354, column 9. See pages 208,278 of PBP. (Severity: 1) -String *may* require interpolation at line 2392, column 51. See page 51 of PBP. (Severity: 1) -String *may* require interpolation at line 2393, column 63. See page 51 of PBP. (Severity: 1) -String *may* require interpolation at line 2409, column 45. See page 51 of PBP. (Severity: 1) -String *may* require interpolation at line 2410, column 57. See page 51 of PBP. (Severity: 1) -Builtin function called with parentheses at line 2423, column 25. See page 13 of PBP. (Severity: 1) -String *may* require interpolation at line 2439, column 50. See page 51 of PBP. (Severity: 1) -Builtin function called with parentheses at line 2452, column 24. See page 13 of PBP. (Severity: 1) -Useless interpolation of literal string at line 2584, column 54. See page 51 of PBP. (Severity: 1) -Useless interpolation of literal string at line 2597, column 44. See page 51 of PBP. (Severity: 1) -6 is not one of the allowed literal values (0, 1, 2). Use the Readonly or Const::Fast module or the "constant" pragma instead at line 2665, column 69. Unnamed numeric literals make code less maintainable. (Severity: 2) -Builtin function called with parentheses at line 2688, column 9. See page 13 of PBP. (Severity: 1) -Builtin function called with parentheses at line 2692, column 10. See page 13 of PBP. (Severity: 1) -Octal literals (0000) are not allowed. Use the Readonly or Const::Fast module or the "constant" pragma instead at line 2702, column 29. Unnamed numeric literals make code less maintainable. (Severity: 2) -Octal literals (0000) are not allowed. Use the Readonly or Const::Fast module or the "constant" pragma instead at line 2704, column 10. Unnamed numeric literals make code less maintainable. (Severity: 2) -777 is not one of the allowed literal values (0, 1, 2). Use the Readonly or Const::Fast module or the "constant" pragma instead at line 2704, column 27. Unnamed numeric literals make code less maintainable. (Severity: 2) -777 is not one of the allowed literal values (0, 1, 2). Use the Readonly or Const::Fast module or the "constant" pragma instead at line 2708, column 10. Unnamed numeric literals make code less maintainable. (Severity: 2) -777 is not one of the allowed literal values (0, 1, 2). Use the Readonly or Const::Fast module or the "constant" pragma instead at line 2709, column 10. Unnamed numeric literals make code less maintainable. (Severity: 2) -Quotes used with a noisy string at line 2752, column 30. See page 53 of PBP. (Severity: 2) -Useless interpolation of literal string at line 2927, column 29. See page 51 of PBP. (Severity: 1) -Regular expression without "/s" flag at line 3010, column 23. See pages 240,241 of PBP. (Severity: 2) -Regular expression without "/x" flag at line 3010, column 23. See page 236 of PBP. (Severity: 3) -Regular expression without "/m" flag at line 3010, column 23. See page 237 of PBP. (Severity: 2) -123456 is not one of the allowed literal values (0, 1, 2). Use the Readonly or Const::Fast module or the "constant" pragma instead at line 3097, column 13. Unnamed numeric literals make code less maintainable. (Severity: 2) -Long number not separated with underscores at line 3097, column 13. See page 59 of PBP. (Severity: 2) -Useless interpolation of literal string at line 3244, column 19. See page 51 of PBP. (Severity: 1) -Quotes used with a string containing no non-whitespace characters at line 3299, column 12. See page 53 of PBP. (Severity: 2) -Quotes used with a string containing no non-whitespace characters at line 3300, column 12. See page 53 of PBP. (Severity: 2) -Quotes used with a string containing no non-whitespace characters at line 3301, column 16. See page 53 of PBP. (Severity: 2) +Found "\N{SPACE}" at the end of the line at line 2205, column 26. Don't use whitespace at the end of lines. (Severity: 1) +Found "\N{SPACE}" at the end of the line at line 2208, column 1. Don't use whitespace at the end of lines. (Severity: 1) +Found "\N{SPACE}" at the end of the line at line 2270, column 1. Don't use whitespace at the end of lines. (Severity: 1) +Found "\N{SPACE}" at the end of the line at line 2278, column 52. Don't use whitespace at the end of lines. (Severity: 1) +Found "\N{SPACE}" at the end of the line at line 2288, column 1. Don't use whitespace at the end of lines. (Severity: 1) +Found "\N{SPACE}" at the end of the line at line 2294, column 76. Don't use whitespace at the end of lines. (Severity: 1) +Postfix control "if" used at line 2342, column 66. See pages 93,94 of PBP. (Severity: 2) +Postfix control "if" used at line 2343, column 41. See pages 93,94 of PBP. (Severity: 2) +Postfix control "if" used at line 2346, column 40. See pages 93,94 of PBP. (Severity: 2) +Return value of flagged function ignored - print at line 2356, column 9. See pages 208,278 of PBP. (Severity: 1) +String *may* require interpolation at line 2394, column 51. See page 51 of PBP. (Severity: 1) +String *may* require interpolation at line 2395, column 63. See page 51 of PBP. (Severity: 1) +String *may* require interpolation at line 2411, column 45. See page 51 of PBP. (Severity: 1) +String *may* require interpolation at line 2412, column 57. See page 51 of PBP. (Severity: 1) +Builtin function called with parentheses at line 2425, column 25. See page 13 of PBP. (Severity: 1) +String *may* require interpolation at line 2441, column 50. See page 51 of PBP. (Severity: 1) +Builtin function called with parentheses at line 2454, column 24. See page 13 of PBP. (Severity: 1) +Useless interpolation of literal string at line 2586, column 54. See page 51 of PBP. (Severity: 1) +Useless interpolation of literal string at line 2599, column 44. See page 51 of PBP. (Severity: 1) +6 is not one of the allowed literal values (0, 1, 2). Use the Readonly or Const::Fast module or the "constant" pragma instead at line 2667, column 69. Unnamed numeric literals make code less maintainable. (Severity: 2) +Builtin function called with parentheses at line 2690, column 9. See page 13 of PBP. (Severity: 1) +Builtin function called with parentheses at line 2694, column 10. See page 13 of PBP. (Severity: 1) +Octal literals (0000) are not allowed. Use the Readonly or Const::Fast module or the "constant" pragma instead at line 2704, column 29. Unnamed numeric literals make code less maintainable. (Severity: 2) +Octal literals (0000) are not allowed. Use the Readonly or Const::Fast module or the "constant" pragma instead at line 2706, column 10. Unnamed numeric literals make code less maintainable. (Severity: 2) +777 is not one of the allowed literal values (0, 1, 2). Use the Readonly or Const::Fast module or the "constant" pragma instead at line 2706, column 27. Unnamed numeric literals make code less maintainable. (Severity: 2) +777 is not one of the allowed literal values (0, 1, 2). Use the Readonly or Const::Fast module or the "constant" pragma instead at line 2710, column 10. Unnamed numeric literals make code less maintainable. (Severity: 2) +777 is not one of the allowed literal values (0, 1, 2). Use the Readonly or Const::Fast module or the "constant" pragma instead at line 2711, column 10. Unnamed numeric literals make code less maintainable. (Severity: 2) +Quotes used with a noisy string at line 2754, column 30. See page 53 of PBP. (Severity: 2) +Useless interpolation of literal string at line 2929, column 29. See page 51 of PBP. (Severity: 1) +Regular expression without "/s" flag at line 3012, column 23. See pages 240,241 of PBP. (Severity: 2) +Regular expression without "/x" flag at line 3012, column 23. See page 236 of PBP. (Severity: 3) +Regular expression without "/m" flag at line 3012, column 23. See page 237 of PBP. (Severity: 2) +123456 is not one of the allowed literal values (0, 1, 2). Use the Readonly or Const::Fast module or the "constant" pragma instead at line 3099, column 13. Unnamed numeric literals make code less maintainable. (Severity: 2) +Long number not separated with underscores at line 3099, column 13. See page 59 of PBP. (Severity: 2) +Useless interpolation of literal string at line 3246, column 19. See page 51 of PBP. (Severity: 1) +Quotes used with a string containing no non-whitespace characters at line 3301, column 12. See page 53 of PBP. (Severity: 2) Quotes used with a string containing no non-whitespace characters at line 3302, column 12. See page 53 of PBP. (Severity: 2) -Quotes used with a string containing no non-whitespace characters at line 3303, column 12. See page 53 of PBP. (Severity: 2) -Quotes used with a string containing no non-whitespace characters at line 3304, column 16. See page 53 of PBP. (Severity: 2) -Quotes used with a string containing no non-whitespace characters at line 3309, column 26. See page 53 of PBP. (Severity: 2) -Builtin function called with parentheses at line 3375, column 17. See page 13 of PBP. (Severity: 1) -File handle for "print" or "printf" is not braced at line 3423, column 9. See page 217 of PBP. (Severity: 1) -Return value of flagged function ignored - print at line 3423, column 9. See pages 208,278 of PBP. (Severity: 1) -Return value of "close" ignored at line 3424, column 9. Check the return value of "close" for success. (Severity: 2) -Return value of flagged function ignored - close at line 3424, column 9. See pages 208,278 of PBP. (Severity: 1) -32 is not one of the allowed literal values (0, 1, 2). Use the Readonly or Const::Fast module or the "constant" pragma instead at line 3439, column 6. Unnamed numeric literals make code less maintainable. (Severity: 2) -32 is not one of the allowed literal values (0, 1, 2). Use the Readonly or Const::Fast module or the "constant" pragma instead at line 3440, column 6. Unnamed numeric literals make code less maintainable. (Severity: 2) -Useless interpolation of literal string at line 3448, column 16. See page 51 of PBP. (Severity: 1) -Useless interpolation of literal string at line 3448, column 21. See page 51 of PBP. (Severity: 1) -Postfix control "for" used at line 3450, column 33. See page 96 of PBP. (Severity: 2) -32 is not one of the allowed literal values (0, 1, 2). Use the Readonly or Const::Fast module or the "constant" pragma instead at line 3450, column 40. Unnamed numeric literals make code less maintainable. (Severity: 2) -Local lexical variable "$Side" is not all lower case or all upper case at line 3470, column 9. See pages 45,46 of PBP. (Severity: 1) -String *may* require interpolation at line 3508, column 49. See page 51 of PBP. (Severity: 1) -String *may* require interpolation at line 3517, column 49. See page 51 of PBP. (Severity: 1) -Quotes used with a noisy string at line 3565, column 44. See page 53 of PBP. (Severity: 2) -Quotes used with a noisy string at line 3565, column 55. See page 53 of PBP. (Severity: 2) -Local lexical variable "$Side" is not all lower case or all upper case at line 3591, column 9. See pages 45,46 of PBP. (Severity: 1) -Use character classes for literal metachars instead of escapes at line 3644, column 29. See page 247 of PBP. (Severity: 1) -Regular expression without "/s" flag at line 3644, column 29. See pages 240,241 of PBP. (Severity: 2) -Regular expression without "/m" flag at line 3644, column 29. See page 237 of PBP. (Severity: 2) -Use character classes for literal metachars instead of escapes at line 3673, column 31. See page 247 of PBP. (Severity: 1) -Regular expression without "/s" flag at line 3673, column 31. See pages 240,241 of PBP. (Severity: 2) -Regular expression without "/m" flag at line 3673, column 31. See page 237 of PBP. (Severity: 2) -Regular expression without "/s" flag at line 3863, column 47. See pages 240,241 of PBP. (Severity: 2) -Regular expression without "/m" flag at line 3863, column 47. See page 237 of PBP. (Severity: 2) -Builtin function called with parentheses at line 3871, column 72. See page 13 of PBP. (Severity: 1) -Postfix control "if" used at line 3877, column 25. See pages 93,94 of PBP. (Severity: 2) -Useless interpolation of literal string at line 3885, column 21. See page 51 of PBP. (Severity: 1) -Local lexical variable "$imapT" is not all lower case or all upper case at line 3886, column 9. See pages 45,46 of PBP. (Severity: 1) -String *may* require interpolation at line 3889, column 61. See page 51 of PBP. (Severity: 1) -String *may* require interpolation at line 3892, column 97. See page 51 of PBP. (Severity: 1) -Builtin function called with parentheses at line 3930, column 51. See page 13 of PBP. (Severity: 1) -Useless use of $_ at line 3989, column 40. $_ should be omitted when calling "uc". (Severity: 2) -Too many arguments at line 4013, column 1. See page 182 of PBP. (Severity: 3) -Too many arguments at line 4032, column 1. See page 182 of PBP. (Severity: 3) -Too many arguments at line 4053, column 1. See page 182 of PBP. (Severity: 3) -Builtin function called with parentheses at line 4069, column 29. See page 13 of PBP. (Severity: 1) -Builtin function called with parentheses at line 4070, column 29. See page 13 of PBP. (Severity: 1) -Regular expression without "/s" flag at line 4102, column 17. See pages 240,241 of PBP. (Severity: 2) -Regular expression without "/m" flag at line 4102, column 17. See page 237 of PBP. (Severity: 2) -Postfix control "if" used at line 4119, column 61. See pages 93,94 of PBP. (Severity: 2) -Regular expression without "/s" flag at line 4211, column 23. See pages 240,241 of PBP. (Severity: 2) -Regular expression without "/x" flag at line 4211, column 23. See page 236 of PBP. (Severity: 3) -Regular expression without "/m" flag at line 4211, column 23. See page 237 of PBP. (Severity: 2) -Use only '//' or '{}' to delimit regexps at line 4338, column 30. See page 246 of PBP. (Severity: 1) -Regular expression without "/s" flag at line 4360, column 30. See pages 240,241 of PBP. (Severity: 2) -Regular expression without "/m" flag at line 4360, column 30. See page 237 of PBP. (Severity: 2) -Quotes used with a noisy string at line 4415, column 26. See page 53 of PBP. (Severity: 2) -Regular expression without "/s" flag at line 4735, column 42. See pages 240,241 of PBP. (Severity: 2) -Regular expression without "/x" flag at line 4735, column 42. See page 236 of PBP. (Severity: 3) -Regular expression without "/m" flag at line 4735, column 42. See page 237 of PBP. (Severity: 2) -Regular expression without "/s" flag at line 4736, column 33. See pages 240,241 of PBP. (Severity: 2) -Regular expression without "/x" flag at line 4736, column 33. See page 236 of PBP. (Severity: 3) -Regular expression without "/m" flag at line 4736, column 33. See page 237 of PBP. (Severity: 2) -Regular expression without "/s" flag at line 4745, column 42. See pages 240,241 of PBP. (Severity: 2) -Regular expression without "/x" flag at line 4745, column 42. See page 236 of PBP. (Severity: 3) -Regular expression without "/m" flag at line 4745, column 42. See page 237 of PBP. (Severity: 2) -Found "\N{SPACE}" at the end of the line at line 4755, column 13. Don't use whitespace at the end of lines. (Severity: 1) -Found "\N{SPACE}" at the end of the line at line 4756, column 41. Don't use whitespace at the end of lines. (Severity: 1) -Found "\N{SPACE}" at the end of the line at line 4757, column 19. Don't use whitespace at the end of lines. (Severity: 1) -Regular expression without "/s" flag at line 4762, column 42. See pages 240,241 of PBP. (Severity: 2) -Regular expression without "/x" flag at line 4762, column 42. See page 236 of PBP. (Severity: 3) -Regular expression without "/m" flag at line 4762, column 42. See page 237 of PBP. (Severity: 2) -Found "\N{SPACE}" at the end of the line at line 4784, column 21. Don't use whitespace at the end of lines. (Severity: 1) -Found "\N{SPACE}" at the end of the line at line 4785, column 49. Don't use whitespace at the end of lines. (Severity: 1) -Found "\N{SPACE}" at the end of the line at line 4786, column 19. Don't use whitespace at the end of lines. (Severity: 1) -Regular expression without "/s" flag at line 4791, column 50. See pages 240,241 of PBP. (Severity: 2) -Regular expression without "/x" flag at line 4791, column 50. See page 236 of PBP. (Severity: 3) -Regular expression without "/m" flag at line 4791, column 50. See page 237 of PBP. (Severity: 2) -Magic punctuation variable $! used at line 4792, column 81. See page 79 of PBP. (Severity: 2) -Found "\N{SPACE}" at the end of the line at line 4819, column 21. Don't use whitespace at the end of lines. (Severity: 1) -Found "\N{SPACE}" at the end of the line at line 4820, column 49. Don't use whitespace at the end of lines. (Severity: 1) -Found "\N{SPACE}" at the end of the line at line 4821, column 19. Don't use whitespace at the end of lines. (Severity: 1) -Found "\N{SPACE}" at the end of the line at line 4889, column 21. Don't use whitespace at the end of lines. (Severity: 1) -Found "\N{SPACE}" at the end of the line at line 4890, column 49. Don't use whitespace at the end of lines. (Severity: 1) -Found "\N{SPACE}" at the end of the line at line 4891, column 19. Don't use whitespace at the end of lines. (Severity: 1) -Found "\N{SPACE}" at the end of the line at line 4893, column 18. Don't use whitespace at the end of lines. (Severity: 1) -Use character classes for literal metachars instead of escapes at line 4896, column 64. See page 247 of PBP. (Severity: 1) -Regular expression without "/s" flag at line 4896, column 64. See pages 240,241 of PBP. (Severity: 2) -Regular expression without "/x" flag at line 4896, column 64. See page 236 of PBP. (Severity: 3) -Regular expression without "/m" flag at line 4896, column 64. See page 237 of PBP. (Severity: 2) -Use character classes for literal metachars instead of escapes at line 4897, column 64. See page 247 of PBP. (Severity: 1) -Regular expression without "/s" flag at line 4897, column 64. See pages 240,241 of PBP. (Severity: 2) -Regular expression without "/x" flag at line 4897, column 64. See page 236 of PBP. (Severity: 3) -Regular expression without "/m" flag at line 4897, column 64. See page 237 of PBP. (Severity: 2) -Use character classes for literal metachars instead of escapes at line 4900, column 56. See page 247 of PBP. (Severity: 1) -Regular expression without "/s" flag at line 4900, column 56. See pages 240,241 of PBP. (Severity: 2) -Regular expression without "/x" flag at line 4900, column 56. See page 236 of PBP. (Severity: 3) -Regular expression without "/m" flag at line 4900, column 56. See page 237 of PBP. (Severity: 2) -Too many arguments at line 4928, column 1. See page 182 of PBP. (Severity: 3) -Local lexical variable "$Side" is not all lower case or all upper case at line 4930, column 9. See pages 45,46 of PBP. (Severity: 1) -Local lexical variable "$Side" is not all lower case or all upper case at line 4963, column 9. See pages 45,46 of PBP. (Severity: 1) -Subroutine "authenticate_imap" with high complexity score (23) at line 5010, column 1. Consider refactoring. (Severity: 3) -Too many arguments at line 5010, column 1. See page 182 of PBP. (Severity: 3) -Found "\N{SPACE}" at the end of the line at line 5010, column 22. Don't use whitespace at the end of lines. (Severity: 1) -Local lexical variable "$Side" is not all lower case or all upper case at line 5012, column 9. See pages 45,46 of PBP. (Severity: 1) -Postfix control "if" used at line 5020, column 34. See pages 93,94 of PBP. (Severity: 2) -Found "\N{SPACE}" at the end of the line at line 5023, column 1. Don't use whitespace at the end of lines. (Severity: 1) -Found "\N{SPACE}" at the end of the line at line 5029, column 1. Don't use whitespace at the end of lines. (Severity: 1) -Postfix control "unless" used at line 5034, column 51. See pages 96,97 of PBP. (Severity: 2) -Postfix control "if" used at line 5037, column 40. See pages 93,94 of PBP. (Severity: 2) -Postfix control "if" used at line 5038, column 40. See pages 93,94 of PBP. (Severity: 2) -Postfix control "if" used at line 5039, column 42. See pages 93,94 of PBP. (Severity: 2) -"unless" block used at line 5042, column 9. See page 97 of PBP. (Severity: 2) -Local lexical variable "$Side" is not all lower case or all upper case at line 5073, column 9. See pages 45,46 of PBP. (Severity: 1) -Postfix control "if" used at line 5124, column 45. See pages 93,94 of PBP. (Severity: 2) -Postfix control "if" used at line 5150, column 45. See pages 93,94 of PBP. (Severity: 2) -Too many arguments at line 5162, column 1. See page 182 of PBP. (Severity: 3) -Local lexical variable "$Side" is not all lower case or all upper case at line 5164, column 9. See pages 45,46 of PBP. (Severity: 1) -Postfix control "if" used at line 5191, column 50. See pages 93,94 of PBP. (Severity: 2) -Numeric escapes in interpolated string at line 5206, column 32. See pages 54,55 of PBP. (Severity: 2) -Use character classes for literal metachars instead of escapes at line 5254, column 32. See page 247 of PBP. (Severity: 1) -Regular expression without "/s" flag at line 5254, column 32. See pages 240,241 of PBP. (Severity: 2) -Regular expression without "/m" flag at line 5254, column 32. See page 237 of PBP. (Severity: 2) -Builtin function called with parentheses at line 5258, column 13. See page 13 of PBP. (Severity: 1) -Use "local $/ = undef" or Path::Tiny instead of joined readline at line 5259, column 43. See page 213 of PBP. (Severity: 3) -Return value of "close" ignored at line 5260, column 13. Check the return value of "close" for success. (Severity: 2) -Return value of flagged function ignored - close at line 5260, column 13. See pages 208,278 of PBP. (Severity: 1) -Use named character classes ([A-Za-z] vs. [[:alpha:]]) at line 5269, column 69. See page 248 of PBP. (Severity: 1) -Use character classes for literal metachars instead of escapes at line 5269, column 69. See page 247 of PBP. (Severity: 1) -Regular expression without "/s" flag at line 5269, column 69. See pages 240,241 of PBP. (Severity: 2) -Regular expression without "/m" flag at line 5269, column 69. See page 237 of PBP. (Severity: 2) -Postfix control "if" used at line 5272, column 37. See pages 93,94 of PBP. (Severity: 2) -Backtick operator used at line 5277, column 20. Use IPC::Open3 instead. (Severity: 3) -"unless" block used at line 5302, column 9. See page 97 of PBP. (Severity: 2) -Useless interpolation of literal string at line 5312, column 69. See page 51 of PBP. (Severity: 1) -Useless interpolation of literal string at line 5312, column 112. See page 51 of PBP. (Severity: 1) -Regular expression without "/s" flag at line 5337, column 32. See pages 240,241 of PBP. (Severity: 2) -Regular expression without "/m" flag at line 5337, column 32. See page 237 of PBP. (Severity: 2) -Found "\N{SPACE}" at the end of the line at line 5400, column 1. Don't use whitespace at the end of lines. (Severity: 1) +Quotes used with a string containing no non-whitespace characters at line 3303, column 16. See page 53 of PBP. (Severity: 2) +Quotes used with a string containing no non-whitespace characters at line 3304, column 12. See page 53 of PBP. (Severity: 2) +Quotes used with a string containing no non-whitespace characters at line 3305, column 12. See page 53 of PBP. (Severity: 2) +Quotes used with a string containing no non-whitespace characters at line 3306, column 16. See page 53 of PBP. (Severity: 2) +Quotes used with a string containing no non-whitespace characters at line 3311, column 26. See page 53 of PBP. (Severity: 2) +Builtin function called with parentheses at line 3377, column 17. See page 13 of PBP. (Severity: 1) +File handle for "print" or "printf" is not braced at line 3425, column 9. See page 217 of PBP. (Severity: 1) +Return value of flagged function ignored - print at line 3425, column 9. See pages 208,278 of PBP. (Severity: 1) +Return value of "close" ignored at line 3426, column 9. Check the return value of "close" for success. (Severity: 2) +Return value of flagged function ignored - close at line 3426, column 9. See pages 208,278 of PBP. (Severity: 1) +32 is not one of the allowed literal values (0, 1, 2). Use the Readonly or Const::Fast module or the "constant" pragma instead at line 3441, column 6. Unnamed numeric literals make code less maintainable. (Severity: 2) +32 is not one of the allowed literal values (0, 1, 2). Use the Readonly or Const::Fast module or the "constant" pragma instead at line 3442, column 6. Unnamed numeric literals make code less maintainable. (Severity: 2) +Useless interpolation of literal string at line 3450, column 16. See page 51 of PBP. (Severity: 1) +Useless interpolation of literal string at line 3450, column 21. See page 51 of PBP. (Severity: 1) +Postfix control "for" used at line 3452, column 33. See page 96 of PBP. (Severity: 2) +32 is not one of the allowed literal values (0, 1, 2). Use the Readonly or Const::Fast module or the "constant" pragma instead at line 3452, column 40. Unnamed numeric literals make code less maintainable. (Severity: 2) +Local lexical variable "$Side" is not all lower case or all upper case at line 3472, column 9. See pages 45,46 of PBP. (Severity: 1) +String *may* require interpolation at line 3510, column 49. See page 51 of PBP. (Severity: 1) +String *may* require interpolation at line 3519, column 49. See page 51 of PBP. (Severity: 1) +Quotes used with a noisy string at line 3567, column 44. See page 53 of PBP. (Severity: 2) +Quotes used with a noisy string at line 3567, column 55. See page 53 of PBP. (Severity: 2) +Local lexical variable "$Side" is not all lower case or all upper case at line 3593, column 9. See pages 45,46 of PBP. (Severity: 1) +Use character classes for literal metachars instead of escapes at line 3646, column 29. See page 247 of PBP. (Severity: 1) +Regular expression without "/s" flag at line 3646, column 29. See pages 240,241 of PBP. (Severity: 2) +Regular expression without "/m" flag at line 3646, column 29. See page 237 of PBP. (Severity: 2) +Use character classes for literal metachars instead of escapes at line 3675, column 31. See page 247 of PBP. (Severity: 1) +Regular expression without "/s" flag at line 3675, column 31. See pages 240,241 of PBP. (Severity: 2) +Regular expression without "/m" flag at line 3675, column 31. See page 237 of PBP. (Severity: 2) +Regular expression without "/s" flag at line 3865, column 47. See pages 240,241 of PBP. (Severity: 2) +Regular expression without "/m" flag at line 3865, column 47. See page 237 of PBP. (Severity: 2) +Builtin function called with parentheses at line 3873, column 72. See page 13 of PBP. (Severity: 1) +Postfix control "if" used at line 3879, column 25. See pages 93,94 of PBP. (Severity: 2) +Useless interpolation of literal string at line 3887, column 21. See page 51 of PBP. (Severity: 1) +Local lexical variable "$imapT" is not all lower case or all upper case at line 3888, column 9. See pages 45,46 of PBP. (Severity: 1) +String *may* require interpolation at line 3891, column 61. See page 51 of PBP. (Severity: 1) +String *may* require interpolation at line 3894, column 97. See page 51 of PBP. (Severity: 1) +Builtin function called with parentheses at line 3932, column 51. See page 13 of PBP. (Severity: 1) +Useless use of $_ at line 3991, column 40. $_ should be omitted when calling "uc". (Severity: 2) +Too many arguments at line 4015, column 1. See page 182 of PBP. (Severity: 3) +Too many arguments at line 4034, column 1. See page 182 of PBP. (Severity: 3) +Too many arguments at line 4055, column 1. See page 182 of PBP. (Severity: 3) +Builtin function called with parentheses at line 4071, column 29. See page 13 of PBP. (Severity: 1) +Builtin function called with parentheses at line 4072, column 29. See page 13 of PBP. (Severity: 1) +Regular expression without "/s" flag at line 4104, column 17. See pages 240,241 of PBP. (Severity: 2) +Regular expression without "/m" flag at line 4104, column 17. See page 237 of PBP. (Severity: 2) +Postfix control "if" used at line 4121, column 61. See pages 93,94 of PBP. (Severity: 2) +Regular expression without "/s" flag at line 4213, column 23. See pages 240,241 of PBP. (Severity: 2) +Regular expression without "/x" flag at line 4213, column 23. See page 236 of PBP. (Severity: 3) +Regular expression without "/m" flag at line 4213, column 23. See page 237 of PBP. (Severity: 2) +Use only '//' or '{}' to delimit regexps at line 4340, column 30. See page 246 of PBP. (Severity: 1) +Regular expression without "/s" flag at line 4362, column 30. See pages 240,241 of PBP. (Severity: 2) +Regular expression without "/m" flag at line 4362, column 30. See page 237 of PBP. (Severity: 2) +Quotes used with a noisy string at line 4417, column 26. See page 53 of PBP. (Severity: 2) +Regular expression without "/s" flag at line 4737, column 42. See pages 240,241 of PBP. (Severity: 2) +Regular expression without "/x" flag at line 4737, column 42. See page 236 of PBP. (Severity: 3) +Regular expression without "/m" flag at line 4737, column 42. See page 237 of PBP. (Severity: 2) +Regular expression without "/s" flag at line 4738, column 33. See pages 240,241 of PBP. (Severity: 2) +Regular expression without "/x" flag at line 4738, column 33. See page 236 of PBP. (Severity: 3) +Regular expression without "/m" flag at line 4738, column 33. See page 237 of PBP. (Severity: 2) +Regular expression without "/s" flag at line 4747, column 42. See pages 240,241 of PBP. (Severity: 2) +Regular expression without "/x" flag at line 4747, column 42. See page 236 of PBP. (Severity: 3) +Regular expression without "/m" flag at line 4747, column 42. See page 237 of PBP. (Severity: 2) +Found "\N{SPACE}" at the end of the line at line 4757, column 13. Don't use whitespace at the end of lines. (Severity: 1) +Found "\N{SPACE}" at the end of the line at line 4758, column 41. Don't use whitespace at the end of lines. (Severity: 1) +Found "\N{SPACE}" at the end of the line at line 4759, column 19. Don't use whitespace at the end of lines. (Severity: 1) +Regular expression without "/s" flag at line 4764, column 42. See pages 240,241 of PBP. (Severity: 2) +Regular expression without "/x" flag at line 4764, column 42. See page 236 of PBP. (Severity: 3) +Regular expression without "/m" flag at line 4764, column 42. See page 237 of PBP. (Severity: 2) +Found "\N{SPACE}" at the end of the line at line 4786, column 21. Don't use whitespace at the end of lines. (Severity: 1) +Found "\N{SPACE}" at the end of the line at line 4787, column 49. Don't use whitespace at the end of lines. (Severity: 1) +Found "\N{SPACE}" at the end of the line at line 4788, column 19. Don't use whitespace at the end of lines. (Severity: 1) +Regular expression without "/s" flag at line 4793, column 50. See pages 240,241 of PBP. (Severity: 2) +Regular expression without "/x" flag at line 4793, column 50. See page 236 of PBP. (Severity: 3) +Regular expression without "/m" flag at line 4793, column 50. See page 237 of PBP. (Severity: 2) +Magic punctuation variable $! used at line 4794, column 81. See page 79 of PBP. (Severity: 2) +Found "\N{SPACE}" at the end of the line at line 4821, column 21. Don't use whitespace at the end of lines. (Severity: 1) +Found "\N{SPACE}" at the end of the line at line 4822, column 49. Don't use whitespace at the end of lines. (Severity: 1) +Found "\N{SPACE}" at the end of the line at line 4823, column 19. Don't use whitespace at the end of lines. (Severity: 1) +Found "\N{SPACE}" at the end of the line at line 4891, column 21. Don't use whitespace at the end of lines. (Severity: 1) +Found "\N{SPACE}" at the end of the line at line 4892, column 49. Don't use whitespace at the end of lines. (Severity: 1) +Found "\N{SPACE}" at the end of the line at line 4893, column 19. Don't use whitespace at the end of lines. (Severity: 1) +Found "\N{SPACE}" at the end of the line at line 4895, column 18. Don't use whitespace at the end of lines. (Severity: 1) +Use character classes for literal metachars instead of escapes at line 4898, column 64. See page 247 of PBP. (Severity: 1) +Regular expression without "/s" flag at line 4898, column 64. See pages 240,241 of PBP. (Severity: 2) +Regular expression without "/x" flag at line 4898, column 64. See page 236 of PBP. (Severity: 3) +Regular expression without "/m" flag at line 4898, column 64. See page 237 of PBP. (Severity: 2) +Use character classes for literal metachars instead of escapes at line 4899, column 64. See page 247 of PBP. (Severity: 1) +Regular expression without "/s" flag at line 4899, column 64. See pages 240,241 of PBP. (Severity: 2) +Regular expression without "/x" flag at line 4899, column 64. See page 236 of PBP. (Severity: 3) +Regular expression without "/m" flag at line 4899, column 64. See page 237 of PBP. (Severity: 2) +Use character classes for literal metachars instead of escapes at line 4902, column 56. See page 247 of PBP. (Severity: 1) +Regular expression without "/s" flag at line 4902, column 56. See pages 240,241 of PBP. (Severity: 2) +Regular expression without "/x" flag at line 4902, column 56. See page 236 of PBP. (Severity: 3) +Regular expression without "/m" flag at line 4902, column 56. See page 237 of PBP. (Severity: 2) +Too many arguments at line 4930, column 1. See page 182 of PBP. (Severity: 3) +Local lexical variable "$Side" is not all lower case or all upper case at line 4932, column 9. See pages 45,46 of PBP. (Severity: 1) +Local lexical variable "$Side" is not all lower case or all upper case at line 4965, column 9. See pages 45,46 of PBP. (Severity: 1) +Subroutine "authenticate_imap" with high complexity score (23) at line 5012, column 1. Consider refactoring. (Severity: 3) +Too many arguments at line 5012, column 1. See page 182 of PBP. (Severity: 3) +Found "\N{SPACE}" at the end of the line at line 5012, column 22. Don't use whitespace at the end of lines. (Severity: 1) +Local lexical variable "$Side" is not all lower case or all upper case at line 5014, column 9. See pages 45,46 of PBP. (Severity: 1) +Postfix control "if" used at line 5022, column 34. See pages 93,94 of PBP. (Severity: 2) +Found "\N{SPACE}" at the end of the line at line 5025, column 1. Don't use whitespace at the end of lines. (Severity: 1) +Found "\N{SPACE}" at the end of the line at line 5031, column 1. Don't use whitespace at the end of lines. (Severity: 1) +Postfix control "unless" used at line 5036, column 51. See pages 96,97 of PBP. (Severity: 2) +Postfix control "if" used at line 5039, column 40. See pages 93,94 of PBP. (Severity: 2) +Postfix control "if" used at line 5040, column 40. See pages 93,94 of PBP. (Severity: 2) +Postfix control "if" used at line 5041, column 42. See pages 93,94 of PBP. (Severity: 2) +"unless" block used at line 5044, column 9. See page 97 of PBP. (Severity: 2) +Local lexical variable "$Side" is not all lower case or all upper case at line 5075, column 9. See pages 45,46 of PBP. (Severity: 1) +Postfix control "if" used at line 5126, column 45. See pages 93,94 of PBP. (Severity: 2) +Postfix control "if" used at line 5152, column 45. See pages 93,94 of PBP. (Severity: 2) +Too many arguments at line 5164, column 1. See page 182 of PBP. (Severity: 3) +Local lexical variable "$Side" is not all lower case or all upper case at line 5166, column 9. See pages 45,46 of PBP. (Severity: 1) +Postfix control "if" used at line 5193, column 50. See pages 93,94 of PBP. (Severity: 2) +Numeric escapes in interpolated string at line 5208, column 32. See pages 54,55 of PBP. (Severity: 2) +Use character classes for literal metachars instead of escapes at line 5256, column 32. See page 247 of PBP. (Severity: 1) +Regular expression without "/s" flag at line 5256, column 32. See pages 240,241 of PBP. (Severity: 2) +Regular expression without "/m" flag at line 5256, column 32. See page 237 of PBP. (Severity: 2) +Builtin function called with parentheses at line 5260, column 13. See page 13 of PBP. (Severity: 1) +Use "local $/ = undef" or Path::Tiny instead of joined readline at line 5261, column 43. See page 213 of PBP. (Severity: 3) +Return value of "close" ignored at line 5262, column 13. Check the return value of "close" for success. (Severity: 2) +Return value of flagged function ignored - close at line 5262, column 13. See pages 208,278 of PBP. (Severity: 1) +Use named character classes ([A-Za-z] vs. [[:alpha:]]) at line 5271, column 69. See page 248 of PBP. (Severity: 1) +Use character classes for literal metachars instead of escapes at line 5271, column 69. See page 247 of PBP. (Severity: 1) +Regular expression without "/s" flag at line 5271, column 69. See pages 240,241 of PBP. (Severity: 2) +Regular expression without "/m" flag at line 5271, column 69. See page 237 of PBP. (Severity: 2) +Postfix control "if" used at line 5274, column 37. See pages 93,94 of PBP. (Severity: 2) +Backtick operator used at line 5279, column 20. Use IPC::Open3 instead. (Severity: 3) +"unless" block used at line 5304, column 9. See page 97 of PBP. (Severity: 2) +Useless interpolation of literal string at line 5314, column 69. See page 51 of PBP. (Severity: 1) +Useless interpolation of literal string at line 5314, column 112. See page 51 of PBP. (Severity: 1) +Regular expression without "/s" flag at line 5339, column 32. See pages 240,241 of PBP. (Severity: 2) +Regular expression without "/m" flag at line 5339, column 32. See page 237 of PBP. (Severity: 2) Found "\N{SPACE}" at the end of the line at line 5402, column 1. Don't use whitespace at the end of lines. (Severity: 1) -Found "\N{SPACE}" at the end of the line at line 5406, column 1. Don't use whitespace at the end of lines. (Severity: 1) -Useless interpolation of literal string at line 5407, column 56. See page 51 of PBP. (Severity: 1) -Quotes used with a noisy string at line 5407, column 56. See page 53 of PBP. (Severity: 2) -Use character classes for literal metachars instead of escapes at line 5415, column 26. See page 247 of PBP. (Severity: 1) -Regular expression without "/s" flag at line 5415, column 26. See pages 240,241 of PBP. (Severity: 2) -Regular expression without "/x" flag at line 5415, column 26. See page 236 of PBP. (Severity: 3) -Regular expression without "/m" flag at line 5415, column 26. See page 237 of PBP. (Severity: 2) -Found "\N{SPACE}" at the end of the line at line 5418, column 1. Don't use whitespace at the end of lines. (Severity: 1) -Useless interpolation of literal string at line 5420, column 71. See page 51 of PBP. (Severity: 1) -Constant "$NB_UNIX_tests_do_valid_directory" is not all upper case at line 5434, column 9. See pages 45,46 of PBP. (Severity: 1) -Postfix control "if" used at line 5436, column 82. See pages 93,94 of PBP. (Severity: 2) -Quotes used with a noisy string at line 5437, column 46. See page 53 of PBP. (Severity: 2) -Constant "$NB_UNIX_tests_do_valid_directory_non_root" is not all upper case at line 5440, column 9. See pages 45,46 of PBP. (Severity: 1) -Postfix control "if" used at line 5442, column 91. See pages 93,94 of PBP. (Severity: 2) -Quotes used with a noisy string at line 5444, column 46. See page 53 of PBP. (Severity: 2) -String *may* require interpolation at line 5460, column 17. See page 51 of PBP. (Severity: 1) -String *may* require interpolation at line 5461, column 17. See page 51 of PBP. (Severity: 1) +Found "\N{SPACE}" at the end of the line at line 5404, column 1. Don't use whitespace at the end of lines. (Severity: 1) +Found "\N{SPACE}" at the end of the line at line 5408, column 1. Don't use whitespace at the end of lines. (Severity: 1) +Useless interpolation of literal string at line 5409, column 56. See page 51 of PBP. (Severity: 1) +Quotes used with a noisy string at line 5409, column 56. See page 53 of PBP. (Severity: 2) +Use character classes for literal metachars instead of escapes at line 5417, column 26. See page 247 of PBP. (Severity: 1) +Regular expression without "/s" flag at line 5417, column 26. See pages 240,241 of PBP. (Severity: 2) +Regular expression without "/x" flag at line 5417, column 26. See page 236 of PBP. (Severity: 3) +Regular expression without "/m" flag at line 5417, column 26. See page 237 of PBP. (Severity: 2) +Found "\N{SPACE}" at the end of the line at line 5420, column 1. Don't use whitespace at the end of lines. (Severity: 1) +Useless interpolation of literal string at line 5422, column 71. See page 51 of PBP. (Severity: 1) +Constant "$NB_UNIX_tests_do_valid_directory" is not all upper case at line 5436, column 9. See pages 45,46 of PBP. (Severity: 1) +Postfix control "if" used at line 5438, column 82. See pages 93,94 of PBP. (Severity: 2) +Quotes used with a noisy string at line 5439, column 46. See page 53 of PBP. (Severity: 2) +Constant "$NB_UNIX_tests_do_valid_directory_non_root" is not all upper case at line 5442, column 9. See pages 45,46 of PBP. (Severity: 1) +Postfix control "if" used at line 5444, column 91. See pages 93,94 of PBP. (Severity: 2) +Quotes used with a noisy string at line 5446, column 46. See page 53 of PBP. (Severity: 2) String *may* require interpolation at line 5462, column 17. See page 51 of PBP. (Severity: 1) -Builtin function called with parentheses at line 5485, column 84. See page 13 of PBP. (Severity: 1) -Postfix control "if" used at line 5491, column 42. See pages 93,94 of PBP. (Severity: 2) -Quotes used with a string containing no non-whitespace characters at line 5503, column 40. See page 53 of PBP. (Severity: 2) -Long number not separated with underscores at line 5509, column 36. See page 59 of PBP. (Severity: 2) -Long number not separated with underscores at line 5511, column 40. See page 59 of PBP. (Severity: 2) -Long number not separated with underscores at line 5512, column 40. See page 59 of PBP. (Severity: 2) -Long number not separated with underscores at line 5525, column 14. See page 59 of PBP. (Severity: 2) -Magic punctuation variable $! used in interpolated string at line 5570, column 34. See page 79 of PBP. (Severity: 2) -File handle for "print" or "printf" is not braced at line 5634, column 17. See page 217 of PBP. (Severity: 1) -Return value of flagged function ignored - print at line 5634, column 17. See pages 208,278 of PBP. (Severity: 1) -Return value of "close" ignored at line 5635, column 17. Check the return value of "close" for success. (Severity: 2) -Return value of flagged function ignored - close at line 5635, column 17. See pages 208,278 of PBP. (Severity: 1) -Return value of "close" ignored at line 5669, column 17. Check the return value of "close" for success. (Severity: 2) -Return value of flagged function ignored - close at line 5669, column 17. See pages 208,278 of PBP. (Severity: 1) -Subroutine "fix_Inbox_INBOX_mapping" is not all lower case or all upper case at line 5690, column 1. See pages 45,46 of PBP. (Severity: 1) -String *may* require interpolation at line 5698, column 91. See page 51 of PBP. (Severity: 1) -String *may* require interpolation at line 5699, column 91. See page 51 of PBP. (Severity: 1) -Subroutine "tests_fix_Inbox_INBOX_mapping" is not all lower case or all upper case at line 5704, column 1. See pages 45,46 of PBP. (Severity: 1) -String *may* require interpolation at line 5721, column 13. See page 51 of PBP. (Severity: 1) -String *may* require interpolation at line 5725, column 13. See page 51 of PBP. (Severity: 1) -Regular expression without "/s" flag at line 5805, column 15. See pages 240,241 of PBP. (Severity: 2) -Regular expression without "/m" flag at line 5805, column 15. See page 237 of PBP. (Severity: 2) -Regular expression without "/s" flag at line 5806, column 15. See pages 240,241 of PBP. (Severity: 2) -Regular expression without "/m" flag at line 5806, column 15. See page 237 of PBP. (Severity: 2) +String *may* require interpolation at line 5463, column 17. See page 51 of PBP. (Severity: 1) +String *may* require interpolation at line 5464, column 17. See page 51 of PBP. (Severity: 1) +Builtin function called with parentheses at line 5487, column 84. See page 13 of PBP. (Severity: 1) +Postfix control "if" used at line 5493, column 42. See pages 93,94 of PBP. (Severity: 2) +Quotes used with a string containing no non-whitespace characters at line 5505, column 40. See page 53 of PBP. (Severity: 2) +Long number not separated with underscores at line 5511, column 36. See page 59 of PBP. (Severity: 2) +Long number not separated with underscores at line 5513, column 40. See page 59 of PBP. (Severity: 2) +Long number not separated with underscores at line 5514, column 40. See page 59 of PBP. (Severity: 2) +Long number not separated with underscores at line 5527, column 14. See page 59 of PBP. (Severity: 2) +Magic punctuation variable $! used in interpolated string at line 5572, column 34. See page 79 of PBP. (Severity: 2) +File handle for "print" or "printf" is not braced at line 5636, column 17. See page 217 of PBP. (Severity: 1) +Return value of flagged function ignored - print at line 5636, column 17. See pages 208,278 of PBP. (Severity: 1) +Return value of "close" ignored at line 5637, column 17. Check the return value of "close" for success. (Severity: 2) +Return value of flagged function ignored - close at line 5637, column 17. See pages 208,278 of PBP. (Severity: 1) +Return value of "close" ignored at line 5671, column 17. Check the return value of "close" for success. (Severity: 2) +Return value of flagged function ignored - close at line 5671, column 17. See pages 208,278 of PBP. (Severity: 1) +Subroutine "fix_Inbox_INBOX_mapping" is not all lower case or all upper case at line 5692, column 1. See pages 45,46 of PBP. (Severity: 1) +String *may* require interpolation at line 5700, column 91. See page 51 of PBP. (Severity: 1) +String *may* require interpolation at line 5701, column 91. See page 51 of PBP. (Severity: 1) +Subroutine "tests_fix_Inbox_INBOX_mapping" is not all lower case or all upper case at line 5706, column 1. See pages 45,46 of PBP. (Severity: 1) +String *may* require interpolation at line 5723, column 13. See page 51 of PBP. (Severity: 1) +String *may* require interpolation at line 5727, column 13. See page 51 of PBP. (Severity: 1) Regular expression without "/s" flag at line 5807, column 15. See pages 240,241 of PBP. (Severity: 2) Regular expression without "/m" flag at line 5807, column 15. See page 237 of PBP. (Severity: 2) -Use character classes for literal metachars instead of escapes at line 5817, column 15. See page 247 of PBP. (Severity: 1) -Regular expression without "/s" flag at line 5817, column 15. See pages 240,241 of PBP. (Severity: 2) -Regular expression without "/m" flag at line 5817, column 15. See page 237 of PBP. (Severity: 2) -Regular expression without "/s" flag at line 5818, column 15. See pages 240,241 of PBP. (Severity: 2) -Regular expression without "/m" flag at line 5818, column 15. See page 237 of PBP. (Severity: 2) +Regular expression without "/s" flag at line 5808, column 15. See pages 240,241 of PBP. (Severity: 2) +Regular expression without "/m" flag at line 5808, column 15. See page 237 of PBP. (Severity: 2) +Regular expression without "/s" flag at line 5809, column 15. See pages 240,241 of PBP. (Severity: 2) +Regular expression without "/m" flag at line 5809, column 15. See page 237 of PBP. (Severity: 2) Use character classes for literal metachars instead of escapes at line 5819, column 15. See page 247 of PBP. (Severity: 1) Regular expression without "/s" flag at line 5819, column 15. See pages 240,241 of PBP. (Severity: 2) Regular expression without "/m" flag at line 5819, column 15. See page 237 of PBP. (Severity: 2) -Use character classes for literal metachars instead of escapes at line 5865, column 31. See page 247 of PBP. (Severity: 1) -Regular expression without "/s" flag at line 5865, column 31. See pages 240,241 of PBP. (Severity: 2) -Regular expression without "/m" flag at line 5865, column 31. See page 237 of PBP. (Severity: 2) -Regular expression without "/s" flag at line 5954, column 24. See pages 240,241 of PBP. (Severity: 2) -Regular expression without "/m" flag at line 5954, column 24. See page 237 of PBP. (Severity: 2) -Regular expression without "/s" flag at line 5957, column 20. See pages 240,241 of PBP. (Severity: 2) -Regular expression without "/m" flag at line 5957, column 20. See page 237 of PBP. (Severity: 2) -Use 'eq' or hash instead of fixed-pattern regexps at line 6169, column 38. See pages 271,272 of PBP. (Severity: 2) -Regular expression without "/s" flag at line 6169, column 38. See pages 240,241 of PBP. (Severity: 2) -Regular expression without "/m" flag at line 6169, column 38. See page 237 of PBP. (Severity: 2) -Regular expression without "/s" flag at line 6170, column 33. See pages 240,241 of PBP. (Severity: 2) -Regular expression without "/m" flag at line 6170, column 33. See page 237 of PBP. (Severity: 2) -Use character classes for literal metachars instead of escapes at line 6174, column 33. See page 247 of PBP. (Severity: 1) -Use [\.\/] instead of \.|\/ at line 6174, column 33. See page 265 of PBP. (Severity: 1) -Regular expression without "/s" flag at line 6174, column 33. See pages 240,241 of PBP. (Severity: 2) -Regular expression without "/m" flag at line 6174, column 33. See page 237 of PBP. (Severity: 2) -Local lexical variable "$Side" is not all lower case or all upper case at line 6204, column 9. See pages 45,46 of PBP. (Severity: 1) -Quotes used with a noisy string at line 6249, column 26. See page 53 of PBP. (Severity: 2) -Postfix control "while" used at line 6249, column 34. See page 96 of PBP. (Severity: 2) -Regular expression without "/s" flag at line 6249, column 53. See pages 240,241 of PBP. (Severity: 2) -Regular expression without "/m" flag at line 6249, column 53. See page 237 of PBP. (Severity: 2) -Quotes used with a noisy string at line 6250, column 26. See page 53 of PBP. (Severity: 2) -Postfix control "while" used at line 6250, column 34. See page 96 of PBP. (Severity: 2) -Use character classes for literal metachars instead of escapes at line 6250, column 53. See page 247 of PBP. (Severity: 1) -Regular expression without "/s" flag at line 6250, column 53. See pages 240,241 of PBP. (Severity: 2) -Regular expression without "/m" flag at line 6250, column 53. See page 237 of PBP. (Severity: 2) -Postfix control "while" used at line 6251, column 36. See page 96 of PBP. (Severity: 2) -Regular expression without "/s" flag at line 6251, column 55. See pages 240,241 of PBP. (Severity: 2) -Regular expression without "/m" flag at line 6251, column 55. See page 237 of PBP. (Severity: 2) +Regular expression without "/s" flag at line 5820, column 15. See pages 240,241 of PBP. (Severity: 2) +Regular expression without "/m" flag at line 5820, column 15. See page 237 of PBP. (Severity: 2) +Use character classes for literal metachars instead of escapes at line 5821, column 15. See page 247 of PBP. (Severity: 1) +Regular expression without "/s" flag at line 5821, column 15. See pages 240,241 of PBP. (Severity: 2) +Regular expression without "/m" flag at line 5821, column 15. See page 237 of PBP. (Severity: 2) +Use character classes for literal metachars instead of escapes at line 5867, column 31. See page 247 of PBP. (Severity: 1) +Regular expression without "/s" flag at line 5867, column 31. See pages 240,241 of PBP. (Severity: 2) +Regular expression without "/m" flag at line 5867, column 31. See page 237 of PBP. (Severity: 2) +Regular expression without "/s" flag at line 5956, column 24. See pages 240,241 of PBP. (Severity: 2) +Regular expression without "/m" flag at line 5956, column 24. See page 237 of PBP. (Severity: 2) +Regular expression without "/s" flag at line 5959, column 20. See pages 240,241 of PBP. (Severity: 2) +Regular expression without "/m" flag at line 5959, column 20. See page 237 of PBP. (Severity: 2) +Use 'eq' or hash instead of fixed-pattern regexps at line 6171, column 38. See pages 271,272 of PBP. (Severity: 2) +Regular expression without "/s" flag at line 6171, column 38. See pages 240,241 of PBP. (Severity: 2) +Regular expression without "/m" flag at line 6171, column 38. See page 237 of PBP. (Severity: 2) +Regular expression without "/s" flag at line 6172, column 33. See pages 240,241 of PBP. (Severity: 2) +Regular expression without "/m" flag at line 6172, column 33. See page 237 of PBP. (Severity: 2) +Use character classes for literal metachars instead of escapes at line 6176, column 33. See page 247 of PBP. (Severity: 1) +Use [\.\/] instead of \.|\/ at line 6176, column 33. See page 265 of PBP. (Severity: 1) +Regular expression without "/s" flag at line 6176, column 33. See pages 240,241 of PBP. (Severity: 2) +Regular expression without "/m" flag at line 6176, column 33. See page 237 of PBP. (Severity: 2) +Local lexical variable "$Side" is not all lower case or all upper case at line 6206, column 9. See pages 45,46 of PBP. (Severity: 1) +Quotes used with a noisy string at line 6251, column 26. See page 53 of PBP. (Severity: 2) +Postfix control "while" used at line 6251, column 34. See page 96 of PBP. (Severity: 2) +Regular expression without "/s" flag at line 6251, column 53. See pages 240,241 of PBP. (Severity: 2) +Regular expression without "/m" flag at line 6251, column 53. See page 237 of PBP. (Severity: 2) Quotes used with a noisy string at line 6252, column 26. See page 53 of PBP. (Severity: 2) Postfix control "while" used at line 6252, column 34. See page 96 of PBP. (Severity: 2) +Use character classes for literal metachars instead of escapes at line 6252, column 53. See page 247 of PBP. (Severity: 1) Regular expression without "/s" flag at line 6252, column 53. See pages 240,241 of PBP. (Severity: 2) Regular expression without "/m" flag at line 6252, column 53. See page 237 of PBP. (Severity: 2) -Forbid $b before $a in sort blocks at line 6254, column 27. See page 152 of PBP. (Severity: 1) -Quotes used with a noisy string at line 6264, column 13. See page 53 of PBP. (Severity: 2) -Quotes used with a noisy string at line 6265, column 13. See page 53 of PBP. (Severity: 2) +Postfix control "while" used at line 6253, column 36. See page 96 of PBP. (Severity: 2) +Regular expression without "/s" flag at line 6253, column 55. See pages 240,241 of PBP. (Severity: 2) +Regular expression without "/m" flag at line 6253, column 55. See page 237 of PBP. (Severity: 2) +Quotes used with a noisy string at line 6254, column 26. See page 53 of PBP. (Severity: 2) +Postfix control "while" used at line 6254, column 34. See page 96 of PBP. (Severity: 2) +Regular expression without "/s" flag at line 6254, column 53. See pages 240,241 of PBP. (Severity: 2) +Regular expression without "/m" flag at line 6254, column 53. See page 237 of PBP. (Severity: 2) +Forbid $b before $a in sort blocks at line 6256, column 27. See page 152 of PBP. (Severity: 1) Quotes used with a noisy string at line 6266, column 13. See page 53 of PBP. (Severity: 2) Quotes used with a noisy string at line 6267, column 13. See page 53 of PBP. (Severity: 2) +Quotes used with a noisy string at line 6268, column 13. See page 53 of PBP. (Severity: 2) Quotes used with a noisy string at line 6269, column 13. See page 53 of PBP. (Severity: 2) -Quotes used with a noisy string at line 6270, column 13. See page 53 of PBP. (Severity: 2) Quotes used with a noisy string at line 6271, column 13. See page 53 of PBP. (Severity: 2) -Local lexical variable "$Side" is not all lower case or all upper case at line 6279, column 9. See pages 45,46 of PBP. (Severity: 1) -Quotes used with a noisy string at line 6365, column 11. See page 53 of PBP. (Severity: 2) -Quotes used with a noisy string at line 6366, column 11. See page 53 of PBP. (Severity: 2) -String *may* require interpolation at line 6400, column 18. See page 51 of PBP. (Severity: 1) -String *may* require interpolation at line 6401, column 48. See page 51 of PBP. (Severity: 1) -Quotes used with a noisy string at line 6412, column 11. See page 53 of PBP. (Severity: 2) -Quotes used with a noisy string at line 6413, column 11. See page 53 of PBP. (Severity: 2) -Quotes used with a noisy string at line 6428, column 11. See page 53 of PBP. (Severity: 2) -Quotes used with a noisy string at line 6429, column 11. See page 53 of PBP. (Severity: 2) -String *may* require interpolation at line 6432, column 18. See page 51 of PBP. (Severity: 1) -String *may* require interpolation at line 6435, column 18. See page 51 of PBP. (Severity: 1) -Quotes used with a string containing no non-whitespace characters at line 6488, column 30. See page 53 of PBP. (Severity: 2) -Quotes used with a string containing no non-whitespace characters at line 6489, column 30. See page 53 of PBP. (Severity: 2) -Quotes used with a noisy string at line 6490, column 30. See page 53 of PBP. (Severity: 2) -Quotes used with a noisy string at line 6491, column 30. See page 53 of PBP. (Severity: 2) -String *may* require interpolation at line 6494, column 74. See page 51 of PBP. (Severity: 1) -String *may* require interpolation at line 6495, column 74. See page 51 of PBP. (Severity: 1) +Quotes used with a noisy string at line 6272, column 13. See page 53 of PBP. (Severity: 2) +Quotes used with a noisy string at line 6273, column 13. See page 53 of PBP. (Severity: 2) +Local lexical variable "$Side" is not all lower case or all upper case at line 6281, column 9. See pages 45,46 of PBP. (Severity: 1) +Quotes used with a noisy string at line 6367, column 11. See page 53 of PBP. (Severity: 2) +Quotes used with a noisy string at line 6368, column 11. See page 53 of PBP. (Severity: 2) +String *may* require interpolation at line 6402, column 18. See page 51 of PBP. (Severity: 1) +String *may* require interpolation at line 6403, column 48. See page 51 of PBP. (Severity: 1) +Quotes used with a noisy string at line 6414, column 11. See page 53 of PBP. (Severity: 2) +Quotes used with a noisy string at line 6415, column 11. See page 53 of PBP. (Severity: 2) +Quotes used with a noisy string at line 6430, column 11. See page 53 of PBP. (Severity: 2) +Quotes used with a noisy string at line 6431, column 11. See page 53 of PBP. (Severity: 2) +String *may* require interpolation at line 6434, column 18. See page 51 of PBP. (Severity: 1) +String *may* require interpolation at line 6437, column 18. See page 51 of PBP. (Severity: 1) +Quotes used with a string containing no non-whitespace characters at line 6490, column 30. See page 53 of PBP. (Severity: 2) +Quotes used with a string containing no non-whitespace characters at line 6491, column 30. See page 53 of PBP. (Severity: 2) +Quotes used with a noisy string at line 6492, column 30. See page 53 of PBP. (Severity: 2) +Quotes used with a noisy string at line 6493, column 30. See page 53 of PBP. (Severity: 2) String *may* require interpolation at line 6496, column 74. See page 51 of PBP. (Severity: 1) String *may* require interpolation at line 6497, column 74. See page 51 of PBP. (Severity: 1) String *may* require interpolation at line 6498, column 74. See page 51 of PBP. (Severity: 1) String *may* require interpolation at line 6499, column 74. See page 51 of PBP. (Severity: 1) -Quotes used with a noisy string at line 6540, column 65. See page 53 of PBP. (Severity: 2) -Quotes used with a noisy string at line 6541, column 65. See page 53 of PBP. (Severity: 2) -Regular expression without "/s" flag at line 6544, column 21. See pages 240,241 of PBP. (Severity: 2) -Regular expression without "/m" flag at line 6544, column 21. See page 237 of PBP. (Severity: 2) -Postfix control "unless" used at line 6550, column 11. See pages 96,97 of PBP. (Severity: 2) -Use 'eq' or hash instead of fixed-pattern regexps at line 6550, column 79. See pages 271,272 of PBP. (Severity: 2) -Regular expression without "/s" flag at line 6550, column 79. See pages 240,241 of PBP. (Severity: 2) -Regular expression without "/m" flag at line 6550, column 79. See page 237 of PBP. (Severity: 2) -Quotes used with a noisy string at line 6566, column 53. See page 53 of PBP. (Severity: 2) -Quotes used with a noisy string at line 6566, column 58. See page 53 of PBP. (Severity: 2) -Quotes used with a noisy string at line 6567, column 55. See page 53 of PBP. (Severity: 2) -Quotes used with a noisy string at line 6567, column 60. See page 53 of PBP. (Severity: 2) -Quotes used with a noisy string at line 6568, column 55. See page 53 of PBP. (Severity: 2) -Quotes used with a noisy string at line 6568, column 60. See page 53 of PBP. (Severity: 2) +String *may* require interpolation at line 6500, column 74. See page 51 of PBP. (Severity: 1) +String *may* require interpolation at line 6501, column 74. See page 51 of PBP. (Severity: 1) +Quotes used with a noisy string at line 6542, column 65. See page 53 of PBP. (Severity: 2) +Quotes used with a noisy string at line 6543, column 65. See page 53 of PBP. (Severity: 2) +Regular expression without "/s" flag at line 6546, column 21. See pages 240,241 of PBP. (Severity: 2) +Regular expression without "/m" flag at line 6546, column 21. See page 237 of PBP. (Severity: 2) +Postfix control "unless" used at line 6552, column 11. See pages 96,97 of PBP. (Severity: 2) +Use 'eq' or hash instead of fixed-pattern regexps at line 6552, column 79. See pages 271,272 of PBP. (Severity: 2) +Regular expression without "/s" flag at line 6552, column 79. See pages 240,241 of PBP. (Severity: 2) +Regular expression without "/m" flag at line 6552, column 79. See page 237 of PBP. (Severity: 2) +Quotes used with a noisy string at line 6568, column 53. See page 53 of PBP. (Severity: 2) +Quotes used with a noisy string at line 6568, column 58. See page 53 of PBP. (Severity: 2) Quotes used with a noisy string at line 6569, column 55. See page 53 of PBP. (Severity: 2) Quotes used with a noisy string at line 6569, column 60. See page 53 of PBP. (Severity: 2) -Quotes used with a noisy string at line 6570, column 57. See page 53 of PBP. (Severity: 2) -Quotes used with a noisy string at line 6570, column 62. See page 53 of PBP. (Severity: 2) +Quotes used with a noisy string at line 6570, column 55. See page 53 of PBP. (Severity: 2) +Quotes used with a noisy string at line 6570, column 60. See page 53 of PBP. (Severity: 2) +Quotes used with a noisy string at line 6571, column 55. See page 53 of PBP. (Severity: 2) +Quotes used with a noisy string at line 6571, column 60. See page 53 of PBP. (Severity: 2) Quotes used with a noisy string at line 6572, column 57. See page 53 of PBP. (Severity: 2) Quotes used with a noisy string at line 6572, column 62. See page 53 of PBP. (Severity: 2) Quotes used with a noisy string at line 6574, column 57. See page 53 of PBP. (Severity: 2) Quotes used with a noisy string at line 6574, column 62. See page 53 of PBP. (Severity: 2) -Numeric escapes in interpolated string at line 6588, column 21. See pages 54,55 of PBP. (Severity: 2) -Use only '//' or '{}' to delimit regexps at line 6591, column 21. See page 246 of PBP. (Severity: 1) -Regular expression without "/s" flag at line 6591, column 21. See pages 240,241 of PBP. (Severity: 2) -Regular expression without "/m" flag at line 6591, column 21. See page 237 of PBP. (Severity: 2) -Use only '//' or '{}' to delimit regexps at line 6592, column 21. See page 246 of PBP. (Severity: 1) -Regular expression without "/s" flag at line 6592, column 21. See pages 240,241 of PBP. (Severity: 2) -Regular expression without "/m" flag at line 6592, column 21. See page 237 of PBP. (Severity: 2) +Quotes used with a noisy string at line 6576, column 57. See page 53 of PBP. (Severity: 2) +Quotes used with a noisy string at line 6576, column 62. See page 53 of PBP. (Severity: 2) +Numeric escapes in interpolated string at line 6590, column 21. See pages 54,55 of PBP. (Severity: 2) Use only '//' or '{}' to delimit regexps at line 6593, column 21. See page 246 of PBP. (Severity: 1) Regular expression without "/s" flag at line 6593, column 21. See pages 240,241 of PBP. (Severity: 2) Regular expression without "/m" flag at line 6593, column 21. See page 237 of PBP. (Severity: 2) Use only '//' or '{}' to delimit regexps at line 6594, column 21. See page 246 of PBP. (Severity: 1) Regular expression without "/s" flag at line 6594, column 21. See pages 240,241 of PBP. (Severity: 2) Regular expression without "/m" flag at line 6594, column 21. See page 237 of PBP. (Severity: 2) -Postfix control "if" used at line 6594, column 30. See pages 93,94 of PBP. (Severity: 2) -Quotes used with a noisy string at line 6594, column 49. See page 53 of PBP. (Severity: 2) -Quotes used with a noisy string at line 6594, column 74. See page 53 of PBP. (Severity: 2) -Expression form of "eval" at line 6605, column 27. See page 161 of PBP. (Severity: 5) -Quotes used with a noisy string at line 6621, column 35. See page 53 of PBP. (Severity: 2) -Regular expression without "/s" flag at line 6632, column 49. See pages 240,241 of PBP. (Severity: 2) -Regular expression without "/m" flag at line 6632, column 49. See page 237 of PBP. (Severity: 2) -"unless" block used at line 6666, column 17. See page 97 of PBP. (Severity: 2) -Postfix control "if" used at line 6679, column 53. See pages 93,94 of PBP. (Severity: 2) -String *may* require interpolation at line 6748, column 13. See page 51 of PBP. (Severity: 1) -String *may* require interpolation at line 6748, column 52. See page 51 of PBP. (Severity: 1) -String *may* require interpolation at line 6754, column 13. See page 51 of PBP. (Severity: 1) -String *may* require interpolation at line 6754, column 45. See page 51 of PBP. (Severity: 1) -Single-quote used as quote-like operator delimiter at line 6755, column 24. Using quotes as delimiters for quote-like operators obfuscates code. (Severity: 3) -String *may* require interpolation at line 6755, column 24. See page 51 of PBP. (Severity: 1) -String *may* require interpolation at line 6756, column 47. See page 51 of PBP. (Severity: 1) -String *may* require interpolation at line 6756, column 73. See page 51 of PBP. (Severity: 1) -String *may* require interpolation at line 6760, column 13. See page 51 of PBP. (Severity: 1) -String *may* require interpolation at line 6760, column 47. See page 51 of PBP. (Severity: 1) -String *may* require interpolation at line 6763, column 13. See page 51 of PBP. (Severity: 1) -String *may* require interpolation at line 6763, column 53. See page 51 of PBP. (Severity: 1) -String *may* require interpolation at line 6763, column 92. See page 51 of PBP. (Severity: 1) -String *may* require interpolation at line 6764, column 13. See page 51 of PBP. (Severity: 1) -String *may* require interpolation at line 6764, column 53. See page 51 of PBP. (Severity: 1) -String *may* require interpolation at line 6765, column 22. See page 51 of PBP. (Severity: 1) -String *may* require interpolation at line 6767, column 24. See page 51 of PBP. (Severity: 1) -String *may* require interpolation at line 6776, column 24. See page 51 of PBP. (Severity: 1) -String *may* require interpolation at line 6782, column 24. See page 51 of PBP. (Severity: 1) -String *may* require interpolation at line 6783, column 12. See page 51 of PBP. (Severity: 1) -String *may* require interpolation at line 6792, column 24. See page 51 of PBP. (Severity: 1) -String *may* require interpolation at line 6793, column 84. See page 51 of PBP. (Severity: 1) -String *may* require interpolation at line 6798, column 9. See page 51 of PBP. (Severity: 1) -String *may* require interpolation at line 6802, column 24. See page 51 of PBP. (Severity: 1) -String *may* require interpolation at line 6808, column 24. See page 51 of PBP. (Severity: 1) -Expression form of "eval" at line 6846, column 27. See page 161 of PBP. (Severity: 5) -"unless" block used at line 6870, column 25. See page 97 of PBP. (Severity: 2) -Use character classes for literal metachars instead of escapes at line 6907, column 31. See page 247 of PBP. (Severity: 1) -Regular expression without "/s" flag at line 6907, column 31. See pages 240,241 of PBP. (Severity: 2) -Regular expression without "/m" flag at line 6907, column 31. See page 237 of PBP. (Severity: 2) -Use character classes for literal metachars instead of escapes at line 6910, column 49. See page 247 of PBP. (Severity: 1) -Regular expression without "/s" flag at line 6910, column 49. See pages 240,241 of PBP. (Severity: 2) -Regular expression without "/m" flag at line 6910, column 49. See page 237 of PBP. (Severity: 2) -Regular expression without "/s" flag at line 6940, column 28. See pages 240,241 of PBP. (Severity: 2) -Regular expression without "/m" flag at line 6940, column 28. See page 237 of PBP. (Severity: 2) -Regular expression without "/s" flag at line 6953, column 27. See pages 240,241 of PBP. (Severity: 2) -Regular expression without "/m" flag at line 6953, column 27. See page 237 of PBP. (Severity: 2) -Useless use of $_ at line 6955, column 60. $_ should be omitted when calling "lc". (Severity: 2) -Useless use of $_ at line 6955, column 82. $_ should be omitted when calling "lc". (Severity: 2) -Builtin function called with parentheses at line 6988, column 21. See page 13 of PBP. (Severity: 1) -String *may* require interpolation at line 7004, column 34. See page 51 of PBP. (Severity: 1) -String *may* require interpolation at line 7004, column 45. See page 51 of PBP. (Severity: 1) -String *may* require interpolation at line 7005, column 34. See page 51 of PBP. (Severity: 1) -String *may* require interpolation at line 7005, column 45. See page 51 of PBP. (Severity: 1) -"unless" block used at line 7144, column 17. See page 97 of PBP. (Severity: 2) -"unless" block used at line 7145, column 17. See page 97 of PBP. (Severity: 2) -Postfix control "if" used at line 7233, column 22. See pages 93,94 of PBP. (Severity: 2) -Subroutine "copy_message" with high complexity score (22) at line 7277, column 1. Consider refactoring. (Severity: 3) -Too many arguments at line 7277, column 1. See page 182 of PBP. (Severity: 3) -Postfix control "if" used at line 7295, column 107. See pages 93,94 of PBP. (Severity: 2) -Useless interpolation of literal string at line 7301, column 40. See page 51 of PBP. (Severity: 1) -Useless interpolation of literal string at line 7306, column 40. See page 51 of PBP. (Severity: 1) -Postfix control "if" used at line 7334, column 26. See pages 93,94 of PBP. (Severity: 2) -Useless interpolation of literal string at line 7344, column 40. See page 51 of PBP. (Severity: 1) -Too many arguments at line 7351, column 1. See page 182 of PBP. (Severity: 3) -Subroutine "message_for_host2" with high complexity score (23) at line 7385, column 1. Consider refactoring. (Severity: 3) -Too many arguments at line 7385, column 1. See page 182 of PBP. (Severity: 3) -Useless interpolation of literal string at line 7414, column 38. See page 51 of PBP. (Severity: 1) -Useless interpolation of literal string at line 7419, column 38. See page 51 of PBP. (Severity: 1) -"unless" block used at line 7424, column 9. See page 97 of PBP. (Severity: 2) -Useless interpolation of literal string at line 7487, column 38. See page 51 of PBP. (Severity: 1) -Useless interpolation of literal string at line 7504, column 21. See page 51 of PBP. (Severity: 1) -Local lexical variable "$imapT" is not all lower case or all upper case at line 7505, column 9. See pages 45,46 of PBP. (Severity: 1) -Quotes used with a string containing no non-whitespace characters at line 7512, column 21. See page 53 of PBP. (Severity: 2) -Constant "$NB_WIN_tests_message_for_host2" is not all upper case at line 7531, column 17. See pages 45,46 of PBP. (Severity: 1) -Postfix control "if" used at line 7532, column 75. See pages 93,94 of PBP. (Severity: 2) -Constant "$NB_UNX_tests_message_for_host2" is not all upper case at line 7540, column 17. See pages 45,46 of PBP. (Severity: 1) -Postfix control "if" used at line 7541, column 72. See pages 93,94 of PBP. (Severity: 2) -Useless interpolation of literal string at line 7590, column 21. See page 51 of PBP. (Severity: 1) -String *may* require interpolation at line 7607, column 53. See page 51 of PBP. (Severity: 1) -Reused variable name in lexical scope: $uid1 at line 7615, column 9. Invent unique variable names. (Severity: 3) -Reused variable name in lexical scope: $uid2 at line 7615, column 9. Invent unique variable names. (Severity: 3) -Useless interpolation of literal string at line 7638, column 21. See page 51 of PBP. (Severity: 1) -String *may* require interpolation at line 7667, column 43. See page 51 of PBP. (Severity: 1) -String *may* require interpolation at line 7669, column 49. See page 51 of PBP. (Severity: 1) -String *may* require interpolation at line 7670, column 53. See page 51 of PBP. (Severity: 1) -Use only '//' or '{}' to delimit regexps at line 7729, column 22. See page 246 of PBP. (Severity: 1) -Regular expression without "/s" flag at line 7729, column 22. See pages 240,241 of PBP. (Severity: 2) -Regular expression without "/m" flag at line 7729, column 22. See page 237 of PBP. (Severity: 2) -Postfix control "if" used at line 7734, column 44. See pages 93,94 of PBP. (Severity: 2) -Postfix control "if" used at line 7735, column 64. See pages 93,94 of PBP. (Severity: 2) -String *may* require interpolation at line 7761, column 70. See page 51 of PBP. (Severity: 1) -Too many arguments at line 7811, column 1. See page 182 of PBP. (Severity: 3) -Useless interpolation of literal string at line 7814, column 40. See page 51 of PBP. (Severity: 1) -Useless interpolation of literal string at line 7820, column 48. See page 51 of PBP. (Severity: 1) -Regular expression without "/s" flag at line 7833, column 41. See pages 240,241 of PBP. (Severity: 2) -Regular expression without "/m" flag at line 7833, column 41. See page 237 of PBP. (Severity: 2) -Regular expression without "/s" flag at line 7852, column 75. See pages 240,241 of PBP. (Severity: 2) -Regular expression without "/m" flag at line 7852, column 75. See page 237 of PBP. (Severity: 2) -Found "\N{SPACE}" at the end of the line at line 7861, column 1. Don't use whitespace at the end of lines. (Severity: 1) -Useless interpolation of literal string at line 7936, column 26. See page 51 of PBP. (Severity: 1) -Quotes used with a string containing no non-whitespace characters at line 8027, column 13. See page 53 of PBP. (Severity: 2) -Useless interpolation of literal string at line 8027, column 13. See page 51 of PBP. (Severity: 1) +Use only '//' or '{}' to delimit regexps at line 6595, column 21. See page 246 of PBP. (Severity: 1) +Regular expression without "/s" flag at line 6595, column 21. See pages 240,241 of PBP. (Severity: 2) +Regular expression without "/m" flag at line 6595, column 21. See page 237 of PBP. (Severity: 2) +Use only '//' or '{}' to delimit regexps at line 6596, column 21. See page 246 of PBP. (Severity: 1) +Regular expression without "/s" flag at line 6596, column 21. See pages 240,241 of PBP. (Severity: 2) +Regular expression without "/m" flag at line 6596, column 21. See page 237 of PBP. (Severity: 2) +Postfix control "if" used at line 6596, column 30. See pages 93,94 of PBP. (Severity: 2) +Quotes used with a noisy string at line 6596, column 49. See page 53 of PBP. (Severity: 2) +Quotes used with a noisy string at line 6596, column 74. See page 53 of PBP. (Severity: 2) +Expression form of "eval" at line 6607, column 27. See page 161 of PBP. (Severity: 5) +Quotes used with a noisy string at line 6623, column 35. See page 53 of PBP. (Severity: 2) +Regular expression without "/s" flag at line 6634, column 49. See pages 240,241 of PBP. (Severity: 2) +Regular expression without "/m" flag at line 6634, column 49. See page 237 of PBP. (Severity: 2) +"unless" block used at line 6668, column 17. See page 97 of PBP. (Severity: 2) +Postfix control "if" used at line 6681, column 53. See pages 93,94 of PBP. (Severity: 2) +String *may* require interpolation at line 6750, column 13. See page 51 of PBP. (Severity: 1) +String *may* require interpolation at line 6750, column 52. See page 51 of PBP. (Severity: 1) +String *may* require interpolation at line 6756, column 13. See page 51 of PBP. (Severity: 1) +String *may* require interpolation at line 6756, column 45. See page 51 of PBP. (Severity: 1) +Single-quote used as quote-like operator delimiter at line 6757, column 24. Using quotes as delimiters for quote-like operators obfuscates code. (Severity: 3) +String *may* require interpolation at line 6757, column 24. See page 51 of PBP. (Severity: 1) +String *may* require interpolation at line 6758, column 47. See page 51 of PBP. (Severity: 1) +String *may* require interpolation at line 6758, column 73. See page 51 of PBP. (Severity: 1) +String *may* require interpolation at line 6762, column 13. See page 51 of PBP. (Severity: 1) +String *may* require interpolation at line 6762, column 47. See page 51 of PBP. (Severity: 1) +String *may* require interpolation at line 6765, column 13. See page 51 of PBP. (Severity: 1) +String *may* require interpolation at line 6765, column 53. See page 51 of PBP. (Severity: 1) +String *may* require interpolation at line 6765, column 92. See page 51 of PBP. (Severity: 1) +String *may* require interpolation at line 6766, column 13. See page 51 of PBP. (Severity: 1) +String *may* require interpolation at line 6766, column 53. See page 51 of PBP. (Severity: 1) +String *may* require interpolation at line 6767, column 22. See page 51 of PBP. (Severity: 1) +String *may* require interpolation at line 6769, column 24. See page 51 of PBP. (Severity: 1) +String *may* require interpolation at line 6778, column 24. See page 51 of PBP. (Severity: 1) +String *may* require interpolation at line 6784, column 24. See page 51 of PBP. (Severity: 1) +String *may* require interpolation at line 6785, column 12. See page 51 of PBP. (Severity: 1) +String *may* require interpolation at line 6794, column 24. See page 51 of PBP. (Severity: 1) +String *may* require interpolation at line 6795, column 84. See page 51 of PBP. (Severity: 1) +String *may* require interpolation at line 6800, column 9. See page 51 of PBP. (Severity: 1) +String *may* require interpolation at line 6804, column 24. See page 51 of PBP. (Severity: 1) +String *may* require interpolation at line 6810, column 24. See page 51 of PBP. (Severity: 1) +Expression form of "eval" at line 6848, column 27. See page 161 of PBP. (Severity: 5) +"unless" block used at line 6872, column 25. See page 97 of PBP. (Severity: 2) +Use character classes for literal metachars instead of escapes at line 6909, column 31. See page 247 of PBP. (Severity: 1) +Regular expression without "/s" flag at line 6909, column 31. See pages 240,241 of PBP. (Severity: 2) +Regular expression without "/m" flag at line 6909, column 31. See page 237 of PBP. (Severity: 2) +Use character classes for literal metachars instead of escapes at line 6912, column 49. See page 247 of PBP. (Severity: 1) +Regular expression without "/s" flag at line 6912, column 49. See pages 240,241 of PBP. (Severity: 2) +Regular expression without "/m" flag at line 6912, column 49. See page 237 of PBP. (Severity: 2) +Regular expression without "/s" flag at line 6942, column 28. See pages 240,241 of PBP. (Severity: 2) +Regular expression without "/m" flag at line 6942, column 28. See page 237 of PBP. (Severity: 2) +Regular expression without "/s" flag at line 6955, column 27. See pages 240,241 of PBP. (Severity: 2) +Regular expression without "/m" flag at line 6955, column 27. See page 237 of PBP. (Severity: 2) +Useless use of $_ at line 6957, column 60. $_ should be omitted when calling "lc". (Severity: 2) +Useless use of $_ at line 6957, column 82. $_ should be omitted when calling "lc". (Severity: 2) +Builtin function called with parentheses at line 6990, column 21. See page 13 of PBP. (Severity: 1) +String *may* require interpolation at line 7006, column 34. See page 51 of PBP. (Severity: 1) +String *may* require interpolation at line 7006, column 45. See page 51 of PBP. (Severity: 1) +String *may* require interpolation at line 7007, column 34. See page 51 of PBP. (Severity: 1) +String *may* require interpolation at line 7007, column 45. See page 51 of PBP. (Severity: 1) +"unless" block used at line 7146, column 17. See page 97 of PBP. (Severity: 2) +"unless" block used at line 7147, column 17. See page 97 of PBP. (Severity: 2) +Postfix control "if" used at line 7235, column 22. See pages 93,94 of PBP. (Severity: 2) +Subroutine "copy_message" with high complexity score (22) at line 7279, column 1. Consider refactoring. (Severity: 3) +Too many arguments at line 7279, column 1. See page 182 of PBP. (Severity: 3) +Postfix control "if" used at line 7297, column 107. See pages 93,94 of PBP. (Severity: 2) +Useless interpolation of literal string at line 7303, column 40. See page 51 of PBP. (Severity: 1) +Useless interpolation of literal string at line 7308, column 40. See page 51 of PBP. (Severity: 1) +Postfix control "if" used at line 7336, column 26. See pages 93,94 of PBP. (Severity: 2) +Useless interpolation of literal string at line 7346, column 40. See page 51 of PBP. (Severity: 1) +Too many arguments at line 7353, column 1. See page 182 of PBP. (Severity: 3) +Subroutine "message_for_host2" with high complexity score (23) at line 7387, column 1. Consider refactoring. (Severity: 3) +Too many arguments at line 7387, column 1. See page 182 of PBP. (Severity: 3) +Useless interpolation of literal string at line 7416, column 38. See page 51 of PBP. (Severity: 1) +Useless interpolation of literal string at line 7421, column 38. See page 51 of PBP. (Severity: 1) +"unless" block used at line 7426, column 9. See page 97 of PBP. (Severity: 2) +Useless interpolation of literal string at line 7489, column 38. See page 51 of PBP. (Severity: 1) +Useless interpolation of literal string at line 7506, column 21. See page 51 of PBP. (Severity: 1) +Local lexical variable "$imapT" is not all lower case or all upper case at line 7507, column 9. See pages 45,46 of PBP. (Severity: 1) +Quotes used with a string containing no non-whitespace characters at line 7514, column 21. See page 53 of PBP. (Severity: 2) +Constant "$NB_WIN_tests_message_for_host2" is not all upper case at line 7533, column 17. See pages 45,46 of PBP. (Severity: 1) +Postfix control "if" used at line 7534, column 75. See pages 93,94 of PBP. (Severity: 2) +Constant "$NB_UNX_tests_message_for_host2" is not all upper case at line 7542, column 17. See pages 45,46 of PBP. (Severity: 1) +Postfix control "if" used at line 7543, column 72. See pages 93,94 of PBP. (Severity: 2) +Useless interpolation of literal string at line 7592, column 21. See page 51 of PBP. (Severity: 1) +String *may* require interpolation at line 7609, column 53. See page 51 of PBP. (Severity: 1) +Reused variable name in lexical scope: $uid1 at line 7617, column 9. Invent unique variable names. (Severity: 3) +Reused variable name in lexical scope: $uid2 at line 7617, column 9. Invent unique variable names. (Severity: 3) +Useless interpolation of literal string at line 7640, column 21. See page 51 of PBP. (Severity: 1) +String *may* require interpolation at line 7669, column 43. See page 51 of PBP. (Severity: 1) +String *may* require interpolation at line 7671, column 49. See page 51 of PBP. (Severity: 1) +String *may* require interpolation at line 7672, column 53. See page 51 of PBP. (Severity: 1) +Use only '//' or '{}' to delimit regexps at line 7731, column 22. See page 246 of PBP. (Severity: 1) +Regular expression without "/s" flag at line 7731, column 22. See pages 240,241 of PBP. (Severity: 2) +Regular expression without "/m" flag at line 7731, column 22. See page 237 of PBP. (Severity: 2) +Postfix control "if" used at line 7736, column 44. See pages 93,94 of PBP. (Severity: 2) +Postfix control "if" used at line 7737, column 64. See pages 93,94 of PBP. (Severity: 2) +String *may* require interpolation at line 7763, column 70. See page 51 of PBP. (Severity: 1) +Too many arguments at line 7813, column 1. See page 182 of PBP. (Severity: 3) +Useless interpolation of literal string at line 7816, column 40. See page 51 of PBP. (Severity: 1) +Useless interpolation of literal string at line 7822, column 48. See page 51 of PBP. (Severity: 1) +Regular expression without "/s" flag at line 7835, column 41. See pages 240,241 of PBP. (Severity: 2) +Regular expression without "/m" flag at line 7835, column 41. See page 237 of PBP. (Severity: 2) +Regular expression without "/s" flag at line 7854, column 75. See pages 240,241 of PBP. (Severity: 2) +Regular expression without "/m" flag at line 7854, column 75. See page 237 of PBP. (Severity: 2) +Found "\N{SPACE}" at the end of the line at line 7863, column 1. Don't use whitespace at the end of lines. (Severity: 1) +Useless interpolation of literal string at line 7938, column 26. See page 51 of PBP. (Severity: 1) Quotes used with a string containing no non-whitespace characters at line 8029, column 13. See page 53 of PBP. (Severity: 2) Useless interpolation of literal string at line 8029, column 13. See page 51 of PBP. (Severity: 1) -Quotes used with a string containing no non-whitespace characters at line 8041, column 13. See page 53 of PBP. (Severity: 2) -Useless interpolation of literal string at line 8041, column 13. See page 51 of PBP. (Severity: 1) -Quotes used with a string containing no non-whitespace characters at line 8042, column 13. See page 53 of PBP. (Severity: 2) -Useless interpolation of literal string at line 8042, column 13. See page 51 of PBP. (Severity: 1) -Too many arguments at line 8050, column 1. See page 182 of PBP. (Severity: 3) -Local lexical variable "$hostX_folder" is not all lower case or all upper case at line 8052, column 9. See pages 45,46 of PBP. (Severity: 1) -Postfix control "if" used at line 8056, column 43. See pages 93,94 of PBP. (Severity: 2) -Found "\N{SPACE}" at the end of the line at line 8070, column 51. Don't use whitespace at the end of lines. (Severity: 1) -Builtin function called with parentheses at line 8077, column 45. See page 13 of PBP. (Severity: 1) -Useless interpolation of literal string at line 8107, column 21. See page 51 of PBP. (Severity: 1) -List of quoted literal words at line 8114, column 21. Use 'qw()' instead. (Severity: 2) -Use character classes for literal metachars instead of escapes at line 8276, column 23. See page 247 of PBP. (Severity: 1) -Regular expression without "/s" flag at line 8276, column 23. See pages 240,241 of PBP. (Severity: 2) -Regular expression without "/m" flag at line 8276, column 23. See page 237 of PBP. (Severity: 2) -Use [\[\]] instead of \[|\] at line 8302, column 23. See page 265 of PBP. (Severity: 1) -Regular expression without "/s" flag at line 8302, column 23. See pages 240,241 of PBP. (Severity: 2) -Regular expression without "/m" flag at line 8302, column 23. See page 237 of PBP. (Severity: 2) -String *may* require interpolation at line 8408, column 22. See page 51 of PBP. (Severity: 1) -String *may* require interpolation at line 8408, column 54. See page 51 of PBP. (Severity: 1) -String *may* require interpolation at line 8408, column 79. See page 51 of PBP. (Severity: 1) -String *may* require interpolation at line 8409, column 21. See page 51 of PBP. (Severity: 1) -String *may* require interpolation at line 8409, column 45. See page 51 of PBP. (Severity: 1) -String *may* require interpolation at line 8432, column 40. See page 51 of PBP. (Severity: 1) -String *may* require interpolation at line 8437, column 16. See page 51 of PBP. (Severity: 1) -String *may* require interpolation at line 8438, column 16. See page 51 of PBP. (Severity: 1) -String *may* require interpolation at line 8439, column 18. See page 51 of PBP. (Severity: 1) -String *may* require interpolation at line 8440, column 18. See page 51 of PBP. (Severity: 1) -Regular expression without "/s" flag at line 8452, column 23. See pages 240,241 of PBP. (Severity: 2) -Regular expression without "/m" flag at line 8452, column 23. See page 237 of PBP. (Severity: 2) -Postfix control "if" used at line 8646, column 53. See pages 93,94 of PBP. (Severity: 2) -Postfix control "if" used at line 8663, column 55. See pages 93,94 of PBP. (Severity: 2) -Useless interpolation of literal string at line 8664, column 43. See page 51 of PBP. (Severity: 1) -Quotes used with a noisy string at line 8667, column 61. See page 53 of PBP. (Severity: 2) -Quotes used with a noisy string at line 8668, column 59. See page 53 of PBP. (Severity: 2) -String *may* require interpolation at line 8740, column 40. See page 51 of PBP. (Severity: 1) -String *may* require interpolation at line 8740, column 53. See page 51 of PBP. (Severity: 1) -Quotes used with a noisy string at line 8817, column 13. See page 53 of PBP. (Severity: 2) -Quotes used with a noisy string at line 8828, column 32. See page 53 of PBP. (Severity: 2) -Quotes used with a noisy string at line 8829, column 32. See page 53 of PBP. (Severity: 2) -Use character classes for literal metachars instead of escapes at line 8848, column 28. See page 247 of PBP. (Severity: 1) -Regular expression without "/s" flag at line 8848, column 28. See pages 240,241 of PBP. (Severity: 2) -Regular expression without "/m" flag at line 8848, column 28. See page 237 of PBP. (Severity: 2) -Regular expression without "/s" flag at line 8850, column 20. See pages 240,241 of PBP. (Severity: 2) -Regular expression without "/m" flag at line 8850, column 20. See page 237 of PBP. (Severity: 2) -Postfix control "if" used at line 8866, column 45. See pages 93,94 of PBP. (Severity: 2) -Postfix control "if" used at line 8871, column 46. See pages 93,94 of PBP. (Severity: 2) -String *may* require interpolation at line 8876, column 61. See page 51 of PBP. (Severity: 1) -Useless interpolation of literal string at line 8877, column 13. See page 51 of PBP. (Severity: 1) -String *may* require interpolation at line 8877, column 61. See page 51 of PBP. (Severity: 1) -Useless interpolation of literal string at line 8878, column 13. See page 51 of PBP. (Severity: 1) +Quotes used with a string containing no non-whitespace characters at line 8031, column 13. See page 53 of PBP. (Severity: 2) +Useless interpolation of literal string at line 8031, column 13. See page 51 of PBP. (Severity: 1) +Quotes used with a string containing no non-whitespace characters at line 8043, column 13. See page 53 of PBP. (Severity: 2) +Useless interpolation of literal string at line 8043, column 13. See page 51 of PBP. (Severity: 1) +Quotes used with a string containing no non-whitespace characters at line 8044, column 13. See page 53 of PBP. (Severity: 2) +Useless interpolation of literal string at line 8044, column 13. See page 51 of PBP. (Severity: 1) +Too many arguments at line 8052, column 1. See page 182 of PBP. (Severity: 3) +Local lexical variable "$hostX_folder" is not all lower case or all upper case at line 8054, column 9. See pages 45,46 of PBP. (Severity: 1) +Postfix control "if" used at line 8058, column 43. See pages 93,94 of PBP. (Severity: 2) +Found "\N{SPACE}" at the end of the line at line 8072, column 51. Don't use whitespace at the end of lines. (Severity: 1) +Builtin function called with parentheses at line 8079, column 45. See page 13 of PBP. (Severity: 1) +Useless interpolation of literal string at line 8109, column 21. See page 51 of PBP. (Severity: 1) +List of quoted literal words at line 8116, column 21. Use 'qw()' instead. (Severity: 2) +Use character classes for literal metachars instead of escapes at line 8278, column 23. See page 247 of PBP. (Severity: 1) +Regular expression without "/s" flag at line 8278, column 23. See pages 240,241 of PBP. (Severity: 2) +Regular expression without "/m" flag at line 8278, column 23. See page 237 of PBP. (Severity: 2) +Use [\[\]] instead of \[|\] at line 8304, column 23. See page 265 of PBP. (Severity: 1) +Regular expression without "/s" flag at line 8304, column 23. See pages 240,241 of PBP. (Severity: 2) +Regular expression without "/m" flag at line 8304, column 23. See page 237 of PBP. (Severity: 2) +String *may* require interpolation at line 8410, column 22. See page 51 of PBP. (Severity: 1) +String *may* require interpolation at line 8410, column 54. See page 51 of PBP. (Severity: 1) +String *may* require interpolation at line 8410, column 79. See page 51 of PBP. (Severity: 1) +String *may* require interpolation at line 8411, column 21. See page 51 of PBP. (Severity: 1) +String *may* require interpolation at line 8411, column 45. See page 51 of PBP. (Severity: 1) +String *may* require interpolation at line 8434, column 40. See page 51 of PBP. (Severity: 1) +String *may* require interpolation at line 8439, column 16. See page 51 of PBP. (Severity: 1) +String *may* require interpolation at line 8440, column 16. See page 51 of PBP. (Severity: 1) +String *may* require interpolation at line 8441, column 18. See page 51 of PBP. (Severity: 1) +String *may* require interpolation at line 8442, column 18. See page 51 of PBP. (Severity: 1) +Regular expression without "/s" flag at line 8454, column 23. See pages 240,241 of PBP. (Severity: 2) +Regular expression without "/m" flag at line 8454, column 23. See page 237 of PBP. (Severity: 2) +Postfix control "if" used at line 8648, column 53. See pages 93,94 of PBP. (Severity: 2) +Postfix control "if" used at line 8665, column 55. See pages 93,94 of PBP. (Severity: 2) +Useless interpolation of literal string at line 8666, column 43. See page 51 of PBP. (Severity: 1) +Quotes used with a noisy string at line 8669, column 61. See page 53 of PBP. (Severity: 2) +Quotes used with a noisy string at line 8670, column 59. See page 53 of PBP. (Severity: 2) +String *may* require interpolation at line 8742, column 40. See page 51 of PBP. (Severity: 1) +String *may* require interpolation at line 8742, column 53. See page 51 of PBP. (Severity: 1) +Quotes used with a noisy string at line 8819, column 13. See page 53 of PBP. (Severity: 2) +Quotes used with a noisy string at line 8830, column 32. See page 53 of PBP. (Severity: 2) +Quotes used with a noisy string at line 8831, column 32. See page 53 of PBP. (Severity: 2) +Use character classes for literal metachars instead of escapes at line 8850, column 28. See page 247 of PBP. (Severity: 1) +Regular expression without "/s" flag at line 8850, column 28. See pages 240,241 of PBP. (Severity: 2) +Regular expression without "/m" flag at line 8850, column 28. See page 237 of PBP. (Severity: 2) +Regular expression without "/s" flag at line 8852, column 20. See pages 240,241 of PBP. (Severity: 2) +Regular expression without "/m" flag at line 8852, column 20. See page 237 of PBP. (Severity: 2) +Postfix control "if" used at line 8868, column 45. See pages 93,94 of PBP. (Severity: 2) +Postfix control "if" used at line 8873, column 46. See pages 93,94 of PBP. (Severity: 2) String *may* require interpolation at line 8878, column 61. See page 51 of PBP. (Severity: 1) Useless interpolation of literal string at line 8879, column 13. See page 51 of PBP. (Severity: 1) -Useless interpolation of literal string at line 8879, column 51. See page 51 of PBP. (Severity: 1) String *may* require interpolation at line 8879, column 61. See page 51 of PBP. (Severity: 1) -Regular expression without "/s" flag at line 8889, column 20. See pages 240,241 of PBP. (Severity: 2) -Regular expression without "/m" flag at line 8889, column 20. See page 237 of PBP. (Severity: 2) -Quotes used with a noisy string at line 8898, column 45. See page 53 of PBP. (Severity: 2) -Quotes used with a noisy string at line 8899, column 53. See page 53 of PBP. (Severity: 2) -Quotes used with a noisy string at line 8900, column 61. See page 53 of PBP. (Severity: 2) -Quotes used with a noisy string at line 8903, column 61. See page 53 of PBP. (Severity: 2) -Quotes used with a noisy string at line 8904, column 67. See page 53 of PBP. (Severity: 2) -String *may* require interpolation at line 8945, column 24. See page 51 of PBP. (Severity: 1) -String *may* require interpolation at line 8984, column 16. See page 51 of PBP. (Severity: 1) -String *may* require interpolation at line 9254, column 16. See page 51 of PBP. (Severity: 1) -String *may* require interpolation at line 9255, column 16. See page 51 of PBP. (Severity: 1) -Expression form of "eval" at line 9403, column 27. See page 161 of PBP. (Severity: 5) -String *may* require interpolation at line 9433, column 22. See page 51 of PBP. (Severity: 1) -String *may* require interpolation at line 9441, column 22. See page 51 of PBP. (Severity: 1) -Numeric escapes in interpolated string at line 9443, column 28. See pages 54,55 of PBP. (Severity: 2) -String *may* require interpolation at line 9443, column 38. See page 51 of PBP. (Severity: 1) -Numeric escapes in interpolated string at line 9448, column 28. See pages 54,55 of PBP. (Severity: 2) -String *may* require interpolation at line 9455, column 23. See page 51 of PBP. (Severity: 1) -Expression form of "eval" at line 9644, column 27. See page 161 of PBP. (Severity: 5) -Builtin function called with parentheses at line 9700, column 16. See page 13 of PBP. (Severity: 1) -Postfix control "if" used at line 9796, column 76. See pages 93,94 of PBP. (Severity: 2) -Useless interpolation of literal string at line 9824, column 18. See page 51 of PBP. (Severity: 1) -Found "\N{SPACE}" at the end of the line at line 9847, column 1. Don't use whitespace at the end of lines. (Severity: 1) -Subroutine "diff_or_NA" is not all lower case or all upper case at line 9857, column 1. See pages 45,46 of PBP. (Severity: 1) -Use named character classes ([0-9] vs. \d) at line 9880, column 21. See page 248 of PBP. (Severity: 1) -Use character classes for literal metachars instead of escapes at line 9880, column 21. See page 247 of PBP. (Severity: 1) -Regular expression without "/s" flag at line 9880, column 21. See pages 240,241 of PBP. (Severity: 2) -Regular expression without "/m" flag at line 9880, column 21. See page 237 of PBP. (Severity: 2) -Subroutine "tests_diff_or_NA" is not all lower case or all upper case at line 9908, column 1. See pages 45,46 of PBP. (Severity: 1) -Too many arguments at line 9955, column 1. See page 182 of PBP. (Severity: 3) -Postfix control "unless" used at line 9993, column 34. See pages 96,97 of PBP. (Severity: 2) -Regular expression without "/s" flag at line 10031, column 51. See pages 240,241 of PBP. (Severity: 2) -Regular expression without "/m" flag at line 10031, column 51. See page 237 of PBP. (Severity: 2) -Regular expression without "/s" flag at line 10047, column 24. See pages 240,241 of PBP. (Severity: 2) -Regular expression without "/m" flag at line 10047, column 24. See page 237 of PBP. (Severity: 2) -Regular expression without "/s" flag at line 10050, column 24. See pages 240,241 of PBP. (Severity: 2) -Regular expression without "/m" flag at line 10050, column 24. See page 237 of PBP. (Severity: 2) -Regular expression without "/s" flag at line 10053, column 24. See pages 240,241 of PBP. (Severity: 2) -Regular expression without "/m" flag at line 10053, column 24. See page 237 of PBP. (Severity: 2) -Regular expression without "/s" flag at line 10056, column 24. See pages 240,241 of PBP. (Severity: 2) -Regular expression without "/m" flag at line 10056, column 24. See page 237 of PBP. (Severity: 2) -Regular expression without "/s" flag at line 10059, column 24. See pages 240,241 of PBP. (Severity: 2) -Regular expression without "/m" flag at line 10059, column 24. See page 237 of PBP. (Severity: 2) -Regular expression without "/s" flag at line 10062, column 97. See pages 240,241 of PBP. (Severity: 2) -Regular expression without "/m" flag at line 10062, column 97. See page 237 of PBP. (Severity: 2) -Numeric escapes in interpolated string at line 10083, column 58. See pages 54,55 of PBP. (Severity: 2) -Return value of "close" ignored at line 10107, column 9. Check the return value of "close" for success. (Severity: 2) -Return value of flagged function ignored - close at line 10107, column 9. See pages 208,278 of PBP. (Severity: 1) -Return value of "close" ignored at line 10142, column 9. Check the return value of "close" for success. (Severity: 2) -Return value of flagged function ignored - close at line 10142, column 9. See pages 208,278 of PBP. (Severity: 1) -Quotes used with a noisy string at line 10153, column 29. See page 53 of PBP. (Severity: 2) -Return value of "close" ignored at line 10178, column 3. Check the return value of "close" for success. (Severity: 2) -Return value of flagged function ignored - close at line 10178, column 3. See pages 208,278 of PBP. (Severity: 1) -Quotes used with a noisy string at line 10193, column 39. See page 53 of PBP. (Severity: 2) -Constant "$NB_UNX_tests_string_to_file" is not all upper case at line 10199, column 17. See pages 45,46 of PBP. (Severity: 1) -Postfix control "if" used at line 10200, column 78. See pages 93,94 of PBP. (Severity: 2) -Builtin function called with parentheses at line 10219, column 16. See page 13 of PBP. (Severity: 1) -File handle for "print" or "printf" is not braced at line 10223, column 9. See page 217 of PBP. (Severity: 1) -Return value of flagged function ignored - print at line 10223, column 9. See pages 208,278 of PBP. (Severity: 1) -Return value of "close" ignored at line 10224, column 9. Check the return value of "close" for success. (Severity: 2) -Return value of flagged function ignored - close at line 10224, column 9. See pages 208,278 of PBP. (Severity: 1) -Backtick operator used at line 10254, column 17. Use IPC::Open3 instead. (Severity: 3) -Builtin function called with parentheses at line 10257, column 17. See page 13 of PBP. (Severity: 1) -Builtin function called with parentheses at line 10259, column 34. See page 13 of PBP. (Severity: 1) -Constant "$NB_WIN_tests_pipemess" is not all upper case at line 10295, column 17. See pages 45,46 of PBP. (Severity: 1) -Postfix control "if" used at line 10296, column 66. See pages 93,94 of PBP. (Severity: 2) -Local lexical variable "$stringT" is not all lower case or all upper case at line 10308, column 9. See pages 45,46 of PBP. (Severity: 1) -Local lexical variable "$errorT" is not all lower case or all upper case at line 10308, column 9. See pages 45,46 of PBP. (Severity: 1) -Constant "$NB_UNX_tests_pipemess" is not all upper case at line 10311, column 17. See pages 45,46 of PBP. (Severity: 1) -Postfix control "if" used at line 10312, column 63. See pages 93,94 of PBP. (Severity: 2) -Split long regexps into smaller qr// chunks at line 10343, column 32. See page 261 of PBP. (Severity: 3) -Regular expression without "/s" flag at line 10343, column 32. See pages 240,241 of PBP. (Severity: 2) -Split long regexps into smaller qr// chunks at line 10347, column 32. See page 261 of PBP. (Severity: 3) -Regular expression without "/s" flag at line 10347, column 32. See pages 240,241 of PBP. (Severity: 2) -Regular expression without "/s" flag at line 10357, column 33. See pages 240,241 of PBP. (Severity: 2) -Regular expression without "/s" flag at line 10362, column 33. See pages 240,241 of PBP. (Severity: 2) -Split long regexps into smaller qr// chunks at line 10366, column 33. See page 261 of PBP. (Severity: 3) -Regular expression without "/s" flag at line 10366, column 33. See pages 240,241 of PBP. (Severity: 2) -Regular expression without "/s" flag at line 10370, column 33. See pages 240,241 of PBP. (Severity: 2) -Regular expression without "/s" flag at line 10371, column 33. See pages 240,241 of PBP. (Severity: 2) -Split long regexps into smaller qr// chunks at line 10377, column 24. See page 261 of PBP. (Severity: 3) -Regular expression without "/s" flag at line 10377, column 24. See pages 240,241 of PBP. (Severity: 2) -Use character classes for literal metachars instead of escapes at line 10404, column 28. See page 247 of PBP. (Severity: 1) -Regular expression without "/s" flag at line 10404, column 28. See pages 240,241 of PBP. (Severity: 2) -Regular expression without "/m" flag at line 10404, column 28. See page 237 of PBP. (Severity: 2) -File handle for "print" or "printf" is not braced at line 10424, column 9. See page 217 of PBP. (Severity: 1) -Return value of flagged function ignored - print at line 10424, column 9. See pages 208,278 of PBP. (Severity: 1) -Return value of "close" ignored at line 10429, column 9. Check the return value of "close" for success. (Severity: 2) -Return value of flagged function ignored - close at line 10429, column 9. See pages 208,278 of PBP. (Severity: 1) -Regular expression without "/s" flag at line 10469, column 36. See pages 240,241 of PBP. (Severity: 2) -Regular expression without "/m" flag at line 10469, column 36. See page 237 of PBP. (Severity: 2) -Use character classes for literal metachars instead of escapes at line 10531, column 35. See page 247 of PBP. (Severity: 1) -Use character classes for literal metachars instead of escapes at line 10534, column 39. See page 247 of PBP. (Severity: 1) -Use character classes for literal metachars instead of escapes at line 10576, column 22. See page 247 of PBP. (Severity: 1) -Regular expression without "/s" flag at line 10588, column 36. See pages 240,241 of PBP. (Severity: 2) -Regular expression without "/m" flag at line 10588, column 36. See page 237 of PBP. (Severity: 2) -Builtin function called with parentheses at line 10606, column 24. See page 13 of PBP. (Severity: 1) -Useless interpolation of literal string at line 10607, column 17. See page 51 of PBP. (Severity: 1) -Useless interpolation of literal string at line 10608, column 17. See page 51 of PBP. (Severity: 1) -Useless interpolation of literal string at line 10623, column 49. See page 51 of PBP. (Severity: 1) -Useless interpolation of literal string at line 10624, column 27. See page 51 of PBP. (Severity: 1) -Useless interpolation of literal string at line 10625, column 33. See page 51 of PBP. (Severity: 1) -Useless interpolation of literal string at line 10626, column 42. See page 51 of PBP. (Severity: 1) -Useless interpolation of literal string at line 10627, column 40. See page 51 of PBP. (Severity: 1) -Cascading if-elsif chain at line 10641, column 2. See pages 117,118 of PBP. (Severity: 3) -Useless interpolation of literal string at line 10641, column 12. See page 51 of PBP. (Severity: 1) -Useless interpolation of literal string at line 10643, column 22. See page 51 of PBP. (Severity: 1) -Useless interpolation of literal string at line 10646, column 27. See page 51 of PBP. (Severity: 1) -Builtin function called with parentheses at line 10647, column 3. See page 13 of PBP. (Severity: 1) -String *may* require interpolation at line 10695, column 44. See page 51 of PBP. (Severity: 1) -String *may* require interpolation at line 10698, column 53. See page 51 of PBP. (Severity: 1) -Regular expression without "/s" flag at line 10711, column 28. See pages 240,241 of PBP. (Severity: 2) -Regular expression without "/m" flag at line 10711, column 28. See page 237 of PBP. (Severity: 2) -Postfix control "if" used at line 10723, column 33. See pages 93,94 of PBP. (Severity: 2) -Postfix control "if" used at line 10731, column 32. See pages 93,94 of PBP. (Severity: 2) -Postfix control "if" used at line 10741, column 34. See pages 93,94 of PBP. (Severity: 2) -Return value of eval not tested at line 10795, column 3. You can't depend upon the value of $@/$EVAL_ERROR to tell whether an eval failed. (Severity: 3) -Backtick operator used at line 10796, column 15. Use IPC::Open3 instead. (Severity: 3) -Split long regexps into smaller qr// chunks at line 10805, column 16. See page 261 of PBP. (Severity: 3) -Use character classes for literal metachars instead of escapes at line 10805, column 16. See page 247 of PBP. (Severity: 1) -Return value of eval not tested at line 10818, column 3. You can't depend upon the value of $@/$EVAL_ERROR to tell whether an eval failed. (Severity: 3) -Backtick operator used at line 10819, column 15. Use IPC::Open3 instead. (Severity: 3) -Split long regexps into smaller qr// chunks at line 10828, column 16. See page 261 of PBP. (Severity: 3) -Use character classes for literal metachars instead of escapes at line 10828, column 16. See page 247 of PBP. (Severity: 1) -Return value of eval not tested at line 10842, column 3. You can't depend upon the value of $@/$EVAL_ERROR to tell whether an eval failed. (Severity: 3) -Capture variable used outside conditional at line 10853, column 12. See page 253 of PBP. (Severity: 3) -Builtin function called with parentheses at line 10921, column 3. See page 13 of PBP. (Severity: 1) -Useless interpolation of literal string at line 10921, column 12. See page 51 of PBP. (Severity: 1) -Useless interpolation of literal string at line 10922, column 35. See page 51 of PBP. (Severity: 1) -Useless interpolation of literal string at line 10923, column 35. See page 51 of PBP. (Severity: 1) -Local lexical variable "$total_ram_in_MB" is not all lower case or all upper case at line 10943, column 9. See pages 45,46 of PBP. (Severity: 1) -Useless interpolation of literal string at line 10943, column 49. See page 51 of PBP. (Severity: 1) -Useless interpolation of literal string at line 10947, column 55. See page 51 of PBP. (Severity: 1) -Long number not separated with underscores at line 10947, column 61. See page 59 of PBP. (Severity: 2) -Backtick operator used at line 10998, column 26. Use IPC::Open3 instead. (Severity: 3) -Backtick operator used at line 11027, column 18. Use IPC::Open3 instead. (Severity: 3) -String delimiter used with "split" at line 11032, column 42. Express it as a regex instead. (Severity: 2) -Quotes used with a noisy string at line 11032, column 48. See page 53 of PBP. (Severity: 2) -Postfix control "if" used at line 11057, column 47. See pages 93,94 of PBP. (Severity: 2) -Postfix control "if" used at line 11074, column 44. See pages 93,94 of PBP. (Severity: 2) -Builtin function called with parentheses at line 11120, column 2. See page 13 of PBP. (Severity: 1) -Builtin function called with parentheses at line 11131, column 11. See page 13 of PBP. (Severity: 1) -Subroutine "remove_Ko" is not all lower case or all upper case at line 11158, column 1. See pages 45,46 of PBP. (Severity: 1) -Regular expression without "/s" flag at line 11161, column 24. See pages 240,241 of PBP. (Severity: 2) -Regular expression without "/m" flag at line 11161, column 24. See page 237 of PBP. (Severity: 2) -Regular expression without "/s" flag at line 11171, column 24. See pages 240,241 of PBP. (Severity: 2) -Regular expression without "/m" flag at line 11171, column 24. See page 237 of PBP. (Severity: 2) -Regular expression without "/s" flag at line 11193, column 19. See pages 240,241 of PBP. (Severity: 2) -Regular expression without "/m" flag at line 11193, column 19. See page 237 of PBP. (Severity: 2) -Use character classes for literal metachars instead of escapes at line 11230, column 20. See page 247 of PBP. (Severity: 1) -Use [\+-] instead of \+|- at line 11230, column 20. See page 265 of PBP. (Severity: 1) -Regular expression without "/s" flag at line 11230, column 20. See pages 240,241 of PBP. (Severity: 2) -Regular expression without "/m" flag at line 11230, column 20. See page 237 of PBP. (Severity: 2) -Postfix control "if" used at line 11233, column 30. See pages 93,94 of PBP. (Severity: 2) -Postfix control "if" used at line 11234, column 36. See pages 93,94 of PBP. (Severity: 2) -Split long regexps into smaller qr// chunks at line 11239, column 19. See page 261 of PBP. (Severity: 3) -Use character classes for literal metachars instead of escapes at line 11239, column 19. See page 247 of PBP. (Severity: 1) -Use [:\.] instead of :|\ at line 11239, column 19. See page 265 of PBP. (Severity: 1) -Use [:\.] instead of :|\ at line 11239, column 19. See page 265 of PBP. (Severity: 1) -Use [\+-] instead of \+|- at line 11239, column 19. See page 265 of PBP. (Severity: 1) -Regular expression without "/s" flag at line 11239, column 19. See pages 240,241 of PBP. (Severity: 2) -Regular expression without "/m" flag at line 11239, column 19. See page 237 of PBP. (Severity: 2) -Postfix control "if" used at line 11251, column 38. See pages 93,94 of PBP. (Severity: 2) -Regular expression without "/s" flag at line 11251, column 72. See pages 240,241 of PBP. (Severity: 2) -Regular expression without "/m" flag at line 11251, column 72. See page 237 of PBP. (Severity: 2) -Postfix control "if" used at line 11252, column 38. See pages 93,94 of PBP. (Severity: 2) -Postfix control "if" used at line 11254, column 46. See pages 93,94 of PBP. (Severity: 2) -Postfix control "if" used at line 11258, column 30. See pages 93,94 of PBP. (Severity: 2) -Postfix control "if" used at line 11260, column 33. See pages 93,94 of PBP. (Severity: 2) -Split long regexps into smaller qr// chunks at line 11265, column 19. See page 261 of PBP. (Severity: 3) -Regular expression without "/s" flag at line 11265, column 19. See pages 240,241 of PBP. (Severity: 2) -Regular expression without "/m" flag at line 11265, column 19. See page 237 of PBP. (Severity: 2) -Regular expression without "/s" flag at line 11282, column 19. See pages 240,241 of PBP. (Severity: 2) -Regular expression without "/m" flag at line 11282, column 19. See page 237 of PBP. (Severity: 2) -Regular expression without "/s" flag at line 11294, column 19. See pages 240,241 of PBP. (Severity: 2) -Regular expression without "/m" flag at line 11294, column 19. See page 237 of PBP. (Severity: 2) -Split long regexps into smaller qr// chunks at line 11306, column 19. See page 261 of PBP. (Severity: 3) -Regular expression without "/s" flag at line 11306, column 19. See pages 240,241 of PBP. (Severity: 2) -Regular expression without "/m" flag at line 11306, column 19. See page 237 of PBP. (Severity: 2) -Postfix control "if" used at line 11312, column 29. See pages 93,94 of PBP. (Severity: 2) -Split long regexps into smaller qr// chunks at line 11318, column 19. See page 261 of PBP. (Severity: 3) -Use character classes for literal metachars instead of escapes at line 11318, column 19. See page 247 of PBP. (Severity: 1) -Use [\+-] instead of \+|- at line 11318, column 19. See page 265 of PBP. (Severity: 1) -Regular expression without "/s" flag at line 11318, column 19. See pages 240,241 of PBP. (Severity: 2) -Regular expression without "/m" flag at line 11318, column 19. See page 237 of PBP. (Severity: 2) -Regular expression without "/s" flag at line 11329, column 19. See pages 240,241 of PBP. (Severity: 2) -Regular expression without "/m" flag at line 11329, column 19. See page 237 of PBP. (Severity: 2) -Found "\N{SPACE}" at the end of the line at line 11436, column 1. Don't use whitespace at the end of lines. (Severity: 1) -Found "\N{SPACE}" at the end of the line at line 11439, column 1. Don't use whitespace at the end of lines. (Severity: 1) -Found "\N{SPACE}" at the end of the line at line 11442, column 1. Don't use whitespace at the end of lines. (Severity: 1) +Useless interpolation of literal string at line 8880, column 13. See page 51 of PBP. (Severity: 1) +String *may* require interpolation at line 8880, column 61. See page 51 of PBP. (Severity: 1) +Useless interpolation of literal string at line 8881, column 13. See page 51 of PBP. (Severity: 1) +Useless interpolation of literal string at line 8881, column 51. See page 51 of PBP. (Severity: 1) +String *may* require interpolation at line 8881, column 61. See page 51 of PBP. (Severity: 1) +Regular expression without "/s" flag at line 8891, column 20. See pages 240,241 of PBP. (Severity: 2) +Regular expression without "/m" flag at line 8891, column 20. See page 237 of PBP. (Severity: 2) +Quotes used with a noisy string at line 8900, column 45. See page 53 of PBP. (Severity: 2) +Quotes used with a noisy string at line 8901, column 53. See page 53 of PBP. (Severity: 2) +Quotes used with a noisy string at line 8902, column 61. See page 53 of PBP. (Severity: 2) +Quotes used with a noisy string at line 8905, column 61. See page 53 of PBP. (Severity: 2) +Quotes used with a noisy string at line 8906, column 67. See page 53 of PBP. (Severity: 2) +String *may* require interpolation at line 8947, column 24. See page 51 of PBP. (Severity: 1) +String *may* require interpolation at line 8986, column 16. See page 51 of PBP. (Severity: 1) +String *may* require interpolation at line 9256, column 16. See page 51 of PBP. (Severity: 1) +String *may* require interpolation at line 9257, column 16. See page 51 of PBP. (Severity: 1) +Expression form of "eval" at line 9405, column 27. See page 161 of PBP. (Severity: 5) +String *may* require interpolation at line 9435, column 22. See page 51 of PBP. (Severity: 1) +String *may* require interpolation at line 9443, column 22. See page 51 of PBP. (Severity: 1) +Numeric escapes in interpolated string at line 9445, column 28. See pages 54,55 of PBP. (Severity: 2) +String *may* require interpolation at line 9445, column 38. See page 51 of PBP. (Severity: 1) +Numeric escapes in interpolated string at line 9450, column 28. See pages 54,55 of PBP. (Severity: 2) +String *may* require interpolation at line 9457, column 23. See page 51 of PBP. (Severity: 1) +Expression form of "eval" at line 9646, column 27. See page 161 of PBP. (Severity: 5) +Builtin function called with parentheses at line 9702, column 16. See page 13 of PBP. (Severity: 1) +Postfix control "if" used at line 9798, column 76. See pages 93,94 of PBP. (Severity: 2) +Useless interpolation of literal string at line 9826, column 18. See page 51 of PBP. (Severity: 1) +Found "\N{SPACE}" at the end of the line at line 9849, column 1. Don't use whitespace at the end of lines. (Severity: 1) +Subroutine "diff_or_NA" is not all lower case or all upper case at line 9859, column 1. See pages 45,46 of PBP. (Severity: 1) +Use named character classes ([0-9] vs. \d) at line 9882, column 21. See page 248 of PBP. (Severity: 1) +Use character classes for literal metachars instead of escapes at line 9882, column 21. See page 247 of PBP. (Severity: 1) +Regular expression without "/s" flag at line 9882, column 21. See pages 240,241 of PBP. (Severity: 2) +Regular expression without "/m" flag at line 9882, column 21. See page 237 of PBP. (Severity: 2) +Subroutine "tests_diff_or_NA" is not all lower case or all upper case at line 9910, column 1. See pages 45,46 of PBP. (Severity: 1) +Too many arguments at line 9957, column 1. See page 182 of PBP. (Severity: 3) +Postfix control "unless" used at line 9995, column 34. See pages 96,97 of PBP. (Severity: 2) +Regular expression without "/s" flag at line 10033, column 51. See pages 240,241 of PBP. (Severity: 2) +Regular expression without "/m" flag at line 10033, column 51. See page 237 of PBP. (Severity: 2) +Regular expression without "/s" flag at line 10049, column 24. See pages 240,241 of PBP. (Severity: 2) +Regular expression without "/m" flag at line 10049, column 24. See page 237 of PBP. (Severity: 2) +Regular expression without "/s" flag at line 10052, column 24. See pages 240,241 of PBP. (Severity: 2) +Regular expression without "/m" flag at line 10052, column 24. See page 237 of PBP. (Severity: 2) +Regular expression without "/s" flag at line 10055, column 24. See pages 240,241 of PBP. (Severity: 2) +Regular expression without "/m" flag at line 10055, column 24. See page 237 of PBP. (Severity: 2) +Regular expression without "/s" flag at line 10058, column 24. See pages 240,241 of PBP. (Severity: 2) +Regular expression without "/m" flag at line 10058, column 24. See page 237 of PBP. (Severity: 2) +Regular expression without "/s" flag at line 10061, column 24. See pages 240,241 of PBP. (Severity: 2) +Regular expression without "/m" flag at line 10061, column 24. See page 237 of PBP. (Severity: 2) +Regular expression without "/s" flag at line 10064, column 97. See pages 240,241 of PBP. (Severity: 2) +Regular expression without "/m" flag at line 10064, column 97. See page 237 of PBP. (Severity: 2) +Numeric escapes in interpolated string at line 10085, column 58. See pages 54,55 of PBP. (Severity: 2) +Return value of "close" ignored at line 10109, column 9. Check the return value of "close" for success. (Severity: 2) +Return value of flagged function ignored - close at line 10109, column 9. See pages 208,278 of PBP. (Severity: 1) +Return value of "close" ignored at line 10144, column 9. Check the return value of "close" for success. (Severity: 2) +Return value of flagged function ignored - close at line 10144, column 9. See pages 208,278 of PBP. (Severity: 1) +Quotes used with a noisy string at line 10155, column 29. See page 53 of PBP. (Severity: 2) +Return value of "close" ignored at line 10180, column 3. Check the return value of "close" for success. (Severity: 2) +Return value of flagged function ignored - close at line 10180, column 3. See pages 208,278 of PBP. (Severity: 1) +Quotes used with a noisy string at line 10195, column 39. See page 53 of PBP. (Severity: 2) +Constant "$NB_UNX_tests_string_to_file" is not all upper case at line 10201, column 17. See pages 45,46 of PBP. (Severity: 1) +Postfix control "if" used at line 10202, column 78. See pages 93,94 of PBP. (Severity: 2) +Builtin function called with parentheses at line 10221, column 16. See page 13 of PBP. (Severity: 1) +File handle for "print" or "printf" is not braced at line 10225, column 9. See page 217 of PBP. (Severity: 1) +Return value of flagged function ignored - print at line 10225, column 9. See pages 208,278 of PBP. (Severity: 1) +Return value of "close" ignored at line 10226, column 9. Check the return value of "close" for success. (Severity: 2) +Return value of flagged function ignored - close at line 10226, column 9. See pages 208,278 of PBP. (Severity: 1) +Backtick operator used at line 10256, column 17. Use IPC::Open3 instead. (Severity: 3) +Builtin function called with parentheses at line 10259, column 17. See page 13 of PBP. (Severity: 1) +Builtin function called with parentheses at line 10261, column 34. See page 13 of PBP. (Severity: 1) +Constant "$NB_WIN_tests_pipemess" is not all upper case at line 10297, column 17. See pages 45,46 of PBP. (Severity: 1) +Postfix control "if" used at line 10298, column 66. See pages 93,94 of PBP. (Severity: 2) +Local lexical variable "$stringT" is not all lower case or all upper case at line 10310, column 9. See pages 45,46 of PBP. (Severity: 1) +Local lexical variable "$errorT" is not all lower case or all upper case at line 10310, column 9. See pages 45,46 of PBP. (Severity: 1) +Constant "$NB_UNX_tests_pipemess" is not all upper case at line 10313, column 17. See pages 45,46 of PBP. (Severity: 1) +Postfix control "if" used at line 10314, column 63. See pages 93,94 of PBP. (Severity: 2) +Split long regexps into smaller qr// chunks at line 10345, column 32. See page 261 of PBP. (Severity: 3) +Regular expression without "/s" flag at line 10345, column 32. See pages 240,241 of PBP. (Severity: 2) +Split long regexps into smaller qr// chunks at line 10349, column 32. See page 261 of PBP. (Severity: 3) +Regular expression without "/s" flag at line 10349, column 32. See pages 240,241 of PBP. (Severity: 2) +Regular expression without "/s" flag at line 10359, column 33. See pages 240,241 of PBP. (Severity: 2) +Regular expression without "/s" flag at line 10364, column 33. See pages 240,241 of PBP. (Severity: 2) +Split long regexps into smaller qr// chunks at line 10368, column 33. See page 261 of PBP. (Severity: 3) +Regular expression without "/s" flag at line 10368, column 33. See pages 240,241 of PBP. (Severity: 2) +Regular expression without "/s" flag at line 10372, column 33. See pages 240,241 of PBP. (Severity: 2) +Regular expression without "/s" flag at line 10373, column 33. See pages 240,241 of PBP. (Severity: 2) +Split long regexps into smaller qr// chunks at line 10379, column 24. See page 261 of PBP. (Severity: 3) +Regular expression without "/s" flag at line 10379, column 24. See pages 240,241 of PBP. (Severity: 2) +Use character classes for literal metachars instead of escapes at line 10406, column 28. See page 247 of PBP. (Severity: 1) +Regular expression without "/s" flag at line 10406, column 28. See pages 240,241 of PBP. (Severity: 2) +Regular expression without "/m" flag at line 10406, column 28. See page 237 of PBP. (Severity: 2) +File handle for "print" or "printf" is not braced at line 10426, column 9. See page 217 of PBP. (Severity: 1) +Return value of flagged function ignored - print at line 10426, column 9. See pages 208,278 of PBP. (Severity: 1) +Return value of "close" ignored at line 10431, column 9. Check the return value of "close" for success. (Severity: 2) +Return value of flagged function ignored - close at line 10431, column 9. See pages 208,278 of PBP. (Severity: 1) +Regular expression without "/s" flag at line 10471, column 36. See pages 240,241 of PBP. (Severity: 2) +Regular expression without "/m" flag at line 10471, column 36. See page 237 of PBP. (Severity: 2) +Use character classes for literal metachars instead of escapes at line 10533, column 35. See page 247 of PBP. (Severity: 1) +Use character classes for literal metachars instead of escapes at line 10536, column 39. See page 247 of PBP. (Severity: 1) +Use character classes for literal metachars instead of escapes at line 10578, column 22. See page 247 of PBP. (Severity: 1) +Regular expression without "/s" flag at line 10590, column 36. See pages 240,241 of PBP. (Severity: 2) +Regular expression without "/m" flag at line 10590, column 36. See page 237 of PBP. (Severity: 2) +Builtin function called with parentheses at line 10608, column 24. See page 13 of PBP. (Severity: 1) +Useless interpolation of literal string at line 10609, column 17. See page 51 of PBP. (Severity: 1) +Useless interpolation of literal string at line 10610, column 17. See page 51 of PBP. (Severity: 1) +Useless interpolation of literal string at line 10625, column 49. See page 51 of PBP. (Severity: 1) +Useless interpolation of literal string at line 10626, column 27. See page 51 of PBP. (Severity: 1) +Useless interpolation of literal string at line 10627, column 33. See page 51 of PBP. (Severity: 1) +Useless interpolation of literal string at line 10628, column 42. See page 51 of PBP. (Severity: 1) +Useless interpolation of literal string at line 10629, column 40. See page 51 of PBP. (Severity: 1) +Cascading if-elsif chain at line 10643, column 2. See pages 117,118 of PBP. (Severity: 3) +Useless interpolation of literal string at line 10643, column 12. See page 51 of PBP. (Severity: 1) +Useless interpolation of literal string at line 10645, column 22. See page 51 of PBP. (Severity: 1) +Useless interpolation of literal string at line 10648, column 27. See page 51 of PBP. (Severity: 1) +Builtin function called with parentheses at line 10649, column 3. See page 13 of PBP. (Severity: 1) +String *may* require interpolation at line 10697, column 44. See page 51 of PBP. (Severity: 1) +String *may* require interpolation at line 10700, column 53. See page 51 of PBP. (Severity: 1) +Regular expression without "/s" flag at line 10713, column 28. See pages 240,241 of PBP. (Severity: 2) +Regular expression without "/m" flag at line 10713, column 28. See page 237 of PBP. (Severity: 2) +Postfix control "if" used at line 10725, column 33. See pages 93,94 of PBP. (Severity: 2) +Postfix control "if" used at line 10733, column 32. See pages 93,94 of PBP. (Severity: 2) +Postfix control "if" used at line 10743, column 34. See pages 93,94 of PBP. (Severity: 2) +Return value of eval not tested at line 10797, column 3. You can't depend upon the value of $@/$EVAL_ERROR to tell whether an eval failed. (Severity: 3) +Backtick operator used at line 10798, column 15. Use IPC::Open3 instead. (Severity: 3) +Split long regexps into smaller qr// chunks at line 10807, column 16. See page 261 of PBP. (Severity: 3) +Use character classes for literal metachars instead of escapes at line 10807, column 16. See page 247 of PBP. (Severity: 1) +Return value of eval not tested at line 10820, column 3. You can't depend upon the value of $@/$EVAL_ERROR to tell whether an eval failed. (Severity: 3) +Backtick operator used at line 10821, column 15. Use IPC::Open3 instead. (Severity: 3) +Split long regexps into smaller qr// chunks at line 10830, column 16. See page 261 of PBP. (Severity: 3) +Use character classes for literal metachars instead of escapes at line 10830, column 16. See page 247 of PBP. (Severity: 1) +Return value of eval not tested at line 10844, column 3. You can't depend upon the value of $@/$EVAL_ERROR to tell whether an eval failed. (Severity: 3) +Capture variable used outside conditional at line 10855, column 12. See page 253 of PBP. (Severity: 3) +Builtin function called with parentheses at line 10923, column 3. See page 13 of PBP. (Severity: 1) +Useless interpolation of literal string at line 10923, column 12. See page 51 of PBP. (Severity: 1) +Useless interpolation of literal string at line 10924, column 35. See page 51 of PBP. (Severity: 1) +Useless interpolation of literal string at line 10925, column 35. See page 51 of PBP. (Severity: 1) +Local lexical variable "$total_ram_in_MB" is not all lower case or all upper case at line 10945, column 9. See pages 45,46 of PBP. (Severity: 1) +Useless interpolation of literal string at line 10945, column 49. See page 51 of PBP. (Severity: 1) +Useless interpolation of literal string at line 10949, column 55. See page 51 of PBP. (Severity: 1) +Long number not separated with underscores at line 10949, column 61. See page 59 of PBP. (Severity: 2) +Backtick operator used at line 11000, column 26. Use IPC::Open3 instead. (Severity: 3) +Backtick operator used at line 11029, column 18. Use IPC::Open3 instead. (Severity: 3) +String delimiter used with "split" at line 11034, column 42. Express it as a regex instead. (Severity: 2) +Quotes used with a noisy string at line 11034, column 48. See page 53 of PBP. (Severity: 2) +Postfix control "if" used at line 11059, column 47. See pages 93,94 of PBP. (Severity: 2) +Postfix control "if" used at line 11076, column 44. See pages 93,94 of PBP. (Severity: 2) +Builtin function called with parentheses at line 11122, column 2. See page 13 of PBP. (Severity: 1) +Builtin function called with parentheses at line 11133, column 11. See page 13 of PBP. (Severity: 1) +Subroutine "remove_Ko" is not all lower case or all upper case at line 11160, column 1. See pages 45,46 of PBP. (Severity: 1) +Regular expression without "/s" flag at line 11163, column 24. See pages 240,241 of PBP. (Severity: 2) +Regular expression without "/m" flag at line 11163, column 24. See page 237 of PBP. (Severity: 2) +Regular expression without "/s" flag at line 11173, column 24. See pages 240,241 of PBP. (Severity: 2) +Regular expression without "/m" flag at line 11173, column 24. See page 237 of PBP. (Severity: 2) +Regular expression without "/s" flag at line 11195, column 19. See pages 240,241 of PBP. (Severity: 2) +Regular expression without "/m" flag at line 11195, column 19. See page 237 of PBP. (Severity: 2) +Use character classes for literal metachars instead of escapes at line 11232, column 20. See page 247 of PBP. (Severity: 1) +Use [\+-] instead of \+|- at line 11232, column 20. See page 265 of PBP. (Severity: 1) +Regular expression without "/s" flag at line 11232, column 20. See pages 240,241 of PBP. (Severity: 2) +Regular expression without "/m" flag at line 11232, column 20. See page 237 of PBP. (Severity: 2) +Postfix control "if" used at line 11235, column 30. See pages 93,94 of PBP. (Severity: 2) +Postfix control "if" used at line 11236, column 36. See pages 93,94 of PBP. (Severity: 2) +Split long regexps into smaller qr// chunks at line 11241, column 19. See page 261 of PBP. (Severity: 3) +Use character classes for literal metachars instead of escapes at line 11241, column 19. See page 247 of PBP. (Severity: 1) +Use [:\.] instead of :|\ at line 11241, column 19. See page 265 of PBP. (Severity: 1) +Use [:\.] instead of :|\ at line 11241, column 19. See page 265 of PBP. (Severity: 1) +Use [\+-] instead of \+|- at line 11241, column 19. See page 265 of PBP. (Severity: 1) +Regular expression without "/s" flag at line 11241, column 19. See pages 240,241 of PBP. (Severity: 2) +Regular expression without "/m" flag at line 11241, column 19. See page 237 of PBP. (Severity: 2) +Postfix control "if" used at line 11253, column 38. See pages 93,94 of PBP. (Severity: 2) +Regular expression without "/s" flag at line 11253, column 72. See pages 240,241 of PBP. (Severity: 2) +Regular expression without "/m" flag at line 11253, column 72. See page 237 of PBP. (Severity: 2) +Postfix control "if" used at line 11254, column 38. See pages 93,94 of PBP. (Severity: 2) +Postfix control "if" used at line 11256, column 46. See pages 93,94 of PBP. (Severity: 2) +Postfix control "if" used at line 11260, column 30. See pages 93,94 of PBP. (Severity: 2) +Postfix control "if" used at line 11262, column 33. See pages 93,94 of PBP. (Severity: 2) +Split long regexps into smaller qr// chunks at line 11267, column 19. See page 261 of PBP. (Severity: 3) +Regular expression without "/s" flag at line 11267, column 19. See pages 240,241 of PBP. (Severity: 2) +Regular expression without "/m" flag at line 11267, column 19. See page 237 of PBP. (Severity: 2) +Regular expression without "/s" flag at line 11284, column 19. See pages 240,241 of PBP. (Severity: 2) +Regular expression without "/m" flag at line 11284, column 19. See page 237 of PBP. (Severity: 2) +Regular expression without "/s" flag at line 11296, column 19. See pages 240,241 of PBP. (Severity: 2) +Regular expression without "/m" flag at line 11296, column 19. See page 237 of PBP. (Severity: 2) +Split long regexps into smaller qr// chunks at line 11308, column 19. See page 261 of PBP. (Severity: 3) +Regular expression without "/s" flag at line 11308, column 19. See pages 240,241 of PBP. (Severity: 2) +Regular expression without "/m" flag at line 11308, column 19. See page 237 of PBP. (Severity: 2) +Postfix control "if" used at line 11314, column 29. See pages 93,94 of PBP. (Severity: 2) +Split long regexps into smaller qr// chunks at line 11320, column 19. See page 261 of PBP. (Severity: 3) +Use character classes for literal metachars instead of escapes at line 11320, column 19. See page 247 of PBP. (Severity: 1) +Use [\+-] instead of \+|- at line 11320, column 19. See page 265 of PBP. (Severity: 1) +Regular expression without "/s" flag at line 11320, column 19. See pages 240,241 of PBP. (Severity: 2) +Regular expression without "/m" flag at line 11320, column 19. See page 237 of PBP. (Severity: 2) +Regular expression without "/s" flag at line 11331, column 19. See pages 240,241 of PBP. (Severity: 2) +Regular expression without "/m" flag at line 11331, column 19. See page 237 of PBP. (Severity: 2) +Found "\N{SPACE}" at the end of the line at line 11438, column 1. Don't use whitespace at the end of lines. (Severity: 1) +Found "\N{SPACE}" at the end of the line at line 11441, column 1. Don't use whitespace at the end of lines. (Severity: 1) Found "\N{SPACE}" at the end of the line at line 11444, column 1. Don't use whitespace at the end of lines. (Severity: 1) -Found "\N{SPACE}" at the end of the line at line 11447, column 1. Don't use whitespace at the end of lines. (Severity: 1) -Found "\N{SPACE}" at the end of the line at line 11450, column 1. Don't use whitespace at the end of lines. (Severity: 1) -Found "\N{SPACE}" at the end of the line at line 11459, column 1. Don't use whitespace at the end of lines. (Severity: 1) -Found "\N{SPACE}" at the end of the line at line 11460, column 57. Don't use whitespace at the end of lines. (Severity: 1) -Found "\N{SPACE}" at the end of the line at line 11461, column 41. Don't use whitespace at the end of lines. (Severity: 1) -Found "\N{SPACE}" at the end of the line at line 11464, column 1. Don't use whitespace at the end of lines. (Severity: 1) -Found "\N{SPACE}" at the end of the line at line 11473, column 1. Don't use whitespace at the end of lines. (Severity: 1) -Found "\N{SPACE}" at the end of the line at line 11474, column 58. Don't use whitespace at the end of lines. (Severity: 1) -Found "\N{SPACE}" at the end of the line at line 11475, column 41. Don't use whitespace at the end of lines. (Severity: 1) -Found "\N{SPACE}" at the end of the line at line 11478, column 1. Don't use whitespace at the end of lines. (Severity: 1) -Found "\N{SPACE}" at the end of the line at line 11487, column 1. Don't use whitespace at the end of lines. (Severity: 1) -Found "\N{SPACE}" at the end of the line at line 11488, column 33. Don't use whitespace at the end of lines. (Severity: 1) -Found "\N{SPACE}" at the end of the line at line 11492, column 10. Don't use whitespace at the end of lines. (Severity: 1) -Found "\N{SPACE}" at the end of the line at line 11493, column 25. Don't use whitespace at the end of lines. (Severity: 1) -Found "\N{SPACE}" at the end of the line at line 11495, column 1. Don't use whitespace at the end of lines. (Severity: 1) -Useless interpolation of literal string at line 11496, column 29. See page 51 of PBP. (Severity: 1) -Useless interpolation of literal string at line 11497, column 29. See page 51 of PBP. (Severity: 1) -Found "\N{SPACE}" at the end of the line at line 11500, column 1. Don't use whitespace at the end of lines. (Severity: 1) -Found "\N{SPACE}" at the end of the line at line 11506, column 1. Don't use whitespace at the end of lines. (Severity: 1) -Found "\N{SPACE}" at the end of the line at line 11515, column 1. Don't use whitespace at the end of lines. (Severity: 1) -Found "\N{SPACE}" at the end of the line at line 11527, column 1. Don't use whitespace at the end of lines. (Severity: 1) -Found "\N{SPACE}" at the end of the line at line 11528, column 33. Don't use whitespace at the end of lines. (Severity: 1) -Found "\N{SPACE}" at the end of the line at line 11532, column 10. Don't use whitespace at the end of lines. (Severity: 1) -Found "\N{SPACE}" at the end of the line at line 11533, column 25. Don't use whitespace at the end of lines. (Severity: 1) -Found "\N{SPACE}" at the end of the line at line 11535, column 1. Don't use whitespace at the end of lines. (Severity: 1) -Found "\N{SPACE}" at the end of the line at line 11541, column 1. Don't use whitespace at the end of lines. (Severity: 1) -Useless interpolation of literal string at line 11548, column 26. See page 51 of PBP. (Severity: 1) -Found "\N{SPACE}" at the end of the line at line 11548, column 63. Don't use whitespace at the end of lines. (Severity: 1) -Found "\N{SPACE}" at the end of the line at line 11549, column 64. Don't use whitespace at the end of lines. (Severity: 1) -Useless interpolation of literal string at line 11550, column 25. See page 51 of PBP. (Severity: 1) -Quotes used with a noisy string at line 11574, column 26. See page 53 of PBP. (Severity: 2) -Quotes used with a noisy string at line 11575, column 26. See page 53 of PBP. (Severity: 2) -Quotes used with a noisy string at line 11581, column 26. See page 53 of PBP. (Severity: 2) -Quotes used with a noisy string at line 11637, column 29. See page 53 of PBP. (Severity: 2) -Quotes used with a noisy string at line 11638, column 29. See page 53 of PBP. (Severity: 2) -Quotes used with a noisy string at line 11643, column 29. See page 53 of PBP. (Severity: 2) -Expression form of "eval" at line 11675, column 56. See page 161 of PBP. (Severity: 5) -Expression form of "eval" at line 11679, column 58. See page 161 of PBP. (Severity: 5) -Postfix control "if" used at line 11684, column 56. See pages 93,94 of PBP. (Severity: 2) -Postfix control "if" used at line 11685, column 58. See pages 93,94 of PBP. (Severity: 2) -Local lexical variable "$Side" is not all lower case or all upper case at line 11697, column 9. See pages 45,46 of PBP. (Severity: 1) -Local lexical variable "$Side" is not all lower case or all upper case at line 11787, column 9. See pages 45,46 of PBP. (Severity: 1) -Local lexical variable "$syncT" is not all lower case or all upper case at line 11804, column 9. See pages 45,46 of PBP. (Severity: 1) -Local lexical variable "$imapT" is not all lower case or all upper case at line 11806, column 9. See pages 45,46 of PBP. (Severity: 1) -Useless interpolation of literal string at line 11810, column 21. See page 51 of PBP. (Severity: 1) -Local lexical variable "$syncT" is not all lower case or all upper case at line 11909, column 9. See pages 45,46 of PBP. (Severity: 1) -Regular expression without "/s" flag at line 11931, column 33. See pages 240,241 of PBP. (Severity: 2) -Regular expression without "/m" flag at line 11931, column 33. See page 237 of PBP. (Severity: 2) -Regular expression without "/s" flag at line 11972, column 26. See pages 240,241 of PBP. (Severity: 2) -Regular expression without "/m" flag at line 11972, column 26. See page 237 of PBP. (Severity: 2) -Use 'eq' or hash instead of fixed-pattern regexps at line 11976, column 36. See pages 271,272 of PBP. (Severity: 2) -Regular expression without "/s" flag at line 11976, column 36. See pages 240,241 of PBP. (Severity: 2) -Regular expression without "/m" flag at line 11976, column 36. See page 237 of PBP. (Severity: 2) -Regular expression without "/s" flag at line 11978, column 31. See pages 240,241 of PBP. (Severity: 2) -Regular expression without "/m" flag at line 11978, column 31. See page 237 of PBP. (Severity: 2) -Regular expression without "/s" flag at line 11984, column 34. See pages 240,241 of PBP. (Severity: 2) -Regular expression without "/m" flag at line 11984, column 34. See page 237 of PBP. (Severity: 2) -Postfix control "if" used at line 11987, column 68. See pages 93,94 of PBP. (Severity: 2) -Split long regexps into smaller qr// chunks at line 12145, column 20. See page 261 of PBP. (Severity: 3) -Use named character classes ([A-Z] vs. [[:upper:]]) at line 12145, column 20. See page 248 of PBP. (Severity: 1) -Use character classes for literal metachars instead of escapes at line 12145, column 20. See page 247 of PBP. (Severity: 1) -Use [\+-] instead of \+|- at line 12145, column 20. See page 265 of PBP. (Severity: 1) -Regular expression without "/s" flag at line 12145, column 20. See pages 240,241 of PBP. (Severity: 2) -Regular expression without "/m" flag at line 12145, column 20. See page 237 of PBP. (Severity: 2) -Postfix control "if" used at line 12151, column 28. See pages 93,94 of PBP. (Severity: 2) -Quotes used with a noisy string at line 12151, column 33. See page 53 of PBP. (Severity: 2) -Postfix control "if" used at line 12152, column 36. See pages 93,94 of PBP. (Severity: 2) -Quotes used with a noisy string at line 12152, column 41. See page 53 of PBP. (Severity: 2) -Local lexical variable "$header_Message_Id" is not all lower case or all upper case at line 12180, column 9. See pages 45,46 of PBP. (Severity: 1) -String *may* require interpolation at line 12180, column 65. See page 51 of PBP. (Severity: 1) -String *may* require interpolation at line 12192, column 43. See page 51 of PBP. (Severity: 1) -String *may* require interpolation at line 12193, column 45. See page 51 of PBP. (Severity: 1) -String *may* require interpolation at line 12194, column 49. See page 51 of PBP. (Severity: 1) -String *may* require interpolation at line 12196, column 45. See page 51 of PBP. (Severity: 1) -String *may* require interpolation at line 12197, column 47. See page 51 of PBP. (Severity: 1) -String *may* require interpolation at line 12198, column 48. See page 51 of PBP. (Severity: 1) -String *may* require interpolation at line 12199, column 56. See page 51 of PBP. (Severity: 1) -String *may* require interpolation at line 12200, column 51. See page 51 of PBP. (Severity: 1) -String *may* require interpolation at line 12202, column 53. See page 51 of PBP. (Severity: 1) -String *may* require interpolation at line 12203, column 55. See page 51 of PBP. (Severity: 1) -String *may* require interpolation at line 12204, column 103. See page 51 of PBP. (Severity: 1) -Postfix control "if" used at line 12233, column 65. See pages 93,94 of PBP. (Severity: 2) -Postfix control "if" used at line 12346, column 81. See pages 93,94 of PBP. (Severity: 2) -Postfix control "unless" used at line 12349, column 32. See pages 96,97 of PBP. (Severity: 2) -Long number not separated with underscores at line 12359, column 74. See page 59 of PBP. (Severity: 2) -Long number not separated with underscores at line 12362, column 81. See page 59 of PBP. (Severity: 2) -Postfix control "unless" used at line 12368, column 30. See pages 96,97 of PBP. (Severity: 2) -Quotes used with a noisy string at line 12385, column 34. See page 53 of PBP. (Severity: 2) -Useless interpolation of literal string at line 12390, column 23. See page 51 of PBP. (Severity: 1) -Builtin function called with parentheses at line 12390, column 41. See page 13 of PBP. (Severity: 1) -Quotes used with a noisy string at line 12402, column 23. See page 53 of PBP. (Severity: 2) -Builtin function called with parentheses at line 12472, column 16. See page 13 of PBP. (Severity: 1) -Quotes used with a string containing no non-whitespace characters at line 12492, column 30. See page 53 of PBP. (Severity: 2) -File handle for "print" or "printf" is not braced at line 12496, column 16. See page 217 of PBP. (Severity: 1) -String *may* require interpolation at line 12497, column 75. See page 51 of PBP. (Severity: 1) +Found "\N{SPACE}" at the end of the line at line 11446, column 1. Don't use whitespace at the end of lines. (Severity: 1) +Found "\N{SPACE}" at the end of the line at line 11449, column 1. Don't use whitespace at the end of lines. (Severity: 1) +Found "\N{SPACE}" at the end of the line at line 11452, column 1. Don't use whitespace at the end of lines. (Severity: 1) +Found "\N{SPACE}" at the end of the line at line 11461, column 1. Don't use whitespace at the end of lines. (Severity: 1) +Found "\N{SPACE}" at the end of the line at line 11462, column 57. Don't use whitespace at the end of lines. (Severity: 1) +Found "\N{SPACE}" at the end of the line at line 11463, column 41. Don't use whitespace at the end of lines. (Severity: 1) +Found "\N{SPACE}" at the end of the line at line 11466, column 1. Don't use whitespace at the end of lines. (Severity: 1) +Found "\N{SPACE}" at the end of the line at line 11475, column 1. Don't use whitespace at the end of lines. (Severity: 1) +Found "\N{SPACE}" at the end of the line at line 11476, column 58. Don't use whitespace at the end of lines. (Severity: 1) +Found "\N{SPACE}" at the end of the line at line 11477, column 41. Don't use whitespace at the end of lines. (Severity: 1) +Found "\N{SPACE}" at the end of the line at line 11480, column 1. Don't use whitespace at the end of lines. (Severity: 1) +Found "\N{SPACE}" at the end of the line at line 11489, column 1. Don't use whitespace at the end of lines. (Severity: 1) +Found "\N{SPACE}" at the end of the line at line 11490, column 33. Don't use whitespace at the end of lines. (Severity: 1) +Found "\N{SPACE}" at the end of the line at line 11494, column 10. Don't use whitespace at the end of lines. (Severity: 1) +Found "\N{SPACE}" at the end of the line at line 11495, column 25. Don't use whitespace at the end of lines. (Severity: 1) +Found "\N{SPACE}" at the end of the line at line 11497, column 1. Don't use whitespace at the end of lines. (Severity: 1) +Useless interpolation of literal string at line 11498, column 29. See page 51 of PBP. (Severity: 1) +Useless interpolation of literal string at line 11499, column 29. See page 51 of PBP. (Severity: 1) +Found "\N{SPACE}" at the end of the line at line 11502, column 1. Don't use whitespace at the end of lines. (Severity: 1) +Found "\N{SPACE}" at the end of the line at line 11508, column 1. Don't use whitespace at the end of lines. (Severity: 1) +Found "\N{SPACE}" at the end of the line at line 11517, column 1. Don't use whitespace at the end of lines. (Severity: 1) +Found "\N{SPACE}" at the end of the line at line 11529, column 1. Don't use whitespace at the end of lines. (Severity: 1) +Found "\N{SPACE}" at the end of the line at line 11530, column 33. Don't use whitespace at the end of lines. (Severity: 1) +Found "\N{SPACE}" at the end of the line at line 11534, column 10. Don't use whitespace at the end of lines. (Severity: 1) +Found "\N{SPACE}" at the end of the line at line 11535, column 25. Don't use whitespace at the end of lines. (Severity: 1) +Found "\N{SPACE}" at the end of the line at line 11537, column 1. Don't use whitespace at the end of lines. (Severity: 1) +Found "\N{SPACE}" at the end of the line at line 11543, column 1. Don't use whitespace at the end of lines. (Severity: 1) +Useless interpolation of literal string at line 11550, column 26. See page 51 of PBP. (Severity: 1) +Found "\N{SPACE}" at the end of the line at line 11550, column 63. Don't use whitespace at the end of lines. (Severity: 1) +Found "\N{SPACE}" at the end of the line at line 11551, column 64. Don't use whitespace at the end of lines. (Severity: 1) +Useless interpolation of literal string at line 11552, column 25. See page 51 of PBP. (Severity: 1) +Quotes used with a noisy string at line 11576, column 26. See page 53 of PBP. (Severity: 2) +Quotes used with a noisy string at line 11577, column 26. See page 53 of PBP. (Severity: 2) +Quotes used with a noisy string at line 11583, column 26. See page 53 of PBP. (Severity: 2) +Quotes used with a noisy string at line 11639, column 29. See page 53 of PBP. (Severity: 2) +Quotes used with a noisy string at line 11640, column 29. See page 53 of PBP. (Severity: 2) +Quotes used with a noisy string at line 11645, column 29. See page 53 of PBP. (Severity: 2) +Expression form of "eval" at line 11677, column 56. See page 161 of PBP. (Severity: 5) +Expression form of "eval" at line 11681, column 58. See page 161 of PBP. (Severity: 5) +Postfix control "if" used at line 11686, column 56. See pages 93,94 of PBP. (Severity: 2) +Postfix control "if" used at line 11687, column 58. See pages 93,94 of PBP. (Severity: 2) +Local lexical variable "$Side" is not all lower case or all upper case at line 11699, column 9. See pages 45,46 of PBP. (Severity: 1) +Local lexical variable "$Side" is not all lower case or all upper case at line 11789, column 9. See pages 45,46 of PBP. (Severity: 1) +Local lexical variable "$syncT" is not all lower case or all upper case at line 11806, column 9. See pages 45,46 of PBP. (Severity: 1) +Local lexical variable "$imapT" is not all lower case or all upper case at line 11808, column 9. See pages 45,46 of PBP. (Severity: 1) +Useless interpolation of literal string at line 11812, column 21. See page 51 of PBP. (Severity: 1) +Local lexical variable "$syncT" is not all lower case or all upper case at line 11911, column 9. See pages 45,46 of PBP. (Severity: 1) +Regular expression without "/s" flag at line 11933, column 33. See pages 240,241 of PBP. (Severity: 2) +Regular expression without "/m" flag at line 11933, column 33. See page 237 of PBP. (Severity: 2) +Regular expression without "/s" flag at line 11974, column 26. See pages 240,241 of PBP. (Severity: 2) +Regular expression without "/m" flag at line 11974, column 26. See page 237 of PBP. (Severity: 2) +Use 'eq' or hash instead of fixed-pattern regexps at line 11978, column 36. See pages 271,272 of PBP. (Severity: 2) +Regular expression without "/s" flag at line 11978, column 36. See pages 240,241 of PBP. (Severity: 2) +Regular expression without "/m" flag at line 11978, column 36. See page 237 of PBP. (Severity: 2) +Regular expression without "/s" flag at line 11980, column 31. See pages 240,241 of PBP. (Severity: 2) +Regular expression without "/m" flag at line 11980, column 31. See page 237 of PBP. (Severity: 2) +Regular expression without "/s" flag at line 11986, column 34. See pages 240,241 of PBP. (Severity: 2) +Regular expression without "/m" flag at line 11986, column 34. See page 237 of PBP. (Severity: 2) +Postfix control "if" used at line 11989, column 68. See pages 93,94 of PBP. (Severity: 2) +Split long regexps into smaller qr// chunks at line 12147, column 20. See page 261 of PBP. (Severity: 3) +Use named character classes ([A-Z] vs. [[:upper:]]) at line 12147, column 20. See page 248 of PBP. (Severity: 1) +Use character classes for literal metachars instead of escapes at line 12147, column 20. See page 247 of PBP. (Severity: 1) +Use [\+-] instead of \+|- at line 12147, column 20. See page 265 of PBP. (Severity: 1) +Regular expression without "/s" flag at line 12147, column 20. See pages 240,241 of PBP. (Severity: 2) +Regular expression without "/m" flag at line 12147, column 20. See page 237 of PBP. (Severity: 2) +Postfix control "if" used at line 12153, column 28. See pages 93,94 of PBP. (Severity: 2) +Quotes used with a noisy string at line 12153, column 33. See page 53 of PBP. (Severity: 2) +Postfix control "if" used at line 12154, column 36. See pages 93,94 of PBP. (Severity: 2) +Quotes used with a noisy string at line 12154, column 41. See page 53 of PBP. (Severity: 2) +Local lexical variable "$header_Message_Id" is not all lower case or all upper case at line 12182, column 9. See pages 45,46 of PBP. (Severity: 1) +String *may* require interpolation at line 12182, column 65. See page 51 of PBP. (Severity: 1) +String *may* require interpolation at line 12194, column 43. See page 51 of PBP. (Severity: 1) +String *may* require interpolation at line 12195, column 45. See page 51 of PBP. (Severity: 1) +String *may* require interpolation at line 12196, column 49. See page 51 of PBP. (Severity: 1) +String *may* require interpolation at line 12198, column 45. See page 51 of PBP. (Severity: 1) +String *may* require interpolation at line 12199, column 47. See page 51 of PBP. (Severity: 1) +String *may* require interpolation at line 12200, column 48. See page 51 of PBP. (Severity: 1) +String *may* require interpolation at line 12201, column 56. See page 51 of PBP. (Severity: 1) +String *may* require interpolation at line 12202, column 51. See page 51 of PBP. (Severity: 1) +String *may* require interpolation at line 12204, column 53. See page 51 of PBP. (Severity: 1) +String *may* require interpolation at line 12205, column 55. See page 51 of PBP. (Severity: 1) +String *may* require interpolation at line 12206, column 103. See page 51 of PBP. (Severity: 1) +Postfix control "if" used at line 12235, column 65. See pages 93,94 of PBP. (Severity: 2) +Postfix control "if" used at line 12348, column 81. See pages 93,94 of PBP. (Severity: 2) +Postfix control "unless" used at line 12351, column 32. See pages 96,97 of PBP. (Severity: 2) +Long number not separated with underscores at line 12361, column 74. See page 59 of PBP. (Severity: 2) +Long number not separated with underscores at line 12364, column 81. See page 59 of PBP. (Severity: 2) +Postfix control "unless" used at line 12370, column 30. See pages 96,97 of PBP. (Severity: 2) +Quotes used with a noisy string at line 12387, column 34. See page 53 of PBP. (Severity: 2) +Useless interpolation of literal string at line 12392, column 23. See page 51 of PBP. (Severity: 1) +Builtin function called with parentheses at line 12392, column 41. See page 13 of PBP. (Severity: 1) +Quotes used with a noisy string at line 12404, column 23. See page 53 of PBP. (Severity: 2) +Builtin function called with parentheses at line 12474, column 16. See page 13 of PBP. (Severity: 1) +Quotes used with a string containing no non-whitespace characters at line 12494, column 30. See page 53 of PBP. (Severity: 2) File handle for "print" or "printf" is not braced at line 12498, column 16. See page 217 of PBP. (Severity: 1) -String *may* require interpolation at line 12499, column 80. See page 51 of PBP. (Severity: 1) -Builtin function called with parentheses at line 12509, column 16. See page 13 of PBP. (Severity: 1) -Ambiguously named variable "last" at line 12548, column 2. See page 48 of PBP. (Severity: 3) -Builtin function called with parentheses at line 12581, column 21. See page 13 of PBP. (Severity: 1) -Found "\N{SPACE}" at the end of the line at line 12591, column 1. Don't use whitespace at the end of lines. (Severity: 1) -Found "\N{SPACE}" at the end of the line at line 12594, column 40. Don't use whitespace at the end of lines. (Severity: 1) -Subroutine "cleanup_mess_from_tests" does not end with "return" at line 12602, column 1. See page 197 of PBP. (Severity: 4) -String *may* require interpolation at line 12747, column 19. See page 51 of PBP. (Severity: 1) -String *may* require interpolation at line 12775, column 34. See page 51 of PBP. (Severity: 1) -String *may* require interpolation at line 12809, column 34. See page 51 of PBP. (Severity: 1) -String *may* require interpolation at line 12833, column 21. See page 51 of PBP. (Severity: 1) -Quotes used with a string containing no non-whitespace characters at line 12844, column 21. See page 53 of PBP. (Severity: 2) -Quotes used with a string containing no non-whitespace characters at line 12893, column 50. See page 53 of PBP. (Severity: 2) -Useless interpolation of literal string at line 12893, column 50. See page 51 of PBP. (Severity: 1) -Reused variable name in lexical scope: $err at line 12901, column 3. Invent unique variable names. (Severity: 3) -Quotes used with a string containing no non-whitespace characters at line 12922, column 24. See page 53 of PBP. (Severity: 2) -Quotes used with a string containing no non-whitespace characters at line 12963, column 50. See page 53 of PBP. (Severity: 2) -Useless interpolation of literal string at line 12963, column 50. See page 51 of PBP. (Severity: 1) -Reused variable name in lexical scope: $err at line 12971, column 3. Invent unique variable names. (Severity: 3) -Builtin function called with parentheses at line 13030, column 12. See page 13 of PBP. (Severity: 1) -Builtin function called with parentheses at line 13046, column 19. See page 13 of PBP. (Severity: 1) -Useless interpolation of literal string at line 13046, column 28. See page 51 of PBP. (Severity: 1) -Useless interpolation of literal string at line 13190, column 13. See page 51 of PBP. (Severity: 1) -Useless interpolation of literal string at line 13190, column 40. See page 51 of PBP. (Severity: 1) -Quotes used with a noisy string at line 13192, column 13. See page 53 of PBP. (Severity: 2) -Quotes used with a noisy string at line 13192, column 35. See page 53 of PBP. (Severity: 2) -Useless interpolation of literal string at line 13194, column 13. See page 51 of PBP. (Severity: 1) -Useless interpolation of literal string at line 13194, column 42. See page 51 of PBP. (Severity: 1) -Useless interpolation of literal string at line 13195, column 13. See page 51 of PBP. (Severity: 1) -Useless interpolation of literal string at line 13195, column 44. See page 51 of PBP. (Severity: 1) -String *may* require interpolation at line 13197, column 59. See page 51 of PBP. (Severity: 1) -String *may* require interpolation at line 13198, column 78. See page 51 of PBP. (Severity: 1) -String *may* require interpolation at line 13199, column 82. See page 51 of PBP. (Severity: 1) -Useless use of $_ at line 13230, column 22. $_ should be omitted when calling "split" with two arguments. (Severity: 2) -Builtin function called with parentheses at line 13250, column 9. See page 13 of PBP. (Severity: 1) -Double-sigil dereference at line 13304, column 17. See page 228 of PBP. (Severity: 2) -Builtin function called with parentheses at line 13331, column 25. See page 13 of PBP. (Severity: 1) -Builtin function called with parentheses at line 13360, column 9. See page 13 of PBP. (Severity: 1) -Builtin function called with parentheses at line 13392, column 15. See page 13 of PBP. (Severity: 1) -Useless interpolation of literal string at line 13396, column 17. See page 51 of PBP. (Severity: 1) -Useless interpolation of literal string at line 13428, column 32. See page 51 of PBP. (Severity: 1) -"warn" used instead of "carp" at line 13429, column 25. See page 283 of PBP. (Severity: 3) -Return value of "close" ignored at line 13431, column 9. Check the return value of "close" for success. (Severity: 2) -Return value of flagged function ignored - close at line 13431, column 9. See pages 208,278 of PBP. (Severity: 1) -Builtin function called with parentheses at line 13436, column 18. See page 13 of PBP. (Severity: 1) -Regular expression without "/s" flag at line 13446, column 40. See pages 240,241 of PBP. (Severity: 2) -Regular expression without "/x" flag at line 13446, column 40. See page 236 of PBP. (Severity: 3) -Regular expression without "/m" flag at line 13446, column 40. See page 237 of PBP. (Severity: 2) -Regular expression without "/s" flag at line 13448, column 23. See pages 240,241 of PBP. (Severity: 2) -Regular expression without "/x" flag at line 13448, column 23. See page 236 of PBP. (Severity: 3) -Regular expression without "/m" flag at line 13448, column 23. See page 237 of PBP. (Severity: 2) -Regular expression without "/s" flag at line 13449, column 23. See pages 240,241 of PBP. (Severity: 2) -Regular expression without "/x" flag at line 13449, column 23. See page 236 of PBP. (Severity: 3) -Regular expression without "/m" flag at line 13449, column 23. See page 237 of PBP. (Severity: 2) +String *may* require interpolation at line 12499, column 75. See page 51 of PBP. (Severity: 1) +File handle for "print" or "printf" is not braced at line 12500, column 16. See page 217 of PBP. (Severity: 1) +String *may* require interpolation at line 12501, column 80. See page 51 of PBP. (Severity: 1) +Builtin function called with parentheses at line 12511, column 16. See page 13 of PBP. (Severity: 1) +Ambiguously named variable "last" at line 12550, column 2. See page 48 of PBP. (Severity: 3) +Builtin function called with parentheses at line 12583, column 21. See page 13 of PBP. (Severity: 1) +Found "\N{SPACE}" at the end of the line at line 12593, column 1. Don't use whitespace at the end of lines. (Severity: 1) +Found "\N{SPACE}" at the end of the line at line 12596, column 40. Don't use whitespace at the end of lines. (Severity: 1) +Subroutine "cleanup_mess_from_tests" does not end with "return" at line 12604, column 1. See page 197 of PBP. (Severity: 4) +String *may* require interpolation at line 12749, column 19. See page 51 of PBP. (Severity: 1) +String *may* require interpolation at line 12777, column 34. See page 51 of PBP. (Severity: 1) +String *may* require interpolation at line 12811, column 34. See page 51 of PBP. (Severity: 1) +String *may* require interpolation at line 12835, column 21. See page 51 of PBP. (Severity: 1) +Quotes used with a string containing no non-whitespace characters at line 12846, column 21. See page 53 of PBP. (Severity: 2) +Quotes used with a string containing no non-whitespace characters at line 12895, column 50. See page 53 of PBP. (Severity: 2) +Useless interpolation of literal string at line 12895, column 50. See page 51 of PBP. (Severity: 1) +Reused variable name in lexical scope: $err at line 12903, column 3. Invent unique variable names. (Severity: 3) +Quotes used with a string containing no non-whitespace characters at line 12924, column 24. See page 53 of PBP. (Severity: 2) +Quotes used with a string containing no non-whitespace characters at line 12965, column 50. See page 53 of PBP. (Severity: 2) +Useless interpolation of literal string at line 12965, column 50. See page 51 of PBP. (Severity: 1) +Reused variable name in lexical scope: $err at line 12973, column 3. Invent unique variable names. (Severity: 3) +Builtin function called with parentheses at line 13032, column 12. See page 13 of PBP. (Severity: 1) +Builtin function called with parentheses at line 13048, column 19. See page 13 of PBP. (Severity: 1) +Useless interpolation of literal string at line 13048, column 28. See page 51 of PBP. (Severity: 1) +Useless interpolation of literal string at line 13192, column 13. See page 51 of PBP. (Severity: 1) +Useless interpolation of literal string at line 13192, column 40. See page 51 of PBP. (Severity: 1) +Quotes used with a noisy string at line 13194, column 13. See page 53 of PBP. (Severity: 2) +Quotes used with a noisy string at line 13194, column 35. See page 53 of PBP. (Severity: 2) +Useless interpolation of literal string at line 13196, column 13. See page 51 of PBP. (Severity: 1) +Useless interpolation of literal string at line 13196, column 42. See page 51 of PBP. (Severity: 1) +Useless interpolation of literal string at line 13197, column 13. See page 51 of PBP. (Severity: 1) +Useless interpolation of literal string at line 13197, column 44. See page 51 of PBP. (Severity: 1) +String *may* require interpolation at line 13199, column 59. See page 51 of PBP. (Severity: 1) +String *may* require interpolation at line 13200, column 78. See page 51 of PBP. (Severity: 1) +String *may* require interpolation at line 13201, column 82. See page 51 of PBP. (Severity: 1) +Useless use of $_ at line 13232, column 22. $_ should be omitted when calling "split" with two arguments. (Severity: 2) +Builtin function called with parentheses at line 13252, column 9. See page 13 of PBP. (Severity: 1) +Double-sigil dereference at line 13306, column 17. See page 228 of PBP. (Severity: 2) +Builtin function called with parentheses at line 13333, column 25. See page 13 of PBP. (Severity: 1) +Builtin function called with parentheses at line 13362, column 9. See page 13 of PBP. (Severity: 1) +Builtin function called with parentheses at line 13394, column 15. See page 13 of PBP. (Severity: 1) +Useless interpolation of literal string at line 13398, column 17. See page 51 of PBP. (Severity: 1) +Useless interpolation of literal string at line 13430, column 32. See page 51 of PBP. (Severity: 1) +"warn" used instead of "carp" at line 13431, column 25. See page 283 of PBP. (Severity: 3) +Return value of "close" ignored at line 13433, column 9. Check the return value of "close" for success. (Severity: 2) +Return value of flagged function ignored - close at line 13433, column 9. See pages 208,278 of PBP. (Severity: 1) +Builtin function called with parentheses at line 13438, column 18. See page 13 of PBP. (Severity: 1) +Regular expression without "/s" flag at line 13448, column 40. See pages 240,241 of PBP. (Severity: 2) +Regular expression without "/x" flag at line 13448, column 40. See page 236 of PBP. (Severity: 3) +Regular expression without "/m" flag at line 13448, column 40. See page 237 of PBP. (Severity: 2) Regular expression without "/s" flag at line 13450, column 23. See pages 240,241 of PBP. (Severity: 2) +Regular expression without "/x" flag at line 13450, column 23. See page 236 of PBP. (Severity: 3) Regular expression without "/m" flag at line 13450, column 23. See page 237 of PBP. (Severity: 2) -Literal line breaks in a string at line 13475, column 19. See pages 60,61 of PBP. (Severity: 3) -Subroutine "myGetOptions" is not all lower case or all upper case at line 13511, column 1. See pages 45,46 of PBP. (Severity: 1) -Subroutine "myGetOptions" with high complexity score (29) at line 13511, column 1. Consider refactoring. (Severity: 3) -Builtin function called with parentheses at line 13532, column 15. See page 13 of PBP. (Severity: 1) -Use character classes for literal metachars instead of escapes at line 13538, column 30. See page 247 of PBP. (Severity: 1) -String delimiter used with "split" at line 13543, column 30. Express it as a regex instead. (Severity: 2) -Quotes used with a noisy string at line 13543, column 36. See page 53 of PBP. (Severity: 2) -Capture variable used outside conditional at line 13543, column 41. See page 253 of PBP. (Severity: 3) -Quotes used with a noisy string at line 13545, column 39. See page 53 of PBP. (Severity: 2) -Quotes used with a noisy string at line 13553, column 47. See page 53 of PBP. (Severity: 2) -Useless use of $_ at line 13554, column 52. $_ should be omitted when calling "split" with two arguments. (Severity: 2) -Quotes used with a noisy string at line 13580, column 55. See page 53 of PBP. (Severity: 2) -String *may* require interpolation at line 13639, column 44. See page 51 of PBP. (Severity: 1) -String *may* require interpolation at line 13646, column 37. See page 51 of PBP. (Severity: 1) -String *may* require interpolation at line 13652, column 41. See page 51 of PBP. (Severity: 1) -String *may* require interpolation at line 13655, column 48. See page 51 of PBP. (Severity: 1) -String *may* require interpolation at line 13660, column 47. See page 51 of PBP. (Severity: 1) -String *may* require interpolation at line 13663, column 53. See page 51 of PBP. (Severity: 1) -String *may* require interpolation at line 13675, column 33. See page 51 of PBP. (Severity: 1) -String *may* require interpolation at line 13679, column 43. See page 51 of PBP. (Severity: 1) -String *may* require interpolation at line 13684, column 38. See page 51 of PBP. (Severity: 1) -String *may* require interpolation at line 13688, column 38. See page 51 of PBP. (Severity: 1) -String *may* require interpolation at line 13692, column 34. See page 51 of PBP. (Severity: 1) -String *may* require interpolation at line 13693, column 43. See page 51 of PBP. (Severity: 1) -Found "\N{SPACE}" at the end of the line at line 13763, column 20. Don't use whitespace at the end of lines. (Severity: 1) -Numeric escapes in interpolated string at line 13770, column 27. See pages 54,55 of PBP. (Severity: 2) -Regular expression without "/s" flag at line 13772, column 23. See pages 240,241 of PBP. (Severity: 2) -Regular expression without "/m" flag at line 13772, column 23. See page 237 of PBP. (Severity: 2) -Found "\N{SPACE}" at the end of the line at line 13977, column 25. Don't use whitespace at the end of lines. (Severity: 1) -Found "\N{SPACE}" at the end of the line at line 13978, column 63. Don't use whitespace at the end of lines. (Severity: 1) -Useless interpolation of literal string at line 13979, column 25. See page 51 of PBP. (Severity: 1) -Useless interpolation of literal string at line 14021, column 35. See page 51 of PBP. (Severity: 1) +Regular expression without "/s" flag at line 13451, column 23. See pages 240,241 of PBP. (Severity: 2) +Regular expression without "/x" flag at line 13451, column 23. See page 236 of PBP. (Severity: 3) +Regular expression without "/m" flag at line 13451, column 23. See page 237 of PBP. (Severity: 2) +Regular expression without "/s" flag at line 13452, column 23. See pages 240,241 of PBP. (Severity: 2) +Regular expression without "/m" flag at line 13452, column 23. See page 237 of PBP. (Severity: 2) +Literal line breaks in a string at line 13477, column 19. See pages 60,61 of PBP. (Severity: 3) +Subroutine "myGetOptions" is not all lower case or all upper case at line 13513, column 1. See pages 45,46 of PBP. (Severity: 1) +Subroutine "myGetOptions" with high complexity score (29) at line 13513, column 1. Consider refactoring. (Severity: 3) +Builtin function called with parentheses at line 13534, column 15. See page 13 of PBP. (Severity: 1) +Use character classes for literal metachars instead of escapes at line 13540, column 30. See page 247 of PBP. (Severity: 1) +String delimiter used with "split" at line 13545, column 30. Express it as a regex instead. (Severity: 2) +Quotes used with a noisy string at line 13545, column 36. See page 53 of PBP. (Severity: 2) +Capture variable used outside conditional at line 13545, column 41. See page 253 of PBP. (Severity: 3) +Quotes used with a noisy string at line 13547, column 39. See page 53 of PBP. (Severity: 2) +Quotes used with a noisy string at line 13555, column 47. See page 53 of PBP. (Severity: 2) +Useless use of $_ at line 13556, column 52. $_ should be omitted when calling "split" with two arguments. (Severity: 2) +Quotes used with a noisy string at line 13582, column 55. See page 53 of PBP. (Severity: 2) +String *may* require interpolation at line 13641, column 44. See page 51 of PBP. (Severity: 1) +String *may* require interpolation at line 13648, column 37. See page 51 of PBP. (Severity: 1) +String *may* require interpolation at line 13654, column 41. See page 51 of PBP. (Severity: 1) +String *may* require interpolation at line 13657, column 48. See page 51 of PBP. (Severity: 1) +String *may* require interpolation at line 13662, column 47. See page 51 of PBP. (Severity: 1) +String *may* require interpolation at line 13665, column 53. See page 51 of PBP. (Severity: 1) +String *may* require interpolation at line 13677, column 33. See page 51 of PBP. (Severity: 1) +String *may* require interpolation at line 13681, column 43. See page 51 of PBP. (Severity: 1) +String *may* require interpolation at line 13686, column 38. See page 51 of PBP. (Severity: 1) +String *may* require interpolation at line 13690, column 38. See page 51 of PBP. (Severity: 1) +String *may* require interpolation at line 13694, column 34. See page 51 of PBP. (Severity: 1) +String *may* require interpolation at line 13695, column 43. See page 51 of PBP. (Severity: 1) +Found "\N{SPACE}" at the end of the line at line 13765, column 20. Don't use whitespace at the end of lines. (Severity: 1) +Numeric escapes in interpolated string at line 13772, column 27. See pages 54,55 of PBP. (Severity: 2) +Regular expression without "/s" flag at line 13774, column 23. See pages 240,241 of PBP. (Severity: 2) +Regular expression without "/m" flag at line 13774, column 23. See page 237 of PBP. (Severity: 2) +Found "\N{SPACE}" at the end of the line at line 13979, column 25. Don't use whitespace at the end of lines. (Severity: 1) +Found "\N{SPACE}" at the end of the line at line 13980, column 63. Don't use whitespace at the end of lines. (Severity: 1) +Useless interpolation of literal string at line 13981, column 25. See page 51 of PBP. (Severity: 1) Useless interpolation of literal string at line 14023, column 35. See page 51 of PBP. (Severity: 1) -Useless interpolation of literal string at line 14024, column 35. See page 51 of PBP. (Severity: 1) -Double-sigil dereference at line 14177, column 17. See page 228 of PBP. (Severity: 2) -Double-sigil dereference at line 14181, column 18. See page 228 of PBP. (Severity: 2) -Double-sigil dereference at line 14186, column 3. See page 228 of PBP. (Severity: 2) -Postfix control "if" used at line 14234, column 46. See pages 93,94 of PBP. (Severity: 2) +Useless interpolation of literal string at line 14025, column 35. See page 51 of PBP. (Severity: 1) +Useless interpolation of literal string at line 14026, column 35. See page 51 of PBP. (Severity: 1) +Double-sigil dereference at line 14179, column 17. See page 228 of PBP. (Severity: 2) +Double-sigil dereference at line 14183, column 18. See page 228 of PBP. (Severity: 2) +Double-sigil dereference at line 14188, column 3. See page 228 of PBP. (Severity: 2) +Postfix control "if" used at line 14236, column 46. See pages 93,94 of PBP. (Severity: 2) 1 files. 437 subroutines/methods. 14,225 statements. -14,377 lines, consisting of: +14,379 lines, consisting of: 2,697 blank lines. - 842 comment lines. + 844 comment lines. 0 data lines. 10,160 lines of Perl code. 678 lines of POD. diff --git a/W/perlcritic_2.txt b/W/perlcritic_2.txt index 37fd9e5..9261b56 100644 --- a/W/perlcritic_2.txt +++ b/W/perlcritic_2.txt @@ -1,4 +1,4 @@ -Main code has high complexity score (411) at line 1, column 1. Consider refactoring. (Severity: 3) +Main code has high complexity score (412) at line 1, column 1. Consider refactoring. (Severity: 3) Missing "REQUIRED ARGUMENTS" section in POD at line 18, column 1. See pages 133,138 of PBP. (Severity: 2) Missing "DIAGNOSTICS" section in POD at line 18, column 1. See pages 133,138 of PBP. (Severity: 2) Missing "DEPENDENCIES" section in POD at line 18, column 1. See pages 133,138 of PBP. (Severity: 2) @@ -54,487 +54,487 @@ Postfix control "if" used at line 2150, column 69. See pages 93,94 of PBP. (Se Code structure is deeply nested at line 2151, column 41. Consider refactoring. (Severity: 3) Postfix control "if" used at line 2162, column 68. See pages 93,94 of PBP. (Severity: 2) Postfix control "if" used at line 2166, column 53. See pages 93,94 of PBP. (Severity: 2) -Postfix control "if" used at line 2340, column 66. See pages 93,94 of PBP. (Severity: 2) -Postfix control "if" used at line 2341, column 41. See pages 93,94 of PBP. (Severity: 2) -Postfix control "if" used at line 2344, column 40. See pages 93,94 of PBP. (Severity: 2) -6 is not one of the allowed literal values (0, 1, 2). Use the Readonly or Const::Fast module or the "constant" pragma instead at line 2665, column 69. Unnamed numeric literals make code less maintainable. (Severity: 2) -Octal literals (0000) are not allowed. Use the Readonly or Const::Fast module or the "constant" pragma instead at line 2702, column 29. Unnamed numeric literals make code less maintainable. (Severity: 2) -Octal literals (0000) are not allowed. Use the Readonly or Const::Fast module or the "constant" pragma instead at line 2704, column 10. Unnamed numeric literals make code less maintainable. (Severity: 2) -777 is not one of the allowed literal values (0, 1, 2). Use the Readonly or Const::Fast module or the "constant" pragma instead at line 2704, column 27. Unnamed numeric literals make code less maintainable. (Severity: 2) -777 is not one of the allowed literal values (0, 1, 2). Use the Readonly or Const::Fast module or the "constant" pragma instead at line 2708, column 10. Unnamed numeric literals make code less maintainable. (Severity: 2) -777 is not one of the allowed literal values (0, 1, 2). Use the Readonly or Const::Fast module or the "constant" pragma instead at line 2709, column 10. Unnamed numeric literals make code less maintainable. (Severity: 2) -Quotes used with a noisy string at line 2752, column 30. See page 53 of PBP. (Severity: 2) -Regular expression without "/s" flag at line 3010, column 23. See pages 240,241 of PBP. (Severity: 2) -Regular expression without "/x" flag at line 3010, column 23. See page 236 of PBP. (Severity: 3) -Regular expression without "/m" flag at line 3010, column 23. See page 237 of PBP. (Severity: 2) -123456 is not one of the allowed literal values (0, 1, 2). Use the Readonly or Const::Fast module or the "constant" pragma instead at line 3097, column 13. Unnamed numeric literals make code less maintainable. (Severity: 2) -Long number not separated with underscores at line 3097, column 13. See page 59 of PBP. (Severity: 2) -Quotes used with a string containing no non-whitespace characters at line 3299, column 12. See page 53 of PBP. (Severity: 2) -Quotes used with a string containing no non-whitespace characters at line 3300, column 12. See page 53 of PBP. (Severity: 2) -Quotes used with a string containing no non-whitespace characters at line 3301, column 16. See page 53 of PBP. (Severity: 2) +Postfix control "if" used at line 2342, column 66. See pages 93,94 of PBP. (Severity: 2) +Postfix control "if" used at line 2343, column 41. See pages 93,94 of PBP. (Severity: 2) +Postfix control "if" used at line 2346, column 40. See pages 93,94 of PBP. (Severity: 2) +6 is not one of the allowed literal values (0, 1, 2). Use the Readonly or Const::Fast module or the "constant" pragma instead at line 2667, column 69. Unnamed numeric literals make code less maintainable. (Severity: 2) +Octal literals (0000) are not allowed. Use the Readonly or Const::Fast module or the "constant" pragma instead at line 2704, column 29. Unnamed numeric literals make code less maintainable. (Severity: 2) +Octal literals (0000) are not allowed. Use the Readonly or Const::Fast module or the "constant" pragma instead at line 2706, column 10. Unnamed numeric literals make code less maintainable. (Severity: 2) +777 is not one of the allowed literal values (0, 1, 2). Use the Readonly or Const::Fast module or the "constant" pragma instead at line 2706, column 27. Unnamed numeric literals make code less maintainable. (Severity: 2) +777 is not one of the allowed literal values (0, 1, 2). Use the Readonly or Const::Fast module or the "constant" pragma instead at line 2710, column 10. Unnamed numeric literals make code less maintainable. (Severity: 2) +777 is not one of the allowed literal values (0, 1, 2). Use the Readonly or Const::Fast module or the "constant" pragma instead at line 2711, column 10. Unnamed numeric literals make code less maintainable. (Severity: 2) +Quotes used with a noisy string at line 2754, column 30. See page 53 of PBP. (Severity: 2) +Regular expression without "/s" flag at line 3012, column 23. See pages 240,241 of PBP. (Severity: 2) +Regular expression without "/x" flag at line 3012, column 23. See page 236 of PBP. (Severity: 3) +Regular expression without "/m" flag at line 3012, column 23. See page 237 of PBP. (Severity: 2) +123456 is not one of the allowed literal values (0, 1, 2). Use the Readonly or Const::Fast module or the "constant" pragma instead at line 3099, column 13. Unnamed numeric literals make code less maintainable. (Severity: 2) +Long number not separated with underscores at line 3099, column 13. See page 59 of PBP. (Severity: 2) +Quotes used with a string containing no non-whitespace characters at line 3301, column 12. See page 53 of PBP. (Severity: 2) Quotes used with a string containing no non-whitespace characters at line 3302, column 12. See page 53 of PBP. (Severity: 2) -Quotes used with a string containing no non-whitespace characters at line 3303, column 12. See page 53 of PBP. (Severity: 2) -Quotes used with a string containing no non-whitespace characters at line 3304, column 16. See page 53 of PBP. (Severity: 2) -Quotes used with a string containing no non-whitespace characters at line 3309, column 26. See page 53 of PBP. (Severity: 2) -Return value of "close" ignored at line 3424, column 9. Check the return value of "close" for success. (Severity: 2) -32 is not one of the allowed literal values (0, 1, 2). Use the Readonly or Const::Fast module or the "constant" pragma instead at line 3439, column 6. Unnamed numeric literals make code less maintainable. (Severity: 2) -32 is not one of the allowed literal values (0, 1, 2). Use the Readonly or Const::Fast module or the "constant" pragma instead at line 3440, column 6. Unnamed numeric literals make code less maintainable. (Severity: 2) -Postfix control "for" used at line 3450, column 33. See page 96 of PBP. (Severity: 2) -32 is not one of the allowed literal values (0, 1, 2). Use the Readonly or Const::Fast module or the "constant" pragma instead at line 3450, column 40. Unnamed numeric literals make code less maintainable. (Severity: 2) -Quotes used with a noisy string at line 3565, column 44. See page 53 of PBP. (Severity: 2) -Quotes used with a noisy string at line 3565, column 55. See page 53 of PBP. (Severity: 2) -Regular expression without "/s" flag at line 3644, column 29. See pages 240,241 of PBP. (Severity: 2) -Regular expression without "/m" flag at line 3644, column 29. See page 237 of PBP. (Severity: 2) -Regular expression without "/s" flag at line 3673, column 31. See pages 240,241 of PBP. (Severity: 2) -Regular expression without "/m" flag at line 3673, column 31. See page 237 of PBP. (Severity: 2) -Regular expression without "/s" flag at line 3863, column 47. See pages 240,241 of PBP. (Severity: 2) -Regular expression without "/m" flag at line 3863, column 47. See page 237 of PBP. (Severity: 2) -Postfix control "if" used at line 3877, column 25. See pages 93,94 of PBP. (Severity: 2) -Useless use of $_ at line 3989, column 40. $_ should be omitted when calling "uc". (Severity: 2) -Too many arguments at line 4013, column 1. See page 182 of PBP. (Severity: 3) -Too many arguments at line 4032, column 1. See page 182 of PBP. (Severity: 3) -Too many arguments at line 4053, column 1. See page 182 of PBP. (Severity: 3) -Regular expression without "/s" flag at line 4102, column 17. See pages 240,241 of PBP. (Severity: 2) -Regular expression without "/m" flag at line 4102, column 17. See page 237 of PBP. (Severity: 2) -Postfix control "if" used at line 4119, column 61. See pages 93,94 of PBP. (Severity: 2) -Regular expression without "/s" flag at line 4211, column 23. See pages 240,241 of PBP. (Severity: 2) -Regular expression without "/x" flag at line 4211, column 23. See page 236 of PBP. (Severity: 3) -Regular expression without "/m" flag at line 4211, column 23. See page 237 of PBP. (Severity: 2) -Regular expression without "/s" flag at line 4360, column 30. See pages 240,241 of PBP. (Severity: 2) -Regular expression without "/m" flag at line 4360, column 30. See page 237 of PBP. (Severity: 2) -Quotes used with a noisy string at line 4415, column 26. See page 53 of PBP. (Severity: 2) -Regular expression without "/s" flag at line 4735, column 42. See pages 240,241 of PBP. (Severity: 2) -Regular expression without "/x" flag at line 4735, column 42. See page 236 of PBP. (Severity: 3) -Regular expression without "/m" flag at line 4735, column 42. See page 237 of PBP. (Severity: 2) -Regular expression without "/s" flag at line 4736, column 33. See pages 240,241 of PBP. (Severity: 2) -Regular expression without "/x" flag at line 4736, column 33. See page 236 of PBP. (Severity: 3) -Regular expression without "/m" flag at line 4736, column 33. See page 237 of PBP. (Severity: 2) -Regular expression without "/s" flag at line 4745, column 42. See pages 240,241 of PBP. (Severity: 2) -Regular expression without "/x" flag at line 4745, column 42. See page 236 of PBP. (Severity: 3) -Regular expression without "/m" flag at line 4745, column 42. See page 237 of PBP. (Severity: 2) -Regular expression without "/s" flag at line 4762, column 42. See pages 240,241 of PBP. (Severity: 2) -Regular expression without "/x" flag at line 4762, column 42. See page 236 of PBP. (Severity: 3) -Regular expression without "/m" flag at line 4762, column 42. See page 237 of PBP. (Severity: 2) -Regular expression without "/s" flag at line 4791, column 50. See pages 240,241 of PBP. (Severity: 2) -Regular expression without "/x" flag at line 4791, column 50. See page 236 of PBP. (Severity: 3) -Regular expression without "/m" flag at line 4791, column 50. See page 237 of PBP. (Severity: 2) -Magic punctuation variable $! used at line 4792, column 81. See page 79 of PBP. (Severity: 2) -Regular expression without "/s" flag at line 4896, column 64. See pages 240,241 of PBP. (Severity: 2) -Regular expression without "/x" flag at line 4896, column 64. See page 236 of PBP. (Severity: 3) -Regular expression without "/m" flag at line 4896, column 64. See page 237 of PBP. (Severity: 2) -Regular expression without "/s" flag at line 4897, column 64. See pages 240,241 of PBP. (Severity: 2) -Regular expression without "/x" flag at line 4897, column 64. See page 236 of PBP. (Severity: 3) -Regular expression without "/m" flag at line 4897, column 64. See page 237 of PBP. (Severity: 2) -Regular expression without "/s" flag at line 4900, column 56. See pages 240,241 of PBP. (Severity: 2) -Regular expression without "/x" flag at line 4900, column 56. See page 236 of PBP. (Severity: 3) -Regular expression without "/m" flag at line 4900, column 56. See page 237 of PBP. (Severity: 2) -Too many arguments at line 4928, column 1. See page 182 of PBP. (Severity: 3) -Subroutine "authenticate_imap" with high complexity score (23) at line 5010, column 1. Consider refactoring. (Severity: 3) -Too many arguments at line 5010, column 1. See page 182 of PBP. (Severity: 3) -Postfix control "if" used at line 5020, column 34. See pages 93,94 of PBP. (Severity: 2) -Postfix control "unless" used at line 5034, column 51. See pages 96,97 of PBP. (Severity: 2) -Postfix control "if" used at line 5037, column 40. See pages 93,94 of PBP. (Severity: 2) -Postfix control "if" used at line 5038, column 40. See pages 93,94 of PBP. (Severity: 2) -Postfix control "if" used at line 5039, column 42. See pages 93,94 of PBP. (Severity: 2) -"unless" block used at line 5042, column 9. See page 97 of PBP. (Severity: 2) -Postfix control "if" used at line 5124, column 45. See pages 93,94 of PBP. (Severity: 2) -Postfix control "if" used at line 5150, column 45. See pages 93,94 of PBP. (Severity: 2) -Too many arguments at line 5162, column 1. See page 182 of PBP. (Severity: 3) -Postfix control "if" used at line 5191, column 50. See pages 93,94 of PBP. (Severity: 2) -Numeric escapes in interpolated string at line 5206, column 32. See pages 54,55 of PBP. (Severity: 2) -Regular expression without "/s" flag at line 5254, column 32. See pages 240,241 of PBP. (Severity: 2) -Regular expression without "/m" flag at line 5254, column 32. See page 237 of PBP. (Severity: 2) -Use "local $/ = undef" or Path::Tiny instead of joined readline at line 5259, column 43. See page 213 of PBP. (Severity: 3) -Return value of "close" ignored at line 5260, column 13. Check the return value of "close" for success. (Severity: 2) -Regular expression without "/s" flag at line 5269, column 69. See pages 240,241 of PBP. (Severity: 2) -Regular expression without "/m" flag at line 5269, column 69. See page 237 of PBP. (Severity: 2) -Postfix control "if" used at line 5272, column 37. See pages 93,94 of PBP. (Severity: 2) -Backtick operator used at line 5277, column 20. Use IPC::Open3 instead. (Severity: 3) -"unless" block used at line 5302, column 9. See page 97 of PBP. (Severity: 2) -Regular expression without "/s" flag at line 5337, column 32. See pages 240,241 of PBP. (Severity: 2) -Regular expression without "/m" flag at line 5337, column 32. See page 237 of PBP. (Severity: 2) -Quotes used with a noisy string at line 5407, column 56. See page 53 of PBP. (Severity: 2) -Regular expression without "/s" flag at line 5415, column 26. See pages 240,241 of PBP. (Severity: 2) -Regular expression without "/x" flag at line 5415, column 26. See page 236 of PBP. (Severity: 3) -Regular expression without "/m" flag at line 5415, column 26. See page 237 of PBP. (Severity: 2) -Postfix control "if" used at line 5436, column 82. See pages 93,94 of PBP. (Severity: 2) -Quotes used with a noisy string at line 5437, column 46. See page 53 of PBP. (Severity: 2) -Postfix control "if" used at line 5442, column 91. See pages 93,94 of PBP. (Severity: 2) -Quotes used with a noisy string at line 5444, column 46. See page 53 of PBP. (Severity: 2) -Postfix control "if" used at line 5491, column 42. See pages 93,94 of PBP. (Severity: 2) -Quotes used with a string containing no non-whitespace characters at line 5503, column 40. See page 53 of PBP. (Severity: 2) -Long number not separated with underscores at line 5509, column 36. See page 59 of PBP. (Severity: 2) -Long number not separated with underscores at line 5511, column 40. See page 59 of PBP. (Severity: 2) -Long number not separated with underscores at line 5512, column 40. See page 59 of PBP. (Severity: 2) -Long number not separated with underscores at line 5525, column 14. See page 59 of PBP. (Severity: 2) -Magic punctuation variable $! used in interpolated string at line 5570, column 34. See page 79 of PBP. (Severity: 2) -Return value of "close" ignored at line 5635, column 17. Check the return value of "close" for success. (Severity: 2) -Return value of "close" ignored at line 5669, column 17. Check the return value of "close" for success. (Severity: 2) -Regular expression without "/s" flag at line 5805, column 15. See pages 240,241 of PBP. (Severity: 2) -Regular expression without "/m" flag at line 5805, column 15. See page 237 of PBP. (Severity: 2) -Regular expression without "/s" flag at line 5806, column 15. See pages 240,241 of PBP. (Severity: 2) -Regular expression without "/m" flag at line 5806, column 15. See page 237 of PBP. (Severity: 2) +Quotes used with a string containing no non-whitespace characters at line 3303, column 16. See page 53 of PBP. (Severity: 2) +Quotes used with a string containing no non-whitespace characters at line 3304, column 12. See page 53 of PBP. (Severity: 2) +Quotes used with a string containing no non-whitespace characters at line 3305, column 12. See page 53 of PBP. (Severity: 2) +Quotes used with a string containing no non-whitespace characters at line 3306, column 16. See page 53 of PBP. (Severity: 2) +Quotes used with a string containing no non-whitespace characters at line 3311, column 26. See page 53 of PBP. (Severity: 2) +Return value of "close" ignored at line 3426, column 9. Check the return value of "close" for success. (Severity: 2) +32 is not one of the allowed literal values (0, 1, 2). Use the Readonly or Const::Fast module or the "constant" pragma instead at line 3441, column 6. Unnamed numeric literals make code less maintainable. (Severity: 2) +32 is not one of the allowed literal values (0, 1, 2). Use the Readonly or Const::Fast module or the "constant" pragma instead at line 3442, column 6. Unnamed numeric literals make code less maintainable. (Severity: 2) +Postfix control "for" used at line 3452, column 33. See page 96 of PBP. (Severity: 2) +32 is not one of the allowed literal values (0, 1, 2). Use the Readonly or Const::Fast module or the "constant" pragma instead at line 3452, column 40. Unnamed numeric literals make code less maintainable. (Severity: 2) +Quotes used with a noisy string at line 3567, column 44. See page 53 of PBP. (Severity: 2) +Quotes used with a noisy string at line 3567, column 55. See page 53 of PBP. (Severity: 2) +Regular expression without "/s" flag at line 3646, column 29. See pages 240,241 of PBP. (Severity: 2) +Regular expression without "/m" flag at line 3646, column 29. See page 237 of PBP. (Severity: 2) +Regular expression without "/s" flag at line 3675, column 31. See pages 240,241 of PBP. (Severity: 2) +Regular expression without "/m" flag at line 3675, column 31. See page 237 of PBP. (Severity: 2) +Regular expression without "/s" flag at line 3865, column 47. See pages 240,241 of PBP. (Severity: 2) +Regular expression without "/m" flag at line 3865, column 47. See page 237 of PBP. (Severity: 2) +Postfix control "if" used at line 3879, column 25. See pages 93,94 of PBP. (Severity: 2) +Useless use of $_ at line 3991, column 40. $_ should be omitted when calling "uc". (Severity: 2) +Too many arguments at line 4015, column 1. See page 182 of PBP. (Severity: 3) +Too many arguments at line 4034, column 1. See page 182 of PBP. (Severity: 3) +Too many arguments at line 4055, column 1. See page 182 of PBP. (Severity: 3) +Regular expression without "/s" flag at line 4104, column 17. See pages 240,241 of PBP. (Severity: 2) +Regular expression without "/m" flag at line 4104, column 17. See page 237 of PBP. (Severity: 2) +Postfix control "if" used at line 4121, column 61. See pages 93,94 of PBP. (Severity: 2) +Regular expression without "/s" flag at line 4213, column 23. See pages 240,241 of PBP. (Severity: 2) +Regular expression without "/x" flag at line 4213, column 23. See page 236 of PBP. (Severity: 3) +Regular expression without "/m" flag at line 4213, column 23. See page 237 of PBP. (Severity: 2) +Regular expression without "/s" flag at line 4362, column 30. See pages 240,241 of PBP. (Severity: 2) +Regular expression without "/m" flag at line 4362, column 30. See page 237 of PBP. (Severity: 2) +Quotes used with a noisy string at line 4417, column 26. See page 53 of PBP. (Severity: 2) +Regular expression without "/s" flag at line 4737, column 42. See pages 240,241 of PBP. (Severity: 2) +Regular expression without "/x" flag at line 4737, column 42. See page 236 of PBP. (Severity: 3) +Regular expression without "/m" flag at line 4737, column 42. See page 237 of PBP. (Severity: 2) +Regular expression without "/s" flag at line 4738, column 33. See pages 240,241 of PBP. (Severity: 2) +Regular expression without "/x" flag at line 4738, column 33. See page 236 of PBP. (Severity: 3) +Regular expression without "/m" flag at line 4738, column 33. See page 237 of PBP. (Severity: 2) +Regular expression without "/s" flag at line 4747, column 42. See pages 240,241 of PBP. (Severity: 2) +Regular expression without "/x" flag at line 4747, column 42. See page 236 of PBP. (Severity: 3) +Regular expression without "/m" flag at line 4747, column 42. See page 237 of PBP. (Severity: 2) +Regular expression without "/s" flag at line 4764, column 42. See pages 240,241 of PBP. (Severity: 2) +Regular expression without "/x" flag at line 4764, column 42. See page 236 of PBP. (Severity: 3) +Regular expression without "/m" flag at line 4764, column 42. See page 237 of PBP. (Severity: 2) +Regular expression without "/s" flag at line 4793, column 50. See pages 240,241 of PBP. (Severity: 2) +Regular expression without "/x" flag at line 4793, column 50. See page 236 of PBP. (Severity: 3) +Regular expression without "/m" flag at line 4793, column 50. See page 237 of PBP. (Severity: 2) +Magic punctuation variable $! used at line 4794, column 81. See page 79 of PBP. (Severity: 2) +Regular expression without "/s" flag at line 4898, column 64. See pages 240,241 of PBP. (Severity: 2) +Regular expression without "/x" flag at line 4898, column 64. See page 236 of PBP. (Severity: 3) +Regular expression without "/m" flag at line 4898, column 64. See page 237 of PBP. (Severity: 2) +Regular expression without "/s" flag at line 4899, column 64. See pages 240,241 of PBP. (Severity: 2) +Regular expression without "/x" flag at line 4899, column 64. See page 236 of PBP. (Severity: 3) +Regular expression without "/m" flag at line 4899, column 64. See page 237 of PBP. (Severity: 2) +Regular expression without "/s" flag at line 4902, column 56. See pages 240,241 of PBP. (Severity: 2) +Regular expression without "/x" flag at line 4902, column 56. See page 236 of PBP. (Severity: 3) +Regular expression without "/m" flag at line 4902, column 56. See page 237 of PBP. (Severity: 2) +Too many arguments at line 4930, column 1. See page 182 of PBP. (Severity: 3) +Subroutine "authenticate_imap" with high complexity score (23) at line 5012, column 1. Consider refactoring. (Severity: 3) +Too many arguments at line 5012, column 1. See page 182 of PBP. (Severity: 3) +Postfix control "if" used at line 5022, column 34. See pages 93,94 of PBP. (Severity: 2) +Postfix control "unless" used at line 5036, column 51. See pages 96,97 of PBP. (Severity: 2) +Postfix control "if" used at line 5039, column 40. See pages 93,94 of PBP. (Severity: 2) +Postfix control "if" used at line 5040, column 40. See pages 93,94 of PBP. (Severity: 2) +Postfix control "if" used at line 5041, column 42. See pages 93,94 of PBP. (Severity: 2) +"unless" block used at line 5044, column 9. See page 97 of PBP. (Severity: 2) +Postfix control "if" used at line 5126, column 45. See pages 93,94 of PBP. (Severity: 2) +Postfix control "if" used at line 5152, column 45. See pages 93,94 of PBP. (Severity: 2) +Too many arguments at line 5164, column 1. See page 182 of PBP. (Severity: 3) +Postfix control "if" used at line 5193, column 50. See pages 93,94 of PBP. (Severity: 2) +Numeric escapes in interpolated string at line 5208, column 32. See pages 54,55 of PBP. (Severity: 2) +Regular expression without "/s" flag at line 5256, column 32. See pages 240,241 of PBP. (Severity: 2) +Regular expression without "/m" flag at line 5256, column 32. See page 237 of PBP. (Severity: 2) +Use "local $/ = undef" or Path::Tiny instead of joined readline at line 5261, column 43. See page 213 of PBP. (Severity: 3) +Return value of "close" ignored at line 5262, column 13. Check the return value of "close" for success. (Severity: 2) +Regular expression without "/s" flag at line 5271, column 69. See pages 240,241 of PBP. (Severity: 2) +Regular expression without "/m" flag at line 5271, column 69. See page 237 of PBP. (Severity: 2) +Postfix control "if" used at line 5274, column 37. See pages 93,94 of PBP. (Severity: 2) +Backtick operator used at line 5279, column 20. Use IPC::Open3 instead. (Severity: 3) +"unless" block used at line 5304, column 9. See page 97 of PBP. (Severity: 2) +Regular expression without "/s" flag at line 5339, column 32. See pages 240,241 of PBP. (Severity: 2) +Regular expression without "/m" flag at line 5339, column 32. See page 237 of PBP. (Severity: 2) +Quotes used with a noisy string at line 5409, column 56. See page 53 of PBP. (Severity: 2) +Regular expression without "/s" flag at line 5417, column 26. See pages 240,241 of PBP. (Severity: 2) +Regular expression without "/x" flag at line 5417, column 26. See page 236 of PBP. (Severity: 3) +Regular expression without "/m" flag at line 5417, column 26. See page 237 of PBP. (Severity: 2) +Postfix control "if" used at line 5438, column 82. See pages 93,94 of PBP. (Severity: 2) +Quotes used with a noisy string at line 5439, column 46. See page 53 of PBP. (Severity: 2) +Postfix control "if" used at line 5444, column 91. See pages 93,94 of PBP. (Severity: 2) +Quotes used with a noisy string at line 5446, column 46. See page 53 of PBP. (Severity: 2) +Postfix control "if" used at line 5493, column 42. See pages 93,94 of PBP. (Severity: 2) +Quotes used with a string containing no non-whitespace characters at line 5505, column 40. See page 53 of PBP. (Severity: 2) +Long number not separated with underscores at line 5511, column 36. See page 59 of PBP. (Severity: 2) +Long number not separated with underscores at line 5513, column 40. See page 59 of PBP. (Severity: 2) +Long number not separated with underscores at line 5514, column 40. See page 59 of PBP. (Severity: 2) +Long number not separated with underscores at line 5527, column 14. See page 59 of PBP. (Severity: 2) +Magic punctuation variable $! used in interpolated string at line 5572, column 34. See page 79 of PBP. (Severity: 2) +Return value of "close" ignored at line 5637, column 17. Check the return value of "close" for success. (Severity: 2) +Return value of "close" ignored at line 5671, column 17. Check the return value of "close" for success. (Severity: 2) Regular expression without "/s" flag at line 5807, column 15. See pages 240,241 of PBP. (Severity: 2) Regular expression without "/m" flag at line 5807, column 15. See page 237 of PBP. (Severity: 2) -Regular expression without "/s" flag at line 5817, column 15. See pages 240,241 of PBP. (Severity: 2) -Regular expression without "/m" flag at line 5817, column 15. See page 237 of PBP. (Severity: 2) -Regular expression without "/s" flag at line 5818, column 15. See pages 240,241 of PBP. (Severity: 2) -Regular expression without "/m" flag at line 5818, column 15. See page 237 of PBP. (Severity: 2) +Regular expression without "/s" flag at line 5808, column 15. See pages 240,241 of PBP. (Severity: 2) +Regular expression without "/m" flag at line 5808, column 15. See page 237 of PBP. (Severity: 2) +Regular expression without "/s" flag at line 5809, column 15. See pages 240,241 of PBP. (Severity: 2) +Regular expression without "/m" flag at line 5809, column 15. See page 237 of PBP. (Severity: 2) Regular expression without "/s" flag at line 5819, column 15. See pages 240,241 of PBP. (Severity: 2) Regular expression without "/m" flag at line 5819, column 15. See page 237 of PBP. (Severity: 2) -Regular expression without "/s" flag at line 5865, column 31. See pages 240,241 of PBP. (Severity: 2) -Regular expression without "/m" flag at line 5865, column 31. See page 237 of PBP. (Severity: 2) -Regular expression without "/s" flag at line 5954, column 24. See pages 240,241 of PBP. (Severity: 2) -Regular expression without "/m" flag at line 5954, column 24. See page 237 of PBP. (Severity: 2) -Regular expression without "/s" flag at line 5957, column 20. See pages 240,241 of PBP. (Severity: 2) -Regular expression without "/m" flag at line 5957, column 20. See page 237 of PBP. (Severity: 2) -Use 'eq' or hash instead of fixed-pattern regexps at line 6169, column 38. See pages 271,272 of PBP. (Severity: 2) -Regular expression without "/s" flag at line 6169, column 38. See pages 240,241 of PBP. (Severity: 2) -Regular expression without "/m" flag at line 6169, column 38. See page 237 of PBP. (Severity: 2) -Regular expression without "/s" flag at line 6170, column 33. See pages 240,241 of PBP. (Severity: 2) -Regular expression without "/m" flag at line 6170, column 33. See page 237 of PBP. (Severity: 2) -Regular expression without "/s" flag at line 6174, column 33. See pages 240,241 of PBP. (Severity: 2) -Regular expression without "/m" flag at line 6174, column 33. See page 237 of PBP. (Severity: 2) -Quotes used with a noisy string at line 6249, column 26. See page 53 of PBP. (Severity: 2) -Postfix control "while" used at line 6249, column 34. See page 96 of PBP. (Severity: 2) -Regular expression without "/s" flag at line 6249, column 53. See pages 240,241 of PBP. (Severity: 2) -Regular expression without "/m" flag at line 6249, column 53. See page 237 of PBP. (Severity: 2) -Quotes used with a noisy string at line 6250, column 26. See page 53 of PBP. (Severity: 2) -Postfix control "while" used at line 6250, column 34. See page 96 of PBP. (Severity: 2) -Regular expression without "/s" flag at line 6250, column 53. See pages 240,241 of PBP. (Severity: 2) -Regular expression without "/m" flag at line 6250, column 53. See page 237 of PBP. (Severity: 2) -Postfix control "while" used at line 6251, column 36. See page 96 of PBP. (Severity: 2) -Regular expression without "/s" flag at line 6251, column 55. See pages 240,241 of PBP. (Severity: 2) -Regular expression without "/m" flag at line 6251, column 55. See page 237 of PBP. (Severity: 2) +Regular expression without "/s" flag at line 5820, column 15. See pages 240,241 of PBP. (Severity: 2) +Regular expression without "/m" flag at line 5820, column 15. See page 237 of PBP. (Severity: 2) +Regular expression without "/s" flag at line 5821, column 15. See pages 240,241 of PBP. (Severity: 2) +Regular expression without "/m" flag at line 5821, column 15. See page 237 of PBP. (Severity: 2) +Regular expression without "/s" flag at line 5867, column 31. See pages 240,241 of PBP. (Severity: 2) +Regular expression without "/m" flag at line 5867, column 31. See page 237 of PBP. (Severity: 2) +Regular expression without "/s" flag at line 5956, column 24. See pages 240,241 of PBP. (Severity: 2) +Regular expression without "/m" flag at line 5956, column 24. See page 237 of PBP. (Severity: 2) +Regular expression without "/s" flag at line 5959, column 20. See pages 240,241 of PBP. (Severity: 2) +Regular expression without "/m" flag at line 5959, column 20. See page 237 of PBP. (Severity: 2) +Use 'eq' or hash instead of fixed-pattern regexps at line 6171, column 38. See pages 271,272 of PBP. (Severity: 2) +Regular expression without "/s" flag at line 6171, column 38. See pages 240,241 of PBP. (Severity: 2) +Regular expression without "/m" flag at line 6171, column 38. See page 237 of PBP. (Severity: 2) +Regular expression without "/s" flag at line 6172, column 33. See pages 240,241 of PBP. (Severity: 2) +Regular expression without "/m" flag at line 6172, column 33. See page 237 of PBP. (Severity: 2) +Regular expression without "/s" flag at line 6176, column 33. See pages 240,241 of PBP. (Severity: 2) +Regular expression without "/m" flag at line 6176, column 33. See page 237 of PBP. (Severity: 2) +Quotes used with a noisy string at line 6251, column 26. See page 53 of PBP. (Severity: 2) +Postfix control "while" used at line 6251, column 34. See page 96 of PBP. (Severity: 2) +Regular expression without "/s" flag at line 6251, column 53. See pages 240,241 of PBP. (Severity: 2) +Regular expression without "/m" flag at line 6251, column 53. See page 237 of PBP. (Severity: 2) Quotes used with a noisy string at line 6252, column 26. See page 53 of PBP. (Severity: 2) Postfix control "while" used at line 6252, column 34. See page 96 of PBP. (Severity: 2) Regular expression without "/s" flag at line 6252, column 53. See pages 240,241 of PBP. (Severity: 2) Regular expression without "/m" flag at line 6252, column 53. See page 237 of PBP. (Severity: 2) -Quotes used with a noisy string at line 6264, column 13. See page 53 of PBP. (Severity: 2) -Quotes used with a noisy string at line 6265, column 13. See page 53 of PBP. (Severity: 2) +Postfix control "while" used at line 6253, column 36. See page 96 of PBP. (Severity: 2) +Regular expression without "/s" flag at line 6253, column 55. See pages 240,241 of PBP. (Severity: 2) +Regular expression without "/m" flag at line 6253, column 55. See page 237 of PBP. (Severity: 2) +Quotes used with a noisy string at line 6254, column 26. See page 53 of PBP. (Severity: 2) +Postfix control "while" used at line 6254, column 34. See page 96 of PBP. (Severity: 2) +Regular expression without "/s" flag at line 6254, column 53. See pages 240,241 of PBP. (Severity: 2) +Regular expression without "/m" flag at line 6254, column 53. See page 237 of PBP. (Severity: 2) Quotes used with a noisy string at line 6266, column 13. See page 53 of PBP. (Severity: 2) Quotes used with a noisy string at line 6267, column 13. See page 53 of PBP. (Severity: 2) +Quotes used with a noisy string at line 6268, column 13. See page 53 of PBP. (Severity: 2) Quotes used with a noisy string at line 6269, column 13. See page 53 of PBP. (Severity: 2) -Quotes used with a noisy string at line 6270, column 13. See page 53 of PBP. (Severity: 2) Quotes used with a noisy string at line 6271, column 13. See page 53 of PBP. (Severity: 2) -Quotes used with a noisy string at line 6365, column 11. See page 53 of PBP. (Severity: 2) -Quotes used with a noisy string at line 6366, column 11. See page 53 of PBP. (Severity: 2) -Quotes used with a noisy string at line 6412, column 11. See page 53 of PBP. (Severity: 2) -Quotes used with a noisy string at line 6413, column 11. See page 53 of PBP. (Severity: 2) -Quotes used with a noisy string at line 6428, column 11. See page 53 of PBP. (Severity: 2) -Quotes used with a noisy string at line 6429, column 11. See page 53 of PBP. (Severity: 2) -Quotes used with a string containing no non-whitespace characters at line 6488, column 30. See page 53 of PBP. (Severity: 2) -Quotes used with a string containing no non-whitespace characters at line 6489, column 30. See page 53 of PBP. (Severity: 2) -Quotes used with a noisy string at line 6490, column 30. See page 53 of PBP. (Severity: 2) -Quotes used with a noisy string at line 6491, column 30. See page 53 of PBP. (Severity: 2) -Quotes used with a noisy string at line 6540, column 65. See page 53 of PBP. (Severity: 2) -Quotes used with a noisy string at line 6541, column 65. See page 53 of PBP. (Severity: 2) -Regular expression without "/s" flag at line 6544, column 21. See pages 240,241 of PBP. (Severity: 2) -Regular expression without "/m" flag at line 6544, column 21. See page 237 of PBP. (Severity: 2) -Postfix control "unless" used at line 6550, column 11. See pages 96,97 of PBP. (Severity: 2) -Use 'eq' or hash instead of fixed-pattern regexps at line 6550, column 79. See pages 271,272 of PBP. (Severity: 2) -Regular expression without "/s" flag at line 6550, column 79. See pages 240,241 of PBP. (Severity: 2) -Regular expression without "/m" flag at line 6550, column 79. See page 237 of PBP. (Severity: 2) -Quotes used with a noisy string at line 6566, column 53. See page 53 of PBP. (Severity: 2) -Quotes used with a noisy string at line 6566, column 58. See page 53 of PBP. (Severity: 2) -Quotes used with a noisy string at line 6567, column 55. See page 53 of PBP. (Severity: 2) -Quotes used with a noisy string at line 6567, column 60. See page 53 of PBP. (Severity: 2) -Quotes used with a noisy string at line 6568, column 55. See page 53 of PBP. (Severity: 2) -Quotes used with a noisy string at line 6568, column 60. See page 53 of PBP. (Severity: 2) +Quotes used with a noisy string at line 6272, column 13. See page 53 of PBP. (Severity: 2) +Quotes used with a noisy string at line 6273, column 13. See page 53 of PBP. (Severity: 2) +Quotes used with a noisy string at line 6367, column 11. See page 53 of PBP. (Severity: 2) +Quotes used with a noisy string at line 6368, column 11. See page 53 of PBP. (Severity: 2) +Quotes used with a noisy string at line 6414, column 11. See page 53 of PBP. (Severity: 2) +Quotes used with a noisy string at line 6415, column 11. See page 53 of PBP. (Severity: 2) +Quotes used with a noisy string at line 6430, column 11. See page 53 of PBP. (Severity: 2) +Quotes used with a noisy string at line 6431, column 11. See page 53 of PBP. (Severity: 2) +Quotes used with a string containing no non-whitespace characters at line 6490, column 30. See page 53 of PBP. (Severity: 2) +Quotes used with a string containing no non-whitespace characters at line 6491, column 30. See page 53 of PBP. (Severity: 2) +Quotes used with a noisy string at line 6492, column 30. See page 53 of PBP. (Severity: 2) +Quotes used with a noisy string at line 6493, column 30. See page 53 of PBP. (Severity: 2) +Quotes used with a noisy string at line 6542, column 65. See page 53 of PBP. (Severity: 2) +Quotes used with a noisy string at line 6543, column 65. See page 53 of PBP. (Severity: 2) +Regular expression without "/s" flag at line 6546, column 21. See pages 240,241 of PBP. (Severity: 2) +Regular expression without "/m" flag at line 6546, column 21. See page 237 of PBP. (Severity: 2) +Postfix control "unless" used at line 6552, column 11. See pages 96,97 of PBP. (Severity: 2) +Use 'eq' or hash instead of fixed-pattern regexps at line 6552, column 79. See pages 271,272 of PBP. (Severity: 2) +Regular expression without "/s" flag at line 6552, column 79. See pages 240,241 of PBP. (Severity: 2) +Regular expression without "/m" flag at line 6552, column 79. See page 237 of PBP. (Severity: 2) +Quotes used with a noisy string at line 6568, column 53. See page 53 of PBP. (Severity: 2) +Quotes used with a noisy string at line 6568, column 58. See page 53 of PBP. (Severity: 2) Quotes used with a noisy string at line 6569, column 55. See page 53 of PBP. (Severity: 2) Quotes used with a noisy string at line 6569, column 60. See page 53 of PBP. (Severity: 2) -Quotes used with a noisy string at line 6570, column 57. See page 53 of PBP. (Severity: 2) -Quotes used with a noisy string at line 6570, column 62. See page 53 of PBP. (Severity: 2) +Quotes used with a noisy string at line 6570, column 55. See page 53 of PBP. (Severity: 2) +Quotes used with a noisy string at line 6570, column 60. See page 53 of PBP. (Severity: 2) +Quotes used with a noisy string at line 6571, column 55. See page 53 of PBP. (Severity: 2) +Quotes used with a noisy string at line 6571, column 60. See page 53 of PBP. (Severity: 2) Quotes used with a noisy string at line 6572, column 57. See page 53 of PBP. (Severity: 2) Quotes used with a noisy string at line 6572, column 62. See page 53 of PBP. (Severity: 2) Quotes used with a noisy string at line 6574, column 57. See page 53 of PBP. (Severity: 2) Quotes used with a noisy string at line 6574, column 62. See page 53 of PBP. (Severity: 2) -Numeric escapes in interpolated string at line 6588, column 21. See pages 54,55 of PBP. (Severity: 2) -Regular expression without "/s" flag at line 6591, column 21. See pages 240,241 of PBP. (Severity: 2) -Regular expression without "/m" flag at line 6591, column 21. See page 237 of PBP. (Severity: 2) -Regular expression without "/s" flag at line 6592, column 21. See pages 240,241 of PBP. (Severity: 2) -Regular expression without "/m" flag at line 6592, column 21. See page 237 of PBP. (Severity: 2) +Quotes used with a noisy string at line 6576, column 57. See page 53 of PBP. (Severity: 2) +Quotes used with a noisy string at line 6576, column 62. See page 53 of PBP. (Severity: 2) +Numeric escapes in interpolated string at line 6590, column 21. See pages 54,55 of PBP. (Severity: 2) Regular expression without "/s" flag at line 6593, column 21. See pages 240,241 of PBP. (Severity: 2) Regular expression without "/m" flag at line 6593, column 21. See page 237 of PBP. (Severity: 2) Regular expression without "/s" flag at line 6594, column 21. See pages 240,241 of PBP. (Severity: 2) Regular expression without "/m" flag at line 6594, column 21. See page 237 of PBP. (Severity: 2) -Postfix control "if" used at line 6594, column 30. See pages 93,94 of PBP. (Severity: 2) -Quotes used with a noisy string at line 6594, column 49. See page 53 of PBP. (Severity: 2) -Quotes used with a noisy string at line 6594, column 74. See page 53 of PBP. (Severity: 2) -Expression form of "eval" at line 6605, column 27. See page 161 of PBP. (Severity: 5) -Quotes used with a noisy string at line 6621, column 35. See page 53 of PBP. (Severity: 2) -Regular expression without "/s" flag at line 6632, column 49. See pages 240,241 of PBP. (Severity: 2) -Regular expression without "/m" flag at line 6632, column 49. See page 237 of PBP. (Severity: 2) -"unless" block used at line 6666, column 17. See page 97 of PBP. (Severity: 2) -Postfix control "if" used at line 6679, column 53. See pages 93,94 of PBP. (Severity: 2) -Single-quote used as quote-like operator delimiter at line 6755, column 24. Using quotes as delimiters for quote-like operators obfuscates code. (Severity: 3) -Expression form of "eval" at line 6846, column 27. See page 161 of PBP. (Severity: 5) -"unless" block used at line 6870, column 25. See page 97 of PBP. (Severity: 2) -Regular expression without "/s" flag at line 6907, column 31. See pages 240,241 of PBP. (Severity: 2) -Regular expression without "/m" flag at line 6907, column 31. See page 237 of PBP. (Severity: 2) -Regular expression without "/s" flag at line 6910, column 49. See pages 240,241 of PBP. (Severity: 2) -Regular expression without "/m" flag at line 6910, column 49. See page 237 of PBP. (Severity: 2) -Regular expression without "/s" flag at line 6940, column 28. See pages 240,241 of PBP. (Severity: 2) -Regular expression without "/m" flag at line 6940, column 28. See page 237 of PBP. (Severity: 2) -Regular expression without "/s" flag at line 6953, column 27. See pages 240,241 of PBP. (Severity: 2) -Regular expression without "/m" flag at line 6953, column 27. See page 237 of PBP. (Severity: 2) -Useless use of $_ at line 6955, column 60. $_ should be omitted when calling "lc". (Severity: 2) -Useless use of $_ at line 6955, column 82. $_ should be omitted when calling "lc". (Severity: 2) -"unless" block used at line 7144, column 17. See page 97 of PBP. (Severity: 2) -"unless" block used at line 7145, column 17. See page 97 of PBP. (Severity: 2) -Postfix control "if" used at line 7233, column 22. See pages 93,94 of PBP. (Severity: 2) -Subroutine "copy_message" with high complexity score (22) at line 7277, column 1. Consider refactoring. (Severity: 3) -Too many arguments at line 7277, column 1. See page 182 of PBP. (Severity: 3) -Postfix control "if" used at line 7295, column 107. See pages 93,94 of PBP. (Severity: 2) -Postfix control "if" used at line 7334, column 26. See pages 93,94 of PBP. (Severity: 2) -Too many arguments at line 7351, column 1. See page 182 of PBP. (Severity: 3) -Subroutine "message_for_host2" with high complexity score (23) at line 7385, column 1. Consider refactoring. (Severity: 3) -Too many arguments at line 7385, column 1. See page 182 of PBP. (Severity: 3) -"unless" block used at line 7424, column 9. See page 97 of PBP. (Severity: 2) -Quotes used with a string containing no non-whitespace characters at line 7512, column 21. See page 53 of PBP. (Severity: 2) -Postfix control "if" used at line 7532, column 75. See pages 93,94 of PBP. (Severity: 2) -Postfix control "if" used at line 7541, column 72. See pages 93,94 of PBP. (Severity: 2) -Reused variable name in lexical scope: $uid1 at line 7615, column 9. Invent unique variable names. (Severity: 3) -Reused variable name in lexical scope: $uid2 at line 7615, column 9. Invent unique variable names. (Severity: 3) -Regular expression without "/s" flag at line 7729, column 22. See pages 240,241 of PBP. (Severity: 2) -Regular expression without "/m" flag at line 7729, column 22. See page 237 of PBP. (Severity: 2) -Postfix control "if" used at line 7734, column 44. See pages 93,94 of PBP. (Severity: 2) -Postfix control "if" used at line 7735, column 64. See pages 93,94 of PBP. (Severity: 2) -Too many arguments at line 7811, column 1. See page 182 of PBP. (Severity: 3) -Regular expression without "/s" flag at line 7833, column 41. See pages 240,241 of PBP. (Severity: 2) -Regular expression without "/m" flag at line 7833, column 41. See page 237 of PBP. (Severity: 2) -Regular expression without "/s" flag at line 7852, column 75. See pages 240,241 of PBP. (Severity: 2) -Regular expression without "/m" flag at line 7852, column 75. See page 237 of PBP. (Severity: 2) -Quotes used with a string containing no non-whitespace characters at line 8027, column 13. See page 53 of PBP. (Severity: 2) +Regular expression without "/s" flag at line 6595, column 21. See pages 240,241 of PBP. (Severity: 2) +Regular expression without "/m" flag at line 6595, column 21. See page 237 of PBP. (Severity: 2) +Regular expression without "/s" flag at line 6596, column 21. See pages 240,241 of PBP. (Severity: 2) +Regular expression without "/m" flag at line 6596, column 21. See page 237 of PBP. (Severity: 2) +Postfix control "if" used at line 6596, column 30. See pages 93,94 of PBP. (Severity: 2) +Quotes used with a noisy string at line 6596, column 49. See page 53 of PBP. (Severity: 2) +Quotes used with a noisy string at line 6596, column 74. See page 53 of PBP. (Severity: 2) +Expression form of "eval" at line 6607, column 27. See page 161 of PBP. (Severity: 5) +Quotes used with a noisy string at line 6623, column 35. See page 53 of PBP. (Severity: 2) +Regular expression without "/s" flag at line 6634, column 49. See pages 240,241 of PBP. (Severity: 2) +Regular expression without "/m" flag at line 6634, column 49. See page 237 of PBP. (Severity: 2) +"unless" block used at line 6668, column 17. See page 97 of PBP. (Severity: 2) +Postfix control "if" used at line 6681, column 53. See pages 93,94 of PBP. (Severity: 2) +Single-quote used as quote-like operator delimiter at line 6757, column 24. Using quotes as delimiters for quote-like operators obfuscates code. (Severity: 3) +Expression form of "eval" at line 6848, column 27. See page 161 of PBP. (Severity: 5) +"unless" block used at line 6872, column 25. See page 97 of PBP. (Severity: 2) +Regular expression without "/s" flag at line 6909, column 31. See pages 240,241 of PBP. (Severity: 2) +Regular expression without "/m" flag at line 6909, column 31. See page 237 of PBP. (Severity: 2) +Regular expression without "/s" flag at line 6912, column 49. See pages 240,241 of PBP. (Severity: 2) +Regular expression without "/m" flag at line 6912, column 49. See page 237 of PBP. (Severity: 2) +Regular expression without "/s" flag at line 6942, column 28. See pages 240,241 of PBP. (Severity: 2) +Regular expression without "/m" flag at line 6942, column 28. See page 237 of PBP. (Severity: 2) +Regular expression without "/s" flag at line 6955, column 27. See pages 240,241 of PBP. (Severity: 2) +Regular expression without "/m" flag at line 6955, column 27. See page 237 of PBP. (Severity: 2) +Useless use of $_ at line 6957, column 60. $_ should be omitted when calling "lc". (Severity: 2) +Useless use of $_ at line 6957, column 82. $_ should be omitted when calling "lc". (Severity: 2) +"unless" block used at line 7146, column 17. See page 97 of PBP. (Severity: 2) +"unless" block used at line 7147, column 17. See page 97 of PBP. (Severity: 2) +Postfix control "if" used at line 7235, column 22. See pages 93,94 of PBP. (Severity: 2) +Subroutine "copy_message" with high complexity score (22) at line 7279, column 1. Consider refactoring. (Severity: 3) +Too many arguments at line 7279, column 1. See page 182 of PBP. (Severity: 3) +Postfix control "if" used at line 7297, column 107. See pages 93,94 of PBP. (Severity: 2) +Postfix control "if" used at line 7336, column 26. See pages 93,94 of PBP. (Severity: 2) +Too many arguments at line 7353, column 1. See page 182 of PBP. (Severity: 3) +Subroutine "message_for_host2" with high complexity score (23) at line 7387, column 1. Consider refactoring. (Severity: 3) +Too many arguments at line 7387, column 1. See page 182 of PBP. (Severity: 3) +"unless" block used at line 7426, column 9. See page 97 of PBP. (Severity: 2) +Quotes used with a string containing no non-whitespace characters at line 7514, column 21. See page 53 of PBP. (Severity: 2) +Postfix control "if" used at line 7534, column 75. See pages 93,94 of PBP. (Severity: 2) +Postfix control "if" used at line 7543, column 72. See pages 93,94 of PBP. (Severity: 2) +Reused variable name in lexical scope: $uid1 at line 7617, column 9. Invent unique variable names. (Severity: 3) +Reused variable name in lexical scope: $uid2 at line 7617, column 9. Invent unique variable names. (Severity: 3) +Regular expression without "/s" flag at line 7731, column 22. See pages 240,241 of PBP. (Severity: 2) +Regular expression without "/m" flag at line 7731, column 22. See page 237 of PBP. (Severity: 2) +Postfix control "if" used at line 7736, column 44. See pages 93,94 of PBP. (Severity: 2) +Postfix control "if" used at line 7737, column 64. See pages 93,94 of PBP. (Severity: 2) +Too many arguments at line 7813, column 1. See page 182 of PBP. (Severity: 3) +Regular expression without "/s" flag at line 7835, column 41. See pages 240,241 of PBP. (Severity: 2) +Regular expression without "/m" flag at line 7835, column 41. See page 237 of PBP. (Severity: 2) +Regular expression without "/s" flag at line 7854, column 75. See pages 240,241 of PBP. (Severity: 2) +Regular expression without "/m" flag at line 7854, column 75. See page 237 of PBP. (Severity: 2) Quotes used with a string containing no non-whitespace characters at line 8029, column 13. See page 53 of PBP. (Severity: 2) -Quotes used with a string containing no non-whitespace characters at line 8041, column 13. See page 53 of PBP. (Severity: 2) -Quotes used with a string containing no non-whitespace characters at line 8042, column 13. See page 53 of PBP. (Severity: 2) -Too many arguments at line 8050, column 1. See page 182 of PBP. (Severity: 3) -Postfix control "if" used at line 8056, column 43. See pages 93,94 of PBP. (Severity: 2) -List of quoted literal words at line 8114, column 21. Use 'qw()' instead. (Severity: 2) -Regular expression without "/s" flag at line 8276, column 23. See pages 240,241 of PBP. (Severity: 2) -Regular expression without "/m" flag at line 8276, column 23. See page 237 of PBP. (Severity: 2) -Regular expression without "/s" flag at line 8302, column 23. See pages 240,241 of PBP. (Severity: 2) -Regular expression without "/m" flag at line 8302, column 23. See page 237 of PBP. (Severity: 2) -Regular expression without "/s" flag at line 8452, column 23. See pages 240,241 of PBP. (Severity: 2) -Regular expression without "/m" flag at line 8452, column 23. See page 237 of PBP. (Severity: 2) -Postfix control "if" used at line 8646, column 53. See pages 93,94 of PBP. (Severity: 2) -Postfix control "if" used at line 8663, column 55. See pages 93,94 of PBP. (Severity: 2) -Quotes used with a noisy string at line 8667, column 61. See page 53 of PBP. (Severity: 2) -Quotes used with a noisy string at line 8668, column 59. See page 53 of PBP. (Severity: 2) -Quotes used with a noisy string at line 8817, column 13. See page 53 of PBP. (Severity: 2) -Quotes used with a noisy string at line 8828, column 32. See page 53 of PBP. (Severity: 2) -Quotes used with a noisy string at line 8829, column 32. See page 53 of PBP. (Severity: 2) -Regular expression without "/s" flag at line 8848, column 28. See pages 240,241 of PBP. (Severity: 2) -Regular expression without "/m" flag at line 8848, column 28. See page 237 of PBP. (Severity: 2) -Regular expression without "/s" flag at line 8850, column 20. See pages 240,241 of PBP. (Severity: 2) -Regular expression without "/m" flag at line 8850, column 20. See page 237 of PBP. (Severity: 2) -Postfix control "if" used at line 8866, column 45. See pages 93,94 of PBP. (Severity: 2) -Postfix control "if" used at line 8871, column 46. See pages 93,94 of PBP. (Severity: 2) -Regular expression without "/s" flag at line 8889, column 20. See pages 240,241 of PBP. (Severity: 2) -Regular expression without "/m" flag at line 8889, column 20. See page 237 of PBP. (Severity: 2) -Quotes used with a noisy string at line 8898, column 45. See page 53 of PBP. (Severity: 2) -Quotes used with a noisy string at line 8899, column 53. See page 53 of PBP. (Severity: 2) -Quotes used with a noisy string at line 8900, column 61. See page 53 of PBP. (Severity: 2) -Quotes used with a noisy string at line 8903, column 61. See page 53 of PBP. (Severity: 2) -Quotes used with a noisy string at line 8904, column 67. See page 53 of PBP. (Severity: 2) -Expression form of "eval" at line 9403, column 27. See page 161 of PBP. (Severity: 5) -Numeric escapes in interpolated string at line 9443, column 28. See pages 54,55 of PBP. (Severity: 2) -Numeric escapes in interpolated string at line 9448, column 28. See pages 54,55 of PBP. (Severity: 2) -Expression form of "eval" at line 9644, column 27. See page 161 of PBP. (Severity: 5) -Postfix control "if" used at line 9796, column 76. See pages 93,94 of PBP. (Severity: 2) -Regular expression without "/s" flag at line 9880, column 21. See pages 240,241 of PBP. (Severity: 2) -Regular expression without "/m" flag at line 9880, column 21. See page 237 of PBP. (Severity: 2) -Too many arguments at line 9955, column 1. See page 182 of PBP. (Severity: 3) -Postfix control "unless" used at line 9993, column 34. See pages 96,97 of PBP. (Severity: 2) -Regular expression without "/s" flag at line 10031, column 51. See pages 240,241 of PBP. (Severity: 2) -Regular expression without "/m" flag at line 10031, column 51. See page 237 of PBP. (Severity: 2) -Regular expression without "/s" flag at line 10047, column 24. See pages 240,241 of PBP. (Severity: 2) -Regular expression without "/m" flag at line 10047, column 24. See page 237 of PBP. (Severity: 2) -Regular expression without "/s" flag at line 10050, column 24. See pages 240,241 of PBP. (Severity: 2) -Regular expression without "/m" flag at line 10050, column 24. See page 237 of PBP. (Severity: 2) -Regular expression without "/s" flag at line 10053, column 24. See pages 240,241 of PBP. (Severity: 2) -Regular expression without "/m" flag at line 10053, column 24. See page 237 of PBP. (Severity: 2) -Regular expression without "/s" flag at line 10056, column 24. See pages 240,241 of PBP. (Severity: 2) -Regular expression without "/m" flag at line 10056, column 24. See page 237 of PBP. (Severity: 2) -Regular expression without "/s" flag at line 10059, column 24. See pages 240,241 of PBP. (Severity: 2) -Regular expression without "/m" flag at line 10059, column 24. See page 237 of PBP. (Severity: 2) -Regular expression without "/s" flag at line 10062, column 97. See pages 240,241 of PBP. (Severity: 2) -Regular expression without "/m" flag at line 10062, column 97. See page 237 of PBP. (Severity: 2) -Numeric escapes in interpolated string at line 10083, column 58. See pages 54,55 of PBP. (Severity: 2) -Return value of "close" ignored at line 10107, column 9. Check the return value of "close" for success. (Severity: 2) -Return value of "close" ignored at line 10142, column 9. Check the return value of "close" for success. (Severity: 2) -Quotes used with a noisy string at line 10153, column 29. See page 53 of PBP. (Severity: 2) -Return value of "close" ignored at line 10178, column 3. Check the return value of "close" for success. (Severity: 2) -Quotes used with a noisy string at line 10193, column 39. See page 53 of PBP. (Severity: 2) -Postfix control "if" used at line 10200, column 78. See pages 93,94 of PBP. (Severity: 2) -Return value of "close" ignored at line 10224, column 9. Check the return value of "close" for success. (Severity: 2) -Backtick operator used at line 10254, column 17. Use IPC::Open3 instead. (Severity: 3) -Postfix control "if" used at line 10296, column 66. See pages 93,94 of PBP. (Severity: 2) -Postfix control "if" used at line 10312, column 63. See pages 93,94 of PBP. (Severity: 2) -Split long regexps into smaller qr// chunks at line 10343, column 32. See page 261 of PBP. (Severity: 3) -Regular expression without "/s" flag at line 10343, column 32. See pages 240,241 of PBP. (Severity: 2) -Split long regexps into smaller qr// chunks at line 10347, column 32. See page 261 of PBP. (Severity: 3) -Regular expression without "/s" flag at line 10347, column 32. See pages 240,241 of PBP. (Severity: 2) -Regular expression without "/s" flag at line 10357, column 33. See pages 240,241 of PBP. (Severity: 2) -Regular expression without "/s" flag at line 10362, column 33. See pages 240,241 of PBP. (Severity: 2) -Split long regexps into smaller qr// chunks at line 10366, column 33. See page 261 of PBP. (Severity: 3) -Regular expression without "/s" flag at line 10366, column 33. See pages 240,241 of PBP. (Severity: 2) -Regular expression without "/s" flag at line 10370, column 33. See pages 240,241 of PBP. (Severity: 2) -Regular expression without "/s" flag at line 10371, column 33. See pages 240,241 of PBP. (Severity: 2) -Split long regexps into smaller qr// chunks at line 10377, column 24. See page 261 of PBP. (Severity: 3) -Regular expression without "/s" flag at line 10377, column 24. See pages 240,241 of PBP. (Severity: 2) -Regular expression without "/s" flag at line 10404, column 28. See pages 240,241 of PBP. (Severity: 2) -Regular expression without "/m" flag at line 10404, column 28. See page 237 of PBP. (Severity: 2) -Return value of "close" ignored at line 10429, column 9. Check the return value of "close" for success. (Severity: 2) -Regular expression without "/s" flag at line 10469, column 36. See pages 240,241 of PBP. (Severity: 2) -Regular expression without "/m" flag at line 10469, column 36. See page 237 of PBP. (Severity: 2) -Regular expression without "/s" flag at line 10588, column 36. See pages 240,241 of PBP. (Severity: 2) -Regular expression without "/m" flag at line 10588, column 36. See page 237 of PBP. (Severity: 2) -Cascading if-elsif chain at line 10641, column 2. See pages 117,118 of PBP. (Severity: 3) -Regular expression without "/s" flag at line 10711, column 28. See pages 240,241 of PBP. (Severity: 2) -Regular expression without "/m" flag at line 10711, column 28. See page 237 of PBP. (Severity: 2) -Postfix control "if" used at line 10723, column 33. See pages 93,94 of PBP. (Severity: 2) -Postfix control "if" used at line 10731, column 32. See pages 93,94 of PBP. (Severity: 2) -Postfix control "if" used at line 10741, column 34. See pages 93,94 of PBP. (Severity: 2) -Return value of eval not tested at line 10795, column 3. You can't depend upon the value of $@/$EVAL_ERROR to tell whether an eval failed. (Severity: 3) -Backtick operator used at line 10796, column 15. Use IPC::Open3 instead. (Severity: 3) -Split long regexps into smaller qr// chunks at line 10805, column 16. See page 261 of PBP. (Severity: 3) -Return value of eval not tested at line 10818, column 3. You can't depend upon the value of $@/$EVAL_ERROR to tell whether an eval failed. (Severity: 3) -Backtick operator used at line 10819, column 15. Use IPC::Open3 instead. (Severity: 3) -Split long regexps into smaller qr// chunks at line 10828, column 16. See page 261 of PBP. (Severity: 3) -Return value of eval not tested at line 10842, column 3. You can't depend upon the value of $@/$EVAL_ERROR to tell whether an eval failed. (Severity: 3) -Capture variable used outside conditional at line 10853, column 12. See page 253 of PBP. (Severity: 3) -Long number not separated with underscores at line 10947, column 61. See page 59 of PBP. (Severity: 2) -Backtick operator used at line 10998, column 26. Use IPC::Open3 instead. (Severity: 3) -Backtick operator used at line 11027, column 18. Use IPC::Open3 instead. (Severity: 3) -String delimiter used with "split" at line 11032, column 42. Express it as a regex instead. (Severity: 2) -Quotes used with a noisy string at line 11032, column 48. See page 53 of PBP. (Severity: 2) -Postfix control "if" used at line 11057, column 47. See pages 93,94 of PBP. (Severity: 2) -Postfix control "if" used at line 11074, column 44. See pages 93,94 of PBP. (Severity: 2) -Regular expression without "/s" flag at line 11161, column 24. See pages 240,241 of PBP. (Severity: 2) -Regular expression without "/m" flag at line 11161, column 24. See page 237 of PBP. (Severity: 2) -Regular expression without "/s" flag at line 11171, column 24. See pages 240,241 of PBP. (Severity: 2) -Regular expression without "/m" flag at line 11171, column 24. See page 237 of PBP. (Severity: 2) -Regular expression without "/s" flag at line 11193, column 19. See pages 240,241 of PBP. (Severity: 2) -Regular expression without "/m" flag at line 11193, column 19. See page 237 of PBP. (Severity: 2) -Regular expression without "/s" flag at line 11230, column 20. See pages 240,241 of PBP. (Severity: 2) -Regular expression without "/m" flag at line 11230, column 20. See page 237 of PBP. (Severity: 2) -Postfix control "if" used at line 11233, column 30. See pages 93,94 of PBP. (Severity: 2) -Postfix control "if" used at line 11234, column 36. See pages 93,94 of PBP. (Severity: 2) -Split long regexps into smaller qr// chunks at line 11239, column 19. See page 261 of PBP. (Severity: 3) -Regular expression without "/s" flag at line 11239, column 19. See pages 240,241 of PBP. (Severity: 2) -Regular expression without "/m" flag at line 11239, column 19. See page 237 of PBP. (Severity: 2) -Postfix control "if" used at line 11251, column 38. See pages 93,94 of PBP. (Severity: 2) -Regular expression without "/s" flag at line 11251, column 72. See pages 240,241 of PBP. (Severity: 2) -Regular expression without "/m" flag at line 11251, column 72. See page 237 of PBP. (Severity: 2) -Postfix control "if" used at line 11252, column 38. See pages 93,94 of PBP. (Severity: 2) -Postfix control "if" used at line 11254, column 46. See pages 93,94 of PBP. (Severity: 2) -Postfix control "if" used at line 11258, column 30. See pages 93,94 of PBP. (Severity: 2) -Postfix control "if" used at line 11260, column 33. See pages 93,94 of PBP. (Severity: 2) -Split long regexps into smaller qr// chunks at line 11265, column 19. See page 261 of PBP. (Severity: 3) -Regular expression without "/s" flag at line 11265, column 19. See pages 240,241 of PBP. (Severity: 2) -Regular expression without "/m" flag at line 11265, column 19. See page 237 of PBP. (Severity: 2) -Regular expression without "/s" flag at line 11282, column 19. See pages 240,241 of PBP. (Severity: 2) -Regular expression without "/m" flag at line 11282, column 19. See page 237 of PBP. (Severity: 2) -Regular expression without "/s" flag at line 11294, column 19. See pages 240,241 of PBP. (Severity: 2) -Regular expression without "/m" flag at line 11294, column 19. See page 237 of PBP. (Severity: 2) -Split long regexps into smaller qr// chunks at line 11306, column 19. See page 261 of PBP. (Severity: 3) -Regular expression without "/s" flag at line 11306, column 19. See pages 240,241 of PBP. (Severity: 2) -Regular expression without "/m" flag at line 11306, column 19. See page 237 of PBP. (Severity: 2) -Postfix control "if" used at line 11312, column 29. See pages 93,94 of PBP. (Severity: 2) -Split long regexps into smaller qr// chunks at line 11318, column 19. See page 261 of PBP. (Severity: 3) -Regular expression without "/s" flag at line 11318, column 19. See pages 240,241 of PBP. (Severity: 2) -Regular expression without "/m" flag at line 11318, column 19. See page 237 of PBP. (Severity: 2) -Regular expression without "/s" flag at line 11329, column 19. See pages 240,241 of PBP. (Severity: 2) -Regular expression without "/m" flag at line 11329, column 19. See page 237 of PBP. (Severity: 2) -Quotes used with a noisy string at line 11574, column 26. See page 53 of PBP. (Severity: 2) -Quotes used with a noisy string at line 11575, column 26. See page 53 of PBP. (Severity: 2) -Quotes used with a noisy string at line 11581, column 26. See page 53 of PBP. (Severity: 2) -Quotes used with a noisy string at line 11637, column 29. See page 53 of PBP. (Severity: 2) -Quotes used with a noisy string at line 11638, column 29. See page 53 of PBP. (Severity: 2) -Quotes used with a noisy string at line 11643, column 29. See page 53 of PBP. (Severity: 2) -Expression form of "eval" at line 11675, column 56. See page 161 of PBP. (Severity: 5) -Expression form of "eval" at line 11679, column 58. See page 161 of PBP. (Severity: 5) -Postfix control "if" used at line 11684, column 56. See pages 93,94 of PBP. (Severity: 2) -Postfix control "if" used at line 11685, column 58. See pages 93,94 of PBP. (Severity: 2) -Regular expression without "/s" flag at line 11931, column 33. See pages 240,241 of PBP. (Severity: 2) -Regular expression without "/m" flag at line 11931, column 33. See page 237 of PBP. (Severity: 2) -Regular expression without "/s" flag at line 11972, column 26. See pages 240,241 of PBP. (Severity: 2) -Regular expression without "/m" flag at line 11972, column 26. See page 237 of PBP. (Severity: 2) -Use 'eq' or hash instead of fixed-pattern regexps at line 11976, column 36. See pages 271,272 of PBP. (Severity: 2) -Regular expression without "/s" flag at line 11976, column 36. See pages 240,241 of PBP. (Severity: 2) -Regular expression without "/m" flag at line 11976, column 36. See page 237 of PBP. (Severity: 2) -Regular expression without "/s" flag at line 11978, column 31. See pages 240,241 of PBP. (Severity: 2) -Regular expression without "/m" flag at line 11978, column 31. See page 237 of PBP. (Severity: 2) -Regular expression without "/s" flag at line 11984, column 34. See pages 240,241 of PBP. (Severity: 2) -Regular expression without "/m" flag at line 11984, column 34. See page 237 of PBP. (Severity: 2) -Postfix control "if" used at line 11987, column 68. See pages 93,94 of PBP. (Severity: 2) -Split long regexps into smaller qr// chunks at line 12145, column 20. See page 261 of PBP. (Severity: 3) -Regular expression without "/s" flag at line 12145, column 20. See pages 240,241 of PBP. (Severity: 2) -Regular expression without "/m" flag at line 12145, column 20. See page 237 of PBP. (Severity: 2) -Postfix control "if" used at line 12151, column 28. See pages 93,94 of PBP. (Severity: 2) -Quotes used with a noisy string at line 12151, column 33. See page 53 of PBP. (Severity: 2) -Postfix control "if" used at line 12152, column 36. See pages 93,94 of PBP. (Severity: 2) -Quotes used with a noisy string at line 12152, column 41. See page 53 of PBP. (Severity: 2) -Postfix control "if" used at line 12233, column 65. See pages 93,94 of PBP. (Severity: 2) -Postfix control "if" used at line 12346, column 81. See pages 93,94 of PBP. (Severity: 2) -Postfix control "unless" used at line 12349, column 32. See pages 96,97 of PBP. (Severity: 2) -Long number not separated with underscores at line 12359, column 74. See page 59 of PBP. (Severity: 2) -Long number not separated with underscores at line 12362, column 81. See page 59 of PBP. (Severity: 2) -Postfix control "unless" used at line 12368, column 30. See pages 96,97 of PBP. (Severity: 2) -Quotes used with a noisy string at line 12385, column 34. See page 53 of PBP. (Severity: 2) -Quotes used with a noisy string at line 12402, column 23. See page 53 of PBP. (Severity: 2) -Quotes used with a string containing no non-whitespace characters at line 12492, column 30. See page 53 of PBP. (Severity: 2) -Ambiguously named variable "last" at line 12548, column 2. See page 48 of PBP. (Severity: 3) -Subroutine "cleanup_mess_from_tests" does not end with "return" at line 12602, column 1. See page 197 of PBP. (Severity: 4) -Quotes used with a string containing no non-whitespace characters at line 12844, column 21. See page 53 of PBP. (Severity: 2) -Quotes used with a string containing no non-whitespace characters at line 12893, column 50. See page 53 of PBP. (Severity: 2) -Reused variable name in lexical scope: $err at line 12901, column 3. Invent unique variable names. (Severity: 3) -Quotes used with a string containing no non-whitespace characters at line 12922, column 24. See page 53 of PBP. (Severity: 2) -Quotes used with a string containing no non-whitespace characters at line 12963, column 50. See page 53 of PBP. (Severity: 2) -Reused variable name in lexical scope: $err at line 12971, column 3. Invent unique variable names. (Severity: 3) -Quotes used with a noisy string at line 13192, column 13. See page 53 of PBP. (Severity: 2) -Quotes used with a noisy string at line 13192, column 35. See page 53 of PBP. (Severity: 2) -Useless use of $_ at line 13230, column 22. $_ should be omitted when calling "split" with two arguments. (Severity: 2) -Double-sigil dereference at line 13304, column 17. See page 228 of PBP. (Severity: 2) -"warn" used instead of "carp" at line 13429, column 25. See page 283 of PBP. (Severity: 3) -Return value of "close" ignored at line 13431, column 9. Check the return value of "close" for success. (Severity: 2) -Regular expression without "/s" flag at line 13446, column 40. See pages 240,241 of PBP. (Severity: 2) -Regular expression without "/x" flag at line 13446, column 40. See page 236 of PBP. (Severity: 3) -Regular expression without "/m" flag at line 13446, column 40. See page 237 of PBP. (Severity: 2) -Regular expression without "/s" flag at line 13448, column 23. See pages 240,241 of PBP. (Severity: 2) -Regular expression without "/x" flag at line 13448, column 23. See page 236 of PBP. (Severity: 3) -Regular expression without "/m" flag at line 13448, column 23. See page 237 of PBP. (Severity: 2) -Regular expression without "/s" flag at line 13449, column 23. See pages 240,241 of PBP. (Severity: 2) -Regular expression without "/x" flag at line 13449, column 23. See page 236 of PBP. (Severity: 3) -Regular expression without "/m" flag at line 13449, column 23. See page 237 of PBP. (Severity: 2) +Quotes used with a string containing no non-whitespace characters at line 8031, column 13. See page 53 of PBP. (Severity: 2) +Quotes used with a string containing no non-whitespace characters at line 8043, column 13. See page 53 of PBP. (Severity: 2) +Quotes used with a string containing no non-whitespace characters at line 8044, column 13. See page 53 of PBP. (Severity: 2) +Too many arguments at line 8052, column 1. See page 182 of PBP. (Severity: 3) +Postfix control "if" used at line 8058, column 43. See pages 93,94 of PBP. (Severity: 2) +List of quoted literal words at line 8116, column 21. Use 'qw()' instead. (Severity: 2) +Regular expression without "/s" flag at line 8278, column 23. See pages 240,241 of PBP. (Severity: 2) +Regular expression without "/m" flag at line 8278, column 23. See page 237 of PBP. (Severity: 2) +Regular expression without "/s" flag at line 8304, column 23. See pages 240,241 of PBP. (Severity: 2) +Regular expression without "/m" flag at line 8304, column 23. See page 237 of PBP. (Severity: 2) +Regular expression without "/s" flag at line 8454, column 23. See pages 240,241 of PBP. (Severity: 2) +Regular expression without "/m" flag at line 8454, column 23. See page 237 of PBP. (Severity: 2) +Postfix control "if" used at line 8648, column 53. See pages 93,94 of PBP. (Severity: 2) +Postfix control "if" used at line 8665, column 55. See pages 93,94 of PBP. (Severity: 2) +Quotes used with a noisy string at line 8669, column 61. See page 53 of PBP. (Severity: 2) +Quotes used with a noisy string at line 8670, column 59. See page 53 of PBP. (Severity: 2) +Quotes used with a noisy string at line 8819, column 13. See page 53 of PBP. (Severity: 2) +Quotes used with a noisy string at line 8830, column 32. See page 53 of PBP. (Severity: 2) +Quotes used with a noisy string at line 8831, column 32. See page 53 of PBP. (Severity: 2) +Regular expression without "/s" flag at line 8850, column 28. See pages 240,241 of PBP. (Severity: 2) +Regular expression without "/m" flag at line 8850, column 28. See page 237 of PBP. (Severity: 2) +Regular expression without "/s" flag at line 8852, column 20. See pages 240,241 of PBP. (Severity: 2) +Regular expression without "/m" flag at line 8852, column 20. See page 237 of PBP. (Severity: 2) +Postfix control "if" used at line 8868, column 45. See pages 93,94 of PBP. (Severity: 2) +Postfix control "if" used at line 8873, column 46. See pages 93,94 of PBP. (Severity: 2) +Regular expression without "/s" flag at line 8891, column 20. See pages 240,241 of PBP. (Severity: 2) +Regular expression without "/m" flag at line 8891, column 20. See page 237 of PBP. (Severity: 2) +Quotes used with a noisy string at line 8900, column 45. See page 53 of PBP. (Severity: 2) +Quotes used with a noisy string at line 8901, column 53. See page 53 of PBP. (Severity: 2) +Quotes used with a noisy string at line 8902, column 61. See page 53 of PBP. (Severity: 2) +Quotes used with a noisy string at line 8905, column 61. See page 53 of PBP. (Severity: 2) +Quotes used with a noisy string at line 8906, column 67. See page 53 of PBP. (Severity: 2) +Expression form of "eval" at line 9405, column 27. See page 161 of PBP. (Severity: 5) +Numeric escapes in interpolated string at line 9445, column 28. See pages 54,55 of PBP. (Severity: 2) +Numeric escapes in interpolated string at line 9450, column 28. See pages 54,55 of PBP. (Severity: 2) +Expression form of "eval" at line 9646, column 27. See page 161 of PBP. (Severity: 5) +Postfix control "if" used at line 9798, column 76. See pages 93,94 of PBP. (Severity: 2) +Regular expression without "/s" flag at line 9882, column 21. See pages 240,241 of PBP. (Severity: 2) +Regular expression without "/m" flag at line 9882, column 21. See page 237 of PBP. (Severity: 2) +Too many arguments at line 9957, column 1. See page 182 of PBP. (Severity: 3) +Postfix control "unless" used at line 9995, column 34. See pages 96,97 of PBP. (Severity: 2) +Regular expression without "/s" flag at line 10033, column 51. See pages 240,241 of PBP. (Severity: 2) +Regular expression without "/m" flag at line 10033, column 51. See page 237 of PBP. (Severity: 2) +Regular expression without "/s" flag at line 10049, column 24. See pages 240,241 of PBP. (Severity: 2) +Regular expression without "/m" flag at line 10049, column 24. See page 237 of PBP. (Severity: 2) +Regular expression without "/s" flag at line 10052, column 24. See pages 240,241 of PBP. (Severity: 2) +Regular expression without "/m" flag at line 10052, column 24. See page 237 of PBP. (Severity: 2) +Regular expression without "/s" flag at line 10055, column 24. See pages 240,241 of PBP. (Severity: 2) +Regular expression without "/m" flag at line 10055, column 24. See page 237 of PBP. (Severity: 2) +Regular expression without "/s" flag at line 10058, column 24. See pages 240,241 of PBP. (Severity: 2) +Regular expression without "/m" flag at line 10058, column 24. See page 237 of PBP. (Severity: 2) +Regular expression without "/s" flag at line 10061, column 24. See pages 240,241 of PBP. (Severity: 2) +Regular expression without "/m" flag at line 10061, column 24. See page 237 of PBP. (Severity: 2) +Regular expression without "/s" flag at line 10064, column 97. See pages 240,241 of PBP. (Severity: 2) +Regular expression without "/m" flag at line 10064, column 97. See page 237 of PBP. (Severity: 2) +Numeric escapes in interpolated string at line 10085, column 58. See pages 54,55 of PBP. (Severity: 2) +Return value of "close" ignored at line 10109, column 9. Check the return value of "close" for success. (Severity: 2) +Return value of "close" ignored at line 10144, column 9. Check the return value of "close" for success. (Severity: 2) +Quotes used with a noisy string at line 10155, column 29. See page 53 of PBP. (Severity: 2) +Return value of "close" ignored at line 10180, column 3. Check the return value of "close" for success. (Severity: 2) +Quotes used with a noisy string at line 10195, column 39. See page 53 of PBP. (Severity: 2) +Postfix control "if" used at line 10202, column 78. See pages 93,94 of PBP. (Severity: 2) +Return value of "close" ignored at line 10226, column 9. Check the return value of "close" for success. (Severity: 2) +Backtick operator used at line 10256, column 17. Use IPC::Open3 instead. (Severity: 3) +Postfix control "if" used at line 10298, column 66. See pages 93,94 of PBP. (Severity: 2) +Postfix control "if" used at line 10314, column 63. See pages 93,94 of PBP. (Severity: 2) +Split long regexps into smaller qr// chunks at line 10345, column 32. See page 261 of PBP. (Severity: 3) +Regular expression without "/s" flag at line 10345, column 32. See pages 240,241 of PBP. (Severity: 2) +Split long regexps into smaller qr// chunks at line 10349, column 32. See page 261 of PBP. (Severity: 3) +Regular expression without "/s" flag at line 10349, column 32. See pages 240,241 of PBP. (Severity: 2) +Regular expression without "/s" flag at line 10359, column 33. See pages 240,241 of PBP. (Severity: 2) +Regular expression without "/s" flag at line 10364, column 33. See pages 240,241 of PBP. (Severity: 2) +Split long regexps into smaller qr// chunks at line 10368, column 33. See page 261 of PBP. (Severity: 3) +Regular expression without "/s" flag at line 10368, column 33. See pages 240,241 of PBP. (Severity: 2) +Regular expression without "/s" flag at line 10372, column 33. See pages 240,241 of PBP. (Severity: 2) +Regular expression without "/s" flag at line 10373, column 33. See pages 240,241 of PBP. (Severity: 2) +Split long regexps into smaller qr// chunks at line 10379, column 24. See page 261 of PBP. (Severity: 3) +Regular expression without "/s" flag at line 10379, column 24. See pages 240,241 of PBP. (Severity: 2) +Regular expression without "/s" flag at line 10406, column 28. See pages 240,241 of PBP. (Severity: 2) +Regular expression without "/m" flag at line 10406, column 28. See page 237 of PBP. (Severity: 2) +Return value of "close" ignored at line 10431, column 9. Check the return value of "close" for success. (Severity: 2) +Regular expression without "/s" flag at line 10471, column 36. See pages 240,241 of PBP. (Severity: 2) +Regular expression without "/m" flag at line 10471, column 36. See page 237 of PBP. (Severity: 2) +Regular expression without "/s" flag at line 10590, column 36. See pages 240,241 of PBP. (Severity: 2) +Regular expression without "/m" flag at line 10590, column 36. See page 237 of PBP. (Severity: 2) +Cascading if-elsif chain at line 10643, column 2. See pages 117,118 of PBP. (Severity: 3) +Regular expression without "/s" flag at line 10713, column 28. See pages 240,241 of PBP. (Severity: 2) +Regular expression without "/m" flag at line 10713, column 28. See page 237 of PBP. (Severity: 2) +Postfix control "if" used at line 10725, column 33. See pages 93,94 of PBP. (Severity: 2) +Postfix control "if" used at line 10733, column 32. See pages 93,94 of PBP. (Severity: 2) +Postfix control "if" used at line 10743, column 34. See pages 93,94 of PBP. (Severity: 2) +Return value of eval not tested at line 10797, column 3. You can't depend upon the value of $@/$EVAL_ERROR to tell whether an eval failed. (Severity: 3) +Backtick operator used at line 10798, column 15. Use IPC::Open3 instead. (Severity: 3) +Split long regexps into smaller qr// chunks at line 10807, column 16. See page 261 of PBP. (Severity: 3) +Return value of eval not tested at line 10820, column 3. You can't depend upon the value of $@/$EVAL_ERROR to tell whether an eval failed. (Severity: 3) +Backtick operator used at line 10821, column 15. Use IPC::Open3 instead. (Severity: 3) +Split long regexps into smaller qr// chunks at line 10830, column 16. See page 261 of PBP. (Severity: 3) +Return value of eval not tested at line 10844, column 3. You can't depend upon the value of $@/$EVAL_ERROR to tell whether an eval failed. (Severity: 3) +Capture variable used outside conditional at line 10855, column 12. See page 253 of PBP. (Severity: 3) +Long number not separated with underscores at line 10949, column 61. See page 59 of PBP. (Severity: 2) +Backtick operator used at line 11000, column 26. Use IPC::Open3 instead. (Severity: 3) +Backtick operator used at line 11029, column 18. Use IPC::Open3 instead. (Severity: 3) +String delimiter used with "split" at line 11034, column 42. Express it as a regex instead. (Severity: 2) +Quotes used with a noisy string at line 11034, column 48. See page 53 of PBP. (Severity: 2) +Postfix control "if" used at line 11059, column 47. See pages 93,94 of PBP. (Severity: 2) +Postfix control "if" used at line 11076, column 44. See pages 93,94 of PBP. (Severity: 2) +Regular expression without "/s" flag at line 11163, column 24. See pages 240,241 of PBP. (Severity: 2) +Regular expression without "/m" flag at line 11163, column 24. See page 237 of PBP. (Severity: 2) +Regular expression without "/s" flag at line 11173, column 24. See pages 240,241 of PBP. (Severity: 2) +Regular expression without "/m" flag at line 11173, column 24. See page 237 of PBP. (Severity: 2) +Regular expression without "/s" flag at line 11195, column 19. See pages 240,241 of PBP. (Severity: 2) +Regular expression without "/m" flag at line 11195, column 19. See page 237 of PBP. (Severity: 2) +Regular expression without "/s" flag at line 11232, column 20. See pages 240,241 of PBP. (Severity: 2) +Regular expression without "/m" flag at line 11232, column 20. See page 237 of PBP. (Severity: 2) +Postfix control "if" used at line 11235, column 30. See pages 93,94 of PBP. (Severity: 2) +Postfix control "if" used at line 11236, column 36. See pages 93,94 of PBP. (Severity: 2) +Split long regexps into smaller qr// chunks at line 11241, column 19. See page 261 of PBP. (Severity: 3) +Regular expression without "/s" flag at line 11241, column 19. See pages 240,241 of PBP. (Severity: 2) +Regular expression without "/m" flag at line 11241, column 19. See page 237 of PBP. (Severity: 2) +Postfix control "if" used at line 11253, column 38. See pages 93,94 of PBP. (Severity: 2) +Regular expression without "/s" flag at line 11253, column 72. See pages 240,241 of PBP. (Severity: 2) +Regular expression without "/m" flag at line 11253, column 72. See page 237 of PBP. (Severity: 2) +Postfix control "if" used at line 11254, column 38. See pages 93,94 of PBP. (Severity: 2) +Postfix control "if" used at line 11256, column 46. See pages 93,94 of PBP. (Severity: 2) +Postfix control "if" used at line 11260, column 30. See pages 93,94 of PBP. (Severity: 2) +Postfix control "if" used at line 11262, column 33. See pages 93,94 of PBP. (Severity: 2) +Split long regexps into smaller qr// chunks at line 11267, column 19. See page 261 of PBP. (Severity: 3) +Regular expression without "/s" flag at line 11267, column 19. See pages 240,241 of PBP. (Severity: 2) +Regular expression without "/m" flag at line 11267, column 19. See page 237 of PBP. (Severity: 2) +Regular expression without "/s" flag at line 11284, column 19. See pages 240,241 of PBP. (Severity: 2) +Regular expression without "/m" flag at line 11284, column 19. See page 237 of PBP. (Severity: 2) +Regular expression without "/s" flag at line 11296, column 19. See pages 240,241 of PBP. (Severity: 2) +Regular expression without "/m" flag at line 11296, column 19. See page 237 of PBP. (Severity: 2) +Split long regexps into smaller qr// chunks at line 11308, column 19. See page 261 of PBP. (Severity: 3) +Regular expression without "/s" flag at line 11308, column 19. See pages 240,241 of PBP. (Severity: 2) +Regular expression without "/m" flag at line 11308, column 19. See page 237 of PBP. (Severity: 2) +Postfix control "if" used at line 11314, column 29. See pages 93,94 of PBP. (Severity: 2) +Split long regexps into smaller qr// chunks at line 11320, column 19. See page 261 of PBP. (Severity: 3) +Regular expression without "/s" flag at line 11320, column 19. See pages 240,241 of PBP. (Severity: 2) +Regular expression without "/m" flag at line 11320, column 19. See page 237 of PBP. (Severity: 2) +Regular expression without "/s" flag at line 11331, column 19. See pages 240,241 of PBP. (Severity: 2) +Regular expression without "/m" flag at line 11331, column 19. See page 237 of PBP. (Severity: 2) +Quotes used with a noisy string at line 11576, column 26. See page 53 of PBP. (Severity: 2) +Quotes used with a noisy string at line 11577, column 26. See page 53 of PBP. (Severity: 2) +Quotes used with a noisy string at line 11583, column 26. See page 53 of PBP. (Severity: 2) +Quotes used with a noisy string at line 11639, column 29. See page 53 of PBP. (Severity: 2) +Quotes used with a noisy string at line 11640, column 29. See page 53 of PBP. (Severity: 2) +Quotes used with a noisy string at line 11645, column 29. See page 53 of PBP. (Severity: 2) +Expression form of "eval" at line 11677, column 56. See page 161 of PBP. (Severity: 5) +Expression form of "eval" at line 11681, column 58. See page 161 of PBP. (Severity: 5) +Postfix control "if" used at line 11686, column 56. See pages 93,94 of PBP. (Severity: 2) +Postfix control "if" used at line 11687, column 58. See pages 93,94 of PBP. (Severity: 2) +Regular expression without "/s" flag at line 11933, column 33. See pages 240,241 of PBP. (Severity: 2) +Regular expression without "/m" flag at line 11933, column 33. See page 237 of PBP. (Severity: 2) +Regular expression without "/s" flag at line 11974, column 26. See pages 240,241 of PBP. (Severity: 2) +Regular expression without "/m" flag at line 11974, column 26. See page 237 of PBP. (Severity: 2) +Use 'eq' or hash instead of fixed-pattern regexps at line 11978, column 36. See pages 271,272 of PBP. (Severity: 2) +Regular expression without "/s" flag at line 11978, column 36. See pages 240,241 of PBP. (Severity: 2) +Regular expression without "/m" flag at line 11978, column 36. See page 237 of PBP. (Severity: 2) +Regular expression without "/s" flag at line 11980, column 31. See pages 240,241 of PBP. (Severity: 2) +Regular expression without "/m" flag at line 11980, column 31. See page 237 of PBP. (Severity: 2) +Regular expression without "/s" flag at line 11986, column 34. See pages 240,241 of PBP. (Severity: 2) +Regular expression without "/m" flag at line 11986, column 34. See page 237 of PBP. (Severity: 2) +Postfix control "if" used at line 11989, column 68. See pages 93,94 of PBP. (Severity: 2) +Split long regexps into smaller qr// chunks at line 12147, column 20. See page 261 of PBP. (Severity: 3) +Regular expression without "/s" flag at line 12147, column 20. See pages 240,241 of PBP. (Severity: 2) +Regular expression without "/m" flag at line 12147, column 20. See page 237 of PBP. (Severity: 2) +Postfix control "if" used at line 12153, column 28. See pages 93,94 of PBP. (Severity: 2) +Quotes used with a noisy string at line 12153, column 33. See page 53 of PBP. (Severity: 2) +Postfix control "if" used at line 12154, column 36. See pages 93,94 of PBP. (Severity: 2) +Quotes used with a noisy string at line 12154, column 41. See page 53 of PBP. (Severity: 2) +Postfix control "if" used at line 12235, column 65. See pages 93,94 of PBP. (Severity: 2) +Postfix control "if" used at line 12348, column 81. See pages 93,94 of PBP. (Severity: 2) +Postfix control "unless" used at line 12351, column 32. See pages 96,97 of PBP. (Severity: 2) +Long number not separated with underscores at line 12361, column 74. See page 59 of PBP. (Severity: 2) +Long number not separated with underscores at line 12364, column 81. See page 59 of PBP. (Severity: 2) +Postfix control "unless" used at line 12370, column 30. See pages 96,97 of PBP. (Severity: 2) +Quotes used with a noisy string at line 12387, column 34. See page 53 of PBP. (Severity: 2) +Quotes used with a noisy string at line 12404, column 23. See page 53 of PBP. (Severity: 2) +Quotes used with a string containing no non-whitespace characters at line 12494, column 30. See page 53 of PBP. (Severity: 2) +Ambiguously named variable "last" at line 12550, column 2. See page 48 of PBP. (Severity: 3) +Subroutine "cleanup_mess_from_tests" does not end with "return" at line 12604, column 1. See page 197 of PBP. (Severity: 4) +Quotes used with a string containing no non-whitespace characters at line 12846, column 21. See page 53 of PBP. (Severity: 2) +Quotes used with a string containing no non-whitespace characters at line 12895, column 50. See page 53 of PBP. (Severity: 2) +Reused variable name in lexical scope: $err at line 12903, column 3. Invent unique variable names. (Severity: 3) +Quotes used with a string containing no non-whitespace characters at line 12924, column 24. See page 53 of PBP. (Severity: 2) +Quotes used with a string containing no non-whitespace characters at line 12965, column 50. See page 53 of PBP. (Severity: 2) +Reused variable name in lexical scope: $err at line 12973, column 3. Invent unique variable names. (Severity: 3) +Quotes used with a noisy string at line 13194, column 13. See page 53 of PBP. (Severity: 2) +Quotes used with a noisy string at line 13194, column 35. See page 53 of PBP. (Severity: 2) +Useless use of $_ at line 13232, column 22. $_ should be omitted when calling "split" with two arguments. (Severity: 2) +Double-sigil dereference at line 13306, column 17. See page 228 of PBP. (Severity: 2) +"warn" used instead of "carp" at line 13431, column 25. See page 283 of PBP. (Severity: 3) +Return value of "close" ignored at line 13433, column 9. Check the return value of "close" for success. (Severity: 2) +Regular expression without "/s" flag at line 13448, column 40. See pages 240,241 of PBP. (Severity: 2) +Regular expression without "/x" flag at line 13448, column 40. See page 236 of PBP. (Severity: 3) +Regular expression without "/m" flag at line 13448, column 40. See page 237 of PBP. (Severity: 2) Regular expression without "/s" flag at line 13450, column 23. See pages 240,241 of PBP. (Severity: 2) +Regular expression without "/x" flag at line 13450, column 23. See page 236 of PBP. (Severity: 3) Regular expression without "/m" flag at line 13450, column 23. See page 237 of PBP. (Severity: 2) -Literal line breaks in a string at line 13475, column 19. See pages 60,61 of PBP. (Severity: 3) -Subroutine "myGetOptions" with high complexity score (29) at line 13511, column 1. Consider refactoring. (Severity: 3) -String delimiter used with "split" at line 13543, column 30. Express it as a regex instead. (Severity: 2) -Quotes used with a noisy string at line 13543, column 36. See page 53 of PBP. (Severity: 2) -Capture variable used outside conditional at line 13543, column 41. See page 253 of PBP. (Severity: 3) -Quotes used with a noisy string at line 13545, column 39. See page 53 of PBP. (Severity: 2) -Quotes used with a noisy string at line 13553, column 47. See page 53 of PBP. (Severity: 2) -Useless use of $_ at line 13554, column 52. $_ should be omitted when calling "split" with two arguments. (Severity: 2) -Quotes used with a noisy string at line 13580, column 55. See page 53 of PBP. (Severity: 2) -Numeric escapes in interpolated string at line 13770, column 27. See pages 54,55 of PBP. (Severity: 2) -Regular expression without "/s" flag at line 13772, column 23. See pages 240,241 of PBP. (Severity: 2) -Regular expression without "/m" flag at line 13772, column 23. See page 237 of PBP. (Severity: 2) -Double-sigil dereference at line 14177, column 17. See page 228 of PBP. (Severity: 2) -Double-sigil dereference at line 14181, column 18. See page 228 of PBP. (Severity: 2) -Double-sigil dereference at line 14186, column 3. See page 228 of PBP. (Severity: 2) -Postfix control "if" used at line 14234, column 46. See pages 93,94 of PBP. (Severity: 2) +Regular expression without "/s" flag at line 13451, column 23. See pages 240,241 of PBP. (Severity: 2) +Regular expression without "/x" flag at line 13451, column 23. See page 236 of PBP. (Severity: 3) +Regular expression without "/m" flag at line 13451, column 23. See page 237 of PBP. (Severity: 2) +Regular expression without "/s" flag at line 13452, column 23. See pages 240,241 of PBP. (Severity: 2) +Regular expression without "/m" flag at line 13452, column 23. See page 237 of PBP. (Severity: 2) +Literal line breaks in a string at line 13477, column 19. See pages 60,61 of PBP. (Severity: 3) +Subroutine "myGetOptions" with high complexity score (29) at line 13513, column 1. Consider refactoring. (Severity: 3) +String delimiter used with "split" at line 13545, column 30. Express it as a regex instead. (Severity: 2) +Quotes used with a noisy string at line 13545, column 36. See page 53 of PBP. (Severity: 2) +Capture variable used outside conditional at line 13545, column 41. See page 253 of PBP. (Severity: 3) +Quotes used with a noisy string at line 13547, column 39. See page 53 of PBP. (Severity: 2) +Quotes used with a noisy string at line 13555, column 47. See page 53 of PBP. (Severity: 2) +Useless use of $_ at line 13556, column 52. $_ should be omitted when calling "split" with two arguments. (Severity: 2) +Quotes used with a noisy string at line 13582, column 55. See page 53 of PBP. (Severity: 2) +Numeric escapes in interpolated string at line 13772, column 27. See pages 54,55 of PBP. (Severity: 2) +Regular expression without "/s" flag at line 13774, column 23. See pages 240,241 of PBP. (Severity: 2) +Regular expression without "/m" flag at line 13774, column 23. See page 237 of PBP. (Severity: 2) +Double-sigil dereference at line 14179, column 17. See page 228 of PBP. (Severity: 2) +Double-sigil dereference at line 14183, column 18. See page 228 of PBP. (Severity: 2) +Double-sigil dereference at line 14188, column 3. See page 228 of PBP. (Severity: 2) +Postfix control "if" used at line 14236, column 46. See pages 93,94 of PBP. (Severity: 2) 1 files. 437 subroutines/methods. 14,225 statements. -14,377 lines, consisting of: +14,379 lines, consisting of: 2,697 blank lines. - 842 comment lines. + 844 comment lines. 0 data lines. 10,160 lines of Perl code. 678 lines of POD. diff --git a/W/perlcritic_3.txt b/W/perlcritic_3.txt index c1a751a..d1815f5 100644 --- a/W/perlcritic_3.txt +++ b/W/perlcritic_3.txt @@ -1,86 +1,86 @@ -Main code has high complexity score (411) at line 1, column 1. Consider refactoring. (Severity: 3) +Main code has high complexity score (412) at line 1, column 1. Consider refactoring. (Severity: 3) "%h1" is declared but not used at line 846, column 1. Unused variables clutter code and make it harder to read. (Severity: 3) "%h2" is declared but not used at line 846, column 1. Unused variables clutter code and make it harder to read. (Severity: 3) Regular expression without "/x" flag at line 1579, column 47. See page 236 of PBP. (Severity: 3) Regular expression without "/x" flag at line 1588, column 47. See page 236 of PBP. (Severity: 3) Code structure is deeply nested at line 2151, column 41. Consider refactoring. (Severity: 3) -Regular expression without "/x" flag at line 3010, column 23. See page 236 of PBP. (Severity: 3) -Too many arguments at line 4013, column 1. See page 182 of PBP. (Severity: 3) -Too many arguments at line 4032, column 1. See page 182 of PBP. (Severity: 3) -Too many arguments at line 4053, column 1. See page 182 of PBP. (Severity: 3) -Regular expression without "/x" flag at line 4211, column 23. See page 236 of PBP. (Severity: 3) -Regular expression without "/x" flag at line 4735, column 42. See page 236 of PBP. (Severity: 3) -Regular expression without "/x" flag at line 4736, column 33. See page 236 of PBP. (Severity: 3) -Regular expression without "/x" flag at line 4745, column 42. See page 236 of PBP. (Severity: 3) -Regular expression without "/x" flag at line 4762, column 42. See page 236 of PBP. (Severity: 3) -Regular expression without "/x" flag at line 4791, column 50. See page 236 of PBP. (Severity: 3) -Regular expression without "/x" flag at line 4896, column 64. See page 236 of PBP. (Severity: 3) -Regular expression without "/x" flag at line 4897, column 64. See page 236 of PBP. (Severity: 3) -Regular expression without "/x" flag at line 4900, column 56. See page 236 of PBP. (Severity: 3) -Too many arguments at line 4928, column 1. See page 182 of PBP. (Severity: 3) -Subroutine "authenticate_imap" with high complexity score (23) at line 5010, column 1. Consider refactoring. (Severity: 3) -Too many arguments at line 5010, column 1. See page 182 of PBP. (Severity: 3) -Too many arguments at line 5162, column 1. See page 182 of PBP. (Severity: 3) -Use "local $/ = undef" or Path::Tiny instead of joined readline at line 5259, column 43. See page 213 of PBP. (Severity: 3) -Backtick operator used at line 5277, column 20. Use IPC::Open3 instead. (Severity: 3) -Regular expression without "/x" flag at line 5415, column 26. See page 236 of PBP. (Severity: 3) -Expression form of "eval" at line 6605, column 27. See page 161 of PBP. (Severity: 5) -Single-quote used as quote-like operator delimiter at line 6755, column 24. Using quotes as delimiters for quote-like operators obfuscates code. (Severity: 3) -Expression form of "eval" at line 6846, column 27. See page 161 of PBP. (Severity: 5) -Subroutine "copy_message" with high complexity score (22) at line 7277, column 1. Consider refactoring. (Severity: 3) -Too many arguments at line 7277, column 1. See page 182 of PBP. (Severity: 3) -Too many arguments at line 7351, column 1. See page 182 of PBP. (Severity: 3) -Subroutine "message_for_host2" with high complexity score (23) at line 7385, column 1. Consider refactoring. (Severity: 3) -Too many arguments at line 7385, column 1. See page 182 of PBP. (Severity: 3) -Reused variable name in lexical scope: $uid1 at line 7615, column 9. Invent unique variable names. (Severity: 3) -Reused variable name in lexical scope: $uid2 at line 7615, column 9. Invent unique variable names. (Severity: 3) -Too many arguments at line 7811, column 1. See page 182 of PBP. (Severity: 3) -Too many arguments at line 8050, column 1. See page 182 of PBP. (Severity: 3) -Expression form of "eval" at line 9403, column 27. See page 161 of PBP. (Severity: 5) -Expression form of "eval" at line 9644, column 27. See page 161 of PBP. (Severity: 5) -Too many arguments at line 9955, column 1. See page 182 of PBP. (Severity: 3) -Backtick operator used at line 10254, column 17. Use IPC::Open3 instead. (Severity: 3) -Split long regexps into smaller qr// chunks at line 10343, column 32. See page 261 of PBP. (Severity: 3) -Split long regexps into smaller qr// chunks at line 10347, column 32. See page 261 of PBP. (Severity: 3) -Split long regexps into smaller qr// chunks at line 10366, column 33. See page 261 of PBP. (Severity: 3) -Split long regexps into smaller qr// chunks at line 10377, column 24. See page 261 of PBP. (Severity: 3) -Cascading if-elsif chain at line 10641, column 2. See pages 117,118 of PBP. (Severity: 3) -Return value of eval not tested at line 10795, column 3. You can't depend upon the value of $@/$EVAL_ERROR to tell whether an eval failed. (Severity: 3) -Backtick operator used at line 10796, column 15. Use IPC::Open3 instead. (Severity: 3) -Split long regexps into smaller qr// chunks at line 10805, column 16. See page 261 of PBP. (Severity: 3) -Return value of eval not tested at line 10818, column 3. You can't depend upon the value of $@/$EVAL_ERROR to tell whether an eval failed. (Severity: 3) -Backtick operator used at line 10819, column 15. Use IPC::Open3 instead. (Severity: 3) -Split long regexps into smaller qr// chunks at line 10828, column 16. See page 261 of PBP. (Severity: 3) -Return value of eval not tested at line 10842, column 3. You can't depend upon the value of $@/$EVAL_ERROR to tell whether an eval failed. (Severity: 3) -Capture variable used outside conditional at line 10853, column 12. See page 253 of PBP. (Severity: 3) -Backtick operator used at line 10998, column 26. Use IPC::Open3 instead. (Severity: 3) -Backtick operator used at line 11027, column 18. Use IPC::Open3 instead. (Severity: 3) -Split long regexps into smaller qr// chunks at line 11239, column 19. See page 261 of PBP. (Severity: 3) -Split long regexps into smaller qr// chunks at line 11265, column 19. See page 261 of PBP. (Severity: 3) -Split long regexps into smaller qr// chunks at line 11306, column 19. See page 261 of PBP. (Severity: 3) -Split long regexps into smaller qr// chunks at line 11318, column 19. See page 261 of PBP. (Severity: 3) -Expression form of "eval" at line 11675, column 56. See page 161 of PBP. (Severity: 5) -Expression form of "eval" at line 11679, column 58. See page 161 of PBP. (Severity: 5) -Split long regexps into smaller qr// chunks at line 12145, column 20. See page 261 of PBP. (Severity: 3) -Ambiguously named variable "last" at line 12548, column 2. See page 48 of PBP. (Severity: 3) -Subroutine "cleanup_mess_from_tests" does not end with "return" at line 12602, column 1. See page 197 of PBP. (Severity: 4) -Reused variable name in lexical scope: $err at line 12901, column 3. Invent unique variable names. (Severity: 3) -Reused variable name in lexical scope: $err at line 12971, column 3. Invent unique variable names. (Severity: 3) -"warn" used instead of "carp" at line 13429, column 25. See page 283 of PBP. (Severity: 3) -Regular expression without "/x" flag at line 13446, column 40. See page 236 of PBP. (Severity: 3) -Regular expression without "/x" flag at line 13448, column 23. See page 236 of PBP. (Severity: 3) -Regular expression without "/x" flag at line 13449, column 23. See page 236 of PBP. (Severity: 3) -Literal line breaks in a string at line 13475, column 19. See pages 60,61 of PBP. (Severity: 3) -Subroutine "myGetOptions" with high complexity score (29) at line 13511, column 1. Consider refactoring. (Severity: 3) -Capture variable used outside conditional at line 13543, column 41. See page 253 of PBP. (Severity: 3) +Regular expression without "/x" flag at line 3012, column 23. See page 236 of PBP. (Severity: 3) +Too many arguments at line 4015, column 1. See page 182 of PBP. (Severity: 3) +Too many arguments at line 4034, column 1. See page 182 of PBP. (Severity: 3) +Too many arguments at line 4055, column 1. See page 182 of PBP. (Severity: 3) +Regular expression without "/x" flag at line 4213, column 23. See page 236 of PBP. (Severity: 3) +Regular expression without "/x" flag at line 4737, column 42. See page 236 of PBP. (Severity: 3) +Regular expression without "/x" flag at line 4738, column 33. See page 236 of PBP. (Severity: 3) +Regular expression without "/x" flag at line 4747, column 42. See page 236 of PBP. (Severity: 3) +Regular expression without "/x" flag at line 4764, column 42. See page 236 of PBP. (Severity: 3) +Regular expression without "/x" flag at line 4793, column 50. See page 236 of PBP. (Severity: 3) +Regular expression without "/x" flag at line 4898, column 64. See page 236 of PBP. (Severity: 3) +Regular expression without "/x" flag at line 4899, column 64. See page 236 of PBP. (Severity: 3) +Regular expression without "/x" flag at line 4902, column 56. See page 236 of PBP. (Severity: 3) +Too many arguments at line 4930, column 1. See page 182 of PBP. (Severity: 3) +Subroutine "authenticate_imap" with high complexity score (23) at line 5012, column 1. Consider refactoring. (Severity: 3) +Too many arguments at line 5012, column 1. See page 182 of PBP. (Severity: 3) +Too many arguments at line 5164, column 1. See page 182 of PBP. (Severity: 3) +Use "local $/ = undef" or Path::Tiny instead of joined readline at line 5261, column 43. See page 213 of PBP. (Severity: 3) +Backtick operator used at line 5279, column 20. Use IPC::Open3 instead. (Severity: 3) +Regular expression without "/x" flag at line 5417, column 26. See page 236 of PBP. (Severity: 3) +Expression form of "eval" at line 6607, column 27. See page 161 of PBP. (Severity: 5) +Single-quote used as quote-like operator delimiter at line 6757, column 24. Using quotes as delimiters for quote-like operators obfuscates code. (Severity: 3) +Expression form of "eval" at line 6848, column 27. See page 161 of PBP. (Severity: 5) +Subroutine "copy_message" with high complexity score (22) at line 7279, column 1. Consider refactoring. (Severity: 3) +Too many arguments at line 7279, column 1. See page 182 of PBP. (Severity: 3) +Too many arguments at line 7353, column 1. See page 182 of PBP. (Severity: 3) +Subroutine "message_for_host2" with high complexity score (23) at line 7387, column 1. Consider refactoring. (Severity: 3) +Too many arguments at line 7387, column 1. See page 182 of PBP. (Severity: 3) +Reused variable name in lexical scope: $uid1 at line 7617, column 9. Invent unique variable names. (Severity: 3) +Reused variable name in lexical scope: $uid2 at line 7617, column 9. Invent unique variable names. (Severity: 3) +Too many arguments at line 7813, column 1. See page 182 of PBP. (Severity: 3) +Too many arguments at line 8052, column 1. See page 182 of PBP. (Severity: 3) +Expression form of "eval" at line 9405, column 27. See page 161 of PBP. (Severity: 5) +Expression form of "eval" at line 9646, column 27. See page 161 of PBP. (Severity: 5) +Too many arguments at line 9957, column 1. See page 182 of PBP. (Severity: 3) +Backtick operator used at line 10256, column 17. Use IPC::Open3 instead. (Severity: 3) +Split long regexps into smaller qr// chunks at line 10345, column 32. See page 261 of PBP. (Severity: 3) +Split long regexps into smaller qr// chunks at line 10349, column 32. See page 261 of PBP. (Severity: 3) +Split long regexps into smaller qr// chunks at line 10368, column 33. See page 261 of PBP. (Severity: 3) +Split long regexps into smaller qr// chunks at line 10379, column 24. See page 261 of PBP. (Severity: 3) +Cascading if-elsif chain at line 10643, column 2. See pages 117,118 of PBP. (Severity: 3) +Return value of eval not tested at line 10797, column 3. You can't depend upon the value of $@/$EVAL_ERROR to tell whether an eval failed. (Severity: 3) +Backtick operator used at line 10798, column 15. Use IPC::Open3 instead. (Severity: 3) +Split long regexps into smaller qr// chunks at line 10807, column 16. See page 261 of PBP. (Severity: 3) +Return value of eval not tested at line 10820, column 3. You can't depend upon the value of $@/$EVAL_ERROR to tell whether an eval failed. (Severity: 3) +Backtick operator used at line 10821, column 15. Use IPC::Open3 instead. (Severity: 3) +Split long regexps into smaller qr// chunks at line 10830, column 16. See page 261 of PBP. (Severity: 3) +Return value of eval not tested at line 10844, column 3. You can't depend upon the value of $@/$EVAL_ERROR to tell whether an eval failed. (Severity: 3) +Capture variable used outside conditional at line 10855, column 12. See page 253 of PBP. (Severity: 3) +Backtick operator used at line 11000, column 26. Use IPC::Open3 instead. (Severity: 3) +Backtick operator used at line 11029, column 18. Use IPC::Open3 instead. (Severity: 3) +Split long regexps into smaller qr// chunks at line 11241, column 19. See page 261 of PBP. (Severity: 3) +Split long regexps into smaller qr// chunks at line 11267, column 19. See page 261 of PBP. (Severity: 3) +Split long regexps into smaller qr// chunks at line 11308, column 19. See page 261 of PBP. (Severity: 3) +Split long regexps into smaller qr// chunks at line 11320, column 19. See page 261 of PBP. (Severity: 3) +Expression form of "eval" at line 11677, column 56. See page 161 of PBP. (Severity: 5) +Expression form of "eval" at line 11681, column 58. See page 161 of PBP. (Severity: 5) +Split long regexps into smaller qr// chunks at line 12147, column 20. See page 261 of PBP. (Severity: 3) +Ambiguously named variable "last" at line 12550, column 2. See page 48 of PBP. (Severity: 3) +Subroutine "cleanup_mess_from_tests" does not end with "return" at line 12604, column 1. See page 197 of PBP. (Severity: 4) +Reused variable name in lexical scope: $err at line 12903, column 3. Invent unique variable names. (Severity: 3) +Reused variable name in lexical scope: $err at line 12973, column 3. Invent unique variable names. (Severity: 3) +"warn" used instead of "carp" at line 13431, column 25. See page 283 of PBP. (Severity: 3) +Regular expression without "/x" flag at line 13448, column 40. See page 236 of PBP. (Severity: 3) +Regular expression without "/x" flag at line 13450, column 23. See page 236 of PBP. (Severity: 3) +Regular expression without "/x" flag at line 13451, column 23. See page 236 of PBP. (Severity: 3) +Literal line breaks in a string at line 13477, column 19. See pages 60,61 of PBP. (Severity: 3) +Subroutine "myGetOptions" with high complexity score (29) at line 13513, column 1. Consider refactoring. (Severity: 3) +Capture variable used outside conditional at line 13545, column 41. See page 253 of PBP. (Severity: 3) 1 files. 437 subroutines/methods. 14,225 statements. -14,377 lines, consisting of: +14,379 lines, consisting of: 2,697 blank lines. - 842 comment lines. + 844 comment lines. 0 data lines. 10,160 lines of Perl code. 678 lines of POD. diff --git a/W/perlcritic_4.txt b/W/perlcritic_4.txt index 67d42e1..e9ea452 100644 --- a/W/perlcritic_4.txt +++ b/W/perlcritic_4.txt @@ -1,18 +1,18 @@ -Expression form of "eval" at line 6605, column 27. See page 161 of PBP. (Severity: 5) -Expression form of "eval" at line 6846, column 27. See page 161 of PBP. (Severity: 5) -Expression form of "eval" at line 9403, column 27. See page 161 of PBP. (Severity: 5) -Expression form of "eval" at line 9644, column 27. See page 161 of PBP. (Severity: 5) -Expression form of "eval" at line 11675, column 56. See page 161 of PBP. (Severity: 5) -Expression form of "eval" at line 11679, column 58. See page 161 of PBP. (Severity: 5) -Subroutine "cleanup_mess_from_tests" does not end with "return" at line 12602, column 1. See page 197 of PBP. (Severity: 4) +Expression form of "eval" at line 6607, column 27. See page 161 of PBP. (Severity: 5) +Expression form of "eval" at line 6848, column 27. See page 161 of PBP. (Severity: 5) +Expression form of "eval" at line 9405, column 27. See page 161 of PBP. (Severity: 5) +Expression form of "eval" at line 9646, column 27. See page 161 of PBP. (Severity: 5) +Expression form of "eval" at line 11677, column 56. See page 161 of PBP. (Severity: 5) +Expression form of "eval" at line 11681, column 58. See page 161 of PBP. (Severity: 5) +Subroutine "cleanup_mess_from_tests" does not end with "return" at line 12604, column 1. See page 197 of PBP. (Severity: 4) 1 files. 437 subroutines/methods. 14,225 statements. -14,377 lines, consisting of: +14,379 lines, consisting of: 2,697 blank lines. - 842 comment lines. + 844 comment lines. 0 data lines. 10,160 lines of Perl code. 678 lines of POD. diff --git a/W/prereq.Ubuntu_16.04_xenial.txt b/W/prereq.Ubuntu_16.04_xenial.txt index ff85876..21aaf28 100644 --- a/W/prereq.Ubuntu_16.04_xenial.txt +++ b/W/prereq.Ubuntu_16.04_xenial.txt @@ -1,6 +1,6 @@ $SHELL says /bin/bash $0 gives ./INSTALL.d/prerequisites_imapsync -ps -ef gives gilles 29646 29645 0 00:34 pts/14 00:00:00 /bin/sh ./INSTALL.d/prerequisites_imapsync +ps -ef gives gilles 29553 29552 0 23:52 pts/26 00:00:00 /bin/sh ./INSTALL.d/prerequisites_imapsync Distributor ID: Ubuntu Description: Ubuntu 16.04.5 LTS Release: 16.04 diff --git a/W/prereq.scandeps.Ubuntu_16.04_xenial.txt b/W/prereq.scandeps.Ubuntu_16.04_xenial.txt index 50728b0..3b17329 100644 --- a/W/prereq.scandeps.Ubuntu_16.04_xenial.txt +++ b/W/prereq.scandeps.Ubuntu_16.04_xenial.txt @@ -5,7 +5,7 @@ Name: Version: - This documentation refers to Imapsync $Revision: 1.3 $ + This documentation refers to Imapsync $Revision: 1.4 $ Usage: @@ -395,10 +395,10 @@ Options/behavior: --host1 test1.lamiral.info --user1 test1 --password1 secret1 \ --host2 test2.lamiral.info --user2 test2 --password2 secret2 -Here is imapsync 1.920 on host petite, a linux system with 0.1/2.0 free GiB of RAM +Here is imapsync 1.921 on host petite, a linux system with 0.1/2.0 free GiB of RAM with Perl 5.22.1 and Mail::IMAPClient 3.38 -$Id: prereq.scandeps.Ubuntu_16.04_xenial.txt,v 1.3 2019/02/10 23:34:08 gilles Exp gilles $ -This imapsync is up to date. ( local 1.920 >= official 1.882 )( Use --noreleasecheck to avoid this release check. ) +$Id: prereq.scandeps.Ubuntu_16.04_xenial.txt,v 1.4 2019/02/18 22:52:23 gilles Exp gilles $ +This imapsync is up to date. ( local 1.921 >= official 1.920 )( Use --noreleasecheck to avoid this release check. ) Homepage: https://imapsync.lamiral.info/ 'Tie::Hash::NamedCapture' => '0.09', 'APR' => '0.009000', @@ -448,13 +448,13 @@ Homepage: https://imapsync.lamiral.info/ 'IO::Compress::Base' => '2.069', 'IO::Compress::RawDeflate' => '2.069', 'IO::Compress::Adapter::Deflate' => '2.069', -'IO::Compress::Zlib::Extra' => '2.069', -'IO::Compress::Gzip::Constants' => '2.069', +'IO::Compress::Zlib::Constants' => '2.069', 'Socket6' => '0.25', 'IO::Socket::SSL::PublicSuffix' => 'undef', 'Net::SSLeay' => '1.72', 'IO::Uncompress::Adapter::Bunzip2' => '2.069', -'IO::Compress::Zlib::Constants' => '2.069', +'IO::Compress::Zlib::Extra' => '2.069', +'IO::Compress::Gzip::Constants' => '2.069', 'IO::Uncompress::Adapter::Inflate' => '2.069', 'IO::Uncompress::Base' => '2.069', 'IO::Compress::Base::Common' => '2.069', @@ -467,7 +467,6 @@ Homepage: https://imapsync.lamiral.info/ 'Authen::NTLM' => '1.09', 'CPAN::Config' => 'undef', 'URI::_foreign' => '1.71', -'URI::_generic' => '1.71', 'URI::mailto' => '1.71', 'URI::data' => '1.71', 'URI::_query' => '1.71', @@ -500,23 +499,22 @@ Homepage: https://imapsync.lamiral.info/ 'URI::file::Base' => '1.71', 'URI::_punycode' => '1.71', 'URI::IRI' => '1.71', -'URI::_idna' => '1.71', +'URI::_ldap' => '1.71', 'URI::ldap' => '1.71', 'URI::news' => '1.71', 'URI::rtsp' => '1.71', 'URI::ssh' => '1.71', -'URI::_ldap' => '1.71', 'URI::sip' => '1.71', -'URI::_userpass' => '1.71', 'URI::Heuristic' => '4.20', +'URI::_userpass' => '1.71', 'URI::_login' => '1.71', +'URI::_idna' => '1.71', +'URI::_generic' => '1.71', 'LWP::MediaTypes' => '6.02', 'File::Listing' => '6.04', 'HTTP::Negotiate' => '6.00', 'Net::HTTP' => '6.09', 'HTTP::Status' => '6.11', -'LWP::Protocol' => '6.15', -'HTTP::Response' => '6.11', 'Net::HTTPS' => '6.09', 'Net::SSL' => '2.88', 'Net::LDAP::DSML' => '0.16', @@ -534,6 +532,8 @@ Homepage: https://imapsync.lamiral.info/ 'LWP' => '6.15', 'HTTP::Date' => '6.02', 'HTTP::Request' => '6.11', +'LWP::Protocol' => '6.15', +'HTTP::Response' => '6.11', 'Mail::IMAPClient::MessageSet' => 'undef', 'Digest::HMAC_MD5' => '1.01', 'Authen::SASL' => '2.16', @@ -553,20 +553,20 @@ Homepage: https://imapsync.lamiral.info/ 'Mail::Util' => '2.13', 'Math::Random::ISAAC::PP' => '1.003', 'Math::Random::ISAAC::XS' => '1.004', -'Compress::Raw::Zlib' => '2.069', 'Net::HTTP::Methods' => '6.09', +'Compress::Raw::Zlib' => '2.069', 'Net::LDAP::Bind' => '1.05', 'Net::LDAP::Extension' => '1.04', 'Net::LDAP::RootDSE' => '0.02', 'Net::LDAP::Search' => '0.14', 'Convert::ASN1::Debug' => '0.27', 'Convert::ASN1' => '0.27', +'Net::LDAP::Constant' => '0.23', +'Net::LDAP::Schema' => '0.9908', 'Net::LDAP::Message' => '1.12', 'Net::LDAP::ASN' => '0.12', -'Net::LDAP::Constant' => '0.23', 'Net::LDAP::Filter' => '0.20', 'XML::SAX::Base' => '1.07', -'Net::LDAP::Schema' => '0.9908', 'Net::LDAP::Entry' => '0.27', 'Net::LDAP::Control' => '0.18', 'Net::LDAP::Util' => '0.19', @@ -628,6 +628,13 @@ Homepage: https://imapsync.lamiral.info/ 'LWP::Protocol::ldap' => '1.25', 'LWP::Protocol::nogo' => 'undef', 'IO::Socket::INET6' => '2.72', +'Regexp::Common::profanity' => '2016020301', +'Regexp::Common::lingua' => '2016020301', +'Regexp::Common::zip' => '2016020301', +'Regexp::Common::net' => '2016020301', +'Regexp::Common::list' => '2016020301', +'Regexp::Common::URI::news' => '2016020301', +'Regexp::Common::URI::pop' => '2016020301', 'Regexp::Common::URI::tel' => '2016020301', 'Regexp::Common::URI::ftp' => '2016020301', 'Regexp::Common::URI::fax' => '2016020301', @@ -636,29 +643,22 @@ Homepage: https://imapsync.lamiral.info/ 'Regexp::Common::URI::prospero' => '2016020301', 'Regexp::Common::URI::tv' => '2016020301', 'Regexp::Common::URI::telnet' => '2016020301', -'Regexp::Common::profanity' => '2016020301', -'Regexp::Common::URI' => '2016020301', -'Regexp::Common::lingua' => '2016020301', -'Regexp::Common::zip' => '2016020301', -'Regexp::Common::net' => '2016020301', -'Regexp::Common::list' => '2016020301', -'Regexp::Common::URI::news' => '2016020301', -'Regexp::Common::URI::pop' => '2016020301', +'Regexp::Common::Email::Address' => '1.01', 'Regexp::Common' => '2016020301', 'Regexp::Common::URI::RFC1808' => '2016020301', 'Regexp::Common::URI::RFC2806' => '2016020301', 'Regexp::Common::_support' => '2016020301', +'Regexp::Common::URI::gopher' => '2016020301', +'Regexp::Common::URI::RFC2384' => '2016020301', +'Regexp::Common::URI::RFC1738' => '2016020301', +'Regexp::Common::URI::RFC1035' => '2016020301', +'Regexp::Common::URI::file' => '2016020301', 'Regexp::Common::URI::http' => '2016020301', 'Regexp::Common::delimited' => '2016020301', 'Regexp::Common::SEN' => '2016020301', 'Regexp::Common::whitespace' => '2016020301', 'Regexp::Common::number' => '2016020301', 'Regexp::Common::balanced' => '2016020301', -'Regexp::Common::CC' => '2016020301', 'Regexp::Common::comment' => '2016020301', -'Regexp::Common::Email::Address' => '1.01', -'Regexp::Common::URI::gopher' => '2016020301', -'Regexp::Common::URI::RFC2384' => '2016020301', -'Regexp::Common::URI::RFC1738' => '2016020301', -'Regexp::Common::URI::RFC1035' => '2016020301', -'Regexp::Common::URI::file' => '2016020301', +'Regexp::Common::URI' => '2016020301', +'Regexp::Common::CC' => '2016020301', diff --git a/imapsync b/imapsync index cf7f280..4e72093 100755 --- a/imapsync +++ b/imapsync @@ -1,6 +1,6 @@ #!/usr/bin/env perl -# $Id: imapsync,v 1.920 2019/02/09 15:45:31 gilles Exp gilles $ +# $Id: imapsync,v 1.921 2019/02/18 10:21:03 gilles Exp gilles $ # structure # pod documentation # use pragmas @@ -25,7 +25,7 @@ and without duplicates. =head1 VERSION -This documentation refers to Imapsync $Revision: 1.920 $ +This documentation refers to Imapsync $Revision: 1.921 $ =head1 USAGE @@ -926,7 +926,7 @@ my( $sync->{timestart} = time ; # Is a float because of use Time::HiRres -$sync->{rcs} = q{$Id: imapsync,v 1.920 2019/02/09 15:45:31 gilles Exp gilles $} ; +$sync->{rcs} = q{$Id: imapsync,v 1.921 2019/02/18 10:21:03 gilles Exp gilles $} ; $sync->{ memory_consumption_at_start } = memory_consumption( ) || 0 ; @@ -1005,8 +1005,8 @@ if ( ! defined $options_good ) { exit $EX_USAGE ; } # the second line (ending with "1 ;") can then stay active or be commented, # the result will be the same: no releasecheck by default (because 0 is then the defined value). -$sync->{releasecheck} = defined $sync->{releasecheck} ? $sync->{releasecheck} : 0 ; -#$sync->{releasecheck} = defined $sync->{releasecheck} ? $sync->{releasecheck} : 1 ; +#$sync->{releasecheck} = defined $sync->{releasecheck} ? $sync->{releasecheck} : 0 ; +$sync->{releasecheck} = defined $sync->{releasecheck} ? $sync->{releasecheck} : 1 ; # just the version if ( $sync->{ version } ) { @@ -2199,7 +2199,9 @@ FOLDER: foreach my $h1_fold ( @h1_folders_wanted ) { push @h1_msgs_to_delete, $h1_msg ; } - if ( not $sync->{ dry } ) + # A bug here with imapsync 1.920, fixed in 1.921 + # Added $h2_msg in the condition. Errors of APPEND were not counted as missing messages on host2! + if ( $h2_msg and not $sync->{ dry } ) { $sync->{ h2_folders_of_md5 }->{ $m_id }->{ $h2_fold } ++ ; } @@ -3505,7 +3507,7 @@ sub imapsync_id vendor => 'Gilles LAMIRAL', 'support-url' => 'https://imapsync.lamiral.info/', # Example of date-time: 19-Sep-2015 08:56:07 - date => date_from_rcs( q{$Date: 2019/02/09 15:45:31 $ } ), + date => date_from_rcs( q{$Date: 2019/02/18 10:21:03 $ } ), } ; my $imapsync_id_github = { @@ -3514,7 +3516,7 @@ sub imapsync_id os => $OSNAME, vendor => 'github', 'support-url' => 'https://github.com/imapsync/imapsync', - date => date_from_rcs( q{$Date: 2019/02/09 15:45:31 $ } ), + date => date_from_rcs( q{$Date: 2019/02/18 10:21:03 $ } ), } ; $imapsync_id = $imapsync_id_lamiral ; @@ -5458,8 +5460,8 @@ sub banner_imapsync my $banner_imapsync = join q{}, q{$RCSfile: imapsync,v $ }, - q{$Revision: 1.920 $ }, - q{$Date: 2019/02/09 15:45:31 $ }, + q{$Revision: 1.921 $ }, + q{$Date: 2019/02/18 10:21:03 $ }, "\n", "Command line used:\n", "$PROGRAM_NAME ", command_line_nopassword( @argv ), "\n" ; diff --git a/tests.sh b/tests.sh index 629da3c..9e1ecea 100644 --- a/tests.sh +++ b/tests.sh @@ -1,6 +1,6 @@ #!/bin/sh -# $Id: tests.sh,v 1.324 2019/02/10 12:16:41 gilles Exp gilles $ +# $Id: tests.sh,v 1.325 2019/02/19 08:28:23 gilles Exp gilles $ # general tests start # general tests end @@ -490,6 +490,19 @@ ll_final_diff() { --folder INBOX --f1f2 INBOX=INBOX.final_diff --maxage 30 } +ll_with_errors() { + can_send && sendtestmessage + can_send && sendtestmessage + $CMD_PERL ./imapsync \ + --host1 $HOST1 --user1 tata \ + --passfile1 ../../var/pass/secret.tata \ + --host2 $HOST2 --user2 titi \ + --passfile2 ../../var/pass/secret.titi \ + --folder INBOX --maxage 30 \ + --regexflag 's/.*/PasGlop \\PasGlopRe/' +} + + ll_errors() { $CMD_PERL ./imapsync \