zydronium/google-nomulus
1
0
Fork 0
mirror of https://github.com/google/nomulus.git synced 2025-06-24 21:40:57 +02:00
Code Issues Projects Releases Packages Wiki Activity
google-nomulus/java/google/registry/flows
History
jianglai ff221fba96 Validate individual fee types 
Currently we validate the fee extension by summing up all fees present in the extension and comparing it against the total fee to be charged. While this works in most cases, we'd like the ability to individually validate each fee. This is especially useful during EAP when two fees are charged, a regular "create" fee that would also be amount we charge during renewal, and a one time "EAP" fee.

Because we can only distinguish fees by their descriptions, we try to match the description to the format string of the fee type enums. We also only require individual fee matches when we are charging more than one type of fees, which makes the change compatible with most existing use cases where only one fees is charged and the description field is ignored in the extension.

We expect the workflow to be that a registrar sends a domain check, and we reply with exactly what fees we are expecting, and then it will use the descriptions in the response to send us a domain create with the correct fees.

Note that we aggregate fees within the same FeeType together. Normally there will only be one fee per type, but in case of custom logic there could be more than one fee for the same type. There is no way to distinguish them as they both use the same description. So it is simpler to just aggregate them.

This CL also includes some reformatting that conforms to google-java-format output.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=186530316
2018-03-06 18:48:39 -05:00
..
annotations Make FlowRunner log ICANN activity report field name 2017-03-27 13:32:57 -04:00
async Move metrics dependencies to artifacts under Maven groupId com.google.monitoring-client 2018-01-04 17:12:35 -05:00
contact Remove unnecessary generic type arguments 2017-11-21 18:17:31 -05:00
custom Remove unnecessary generic type arguments 2017-11-21 18:17:31 -05:00
domain Validate individual fee types 2018-03-06 18:48:39 -05:00
exceptions Allow domain transfers with 0 period and in auto-renew grace period 2017-10-04 16:16:45 -04:00
host Clean up some code quality issues 2017-12-01 22:14:06 -05:00
picker Make EppInput.getSingleExtension() return Optional, not @Nullable 2018-01-19 14:40:10 -05:00
poll Remove leniency on poll message ID format without years in them 2018-02-20 15:12:43 -05:00
session Switch from Guava Optionals to Java 8 Optionals 2017-10-24 16:53:47 -04:00
soy Remove autoescape="strict" attributes from Soy templates. 2017-10-04 16:16:45 -04:00
BUILD Move metrics dependencies to artifacts under Maven groupId com.google.monitoring-client 2018-01-04 17:12:35 -05:00
CheckApiAction.java Remove unnecessary generic type arguments 2017-11-21 18:17:31 -05:00
EppConsoleAction.java Change @Auth to an AutoValue, and created a set of predefined Auths 2017-08-01 16:33:10 -04:00
EppController.java Rationalize logging statements across codebase 2018-01-19 14:56:45 -05:00
EppException.java Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
EppMetrics.java Move metrics dependencies to artifacts under Maven groupId com.google.monitoring-client 2018-01-04 17:12:35 -05:00
EppRequestHandler.java Set HTTP header when processing logout request 2017-11-07 17:30:13 -05:00
EppRequestSource.java Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
EppTlsAction.java Change @Auth to an AutoValue, and created a set of predefined Auths 2017-08-01 16:33:10 -04:00
EppToolAction.java Change @Auth to an AutoValue, and created a set of predefined Auths 2017-08-01 16:33:10 -04:00
EppXmlTransformer.java Rationalize logging statements across codebase 2018-01-19 14:56:45 -05:00
ExtensionManager.java Run automatic Java 8 conversion over codebase 2017-10-10 12:09:41 -04:00
Flow.java Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
FlowComponent.java Add extensibility framework for allocation tokens 2018-02-01 21:54:29 -05:00
FlowMetadata.java Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
FlowModule.java Make EppInput.getSingleExtension() return Optional, not @Nullable 2018-01-19 14:40:10 -05:00
FlowReporter.java Rationalize logging statements across codebase 2018-01-19 14:56:45 -05:00
FlowRunner.java Rationalize logging statements across codebase 2018-01-19 14:56:45 -05:00
FlowScope.java Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
FlowUtils.java Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
GaeUserCredentials.java Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
HttpSessionMetadata.java Switch from Guava Optionals to Java 8 Optionals 2017-10-24 16:53:47 -04:00
PasswordOnlyTransportCredentials.java Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
ResourceFlowUtils.java Replace com.google.common.base.Predicate with java.util.function.Predicate 2017-12-27 11:21:28 -05:00
ServerTridProvider.java Clean up some code quality issues 2017-12-01 22:14:06 -05:00
ServerTridProviderImpl.java Refactor out creation of server TRIDs so they can be tested 2017-04-13 10:55:47 -04:00
ServerTridProviderModule.java Refactor out creation of server TRIDs so they can be tested 2017-04-13 10:55:47 -04:00
SessionMetadata.java Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
StatelessRequestSessionMetadata.java Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
TlsCredentials.java Switch from Guava Optionals to Java 8 Optionals 2017-10-24 16:53:47 -04:00
TransactionalFlow.java Refer to Datastore everywhere correctly by its capitalized form 2017-02-17 12:12:12 -05:00
TransportCredentials.java Clean up some code quality issues 2017-12-01 22:14:06 -05:00