mirror of
https://github.com/google/nomulus.git
synced 2025-05-05 22:47:51 +02:00
75add42a1b
Many registry tools tests modify system properties but do not restore them to original state. These tests must be isolated from each other and cannot share the same test execution process. This has a huge impact on test performance under Gradle, which seems to have higher process startup overhead. Current Gradle test config has to set 'forEvery' to 1, i.e., every test class must be run in a freshly started process. This change significantly reduces the number of tests that need isolation, making it easier to optimize test config for the remaining tests. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=221350284
71 lines
2.6 KiB
Java
71 lines
2.6 KiB
Java
// Copyright 2017 The Nomulus Authors. All Rights Reserved.
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package google.registry.tools;
|
|
|
|
import static com.google.common.truth.Truth.assertThat;
|
|
|
|
import com.google.api.client.auth.oauth2.Credential;
|
|
import com.google.api.client.http.HttpRequest;
|
|
import com.google.api.client.http.HttpRequestFactory;
|
|
import com.google.api.client.http.HttpRequestInitializer;
|
|
import google.registry.config.RegistryConfig;
|
|
import google.registry.testing.SystemPropertyRule;
|
|
import org.junit.Before;
|
|
import org.junit.Rule;
|
|
import org.junit.Test;
|
|
import org.junit.runner.RunWith;
|
|
import org.junit.runners.JUnit4;
|
|
|
|
@RunWith(JUnit4.class)
|
|
public class DefaultRequestFactoryModuleTest {
|
|
|
|
private static final Credential FAKE_CREDENTIAL = new Credential(
|
|
new Credential.AccessMethod() {
|
|
@Override
|
|
public void intercept(HttpRequest request, String accessToken) {}
|
|
|
|
@Override
|
|
public String getAccessTokenFromRequest(HttpRequest request) {
|
|
return "MockAccessToken";
|
|
}
|
|
});
|
|
|
|
@Rule public final SystemPropertyRule systemPropertyRule = new SystemPropertyRule();
|
|
|
|
DefaultRequestFactoryModule module = new DefaultRequestFactoryModule();
|
|
|
|
@Before
|
|
public void setUp() {
|
|
RegistryToolEnvironment.UNITTEST.setup(systemPropertyRule);
|
|
}
|
|
|
|
@Test
|
|
public void test_provideHttpRequestFactory_localhost() {
|
|
// Make sure that localhost creates a request factory with an initializer.
|
|
RegistryConfig.CONFIG_SETTINGS.get().appEngine.isLocal = true;
|
|
HttpRequestFactory factory = module.provideHttpRequestFactory(() -> FAKE_CREDENTIAL);
|
|
HttpRequestInitializer initializer = factory.getInitializer();
|
|
assertThat(initializer).isNotNull();
|
|
assertThat(initializer).isNotSameAs(FAKE_CREDENTIAL);
|
|
}
|
|
|
|
@Test
|
|
public void test_provideHttpRequestFactory_remote() {
|
|
// Make sure that example.com creates a request factory with the UNITTEST client id but no
|
|
RegistryConfig.CONFIG_SETTINGS.get().appEngine.isLocal = false;
|
|
HttpRequestFactory factory = module.provideHttpRequestFactory(() -> FAKE_CREDENTIAL);
|
|
assertThat(factory.getInitializer()).isSameAs(FAKE_CREDENTIAL);
|
|
}
|
|
}
|