mirror of
https://github.com/google/nomulus.git
synced 2025-06-22 12:20:46 +02:00
f742ac8056
This refactors RequestHandler so that it handles the construction of the request component itself, rather than being handed a pre-built request component instance constructed by the invoking servlet. The motivation for this change is so that RequestHandler can be extended in future CLs to compute authentication results, and can provide those results as an available binding in the constructed request component. An alternative approach could have been to compute the authentication results within RequestModule itself, but I think it's clearer to keep business logic like that outside of Dagger providers. This CL makes the following individual changes: - Adds request component builders, which implement a RequestComponentBuilder interface so they can all be manipulated by RequestHandler - Instead of obtaining request components via factory methods on the global components, one now can have global-scoped bindings just inject the request component builders (which requires adding a module to each global component declaring the subcomponent). This follows the recommended approach here: http://google.github.io/dagger/subcomponents.html - Instead of exposing request components on the global component interface, we now expose module-specific subclasses of RequestHandler that @Inject the appropriate request component builder's provider and pass it to the superclass (note that inheritance isn't strictly necessary here but saves boilerplate) - RequestHandler now takes the Provider<RequestComponentBuilder> and builds the component itself using its own fresh RequestModule instance. This provides some nice encapsulation but is mainly needed for adding a RequestAuthModule in future work. - RequestHandler also takes UserService now, which can be provided via Dagger by the subclass. Longer-term that will go away in favor of instead providing AuthStrategy instances, some of which will use UserService internally. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=138815648 |
||
|---|---|---|
| .. | ||
| backup | ||
| batch | ||
| bigquery | ||
| braintree | ||
| builddefs | ||
| config | ||
| cron | ||
| dns | ||
| eclipse | ||
| env | ||
| export | ||
| flows | ||
| gcs | ||
| groups | ||
| idn | ||
| keyring/api | ||
| loadtest | ||
| mapreduce | ||
| model | ||
| module | ||
| monitoring | ||
| pricing | ||
| rdap | ||
| rde | ||
| request | ||
| security | ||
| storage/drive | ||
| tldconfig/idn | ||
| tmch | ||
| tools | ||
| ui | ||
| util | ||
| whois | ||
| xjc | ||
| xml | ||
| BUILD | ||
| repositories.bzl | ||