zydronium/google-nomulus
1
0
Fork 0
mirror of https://github.com/google/nomulus.git synced 2025-06-21 03:40:47 +02:00
Code Issues Projects Releases Packages Wiki Activity
google-nomulus/javatests/google/registry/testing
History
nickfelt f640d765e8 Log EppExceptions in EppController at INFO (vs FlowRunner at WARNING) 
The logging for exceptions in FlowRunner - always at WARNING - has long been sub-optimal.  For EppExceptions it's too aggressive/spammy to log at WARNING because it's generally not actionable - EppException gets properly thrown for all kinds of ordinary reasons (trying to create a resource when one already exists with that foreign key) and/or for client misbehavior that we can't control (sending bad parameter values, etc.).  For non-EppException RuntimeExceptions, it's redundant with existing logging in EppController.

This CL resolves this by removing that logging in FlowRunner entirely in favor of the EppController logging, where we're now logging EppExceptions at INFO in parallel with the existing logging of RuntimeExceptions at SEVERE.  This has the benefit that we're now logging EppExceptions that come from FlowPicker (by way of EppExceptionInProviderException),  which previously were unlogged.

Note however that this does mean that in places where we run FlowRunner without EppController - exclusively test code as it stands today - we'd no longer be logging EppExceptions.  If that seems like a loss, we could either reinstate logging there (at INFO) and just deal with redundant messages for most EppExceptions, or we could add it manually to places where we call FlowRunner.run() in tests and avoid the redundancy that way.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=154733365
2017-05-03 11:04:51 -04:00
..
mapreduce Add mapreduce cleanup action 2017-03-13 10:24:57 -04:00
sftp Remove an unused exception 2017-02-02 17:06:50 -05:00
testdata Refactor RdeKeyringModule into FakeKeyringModule 2017-03-21 14:53:25 -04:00
AbstractDomainBaseSubject.java Remove the ofy().load() inside of HostResource.cloneProjectedAtTime 2017-03-13 11:22:55 -04:00
AbstractEppResourceSubject.java Add EppResource diffing to AbstractEppResourceSubject.isEqualTo() 2017-03-27 13:07:22 -04:00
AppEngineRule.java Turn on memcache in flow tests. 2017-04-26 11:04:56 -04:00
BouncyCastleProviderRule.java Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
BUILD Add flow-level EPP metric tests 2017-05-03 10:51:12 -04:00
CertificateSamples.java Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
ContactResourceSubject.java Remove the ofy().load() inside of HostResource.cloneProjectedAtTime 2017-03-13 11:22:55 -04:00
DatastoreHelper.java Turn on memcache in flow tests. 2017-04-26 11:04:56 -04:00
default_premium_list_testdata.csv Don't allow duplicates in premium/reserved lists 2017-02-27 11:17:58 -05:00
DeterministicStringGenerator.java Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
DomainApplicationSubject.java Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
DomainResourceSubject.java Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
EppExceptionSubject.java Replace deprecated Truth hasMessage() method with hasMessageThat() 2017-04-26 10:35:23 -04:00
EppLoader.java Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
EppMetricSubject.java Add more EPP metric lifecycle tests 2017-05-03 10:58:51 -04:00
ExceptionRule.java Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
FailAnswer.java Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
FakeClock.java Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
FakeHttpSession.java Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
FakeJsonResponse.java Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
FakeKeyringModule.java Refactor RdeKeyringModule into FakeKeyringModule 2017-03-21 14:53:25 -04:00
FakeOAuthService.java Add more tests to new authentication framework 2017-02-27 11:19:27 -05:00
FakeResponse.java Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
FakeServletInputStream.java Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
FakeServletOutputStream.java Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
FakeSleeper.java Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
FakeURLFetchService.java Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
FakeUserService.java Daggerize XsrfTokenManager 2017-02-22 11:43:10 -05:00
ForwardingURLFetchService.java Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
FullFieldsTestEntityHelper.java Refactor out creation of server TRIDs so they can be tested 2017-04-13 10:55:47 -04:00
GcsTestingUtils.java Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
GenericEppResourceSubject.java Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
GpgSystemCommandRule.java Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
HistoryEntrySubject.java Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
HostResourceSubject.java Improve handling of lastSubordinateChange and beef up tests 2017-02-17 12:23:36 -05:00
InjectRule.java Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
IoSpyRule.java Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
logging.properties Rename Java packages to use the .google TLD 2016-05-13 20:04:42 -04:00
LogsSubject.java Make FlowRunner log ICANN activity report field name 2017-03-27 13:32:57 -04:00
MemcacheHelper.java Add MemcacheHelper to simplify memcache usage in tests 2017-04-26 11:12:17 -04:00
package-info.java Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
Providers.java Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
ReflectiveFieldExtractor.java Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
ReflectiveSubjectFactory.java Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
ShardableTestCase.java Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
SlurpAnswer.java Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
SystemInfo.java Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
SystemPropertyRule.java Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
TaskQueueHelper.java Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
TestDataHelper.java Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
TestLogHandlerUtils.java Log EppExceptions in EppController at INFO (vs FlowRunner at WARNING) 2017-05-03 11:04:51 -04:00
TestObject.java Add @VirtualEntity checking to Ofy's deleteWithoutBackup() 2017-02-08 17:31:07 -05:00
TruthChainer.java Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
UriParameters.java Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
UserInfo.java Update copyright year on all license headers 2017-02-02 16:27:22 -05:00