google-nomulus/javatests/google/registry/xjc/XjcObjectTest.java
cgoldfeder f3a0b78145 Move thrown.expect() right before the throwing statement
aka regexing for fun and profit.

This also makes sure that there are no statements after the
throwing statement, since these would be dead code. There
were a surprising number of places with assertions after
the throw, and none of these are actually triggered in tests
ever. When I found these, I replaced them with try/catch/rethrow
which makes the assertions actually happen:

before:

// This is the ExceptionRule that checks EppException marshaling
thrown.expect(FooException.class);
doThrowingThing();
assertSomething();  // Dead code!

after:

try {
  doThrowingThing();
  assertWithMessage("...").fail();
} catch (FooException e) {
  assertSomething();
  // For EppExceptions:
  assertAboutEppExceptins().that(e).marshalsToXml();
}

To make this work, I added EppExceptionSubject.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=135793407
2016-10-11 11:27:54 -04:00

127 lines
5 KiB
Java

// Copyright 2016 The Domain Registry Authors. All Rights Reserved.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
package google.registry.xjc;
import static com.google.common.truth.Truth.assertThat;
import static com.google.common.truth.Truth.assertWithMessage;
import static google.registry.util.ResourceUtils.readResourceUtf8;
import static google.registry.xjc.XjcXmlTransformer.unmarshal;
import static java.nio.charset.StandardCharsets.UTF_16;
import static java.nio.charset.StandardCharsets.UTF_8;
import com.google.re2j.Pattern;
import google.registry.testing.ExceptionRule;
import google.registry.xjc.rde.XjcRdeDeposit;
import google.registry.xjc.rde.XjcRdeDepositTypeType;
import google.registry.xjc.rdecontact.XjcRdeContact;
import java.io.ByteArrayInputStream;
import java.io.ByteArrayOutputStream;
import org.junit.Rule;
import org.junit.Test;
import org.junit.runner.RunWith;
import org.junit.runners.JUnit4;
/** Unit tests for {@code XjcObject}. */
@RunWith(JUnit4.class)
public class XjcObjectTest {
@Rule
public final ExceptionRule thrown = new ExceptionRule();
private static final String RDE_DEPOSIT_FULL =
readResourceUtf8(XjcObjectTest.class, "testdata/rde_deposit_full.xml");
@Test
public void testMarshalUtf8() throws Exception {
XjcRdeDeposit deposit = unmarshalFullDeposit();
ByteArrayOutputStream out = new ByteArrayOutputStream();
deposit.marshal(out, UTF_8);
String xml = out.toString(UTF_8.toString());
Pattern pat = Pattern.compile("^<\\?xml version=\"1\\.0\" encoding=\"UTF[-_]?8\"");
assertWithMessage("bad xml declaration: " + xml).that(pat.matcher(xml).find()).isTrue();
assertWithMessage("encode/decode didn't work: " + xml).that(xml).contains("Jane Doe");
}
@Test
public void testMarshalUtf16() throws Exception {
XjcRdeDeposit deposit = unmarshalFullDeposit();
ByteArrayOutputStream out = new ByteArrayOutputStream();
deposit.marshal(out, UTF_16);
String xml = out.toString(UTF_16.toString());
Pattern pat = Pattern.compile("^<\\?xml version=\"1\\.0\" encoding=\"UTF[-_]?16\"");
assertWithMessage(xml).that(pat.matcher(xml).find()).isTrue();
assertWithMessage("encode/decode didn't work: " + xml).that(xml).contains("Jane Doe");
}
@Test
public void testMarshalValidation() throws Exception {
XjcRdeDeposit deposit = unmarshalFullDeposit();
deposit.setId("");
thrown.expect(Throwable.class, "pattern '\\w{1,13}' for type 'depositIdType'");
deposit.marshal(new ByteArrayOutputStream(), UTF_8);
}
@Test
public void testUnmarshalUTF8() throws Exception {
XjcRdeDeposit deposit = unmarshalFullDeposit();
assertThat(deposit).isNotNull();
assertThat(deposit.getType()).isEqualTo(XjcRdeDepositTypeType.FULL);
assertThat(deposit.getRdeMenu().getVersion()).isEqualTo("1.0");
}
@Test
public void testUnmarshalUTF16() throws Exception {
XjcRdeDeposit deposit = unmarshal(XjcRdeDeposit.class, new ByteArrayInputStream(
RDE_DEPOSIT_FULL.replaceFirst("UTF-8", "UTF-16").getBytes(UTF_16)));
assertThat(deposit).isNotNull();
assertThat(deposit.getType()).isEqualTo(XjcRdeDepositTypeType.FULL);
assertThat(deposit.getRdeMenu().getVersion()).isEqualTo("1.0");
}
@Test
public void testUnmarshalValidation() throws Exception {
thrown.expect(Throwable.class, "pattern '\\w{1,13}' for type 'depositIdType'");
unmarshal(XjcRdeDeposit.class, new ByteArrayInputStream(
RDE_DEPOSIT_FULL.replaceFirst("id=\"[^\"]+\"", "id=\"\"").getBytes(UTF_8)));
}
@Test
public void testToString() throws Exception {
String xml = unmarshalFullDeposit().toString();
assertWithMessage(xml).that(xml).startsWith("<rde:deposit ");
assertWithMessage(xml).that(xml.length()).isGreaterThan(1000);
}
@Test
public void testToStringNoValidation() {
String xml = new XjcRdeContact().toString();
assertWithMessage(xml).that(xml).startsWith("<XjcRdeContact ");
}
@Test
public void testNamespaceEpp() throws Exception {
String xml = unmarshal(XjcObject.class, new ByteArrayInputStream(readResourceUtf8(
XjcObjectTest.class, "testdata/greeting.xml").getBytes(UTF_8))).toString();
assertWithMessage(xml).that(xml).startsWith("<epp:epp ");
assertWithMessage(xml).that(xml).contains("\"urn:ietf:params:xml:ns:epp-1.0\"");
assertWithMessage(xml).that(xml).contains("<epp:greeting>");
}
/** Unmarshals XML assuming UTF-8 encoding. */
private static XjcRdeDeposit unmarshalFullDeposit() throws Exception {
return unmarshal(
XjcRdeDeposit.class, new ByteArrayInputStream(RDE_DEPOSIT_FULL.getBytes(UTF_8)));
}
}