zydronium/google-nomulus
1
0
Fork 0
mirror of https://github.com/google/nomulus.git synced 2025-06-19 10:50:49 +02:00
Code Issues Projects Releases Packages Wiki Activity
google-nomulus/javatests/google/registry/testing
History
cgoldfeder f3a0b78145 Move thrown.expect() right before the throwing statement 
aka regexing for fun and profit.

This also makes sure that there are no statements after the
throwing statement, since these would be dead code. There
were a surprising number of places with assertions after
the throw, and none of these are actually triggered in tests
ever. When I found these, I replaced them with try/catch/rethrow
which makes the assertions actually happen:

before:

// This is the ExceptionRule that checks EppException marshaling
thrown.expect(FooException.class);
doThrowingThing();
assertSomething();  // Dead code!

after:

try {
  doThrowingThing();
  assertWithMessage("...").fail();
} catch (FooException e) {
  assertSomething();
  // For EppExceptions:
  assertAboutEppExceptins().that(e).marshalsToXml();
}

To make this work, I added EppExceptionSubject.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=135793407
2016-10-11 11:27:54 -04:00
..
mapreduce Centralize creation of MapreduceRunner in unit tests 2016-10-11 11:27:41 -04:00
sftp Convert entire project to strict lexicographical import sort ordering 2016-07-13 15:59:53 -04:00
AbstractDomainBaseSubject.java Replace Truth's deprecated getSubject() method with actual() 2016-10-07 14:38:31 -04:00
AbstractEppResourceSubject.java Fix more deprecated methods in truth tests 2016-10-07 15:29:49 -04:00
AppEngineRule.java Rename "clientIdentifier" to "clientId" almost everywhere 2016-09-22 14:30:05 -04:00
BouncyCastleProviderRule.java Convert entire project to strict lexicographical import sort ordering 2016-07-13 15:59:53 -04:00
BUILD Add dagger map for injecting DnsWriter implementations 2016-08-05 20:38:21 -04:00
CertificateSamples.java Rename Java packages to use the .google TLD 2016-05-13 20:04:42 -04:00
ContactResourceSubject.java Replace Truth's deprecated getSubject() method with actual() 2016-10-07 14:38:31 -04:00
DatastoreHelper.java Make DatastoreHelper set creation time to START_OF_TIME for contacts 2016-10-03 16:25:55 -04:00
default_premium_list_testdata.csv mv com/google/domain/registry google/registry 2016-05-13 18:55:08 -04:00
DeterministicStringGenerator.java Remove trailing whitespace in files 2016-10-07 15:29:47 -04:00
DomainApplicationSubject.java Replace Truth's deprecated getSubject() method with actual() 2016-10-07 14:38:31 -04:00
DomainResourceSubject.java Replace Truth's deprecated getSubject() method with actual() 2016-10-07 14:38:31 -04:00
EppExceptionSubject.java Move thrown.expect() right before the throwing statement 2016-10-11 11:27:54 -04:00
EppLoader.java Convert entire project to strict lexicographical import sort ordering 2016-07-13 15:59:53 -04:00
ExceptionRule.java Move thrown.expect() right before the throwing statement 2016-10-11 11:27:54 -04:00
FailAnswer.java Rename Java packages to use the .google TLD 2016-05-13 20:04:42 -04:00
FakeClock.java Add a batched [] for DNS refreshing on host renames 2016-10-03 16:11:00 -04:00
FakeHttpSession.java Convert entire project to strict lexicographical import sort ordering 2016-07-13 15:59:53 -04:00
FakeJsonResponse.java Convert entire project to strict lexicographical import sort ordering 2016-07-13 15:59:53 -04:00
FakeResponse.java Convert entire project to strict lexicographical import sort ordering 2016-07-13 15:59:53 -04:00
FakeServletInputStream.java Convert entire project to strict lexicographical import sort ordering 2016-07-13 15:59:53 -04:00
FakeServletOutputStream.java Convert entire project to strict lexicographical import sort ordering 2016-07-13 15:59:53 -04:00
FakeSleeper.java Add a batched [] for DNS refreshing on host renames 2016-10-03 16:11:00 -04:00
FakeURLFetchService.java Convert entire project to strict lexicographical import sort ordering 2016-07-13 15:59:53 -04:00
ForwardingURLFetchService.java Convert entire project to strict lexicographical import sort ordering 2016-07-13 15:59:53 -04:00
FullFieldsTestEntityHelper.java Rename "clientIdentifier" to "clientId" almost everywhere 2016-09-22 14:30:05 -04:00
GcsTestingUtils.java Convert entire project to strict lexicographical import sort ordering 2016-07-13 15:59:53 -04:00
GenericEppResourceSubject.java Convert entire project to strict lexicographical import sort ordering 2016-07-13 15:59:53 -04:00
GpgSystemCommandRule.java Convert entire project to strict lexicographical import sort ordering 2016-07-13 15:59:53 -04:00
HistoryEntrySubject.java Fix more deprecated methods in truth tests 2016-10-07 15:29:49 -04:00
HostResourceSubject.java Convert entire project to strict lexicographical import sort ordering 2016-07-13 15:59:53 -04:00
InjectRule.java Convert entire project to strict lexicographical import sort ordering 2016-07-13 15:59:53 -04:00
IoSpyRule.java Convert entire project to strict lexicographical import sort ordering 2016-07-13 15:59:53 -04:00
logging.properties Rename Java packages to use the .google TLD 2016-05-13 20:04:42 -04:00
LogsSubject.java Replace Truth's deprecated getSubject() method with actual() 2016-10-07 14:38:31 -04:00
package-info.java Rename Java packages to use the .google TLD 2016-05-13 20:04:42 -04:00
Providers.java Upgrade apache_sshd CL #2: Update to v1_2_0 2016-06-27 16:41:48 -04:00
ReflectiveFieldExtractor.java Rename Java packages to use the .google TLD 2016-05-13 20:04:42 -04:00
ReflectiveSubjectFactory.java Convert entire project to strict lexicographical import sort ordering 2016-07-13 15:59:53 -04:00
RegistryConfigRule.java Convert entire project to strict lexicographical import sort ordering 2016-07-13 15:59:53 -04:00
ShardableTestCase.java Tidy up ExpandrecurringBillingEventsAction 2016-07-13 15:58:34 -04:00
SlurpAnswer.java Convert entire project to strict lexicographical import sort ordering 2016-07-13 15:59:53 -04:00
SystemInfo.java Convert entire project to strict lexicographical import sort ordering 2016-07-13 15:59:53 -04:00
SystemPropertyRule.java Convert entire project to strict lexicographical import sort ordering 2016-07-13 15:59:53 -04:00
TaskQueueHelper.java Always use the constructor to make Immutable Collection Builders 2016-10-07 14:37:02 -04:00
TestDataHelper.java Actionize the EPP endpoints. 2016-06-14 16:30:12 -04:00
TestObject.java Convert entire project to strict lexicographical import sort ordering 2016-07-13 15:59:53 -04:00
TruthChainer.java Rename Java packages to use the .google TLD 2016-05-13 20:04:42 -04:00
UriParameters.java Convert entire project to strict lexicographical import sort ordering 2016-07-13 15:59:53 -04:00
UserInfo.java Rename Java packages to use the .google TLD 2016-05-13 20:04:42 -04:00