mirror of
https://github.com/google/nomulus.git
synced 2025-05-03 13:37:51 +02:00
aka regexing for fun and profit. This also makes sure that there are no statements after the throwing statement, since these would be dead code. There were a surprising number of places with assertions after the throw, and none of these are actually triggered in tests ever. When I found these, I replaced them with try/catch/rethrow which makes the assertions actually happen: before: // This is the ExceptionRule that checks EppException marshaling thrown.expect(FooException.class); doThrowingThing(); assertSomething(); // Dead code! after: try { doThrowingThing(); assertWithMessage("...").fail(); } catch (FooException e) { assertSomething(); // For EppExceptions: assertAboutEppExceptins().that(e).marshalsToXml(); } To make this work, I added EppExceptionSubject. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=135793407
223 lines
7.8 KiB
Java
223 lines
7.8 KiB
Java
// Copyright 2016 The Domain Registry Authors. All Rights Reserved.
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package google.registry.flows.poll;
|
|
|
|
import static google.registry.testing.DatastoreHelper.createHistoryEntryForEppResource;
|
|
import static google.registry.testing.DatastoreHelper.createTld;
|
|
import static google.registry.testing.DatastoreHelper.newDomainResource;
|
|
import static google.registry.testing.DatastoreHelper.persistActiveContact;
|
|
import static google.registry.testing.DatastoreHelper.persistResource;
|
|
import static google.registry.util.DateTimeUtils.END_OF_TIME;
|
|
|
|
import google.registry.flows.FlowTestCase;
|
|
import google.registry.flows.poll.PollAckFlow.InvalidMessageIdException;
|
|
import google.registry.flows.poll.PollAckFlow.MessageDoesNotExistException;
|
|
import google.registry.flows.poll.PollAckFlow.MissingMessageIdException;
|
|
import google.registry.flows.poll.PollAckFlow.NotAuthorizedToAckMessageException;
|
|
import google.registry.model.contact.ContactResource;
|
|
import google.registry.model.domain.DomainResource;
|
|
import google.registry.model.poll.PollMessage;
|
|
import google.registry.testing.ExceptionRule;
|
|
import org.joda.time.DateTime;
|
|
import org.junit.Before;
|
|
import org.junit.Rule;
|
|
import org.junit.Test;
|
|
|
|
/** Unit tests for {@link PollAckFlow}. */
|
|
public class PollAckFlowTest extends FlowTestCase<PollAckFlow> {
|
|
|
|
/** This is the message id contained in the "poll_ack.xml" test data file. */
|
|
private static final long MESSAGE_ID = 3;
|
|
|
|
private DomainResource domain;
|
|
private ContactResource contact;
|
|
|
|
@Rule
|
|
public final ExceptionRule thrown = new ExceptionRule();
|
|
|
|
@Before
|
|
public void setUp() {
|
|
setEppInput("poll_ack.xml");
|
|
setClientIdForFlow("NewRegistrar");
|
|
clock.setTo(DateTime.parse("2011-01-02T01:01:01Z"));
|
|
createTld("example");
|
|
clock.advanceOneMilli();
|
|
contact = persistActiveContact("jd1234");
|
|
clock.advanceOneMilli();
|
|
domain = persistResource(newDomainResource("test.example", contact));
|
|
clock.advanceOneMilli();
|
|
}
|
|
|
|
private void persistOneTimePollMessage(long messageId) {
|
|
persistResource(
|
|
new PollMessage.OneTime.Builder()
|
|
.setId(messageId)
|
|
.setClientId(getClientIdForFlow())
|
|
.setEventTime(clock.nowUtc().minusDays(1))
|
|
.setMsg("Some poll message.")
|
|
.setParent(createHistoryEntryForEppResource(domain))
|
|
.build());
|
|
}
|
|
|
|
private void persistAutorenewPollMessage(DateTime eventTime, DateTime endTime) {
|
|
persistResource(
|
|
new PollMessage.Autorenew.Builder()
|
|
.setId(MESSAGE_ID)
|
|
.setClientId(getClientIdForFlow())
|
|
.setEventTime(eventTime)
|
|
.setAutorenewEndTime(endTime)
|
|
.setMsg("Domain was auto-renewed.")
|
|
.setTargetId("example.com")
|
|
.setParent(createHistoryEntryForEppResource(domain))
|
|
.build());
|
|
}
|
|
|
|
@Test
|
|
public void testDryRun() throws Exception {
|
|
persistOneTimePollMessage(MESSAGE_ID);
|
|
dryRunFlowAssertResponse(readFile("poll_ack_response_empty.xml"));
|
|
}
|
|
|
|
@Test
|
|
public void testSuccess_contactPollMessage() throws Exception {
|
|
setEppInput("poll_ack_contact.xml");
|
|
persistResource(
|
|
new PollMessage.OneTime.Builder()
|
|
.setId(MESSAGE_ID)
|
|
.setClientId(getClientIdForFlow())
|
|
.setEventTime(clock.nowUtc().minusDays(1))
|
|
.setMsg("Some poll message.")
|
|
.setParent(createHistoryEntryForEppResource(contact))
|
|
.build());
|
|
assertTransactionalFlow(true);
|
|
runFlowAssertResponse(readFile("poll_ack_response_empty.xml"));
|
|
}
|
|
|
|
@Test
|
|
public void testSuccess_messageOnContactResource() throws Exception {
|
|
persistOneTimePollMessage(MESSAGE_ID);
|
|
assertTransactionalFlow(true);
|
|
runFlowAssertResponse(readFile("poll_ack_response_empty.xml"));
|
|
}
|
|
|
|
@Test
|
|
public void testSuccess_recentActiveAutorenew() throws Exception {
|
|
persistAutorenewPollMessage(clock.nowUtc().minusMonths(6), END_OF_TIME);
|
|
assertTransactionalFlow(true);
|
|
runFlowAssertResponse(readFile("poll_ack_response_empty.xml"));
|
|
}
|
|
|
|
@Test
|
|
public void testSuccess_oldActiveAutorenew() throws Exception {
|
|
persistAutorenewPollMessage(clock.nowUtc().minusYears(2), END_OF_TIME);
|
|
// Create three other messages to be queued for retrieval to get our count right, since the poll
|
|
// ack response wants there to be 4 messages in the queue when the ack comes back.
|
|
for (int i = 1; i < 4; i++) {
|
|
persistOneTimePollMessage(MESSAGE_ID + i);
|
|
}
|
|
assertTransactionalFlow(true);
|
|
runFlowAssertResponse(readFile("poll_ack_response.xml"));
|
|
}
|
|
|
|
@Test
|
|
public void testSuccess_oldInactiveAutorenew() throws Exception {
|
|
persistAutorenewPollMessage(clock.nowUtc().minusMonths(6), clock.nowUtc());
|
|
assertTransactionalFlow(true);
|
|
runFlowAssertResponse(readFile("poll_ack_response_empty.xml"));
|
|
}
|
|
|
|
@Test
|
|
public void testSuccess_moreMessages() throws Exception {
|
|
// Create five messages to be queued for retrieval, one of which will be acked.
|
|
for (int i = 0; i < 5; i++) {
|
|
persistOneTimePollMessage(MESSAGE_ID + i);
|
|
}
|
|
assertTransactionalFlow(true);
|
|
runFlowAssertResponse(readFile("poll_ack_response.xml"));
|
|
}
|
|
|
|
@Test
|
|
public void testFailure_noSuchMessage() throws Exception {
|
|
assertTransactionalFlow(true);
|
|
thrown.expect(
|
|
MessageDoesNotExistException.class,
|
|
String.format("(1-3-EXAMPLE-4-%d)", MESSAGE_ID));
|
|
runFlow();
|
|
}
|
|
|
|
@Test
|
|
public void testFailure_invalidId_wrongNumberOfComponents() throws Exception {
|
|
setEppInput("poll_ack_invalid_id.xml");
|
|
assertTransactionalFlow(true);
|
|
thrown.expect(InvalidMessageIdException.class);
|
|
runFlow();
|
|
}
|
|
|
|
@Test
|
|
public void testFailure_invalidId_stringInsteadOfNumeric() throws Exception {
|
|
setEppInput("poll_ack_invalid_string_id.xml");
|
|
assertTransactionalFlow(true);
|
|
thrown.expect(InvalidMessageIdException.class);
|
|
runFlow();
|
|
}
|
|
|
|
@Test
|
|
public void testFailure_invalidEppResourceClassId() throws Exception {
|
|
setEppInput("poll_ack_invalid_eppresource_id.xml");
|
|
assertTransactionalFlow(true);
|
|
thrown.expect(InvalidMessageIdException.class);
|
|
runFlow();
|
|
}
|
|
|
|
@Test
|
|
public void testFailure_missingId() throws Exception {
|
|
setEppInput("poll_ack_missing_id.xml");
|
|
assertTransactionalFlow(true);
|
|
thrown.expect(MissingMessageIdException.class);
|
|
runFlow();
|
|
}
|
|
|
|
@Test
|
|
public void testFailure_differentRegistrar() throws Exception {
|
|
persistResource(
|
|
new PollMessage.OneTime.Builder()
|
|
.setId(MESSAGE_ID)
|
|
.setClientId("TheRegistrar")
|
|
.setEventTime(clock.nowUtc().minusDays(1))
|
|
.setMsg("Some poll message.")
|
|
.setParent(createHistoryEntryForEppResource(domain))
|
|
.build());
|
|
assertTransactionalFlow(true);
|
|
thrown.expect(NotAuthorizedToAckMessageException.class);
|
|
runFlow();
|
|
}
|
|
|
|
@Test
|
|
public void testFailure_messageInFuture() throws Exception {
|
|
persistResource(
|
|
new PollMessage.OneTime.Builder()
|
|
.setId(MESSAGE_ID)
|
|
.setClientId(getClientIdForFlow())
|
|
.setEventTime(clock.nowUtc().plusDays(1))
|
|
.setMsg("Some poll message.")
|
|
.setParent(createHistoryEntryForEppResource(domain))
|
|
.build());
|
|
assertTransactionalFlow(true);
|
|
thrown.expect(
|
|
MessageDoesNotExistException.class,
|
|
String.format("(1-3-EXAMPLE-4-%d)", MESSAGE_ID));
|
|
runFlow();
|
|
}
|
|
}
|