google-nomulus/javatests/google/registry/testing/DomainApplicationSubject.java
glorioso 08b068b7bf Remove unnecessary Objects.equals() call on collections
This fixes a bug where collections of incompatible types are being tested for equality to each other (e.g.: Set<Foo> equals Set<Integer> should never return true unless both sets are empty, a bit of a vacuous assertion).

This change is necessary to unblock future improvements to the static analysis capabilities of the java compiler.
Tested:
    TAP --sample for global presubmit queue
    []

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=178798071
2017-12-13 12:43:45 -05:00

84 lines
3.2 KiB
Java

// Copyright 2017 The Nomulus Authors. All Rights Reserved.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
package google.registry.testing;
import static com.google.common.base.Preconditions.checkNotNull;
import static com.google.common.truth.Truth.assertAbout;
import static com.google.common.truth.Truth.assertThat;
import com.google.common.truth.FailureMetadata;
import com.google.common.truth.SimpleSubjectBuilder;
import google.registry.model.domain.DomainApplication;
import google.registry.model.domain.Period;
import google.registry.model.domain.launch.ApplicationStatus;
import google.registry.model.smd.EncodedSignedMark;
import google.registry.testing.TruthChainer.And;
import java.util.Objects;
/** Truth subject for asserting things about {@link DomainApplication} instances. */
public final class DomainApplicationSubject
extends AbstractDomainBaseSubject<DomainApplication, DomainApplicationSubject> {
public And<DomainApplicationSubject> hasPeriodYears(int years) {
assertThat(actual().getPeriod()).isNotNull();
assertThat(actual().getPeriod().getUnit()).isEqualTo(Period.Unit.YEARS);
assertThat(actual().getPeriod().getValue()).isEqualTo(years);
return andChainer();
}
public And<DomainApplicationSubject> hasApplicationStatus(
ApplicationStatus applicationStatus) {
if (!Objects.equals(actual().getApplicationStatus(), applicationStatus)) {
failWithBadResults(
"has application status", applicationStatus, actual().getApplicationStatus());
}
return andChainer();
}
public And<DomainApplicationSubject> doesNotHaveApplicationStatus(
ApplicationStatus applicationStatus) {
return doesNotHaveValue(
applicationStatus,
actual().getApplicationStatus(),
"application status");
}
public And<DomainApplicationSubject> hasExactlyEncodedSignedMarks(
EncodedSignedMark... encodedSignedMarks) {
assertThat(actual().getEncodedSignedMarks())
.named("the encoded signed marks of " + actualAsString())
.containsExactly((Object[]) encodedSignedMarks);
return andChainer();
}
public And<DomainApplicationSubject> hasNumEncodedSignedMarks(int num) {
if (actual().getEncodedSignedMarks().size() != num) {
failWithBadResults(
"has this many encoded signed marks: ", num, actual().getEncodedSignedMarks().size());
}
return andChainer();
}
public DomainApplicationSubject(FailureMetadata failureMetadata, DomainApplication subject) {
super(failureMetadata, checkNotNull(subject));
}
public static SimpleSubjectBuilder<DomainApplicationSubject, DomainApplication>
assertAboutApplications() {
return assertAbout(DomainApplicationSubject::new);
}
}