mirror of
https://github.com/google/nomulus.git
synced 2025-05-04 14:07:51 +02:00
This change required several things: - Separating out the interfaces that merely do HTTP calls to the backend from those that require the remote API (only load the remote API for the latter). Only the tools service provides the remote api endpoint. - Removing the XSRF token as an authentication mechanism (with OAUTH, we no longer need this, and trying to provide it requires initialization of the datastore code which requires the remote API) I can't think of a compelling unit test for this beyond what already exists. Tested: Verified that: - nomulus tool commands (e.g. "list_tlds") work against the tools service as they currently do - The "curl" command hits endpoints on "tools" by default. - We can use --server to specify endpoints on the default service. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=211510454
120 lines
4.4 KiB
Java
120 lines
4.4 KiB
Java
// Copyright 2017 The Nomulus Authors. All Rights Reserved.
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package google.registry.tools;
|
|
|
|
import static com.google.common.truth.Truth.assertThat;
|
|
import static google.registry.request.JsonResponse.JSON_SAFETY_PREFIX;
|
|
import static google.registry.testing.JUnitBackports.assertThrows;
|
|
import static google.registry.testing.TestDataHelper.loadFile;
|
|
import static org.mockito.Matchers.any;
|
|
import static org.mockito.Matchers.anyMapOf;
|
|
import static org.mockito.Matchers.eq;
|
|
import static org.mockito.Mockito.reset;
|
|
import static org.mockito.Mockito.when;
|
|
|
|
import com.beust.jcommander.ParameterException;
|
|
import com.google.common.base.VerifyException;
|
|
import com.google.common.collect.ImmutableMap;
|
|
import com.google.common.net.MediaType;
|
|
import google.registry.tools.CommandWithConnection.Connection;
|
|
import google.registry.tools.server.CreatePremiumListAction;
|
|
import org.junit.Before;
|
|
import org.junit.Test;
|
|
import org.mockito.Mock;
|
|
|
|
/** Unit tests for {@link CreatePremiumListCommand}. */
|
|
public class CreatePremiumListCommandTest<C extends CreatePremiumListCommand>
|
|
extends CreateOrUpdatePremiumListCommandTestCase<C> {
|
|
|
|
@Mock
|
|
Connection connection;
|
|
|
|
String premiumTermsPath;
|
|
String premiumTermsCsv;
|
|
String servletPath;
|
|
|
|
@Before
|
|
public void init() throws Exception {
|
|
command.setConnection(connection);
|
|
premiumTermsPath =
|
|
writeToNamedTmpFile(
|
|
"example_premium_terms.csv",
|
|
loadFile(CreatePremiumListCommandTest.class, "example_premium_terms.csv"));
|
|
servletPath = "/_dr/admin/createPremiumList";
|
|
when(connection.send(
|
|
eq(CreatePremiumListAction.PATH),
|
|
anyMapOf(String.class, String.class),
|
|
any(MediaType.class),
|
|
any(byte[].class)))
|
|
.thenReturn(JSON_SAFETY_PREFIX + "{\"status\":\"success\",\"lines\":[]}");
|
|
}
|
|
|
|
@Test
|
|
public void testRun() throws Exception {
|
|
runCommandForced("-i=" + premiumTermsPath, "-n=foo");
|
|
assertInStdout("Successfully");
|
|
verifySentParams(
|
|
connection,
|
|
servletPath,
|
|
ImmutableMap.of("name", "foo", "inputData", generateInputData(premiumTermsPath)));
|
|
}
|
|
|
|
@Test
|
|
public void testRun_noProvidedName_usesBasenameOfInputFile() throws Exception {
|
|
runCommandForced("-i=" + premiumTermsPath);
|
|
assertInStdout("Successfully");
|
|
verifySentParams(
|
|
connection,
|
|
servletPath,
|
|
ImmutableMap.of(
|
|
"name", "example_premium_terms", "inputData", generateInputData(premiumTermsPath)));
|
|
}
|
|
|
|
@Test
|
|
public void testRun_errorResponse() throws Exception {
|
|
reset(connection);
|
|
command.setConnection(connection);
|
|
when(connection.send(
|
|
eq(CreatePremiumListAction.PATH),
|
|
anyMapOf(String.class, String.class),
|
|
any(MediaType.class),
|
|
any(byte[].class)))
|
|
.thenReturn(
|
|
JSON_SAFETY_PREFIX + "{\"status\":\"error\",\"error\":\"foo already exists\"}");
|
|
VerifyException thrown =
|
|
assertThrows(
|
|
VerifyException.class, () -> runCommandForced("-i=" + premiumTermsPath, "-n=foo"));
|
|
assertThat(thrown).hasMessageThat().contains("Server error:");
|
|
}
|
|
|
|
@Test
|
|
public void testRun_noInputFileSpecified_throwsException() {
|
|
ParameterException thrown = assertThrows(ParameterException.class, this::runCommand);
|
|
assertThat(thrown).hasMessageThat().contains("The following option is required");
|
|
}
|
|
|
|
@Test
|
|
public void testRun_invalidInputData() throws Exception {
|
|
premiumTermsPath =
|
|
writeToNamedTmpFile(
|
|
"tmp_file2",
|
|
loadFile(CreatePremiumListCommandTest.class, "example_invalid_premium_terms.csv"));
|
|
IllegalArgumentException thrown =
|
|
assertThrows(
|
|
IllegalArgumentException.class,
|
|
() -> runCommandForced("-i=" + premiumTermsPath, "-n=foo"));
|
|
assertThat(thrown).hasMessageThat().contains("Could not parse line in premium list");
|
|
}
|
|
}
|