google-nomulus/javatests/google/registry
shicong e382299212 Resolve carry-over state issue in TestServerRule
The TestServerRule object is shared between retries in the same test,
so the testServer object constructed in TestServerRule's constructor
will be shared as well. This should be the reason why the test retry
carries over some state. (The log in the test proves that the
testServer object is shared because it listens to the same port in
all retries, which should not happen if its constructor is invoked
every time. You can find multiple "TestServerRule is listening on:
[]in this test
[]

So, this CL delayed the construction to rule.before() method which is
invoked before every retry.(You can see each retry has a test server
listening to different port and the error is "It differed by <16> pixels."
for all attempts instead of not clickable button []

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=246904446
2019-05-13 12:29:53 -04:00
..
backup Allow third_party/java_src/gtld/ to use :mockito2_for_third_party 2019-03-20 14:25:28 -04:00
batch Replace deprecated Mockito Matchers class 2019-05-06 16:21:27 -04:00
beam Replace deprecated Mockito Matchers class 2019-05-06 16:21:27 -04:00
bigquery Replace deprecated Mockito Matchers class 2019-05-06 16:21:27 -04:00
builddefs Fix .bzl files with buildifier 2019-02-25 11:13:08 -05:00
config Configure client id and client secret in the config file 2018-12-05 16:04:08 -05:00
cron Clean up third_party imports in BUILD files 2018-07-14 01:11:51 -04:00
dns Replace deprecated Mockito Matchers class 2019-05-06 16:21:27 -04:00
documentation Fix some statically detected code issues 2019-04-22 12:54:34 -04:00
export Migrate from containsAllIn to containsAtLeastElementsIn 2019-05-06 16:44:06 -04:00
flows Validate on-load that an AllocationToken can be used 2019-05-06 16:54:55 -04:00
groups Replace deprecated Mockito Matchers class 2019-05-06 16:21:27 -04:00
keyring Migrate from is(Not)SameAs to is(Not)SameInstanceAs. 2019-05-06 16:42:30 -04:00
mapreduce/inputs Merge DomainResource into DomainBase 2019-01-28 15:57:10 -05:00
model Fix Bazel build error 2019-05-06 17:00:03 -04:00
module Allow third_party/java_src/gtld/ to use :mockito2_for_third_party 2019-03-20 14:25:28 -04:00
monitoring/whitebox Allow third_party/java_src/gtld/ to use :mockito2_for_third_party 2019-03-20 14:25:28 -04:00
pricing Clean up third_party imports in BUILD files 2018-07-14 01:11:51 -04:00
proxy Replace deprecated Mockito Matchers class 2019-05-06 16:21:27 -04:00
rdap Add Jsonable and AbstractJsonableObject for easier RDAP object building 2019-05-06 16:27:59 -04:00
rde Migrate from containsAllOf to containsAtLeast 2019-05-06 16:53:03 -04:00
reporting Replace deprecated Mockito Matchers class 2019-05-06 16:21:27 -04:00
request Migrate from containsAllOf to containsAtLeast 2019-05-06 16:53:03 -04:00
security Allow third_party/java_src/gtld/ to use :mockito2_for_third_party 2019-03-20 14:25:28 -04:00
server Fix Kokoro build 2019-04-05 11:56:24 -04:00
storage/drive Replace deprecated Mockito Matchers class 2019-05-06 16:21:27 -04:00
testing Migrate Truth Subjects from no-arg check() to use description 2019-05-06 16:49:01 -04:00
tldconfig/idn Remove the use of InjectRule in IdnLabelValidatorTest 2018-10-22 18:54:53 -04:00
tmch Replace deprecated Mockito Matchers class 2019-05-06 16:21:27 -04:00
tools Add a command to update allocation tokens 2019-05-06 16:56:33 -04:00
ui Replace deprecated Mockito Matchers class 2019-05-06 16:21:27 -04:00
util Migrate from is(Not)SameAs to is(Not)SameInstanceAs. 2019-05-06 16:42:30 -04:00
webdriver Resolve carry-over state issue in TestServerRule 2019-05-13 12:29:53 -04:00
whois Replace deprecated Mockito Matchers class 2019-05-06 16:21:27 -04:00
xjc Clean up internal imports in BUILD files 2018-07-14 01:37:03 -04:00
xml Fix some issues caught by IntelliJ static code analysis 2019-01-28 16:08:24 -05:00