mirror of
https://github.com/google/nomulus.git
synced 2025-06-09 14:04:45 +02:00
This eliminates the use of Objectify polymorphism for EPP resources entirely (yay!), which makes the Registry 3.0 database migration easier. It is unfortunate that the naming parallelism of EppResources is lost between ContactResource, HostResource, and DomainResource, but the actual type as far as Datastore was concerned was DomainBase all along, and it would be a much more substantial data migration to allow us to continue using the class name DomainResource now that we're no longer using Objectify polymorphism. This simply isn't worth it. This also removes the polymorphic Datastore indexes (which will no longer function as of this change). The non-polymorphic replacement indexes were added in [] ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=230930546
413 lines
17 KiB
Java
413 lines
17 KiB
Java
// Copyright 2017 The Nomulus Authors. All Rights Reserved.
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package google.registry.flows.domain;
|
|
|
|
import static com.google.common.truth.Truth.assertThat;
|
|
import static google.registry.model.reporting.DomainTransactionRecord.TransactionReportField.RESTORED_DOMAINS;
|
|
import static google.registry.model.reporting.DomainTransactionRecord.TransactionReportField.TRANSFER_SUCCESSFUL;
|
|
import static google.registry.model.reporting.HistoryEntry.Type.DOMAIN_CREATE;
|
|
import static google.registry.model.reporting.HistoryEntry.Type.DOMAIN_TRANSFER_CANCEL;
|
|
import static google.registry.model.reporting.HistoryEntry.Type.DOMAIN_TRANSFER_REQUEST;
|
|
import static google.registry.testing.DatastoreHelper.assertBillingEvents;
|
|
import static google.registry.testing.DatastoreHelper.createPollMessageForImplicitTransfer;
|
|
import static google.registry.testing.DatastoreHelper.deleteResource;
|
|
import static google.registry.testing.DatastoreHelper.getOnlyHistoryEntryOfType;
|
|
import static google.registry.testing.DatastoreHelper.getPollMessages;
|
|
import static google.registry.testing.DatastoreHelper.loadRegistrar;
|
|
import static google.registry.testing.DatastoreHelper.persistResource;
|
|
import static google.registry.testing.DomainBaseSubject.assertAboutDomains;
|
|
import static google.registry.testing.EppExceptionSubject.assertAboutEppExceptions;
|
|
import static google.registry.testing.HistoryEntrySubject.assertAboutHistoryEntries;
|
|
import static google.registry.testing.JUnitBackports.assertThrows;
|
|
import static google.registry.util.DateTimeUtils.END_OF_TIME;
|
|
|
|
import com.google.common.collect.ImmutableList;
|
|
import com.google.common.collect.ImmutableSet;
|
|
import google.registry.flows.EppException;
|
|
import google.registry.flows.ResourceFlowUtils.BadAuthInfoForResourceException;
|
|
import google.registry.flows.ResourceFlowUtils.ResourceDoesNotExistException;
|
|
import google.registry.flows.domain.DomainFlowUtils.NotAuthorizedForTldException;
|
|
import google.registry.flows.exceptions.NotPendingTransferException;
|
|
import google.registry.flows.exceptions.NotTransferInitiatorException;
|
|
import google.registry.model.contact.ContactAuthInfo;
|
|
import google.registry.model.domain.DomainAuthInfo;
|
|
import google.registry.model.domain.DomainBase;
|
|
import google.registry.model.domain.GracePeriod;
|
|
import google.registry.model.eppcommon.AuthInfo.PasswordAuth;
|
|
import google.registry.model.poll.PollMessage;
|
|
import google.registry.model.registry.Registry;
|
|
import google.registry.model.reporting.DomainTransactionRecord;
|
|
import google.registry.model.reporting.HistoryEntry;
|
|
import google.registry.model.transfer.TransferData;
|
|
import google.registry.model.transfer.TransferResponse.DomainTransferResponse;
|
|
import google.registry.model.transfer.TransferStatus;
|
|
import org.joda.time.DateTime;
|
|
import org.joda.time.Duration;
|
|
import org.junit.Before;
|
|
import org.junit.Test;
|
|
|
|
/** Unit tests for {@link DomainTransferCancelFlow}. */
|
|
public class DomainTransferCancelFlowTest
|
|
extends DomainTransferFlowTestCase<DomainTransferCancelFlow, DomainBase> {
|
|
|
|
@Before
|
|
public void setUp() {
|
|
setEppInput("domain_transfer_cancel.xml");
|
|
setClientIdForFlow("NewRegistrar");
|
|
setupDomainWithPendingTransfer("example", "tld");
|
|
}
|
|
|
|
private void doSuccessfulTest(String commandFilename, String expectedXmlFilename)
|
|
throws Exception {
|
|
setEppInput(commandFilename);
|
|
|
|
// Replace the ROID in the xml file with the one generated in our test.
|
|
eppLoader.replaceAll("JD1234-REP", contact.getRepoId());
|
|
// Make sure the implicit billing event is there; it will be deleted by the flow.
|
|
// We also expect to see autorenew events for the gaining and losing registrars.
|
|
assertBillingEvents(
|
|
getBillingEventForImplicitTransfer(),
|
|
getGainingClientAutorenewEvent(),
|
|
getLosingClientAutorenewEvent());
|
|
// We should see poll messages for the implicit ack case going to both registrars, and an
|
|
// autorenew poll message for the new registrar.
|
|
HistoryEntry historyEntryDomainTransferRequest =
|
|
getOnlyHistoryEntryOfType(domain, HistoryEntry.Type.DOMAIN_TRANSFER_REQUEST);
|
|
assertPollMessages(
|
|
"NewRegistrar",
|
|
new PollMessage.Autorenew.Builder()
|
|
.setTargetId(getUniqueIdFromCommand())
|
|
.setClientId("NewRegistrar")
|
|
.setEventTime(EXTENDED_REGISTRATION_EXPIRATION_TIME)
|
|
.setAutorenewEndTime(END_OF_TIME)
|
|
.setMsg("Domain was auto-renewed.")
|
|
.setParent(historyEntryDomainTransferRequest)
|
|
.build(),
|
|
createPollMessageForImplicitTransfer(
|
|
domain,
|
|
historyEntryDomainTransferRequest,
|
|
"NewRegistrar",
|
|
TRANSFER_REQUEST_TIME,
|
|
TRANSFER_EXPIRATION_TIME,
|
|
TRANSFER_REQUEST_TIME,
|
|
EXTENDED_REGISTRATION_EXPIRATION_TIME));
|
|
assertPollMessages(
|
|
"TheRegistrar",
|
|
createPollMessageForImplicitTransfer(
|
|
domain,
|
|
historyEntryDomainTransferRequest,
|
|
"TheRegistrar",
|
|
TRANSFER_REQUEST_TIME,
|
|
TRANSFER_EXPIRATION_TIME,
|
|
TRANSFER_REQUEST_TIME,
|
|
EXTENDED_REGISTRATION_EXPIRATION_TIME));
|
|
clock.advanceOneMilli();
|
|
|
|
// Setup done; run the test.
|
|
assertTransactionalFlow(true);
|
|
DateTime originalExpirationTime = domain.getRegistrationExpirationTime();
|
|
ImmutableSet<GracePeriod> originalGracePeriods = domain.getGracePeriods();
|
|
TransferData originalTransferData = domain.getTransferData();
|
|
runFlowAssertResponse(loadFile(expectedXmlFilename));
|
|
|
|
// Transfer should have been cancelled. Verify correct fields were set.
|
|
domain = reloadResourceByForeignKey();
|
|
assertTransferFailed(domain, TransferStatus.CLIENT_CANCELLED, originalTransferData);
|
|
assertAboutDomains()
|
|
.that(domain)
|
|
.hasRegistrationExpirationTime(originalExpirationTime)
|
|
.and()
|
|
.hasLastTransferTimeNotEqualTo(clock.nowUtc());
|
|
assertAboutDomains()
|
|
.that(domain)
|
|
.hasOneHistoryEntryEachOfTypes(
|
|
DOMAIN_CREATE, DOMAIN_TRANSFER_REQUEST, DOMAIN_TRANSFER_CANCEL)
|
|
.and()
|
|
.hasLastEppUpdateTime(clock.nowUtc())
|
|
.and()
|
|
.hasLastEppUpdateClientId("NewRegistrar");
|
|
final HistoryEntry historyEntryTransferCancel =
|
|
getOnlyHistoryEntryOfType(domain, DOMAIN_TRANSFER_CANCEL);
|
|
assertAboutHistoryEntries()
|
|
.that(historyEntryTransferCancel)
|
|
.hasClientId("NewRegistrar")
|
|
.and()
|
|
.hasOtherClientId("TheRegistrar");
|
|
// The only billing event left should be the original autorenew event, now reopened.
|
|
assertBillingEvents(
|
|
getLosingClientAutorenewEvent().asBuilder().setRecurrenceEndTime(END_OF_TIME).build());
|
|
// The poll message (in the future) to the gaining registrar for implicit ack should be gone.
|
|
assertThat(getPollMessages("NewRegistrar", clock.nowUtc().plusMonths(1))).isEmpty();
|
|
// The poll message in the future to the losing registrar should be gone too, but there should
|
|
// be two at the current time to the losing registrar - one for the original autorenew event,
|
|
// and another for the transfer being cancelled.
|
|
assertPollMessages(
|
|
"TheRegistrar",
|
|
new PollMessage.Autorenew.Builder()
|
|
.setTargetId(getUniqueIdFromCommand())
|
|
.setClientId("TheRegistrar")
|
|
.setEventTime(originalExpirationTime)
|
|
.setAutorenewEndTime(END_OF_TIME)
|
|
.setMsg("Domain was auto-renewed.")
|
|
.setParent(getOnlyHistoryEntryOfType(domain, DOMAIN_CREATE))
|
|
.build(),
|
|
new PollMessage.OneTime.Builder()
|
|
.setClientId("TheRegistrar")
|
|
.setEventTime(clock.nowUtc())
|
|
.setResponseData(
|
|
ImmutableList.of(
|
|
new DomainTransferResponse.Builder()
|
|
.setFullyQualifiedDomainName(getUniqueIdFromCommand())
|
|
.setTransferStatus(TransferStatus.CLIENT_CANCELLED)
|
|
.setTransferRequestTime(TRANSFER_REQUEST_TIME)
|
|
.setGainingClientId("NewRegistrar")
|
|
.setLosingClientId("TheRegistrar")
|
|
.setPendingTransferExpirationTime(clock.nowUtc())
|
|
.build()))
|
|
.setMsg("Transfer cancelled.")
|
|
.setParent(getOnlyHistoryEntryOfType(domain, DOMAIN_TRANSFER_CANCEL))
|
|
.build());
|
|
|
|
// The original grace periods should remain untouched.
|
|
assertThat(domain.getGracePeriods()).containsExactlyElementsIn(originalGracePeriods);
|
|
}
|
|
|
|
private void doFailingTest(String commandFilename) throws Exception {
|
|
setEppInput(commandFilename);
|
|
// Replace the ROID in the xml file with the one generated in our test.
|
|
eppLoader.replaceAll("JD1234-REP", contact.getRepoId());
|
|
// Setup done; run the test.
|
|
assertTransactionalFlow(true);
|
|
runFlow();
|
|
}
|
|
|
|
@Test
|
|
public void testDryRun() throws Exception {
|
|
setEppInput("domain_transfer_cancel.xml");
|
|
eppLoader.replaceAll("JD1234-REP", contact.getRepoId());
|
|
dryRunFlowAssertResponse(loadFile("domain_transfer_cancel_response.xml"));
|
|
}
|
|
|
|
@Test
|
|
public void testSuccess() throws Exception {
|
|
doSuccessfulTest("domain_transfer_cancel.xml", "domain_transfer_cancel_response.xml");
|
|
}
|
|
|
|
@Test
|
|
public void testSuccess_domainAuthInfo() throws Exception {
|
|
doSuccessfulTest(
|
|
"domain_transfer_cancel_domain_authinfo.xml", "domain_transfer_cancel_response.xml");
|
|
}
|
|
|
|
@Test
|
|
public void testSuccess_contactAuthInfo() throws Exception {
|
|
doSuccessfulTest(
|
|
"domain_transfer_cancel_contact_authinfo.xml", "domain_transfer_cancel_response.xml");
|
|
}
|
|
|
|
@Test
|
|
public void testFailure_badContactPassword() {
|
|
// Change the contact's password so it does not match the password in the file.
|
|
contact =
|
|
persistResource(
|
|
contact
|
|
.asBuilder()
|
|
.setAuthInfo(ContactAuthInfo.create(PasswordAuth.create("badpassword")))
|
|
.build());
|
|
EppException thrown =
|
|
assertThrows(
|
|
BadAuthInfoForResourceException.class,
|
|
() -> doFailingTest("domain_transfer_cancel_contact_authinfo.xml"));
|
|
assertAboutEppExceptions().that(thrown).marshalsToXml();
|
|
}
|
|
|
|
@Test
|
|
public void testFailure_badDomainPassword() {
|
|
// Change the domain's password so it does not match the password in the file.
|
|
domain =
|
|
persistResource(
|
|
domain
|
|
.asBuilder()
|
|
.setAuthInfo(DomainAuthInfo.create(PasswordAuth.create("badpassword")))
|
|
.build());
|
|
EppException thrown =
|
|
assertThrows(
|
|
BadAuthInfoForResourceException.class,
|
|
() -> doFailingTest("domain_transfer_cancel_domain_authinfo.xml"));
|
|
assertAboutEppExceptions().that(thrown).marshalsToXml();
|
|
}
|
|
|
|
@Test
|
|
public void testFailure_neverBeenTransferred() {
|
|
changeTransferStatus(null);
|
|
EppException thrown =
|
|
assertThrows(
|
|
NotPendingTransferException.class, () -> doFailingTest("domain_transfer_cancel.xml"));
|
|
assertAboutEppExceptions().that(thrown).marshalsToXml();
|
|
}
|
|
|
|
@Test
|
|
public void testFailure_clientApproved() {
|
|
changeTransferStatus(TransferStatus.CLIENT_APPROVED);
|
|
EppException thrown =
|
|
assertThrows(
|
|
NotPendingTransferException.class, () -> doFailingTest("domain_transfer_cancel.xml"));
|
|
assertAboutEppExceptions().that(thrown).marshalsToXml();
|
|
}
|
|
|
|
@Test
|
|
public void testFailure_clientRejected() {
|
|
changeTransferStatus(TransferStatus.CLIENT_REJECTED);
|
|
EppException thrown =
|
|
assertThrows(
|
|
NotPendingTransferException.class, () -> doFailingTest("domain_transfer_cancel.xml"));
|
|
assertAboutEppExceptions().that(thrown).marshalsToXml();
|
|
}
|
|
|
|
@Test
|
|
public void testFailure_clientCancelled() {
|
|
changeTransferStatus(TransferStatus.CLIENT_CANCELLED);
|
|
EppException thrown =
|
|
assertThrows(
|
|
NotPendingTransferException.class, () -> doFailingTest("domain_transfer_cancel.xml"));
|
|
assertAboutEppExceptions().that(thrown).marshalsToXml();
|
|
}
|
|
|
|
@Test
|
|
public void testFailure_serverApproved() {
|
|
changeTransferStatus(TransferStatus.SERVER_APPROVED);
|
|
EppException thrown =
|
|
assertThrows(
|
|
NotPendingTransferException.class, () -> doFailingTest("domain_transfer_cancel.xml"));
|
|
assertAboutEppExceptions().that(thrown).marshalsToXml();
|
|
}
|
|
|
|
@Test
|
|
public void testFailure_serverCancelled() {
|
|
changeTransferStatus(TransferStatus.SERVER_CANCELLED);
|
|
EppException thrown =
|
|
assertThrows(
|
|
NotPendingTransferException.class, () -> doFailingTest("domain_transfer_cancel.xml"));
|
|
assertAboutEppExceptions().that(thrown).marshalsToXml();
|
|
}
|
|
|
|
@Test
|
|
public void testFailure_sponsoringClient() {
|
|
setClientIdForFlow("TheRegistrar");
|
|
EppException thrown =
|
|
assertThrows(
|
|
NotTransferInitiatorException.class, () -> doFailingTest("domain_transfer_cancel.xml"));
|
|
assertAboutEppExceptions().that(thrown).marshalsToXml();
|
|
}
|
|
|
|
@Test
|
|
public void testFailure_unrelatedClient() {
|
|
setClientIdForFlow("ClientZ");
|
|
EppException thrown =
|
|
assertThrows(
|
|
NotTransferInitiatorException.class, () -> doFailingTest("domain_transfer_cancel.xml"));
|
|
assertAboutEppExceptions().that(thrown).marshalsToXml();
|
|
}
|
|
|
|
@Test
|
|
public void testFailure_deletedDomain() throws Exception {
|
|
domain =
|
|
persistResource(domain.asBuilder().setDeletionTime(clock.nowUtc().minusDays(1)).build());
|
|
ResourceDoesNotExistException thrown =
|
|
assertThrows(
|
|
ResourceDoesNotExistException.class, () -> doFailingTest("domain_transfer_cancel.xml"));
|
|
assertThat(thrown).hasMessageThat().contains(String.format("(%s)", getUniqueIdFromCommand()));
|
|
}
|
|
|
|
@Test
|
|
public void testFailure_nonexistentDomain() throws Exception {
|
|
deleteResource(domain);
|
|
ResourceDoesNotExistException thrown =
|
|
assertThrows(
|
|
ResourceDoesNotExistException.class, () -> doFailingTest("domain_transfer_cancel.xml"));
|
|
assertThat(thrown).hasMessageThat().contains(String.format("(%s)", getUniqueIdFromCommand()));
|
|
}
|
|
|
|
@Test
|
|
public void testFailure_notAuthorizedForTld() {
|
|
persistResource(
|
|
loadRegistrar("NewRegistrar").asBuilder().setAllowedTlds(ImmutableSet.of()).build());
|
|
EppException thrown =
|
|
assertThrows(
|
|
NotAuthorizedForTldException.class,
|
|
() ->
|
|
doSuccessfulTest(
|
|
"domain_transfer_cancel.xml", "domain_transfer_cancel_response.xml"));
|
|
assertAboutEppExceptions().that(thrown).marshalsToXml();
|
|
}
|
|
|
|
@Test
|
|
public void testSuccess_superuserNotAuthorizedForTld() throws Exception {
|
|
persistResource(
|
|
loadRegistrar("NewRegistrar").asBuilder().setAllowedTlds(ImmutableSet.of()).build());
|
|
clock.advanceOneMilli();
|
|
runFlowAssertResponse(
|
|
CommitMode.LIVE, UserPrivileges.SUPERUSER, loadFile("domain_transfer_cancel_response.xml"));
|
|
}
|
|
|
|
// NB: No need to test pending delete status since pending transfers will get cancelled upon
|
|
// entering pending delete phase. So it's already handled in that test case.
|
|
|
|
@Test
|
|
public void testIcannActivityReportField_getsLogged() throws Exception {
|
|
clock.advanceOneMilli();
|
|
runFlow();
|
|
assertIcannReportingActivityFieldLogged("srs-dom-transfer-cancel");
|
|
assertTldsFieldLogged("tld");
|
|
}
|
|
|
|
@Test
|
|
public void testIcannTransactionRecord_noRecordsToCancel() throws Exception {
|
|
clock.advanceOneMilli();
|
|
runFlow();
|
|
HistoryEntry persistedEntry = getOnlyHistoryEntryOfType(domain, DOMAIN_TRANSFER_CANCEL);
|
|
// No cancellation records should be produced
|
|
assertThat(persistedEntry.getDomainTransactionRecords()).isEmpty();
|
|
}
|
|
|
|
@Test
|
|
public void testIcannTransactionRecord_cancelsPreviousRecords() throws Exception {
|
|
clock.advanceOneMilli();
|
|
persistResource(
|
|
Registry.get("tld")
|
|
.asBuilder()
|
|
.setAutomaticTransferLength(Duration.standardDays(2))
|
|
.setTransferGracePeriodLength(Duration.standardDays(3))
|
|
.build());
|
|
DomainTransactionRecord previousSuccessRecord =
|
|
DomainTransactionRecord.create("tld", clock.nowUtc().plusDays(1), TRANSFER_SUCCESSFUL, 1);
|
|
// We only want to cancel TRANSFER_SUCCESSFUL records
|
|
DomainTransactionRecord notCancellableRecord =
|
|
DomainTransactionRecord.create("tld", clock.nowUtc().plusDays(1), RESTORED_DOMAINS, 5);
|
|
persistResource(
|
|
new HistoryEntry.Builder()
|
|
.setType(DOMAIN_TRANSFER_REQUEST)
|
|
.setParent(domain)
|
|
.setModificationTime(clock.nowUtc().minusDays(4))
|
|
.setDomainTransactionRecords(
|
|
ImmutableSet.of(previousSuccessRecord, notCancellableRecord))
|
|
.build());
|
|
runFlow();
|
|
HistoryEntry persistedEntry = getOnlyHistoryEntryOfType(domain, DOMAIN_TRANSFER_CANCEL);
|
|
// We should only produce a cancellation record for the original transfer success
|
|
assertThat(persistedEntry.getDomainTransactionRecords())
|
|
.containsExactly(previousSuccessRecord.asBuilder().setReportAmount(-1).build());
|
|
}
|
|
}
|