mirror of
https://github.com/google/nomulus.git
synced 2025-08-03 16:32:11 +02:00
dc88b48772
* Disallow admin triggering of internal endpoints
Stop simply relying on the presence of the X-AppEngine-QueueName as an
indicator that an endpoint has been triggered internally, as this allows
admins to trigger a remote execution vulnerability.
We now supplement this check by ensuring that there is no authenticated user.
Since only an admin user can set these headers, this means that the header
must have been set by an internal request.
Tested:
In addition to the new unit test, verified on Crash that:
- Internal requests are still getting authenticated via the internal auth
mechanism.
- Admin requests with the X-AppEngine-QueueName header are rejected as
"unauthorized."
* Reformatted.
|
||
|---|---|---|
| .. | ||
| gradle/dependency-locks | ||
| src | ||
| WEB-INF/appengine-generated | ||
| build.gradle | ||
| Dockerfile | ||
| karma.conf.js | ||