mirror of
https://github.com/google/nomulus.git
synced 2025-05-29 08:50:09 +02:00
e2528875b2
This eliminates the use of Objectify polymorphism for EPP resources entirely (yay!), which makes the Registry 3.0 database migration easier. It is unfortunate that the naming parallelism of EppResources is lost between ContactResource, HostResource, and DomainResource, but the actual type as far as Datastore was concerned was DomainBase all along, and it would be a much more substantial data migration to allow us to continue using the class name DomainResource now that we're no longer using Objectify polymorphism. This simply isn't worth it. This also removes the polymorphic Datastore indexes (which will no longer function as of this change). The non-polymorphic replacement indexes were added in [] ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=230930546
375 lines
14 KiB
Java
375 lines
14 KiB
Java
// Copyright 2017 The Nomulus Authors. All Rights Reserved.
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package google.registry.dns;
|
|
|
|
import static com.google.common.truth.Truth.assertThat;
|
|
import static google.registry.testing.DatastoreHelper.createTld;
|
|
import static google.registry.testing.DatastoreHelper.persistActiveDomain;
|
|
import static google.registry.testing.DatastoreHelper.persistActiveSubordinateHost;
|
|
import static google.registry.testing.DatastoreHelper.persistResource;
|
|
import static google.registry.testing.JUnitBackports.assertThrows;
|
|
import static org.mockito.Matchers.any;
|
|
import static org.mockito.Mockito.doThrow;
|
|
import static org.mockito.Mockito.mock;
|
|
import static org.mockito.Mockito.verify;
|
|
import static org.mockito.Mockito.verifyNoMoreInteractions;
|
|
import static org.mockito.Mockito.when;
|
|
|
|
import com.google.common.collect.ImmutableMap;
|
|
import com.google.common.collect.ImmutableSet;
|
|
import google.registry.dns.DnsMetrics.ActionStatus;
|
|
import google.registry.dns.DnsMetrics.CommitStatus;
|
|
import google.registry.dns.DnsMetrics.PublishStatus;
|
|
import google.registry.dns.writer.DnsWriter;
|
|
import google.registry.model.domain.DomainBase;
|
|
import google.registry.model.ofy.Ofy;
|
|
import google.registry.model.registry.Registry;
|
|
import google.registry.request.HttpException.ServiceUnavailableException;
|
|
import google.registry.request.lock.LockHandler;
|
|
import google.registry.testing.AppEngineRule;
|
|
import google.registry.testing.FakeClock;
|
|
import google.registry.testing.FakeLockHandler;
|
|
import google.registry.testing.InjectRule;
|
|
import org.joda.time.DateTime;
|
|
import org.joda.time.Duration;
|
|
import org.junit.Before;
|
|
import org.junit.Rule;
|
|
import org.junit.Test;
|
|
import org.junit.runner.RunWith;
|
|
import org.junit.runners.JUnit4;
|
|
|
|
/** Unit tests for {@link PublishDnsUpdatesAction}. */
|
|
@RunWith(JUnit4.class)
|
|
public class PublishDnsUpdatesActionTest {
|
|
|
|
@Rule
|
|
public final AppEngineRule appEngine = AppEngineRule.builder()
|
|
.withDatastore()
|
|
.withTaskQueue()
|
|
.build();
|
|
|
|
@Rule
|
|
public final InjectRule inject = new InjectRule();
|
|
private final FakeClock clock = new FakeClock(DateTime.parse("1971-01-01TZ"));
|
|
private final FakeLockHandler lockHandler = new FakeLockHandler(true);
|
|
private final DnsWriter dnsWriter = mock(DnsWriter.class);
|
|
private final DnsMetrics dnsMetrics = mock(DnsMetrics.class);
|
|
private final DnsQueue dnsQueue = mock(DnsQueue.class);
|
|
private PublishDnsUpdatesAction action;
|
|
|
|
@Before
|
|
public void setUp() {
|
|
inject.setStaticField(Ofy.class, "clock", clock);
|
|
createTld("xn--q9jyb4c");
|
|
persistResource(
|
|
Registry.get("xn--q9jyb4c")
|
|
.asBuilder()
|
|
.setDnsWriters(ImmutableSet.of("correctWriter"))
|
|
.build());
|
|
DomainBase domain1 = persistActiveDomain("example.xn--q9jyb4c");
|
|
persistActiveSubordinateHost("ns1.example.xn--q9jyb4c", domain1);
|
|
persistActiveSubordinateHost("ns2.example.xn--q9jyb4c", domain1);
|
|
DomainBase domain2 = persistActiveDomain("example2.xn--q9jyb4c");
|
|
persistActiveSubordinateHost("ns1.example.xn--q9jyb4c", domain2);
|
|
clock.advanceOneMilli();
|
|
}
|
|
|
|
private PublishDnsUpdatesAction createAction(String tld) {
|
|
PublishDnsUpdatesAction action = new PublishDnsUpdatesAction();
|
|
action.timeout = Duration.standardSeconds(10);
|
|
action.tld = tld;
|
|
action.hosts = ImmutableSet.of();
|
|
action.domains = ImmutableSet.of();
|
|
action.itemsCreateTime = clock.nowUtc().minusHours(2);
|
|
action.enqueuedTime = clock.nowUtc().minusHours(1);
|
|
action.dnsWriter = "correctWriter";
|
|
action.dnsWriterProxy = new DnsWriterProxy(ImmutableMap.of("correctWriter", dnsWriter));
|
|
action.dnsMetrics = dnsMetrics;
|
|
action.dnsQueue = dnsQueue;
|
|
action.lockIndex = 1;
|
|
action.numPublishLocks = 1;
|
|
action.lockHandler = lockHandler;
|
|
action.clock = clock;
|
|
return action;
|
|
}
|
|
|
|
@Test
|
|
public void testHost_published() {
|
|
action = createAction("xn--q9jyb4c");
|
|
action.hosts = ImmutableSet.of("ns1.example.xn--q9jyb4c");
|
|
|
|
action.run();
|
|
|
|
verify(dnsWriter).publishHost("ns1.example.xn--q9jyb4c");
|
|
verify(dnsWriter).commit();
|
|
verifyNoMoreInteractions(dnsWriter);
|
|
verify(dnsMetrics).incrementPublishDomainRequests("xn--q9jyb4c", 0, PublishStatus.ACCEPTED);
|
|
verify(dnsMetrics).incrementPublishDomainRequests("xn--q9jyb4c", 0, PublishStatus.REJECTED);
|
|
verify(dnsMetrics).incrementPublishHostRequests("xn--q9jyb4c", 1, PublishStatus.ACCEPTED);
|
|
verify(dnsMetrics).incrementPublishHostRequests("xn--q9jyb4c", 0, PublishStatus.REJECTED);
|
|
verify(dnsMetrics)
|
|
.recordCommit("xn--q9jyb4c", "correctWriter", CommitStatus.SUCCESS, Duration.ZERO, 0, 1);
|
|
verify(dnsMetrics)
|
|
.recordActionResult(
|
|
"xn--q9jyb4c",
|
|
"correctWriter",
|
|
ActionStatus.SUCCESS,
|
|
1,
|
|
Duration.standardHours(2),
|
|
Duration.standardHours(1));
|
|
verifyNoMoreInteractions(dnsMetrics);
|
|
verifyNoMoreInteractions(dnsQueue);
|
|
}
|
|
|
|
@Test
|
|
public void testDomain_published() {
|
|
action = createAction("xn--q9jyb4c");
|
|
action.domains = ImmutableSet.of("example.xn--q9jyb4c");
|
|
|
|
action.run();
|
|
|
|
verify(dnsWriter).publishDomain("example.xn--q9jyb4c");
|
|
verify(dnsWriter).commit();
|
|
verifyNoMoreInteractions(dnsWriter);
|
|
verify(dnsMetrics).incrementPublishDomainRequests("xn--q9jyb4c", 1, PublishStatus.ACCEPTED);
|
|
verify(dnsMetrics).incrementPublishDomainRequests("xn--q9jyb4c", 0, PublishStatus.REJECTED);
|
|
verify(dnsMetrics).incrementPublishHostRequests("xn--q9jyb4c", 0, PublishStatus.ACCEPTED);
|
|
verify(dnsMetrics).incrementPublishHostRequests("xn--q9jyb4c", 0, PublishStatus.REJECTED);
|
|
verify(dnsMetrics)
|
|
.recordCommit("xn--q9jyb4c", "correctWriter", CommitStatus.SUCCESS, Duration.ZERO, 1, 0);
|
|
verify(dnsMetrics)
|
|
.recordActionResult(
|
|
"xn--q9jyb4c",
|
|
"correctWriter",
|
|
ActionStatus.SUCCESS,
|
|
1,
|
|
Duration.standardHours(2),
|
|
Duration.standardHours(1));
|
|
verifyNoMoreInteractions(dnsMetrics);
|
|
verifyNoMoreInteractions(dnsQueue);
|
|
}
|
|
|
|
@Test
|
|
public void testAction_acquiresCorrectLock() {
|
|
persistResource(Registry.get("xn--q9jyb4c").asBuilder().setNumDnsPublishLocks(4).build());
|
|
action = createAction("xn--q9jyb4c");
|
|
action.lockIndex = 2;
|
|
action.numPublishLocks = 4;
|
|
action.domains = ImmutableSet.of("example.xn--q9jyb4c");
|
|
LockHandler mockLockHandler = mock(LockHandler.class);
|
|
when(mockLockHandler.executeWithLocks(any(), any(), any(), any())).thenReturn(true);
|
|
action.lockHandler = mockLockHandler;
|
|
|
|
action.run();
|
|
|
|
verify(mockLockHandler)
|
|
.executeWithLocks(
|
|
action, "xn--q9jyb4c", Duration.standardSeconds(10), "DNS updates-lock 2 of 4");
|
|
}
|
|
|
|
@Test
|
|
public void testPublish_commitFails() {
|
|
action = createAction("xn--q9jyb4c");
|
|
action.domains = ImmutableSet.of("example.xn--q9jyb4c", "example2.xn--q9jyb4c");
|
|
action.hosts =
|
|
ImmutableSet.of(
|
|
"ns1.example.xn--q9jyb4c", "ns2.example.xn--q9jyb4c", "ns1.example2.xn--q9jyb4c");
|
|
doThrow(new RuntimeException()).when(dnsWriter).commit();
|
|
|
|
assertThrows(RuntimeException.class, action::run);
|
|
|
|
verify(dnsMetrics).incrementPublishDomainRequests("xn--q9jyb4c", 2, PublishStatus.ACCEPTED);
|
|
verify(dnsMetrics).incrementPublishDomainRequests("xn--q9jyb4c", 0, PublishStatus.REJECTED);
|
|
verify(dnsMetrics).incrementPublishHostRequests("xn--q9jyb4c", 3, PublishStatus.ACCEPTED);
|
|
verify(dnsMetrics).incrementPublishHostRequests("xn--q9jyb4c", 0, PublishStatus.REJECTED);
|
|
verify(dnsMetrics)
|
|
.recordCommit("xn--q9jyb4c", "correctWriter", CommitStatus.FAILURE, Duration.ZERO, 2, 3);
|
|
verify(dnsMetrics)
|
|
.recordActionResult(
|
|
"xn--q9jyb4c",
|
|
"correctWriter",
|
|
ActionStatus.COMMIT_FAILURE,
|
|
5,
|
|
Duration.standardHours(2),
|
|
Duration.standardHours(1));
|
|
verifyNoMoreInteractions(dnsMetrics);
|
|
verifyNoMoreInteractions(dnsQueue);
|
|
}
|
|
|
|
@Test
|
|
public void testHostAndDomain_published() {
|
|
action = createAction("xn--q9jyb4c");
|
|
action.domains = ImmutableSet.of("example.xn--q9jyb4c", "example2.xn--q9jyb4c");
|
|
action.hosts = ImmutableSet.of(
|
|
"ns1.example.xn--q9jyb4c", "ns2.example.xn--q9jyb4c", "ns1.example2.xn--q9jyb4c");
|
|
|
|
action.run();
|
|
|
|
verify(dnsWriter).publishDomain("example.xn--q9jyb4c");
|
|
verify(dnsWriter).publishDomain("example2.xn--q9jyb4c");
|
|
verify(dnsWriter).publishHost("ns1.example.xn--q9jyb4c");
|
|
verify(dnsWriter).publishHost("ns2.example.xn--q9jyb4c");
|
|
verify(dnsWriter).publishHost("ns1.example2.xn--q9jyb4c");
|
|
verify(dnsWriter).commit();
|
|
verifyNoMoreInteractions(dnsWriter);
|
|
verify(dnsMetrics).incrementPublishDomainRequests("xn--q9jyb4c", 2, PublishStatus.ACCEPTED);
|
|
verify(dnsMetrics).incrementPublishDomainRequests("xn--q9jyb4c", 0, PublishStatus.REJECTED);
|
|
verify(dnsMetrics).incrementPublishHostRequests("xn--q9jyb4c", 3, PublishStatus.ACCEPTED);
|
|
verify(dnsMetrics).incrementPublishHostRequests("xn--q9jyb4c", 0, PublishStatus.REJECTED);
|
|
verify(dnsMetrics)
|
|
.recordCommit("xn--q9jyb4c", "correctWriter", CommitStatus.SUCCESS, Duration.ZERO, 2, 3);
|
|
verify(dnsMetrics)
|
|
.recordActionResult(
|
|
"xn--q9jyb4c",
|
|
"correctWriter",
|
|
ActionStatus.SUCCESS,
|
|
5,
|
|
Duration.standardHours(2),
|
|
Duration.standardHours(1));
|
|
verifyNoMoreInteractions(dnsMetrics);
|
|
verifyNoMoreInteractions(dnsQueue);
|
|
}
|
|
|
|
@Test
|
|
public void testWrongTld_notPublished() {
|
|
action = createAction("xn--q9jyb4c");
|
|
action.domains = ImmutableSet.of("example.com", "example2.com");
|
|
action.hosts = ImmutableSet.of("ns1.example.com", "ns2.example.com", "ns1.example2.com");
|
|
|
|
action.run();
|
|
|
|
verify(dnsWriter).commit();
|
|
verifyNoMoreInteractions(dnsWriter);
|
|
verify(dnsMetrics).incrementPublishDomainRequests("xn--q9jyb4c", 0, PublishStatus.ACCEPTED);
|
|
verify(dnsMetrics).incrementPublishDomainRequests("xn--q9jyb4c", 2, PublishStatus.REJECTED);
|
|
verify(dnsMetrics).incrementPublishHostRequests("xn--q9jyb4c", 0, PublishStatus.ACCEPTED);
|
|
verify(dnsMetrics).incrementPublishHostRequests("xn--q9jyb4c", 3, PublishStatus.REJECTED);
|
|
verify(dnsMetrics)
|
|
.recordCommit("xn--q9jyb4c", "correctWriter", CommitStatus.SUCCESS, Duration.ZERO, 0, 0);
|
|
verify(dnsMetrics)
|
|
.recordActionResult(
|
|
"xn--q9jyb4c",
|
|
"correctWriter",
|
|
ActionStatus.SUCCESS,
|
|
5,
|
|
Duration.standardHours(2),
|
|
Duration.standardHours(1));
|
|
verifyNoMoreInteractions(dnsMetrics);
|
|
verifyNoMoreInteractions(dnsQueue);
|
|
}
|
|
|
|
@Test
|
|
public void testLockIsntAvailable() {
|
|
action = createAction("xn--q9jyb4c");
|
|
action.domains = ImmutableSet.of("example.com", "example2.com");
|
|
action.hosts = ImmutableSet.of("ns1.example.com", "ns2.example.com", "ns1.example2.com");
|
|
action.lockHandler = new FakeLockHandler(false);
|
|
|
|
ServiceUnavailableException thrown =
|
|
assertThrows(ServiceUnavailableException.class, action::run);
|
|
|
|
assertThat(thrown).hasMessageThat().contains("Lock failure");
|
|
verifyNoMoreInteractions(dnsWriter);
|
|
verify(dnsMetrics)
|
|
.recordActionResult(
|
|
"xn--q9jyb4c",
|
|
"correctWriter",
|
|
ActionStatus.LOCK_FAILURE,
|
|
5,
|
|
Duration.standardHours(2),
|
|
Duration.standardHours(1));
|
|
verifyNoMoreInteractions(dnsMetrics);
|
|
verifyNoMoreInteractions(dnsQueue);
|
|
}
|
|
|
|
@Test
|
|
public void testParam_invalidLockIndex() {
|
|
persistResource(Registry.get("xn--q9jyb4c").asBuilder().setNumDnsPublishLocks(4).build());
|
|
action = createAction("xn--q9jyb4c");
|
|
action.domains = ImmutableSet.of("example.com");
|
|
action.hosts = ImmutableSet.of("ns1.example.com");
|
|
action.lockIndex = 5;
|
|
action.numPublishLocks = 4;
|
|
|
|
action.run();
|
|
|
|
verifyNoMoreInteractions(dnsWriter);
|
|
verify(dnsMetrics)
|
|
.recordActionResult(
|
|
"xn--q9jyb4c",
|
|
"correctWriter",
|
|
ActionStatus.BAD_LOCK_INDEX,
|
|
2,
|
|
Duration.standardHours(2),
|
|
Duration.standardHours(1));
|
|
verifyNoMoreInteractions(dnsMetrics);
|
|
verify(dnsQueue).addDomainRefreshTask("example.com");
|
|
verify(dnsQueue).addHostRefreshTask("ns1.example.com");
|
|
verifyNoMoreInteractions(dnsQueue);
|
|
}
|
|
|
|
@Test
|
|
public void testRegistryParam_mismatchedMaxLocks() {
|
|
persistResource(Registry.get("xn--q9jyb4c").asBuilder().setNumDnsPublishLocks(4).build());
|
|
action = createAction("xn--q9jyb4c");
|
|
action.domains = ImmutableSet.of("example.com");
|
|
action.hosts = ImmutableSet.of("ns1.example.com");
|
|
action.lockIndex = 3;
|
|
action.numPublishLocks = 5;
|
|
|
|
action.run();
|
|
|
|
verifyNoMoreInteractions(dnsWriter);
|
|
verify(dnsMetrics)
|
|
.recordActionResult(
|
|
"xn--q9jyb4c",
|
|
"correctWriter",
|
|
ActionStatus.BAD_LOCK_INDEX,
|
|
2,
|
|
Duration.standardHours(2),
|
|
Duration.standardHours(1));
|
|
verifyNoMoreInteractions(dnsMetrics);
|
|
verify(dnsQueue).addDomainRefreshTask("example.com");
|
|
verify(dnsQueue).addHostRefreshTask("ns1.example.com");
|
|
verifyNoMoreInteractions(dnsQueue);
|
|
}
|
|
|
|
@Test
|
|
public void testWrongDnsWriter() {
|
|
action = createAction("xn--q9jyb4c");
|
|
action.domains = ImmutableSet.of("example.com", "example2.com");
|
|
action.hosts = ImmutableSet.of("ns1.example.com", "ns2.example.com", "ns1.example2.com");
|
|
action.dnsWriter = "wrongWriter";
|
|
|
|
action.run();
|
|
|
|
verifyNoMoreInteractions(dnsWriter);
|
|
verify(dnsMetrics)
|
|
.recordActionResult(
|
|
"xn--q9jyb4c",
|
|
"wrongWriter",
|
|
ActionStatus.BAD_WRITER,
|
|
5,
|
|
Duration.standardHours(2),
|
|
Duration.standardHours(1));
|
|
verifyNoMoreInteractions(dnsMetrics);
|
|
verify(dnsQueue).addDomainRefreshTask("example.com");
|
|
verify(dnsQueue).addDomainRefreshTask("example2.com");
|
|
verify(dnsQueue).addHostRefreshTask("ns1.example.com");
|
|
verify(dnsQueue).addHostRefreshTask("ns2.example.com");
|
|
verify(dnsQueue).addHostRefreshTask("ns1.example2.com");
|
|
verifyNoMoreInteractions(dnsQueue);
|
|
}
|
|
}
|