mirror of
https://github.com/google/nomulus.git
synced 2025-05-01 12:37:52 +02:00
Certain flows need to launch batched jobs. Logically this would mean that flows depend on batch. However, the current state of dependency was the other way around, and the reason for that was ResourceFlowUtils.java that had in it some utility functions that weren't used in the flows and were needed in the batch jobs. This CL removes these utility functions from the /flows/ directory, letting us reverse the dependency edge between flows/ and batch/ Part of this was moving the flows/async/ code into batch/ - which also makes sense because flows/async/ just "enqueued" tasks that would then be run by actions in batch/ It makes sense that the code that enqueues the tasks and the code that dequeues the tasks sit in the same library. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=228698761
165 lines
5.9 KiB
Java
165 lines
5.9 KiB
Java
// Copyright 2017 The Nomulus Authors. All Rights Reserved.
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package google.registry.batch;
|
|
|
|
import static com.google.appengine.api.taskqueue.QueueConstants.maxLeaseCount;
|
|
import static com.google.monitoring.metrics.EventMetric.DEFAULT_FITTER;
|
|
import static google.registry.batch.AsyncTaskMetrics.OperationType.CONTACT_AND_HOST_DELETE;
|
|
import static google.registry.batch.AsyncTaskMetrics.OperationType.DNS_REFRESH;
|
|
|
|
import com.google.common.annotations.VisibleForTesting;
|
|
import com.google.common.collect.ImmutableSet;
|
|
import com.google.common.flogger.FluentLogger;
|
|
import com.google.monitoring.metrics.DistributionFitter;
|
|
import com.google.monitoring.metrics.EventMetric;
|
|
import com.google.monitoring.metrics.FibonacciFitter;
|
|
import com.google.monitoring.metrics.IncrementableMetric;
|
|
import com.google.monitoring.metrics.LabelDescriptor;
|
|
import com.google.monitoring.metrics.MetricRegistryImpl;
|
|
import google.registry.util.Clock;
|
|
import javax.inject.Inject;
|
|
import org.joda.time.DateTime;
|
|
import org.joda.time.Duration;
|
|
|
|
/**
|
|
* Instrumentation for async flows (contact/host deletion and DNS refreshes).
|
|
*
|
|
* @see AsyncTaskEnqueuer
|
|
*/
|
|
public class AsyncTaskMetrics {
|
|
|
|
private static final FluentLogger logger = FluentLogger.forEnclosingClass();
|
|
|
|
private final Clock clock;
|
|
|
|
@Inject
|
|
public AsyncTaskMetrics(Clock clock) {
|
|
this.clock = clock;
|
|
}
|
|
|
|
/**
|
|
* A Fibonacci fitter used for bucketing the batch count.
|
|
*
|
|
* <p>We use a Fibonacci filter because it provides better resolution at the low end than an
|
|
* exponential fitter, which is important because most batch sizes are likely to be very low,
|
|
* despite going up to 1,000 on the high end. Also, the precision is better, as batch size is
|
|
* inherently an integer, whereas an exponential fitter with an exponent base less than 2 would
|
|
* have unintuitive boundaries.
|
|
*/
|
|
private static final DistributionFitter FITTER_BATCH_SIZE =
|
|
FibonacciFitter.create(maxLeaseCount());
|
|
|
|
private static final ImmutableSet<LabelDescriptor> LABEL_DESCRIPTORS =
|
|
ImmutableSet.of(
|
|
LabelDescriptor.create("operation_type", "The type of async flow operation."),
|
|
LabelDescriptor.create("result", "The result of the async flow operation."));
|
|
|
|
@VisibleForTesting
|
|
static final IncrementableMetric asyncFlowOperationCounts =
|
|
MetricRegistryImpl.getDefault()
|
|
.newIncrementableMetric(
|
|
"/async_flows/operations",
|
|
"Count of Async Flow Operations",
|
|
"count",
|
|
LABEL_DESCRIPTORS);
|
|
|
|
@VisibleForTesting
|
|
static final EventMetric asyncFlowOperationProcessingTime =
|
|
MetricRegistryImpl.getDefault()
|
|
.newEventMetric(
|
|
"/async_flows/processing_time",
|
|
"Async Flow Processing Time",
|
|
"milliseconds",
|
|
LABEL_DESCRIPTORS,
|
|
DEFAULT_FITTER);
|
|
|
|
@VisibleForTesting
|
|
static final EventMetric asyncFlowBatchSize =
|
|
MetricRegistryImpl.getDefault()
|
|
.newEventMetric(
|
|
"/async_flows/batch_size",
|
|
"Async Operation Batch Size",
|
|
"batch size",
|
|
ImmutableSet.of(
|
|
LabelDescriptor.create("operation_type", "The type of async flow operation.")),
|
|
FITTER_BATCH_SIZE);
|
|
|
|
/** The type of asynchronous operation. */
|
|
public enum OperationType {
|
|
CONTACT_DELETE("contactDelete"),
|
|
HOST_DELETE("hostDelete"),
|
|
CONTACT_AND_HOST_DELETE("contactAndHostDelete"),
|
|
DNS_REFRESH("dnsRefresh");
|
|
|
|
private final String metricLabelValue;
|
|
|
|
OperationType(String metricLabelValue) {
|
|
this.metricLabelValue = metricLabelValue;
|
|
}
|
|
|
|
String getMetricLabelValue() {
|
|
return metricLabelValue;
|
|
}
|
|
}
|
|
|
|
/** The result of an asynchronous operation. */
|
|
public enum OperationResult {
|
|
/** The operation processed correctly and the result was success. */
|
|
SUCCESS("success"),
|
|
|
|
/** The operation processed correctly and the result was failure. */
|
|
FAILURE("failure"),
|
|
|
|
/** The operation did not process correctly due to some unexpected error. */
|
|
ERROR("error"),
|
|
|
|
/** The operation was skipped because the request is now stale. */
|
|
STALE("stale");
|
|
|
|
private final String metricLabelValue;
|
|
|
|
OperationResult(String metricLabelValue) {
|
|
this.metricLabelValue = metricLabelValue;
|
|
}
|
|
|
|
String getMetricLabelValue() {
|
|
return metricLabelValue;
|
|
}
|
|
}
|
|
|
|
public void recordAsyncFlowResult(
|
|
OperationType operationType, OperationResult operationResult, DateTime whenEnqueued) {
|
|
asyncFlowOperationCounts.increment(
|
|
operationType.getMetricLabelValue(), operationResult.getMetricLabelValue());
|
|
long processingMillis = new Duration(whenEnqueued, clock.nowUtc()).getMillis();
|
|
asyncFlowOperationProcessingTime.record(
|
|
processingMillis,
|
|
operationType.getMetricLabelValue(),
|
|
operationResult.getMetricLabelValue());
|
|
logger.atInfo().log(
|
|
"Asynchronous %s operation took %d ms to process, yielding result: %s.",
|
|
operationType.getMetricLabelValue(),
|
|
processingMillis,
|
|
operationResult.getMetricLabelValue());
|
|
}
|
|
|
|
public void recordContactHostDeletionBatchSize(long batchSize) {
|
|
asyncFlowBatchSize.record(batchSize, CONTACT_AND_HOST_DELETE.getMetricLabelValue());
|
|
}
|
|
|
|
public void recordDnsRefreshBatchSize(long batchSize) {
|
|
asyncFlowBatchSize.record(batchSize, DNS_REFRESH.getMetricLabelValue());
|
|
}
|
|
}
|