google-nomulus/javatests/google/registry/tools
weiminyu 7c64992c73 Cloned from CL 251456914 by 'g4 patch'.
Original change by cpovirk@cpovirk:rosie251284456-0055_Rosie:31511:citc on 2019/06/04 09:48:27.

Update to Truth 0.45, and address deprecations.

Renames may include:
- containsAllOf => containsAtLeast
- containsAllIn => containsAtLeastElementsIn
- isSameAs => isSameInstanceAs
- isOrdered => isInOrder
- isStrictlyOrdered => isInStrictOrder

The other major change is to change custom subjects to extend raw Subject instead of supplying type parameters. The type parameters are being removed from Subject. This CL will temporarily produce rawtypes warnings, which will go away when I remove the type parameters (as soon as this batch of CLs is submitted).

Some CLs in this batch also migrate calls away from actualAsString(). Its literal replacement is `"<" + actual + ">"` (unless an object overrides actualCustomStringRepresentation()), but usually I've made a larger change, such as switching from an old-style "Not true that..." failure message to one generated with the Fact API. In that case, the new code usually contains a direct reference to this.actual (a field that I occasionally had to create). Another larger change I sometimes made is to switch from a manual check-and-fail approach to instead use check(...). And sometimes I just remove a withMessage() call that's no longer necessary now that the code uses check(...), or I introduce a check(...) call. (An assertion made with check(...) automatically includes the actual value from the original subject, so there's no need to set it again with withMessage().)

Finally, there's one CL in this batch in which I migrate a Correspondence subclass to instead use Correspondence.from.

END_PUBLIC

If this is too many changes at once, let me know, and I can split it up and/or explain further. In the past, I've erred on the side of sending separate CLs for each change, which has required some owners to manually reapply each one, so now I'm trying this way.

Thanks again for your patience. There is an outside chance that this will be the last CL I send you before Truth 1.0 -- but certainly no promises :)

More information:
  Renames:
    []
    []
    []
  Removing type parameters: []
  Migration from old fail*(...) methods to new ones and to check(...): []
  Changes that replace assert*(...) with introduce check(...): []
  Correspondence subclass to Correspondence.from: []

Tested:
    TAP --sample ran all affected tests and none failed
    []

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=251921007
2019-06-07 11:46:44 -04:00
..
params Delete end-date sunrise, landrush, and sunrush phases 2019-01-10 16:23:35 -05:00
server Smear out DNS updates over time when updating DNS for all domains 2019-06-06 10:44:27 -04:00
testdata Update signed marks files and add an expiration test 2018-06-27 15:28:53 -04:00
AppEngineConnectionTest.java Remove backported MockitoJUnitRule 2019-03-08 18:35:00 -05:00
AuthModuleTest.java Add the ability to provide credential JSON file to the nomulus tool 2018-12-20 07:46:33 -05:00
BUILD Upgrade to AutoValue 1.6.3 2019-05-30 12:52:21 -04:00
CheckDomainClaimsCommandTest.java Default to admin registrar in check_domain commands 2018-09-08 00:19:53 -04:00
CheckDomainCommandTest.java Default to admin registrar in check_domain commands 2018-09-08 00:19:53 -04:00
CommandTestCase.java Remove backported MockitoJUnitRule 2019-03-08 18:35:00 -05:00
ComparableEntityTest.java Clean up some areas in preparation for externalized codebase 2018-11-16 16:51:11 -05:00
CompareDbBackupsTest.java Remove more unused Truth8.assertThat() static imports in tests 2017-11-07 17:22:56 -05:00
CountDomainsCommandTest.java Add nomulus count_domains command 2018-05-05 23:37:11 -04:00
CreateAnchorTenantCommandTest.java Remove unnecessary "throws" declarations 2018-06-18 18:17:56 -04:00
CreateCdnsTldTest.java Use @DefaultCredential for Cloud API access in GAE 2018-09-20 11:19:36 -04:00
CreateContactCommandTest.java Remove unnecessary "throws" declarations 2018-06-18 18:17:56 -04:00
CreateDomainCommandTest.java Allow square bracket expansion when specifying nameservers 2018-08-10 13:44:25 -04:00
CreateHostCommandTest.java Remove unnecessary "throws" declarations 2018-06-18 18:17:56 -04:00
CreateOrUpdatePremiumListCommandTestCase.java Replace deprecated Mockito Matchers class 2019-05-06 16:21:27 -04:00
CreateOrUpdateReservedListCommandTestCase.java Remove unnecessary "throws" declarations 2018-06-18 18:17:56 -04:00
CreatePremiumListCommandTest.java Replace deprecated Mockito Matchers class 2019-05-06 16:21:27 -04:00
CreateRegistrarCommandTest.java Migrate org.mockito.Matchers#any* to org.mockito.ArgumentMatchers 2019-05-30 12:52:21 -04:00
CreateRegistrarGroupsCommandTest.java Replace deprecated Mockito Matchers class 2019-05-06 16:21:27 -04:00
CreateReservedListCommandTest.java Remove more unnecessary "throws" declarations 2018-06-27 15:28:52 -04:00
CreateTldCommandTest.java Just use default Joda DateTime toString() 2019-05-06 16:18:09 -04:00
CurlCommandTest.java Replace deprecated Mockito Matchers class 2019-05-06 16:21:27 -04:00
DeleteAllocationTokensCommandTest.java Modify DeleteAllocationTokensCommand to have the same input structure as UpdateATC 2019-05-30 12:52:21 -04:00
DeleteDomainCommandTest.java Remove unnecessary "throws" declarations 2018-06-18 18:17:56 -04:00
DeleteHostCommandTest.java Remove unnecessary "throws" declarations 2018-06-18 18:17:56 -04:00
DeletePremiumListCommandTest.java Remove unnecessary "throws" declarations 2018-06-18 18:17:56 -04:00
DeleteReservedListCommandTest.java Remove unnecessary "throws" declarations 2018-06-18 18:17:56 -04:00
DeleteTldCommandTest.java Statically import commonly used TldState enum values 2019-01-14 16:23:15 -05:00
EncryptEscrowDepositCommandTest.java Simplify the RyDE API 2018-07-17 22:03:53 -04:00
EppLifecycleToolsTest.java Merge DomainResource into DomainBase 2019-01-28 15:57:10 -05:00
EppToolCommandTest.java Don't prompt to confirm non-mutating nomulus EPP tool commands 2018-04-10 16:53:18 -04:00
EppToolCommandTestCase.java Remove unnecessary "throws" declarations 2018-06-18 18:17:56 -04:00
EppToolVerifier.java Replace deprecated Mockito Matchers class 2019-05-06 16:21:27 -04:00
ExecuteEppCommandTest.java Do not use InjectRule to mock stdin in ExecuteEppCommandTest 2018-10-22 18:46:36 -04:00
GenerateAllocationTokensCommandTest.java Migrate org.mockito.Matchers#any* to org.mockito.ArgumentMatchers 2019-05-30 12:52:21 -04:00
GenerateDnsReportCommandTest.java Migrate from containsAllOf to containsAtLeast 2019-05-06 16:53:03 -04:00
GenerateEscrowDepositCommandTest.java Wrap ModulesService in new AppEngineServiceUtils 2018-08-10 13:44:25 -04:00
GetAllocationTokenCommandTest.java Add necessary fields to the AllocationToken schema 2019-04-15 14:53:45 -04:00
GetClaimsListCommandTest.java Remove more unused Truth8.assertThat() static imports in tests 2017-11-07 17:22:56 -05:00
GetContactCommandTest.java Remove unnecessary "throws" declarations 2018-06-18 18:17:56 -04:00
GetDomainCommandTest.java Merge DomainResource into DomainBase 2019-01-28 15:57:10 -05:00
GetHistoryEntriesCommandTest.java Merge DomainResource into DomainBase 2019-01-28 15:57:10 -05:00
GetHostCommandTest.java Remove unnecessary "throws" declarations 2018-06-18 18:17:56 -04:00
GetOperationStatusCommandTest.java Support datastore restore in Nomulus tool 2019-01-10 16:23:35 -05:00
GetRegistrarCommandTest.java Remove unnecessary "throws" declarations 2018-06-18 18:17:56 -04:00
GetResourceByKeyCommandTest.java Remove unnecessary "throws" declarations 2018-06-18 18:17:56 -04:00
GetSchemaTreeCommandTest.java Migrate from assertThat(foo).named("foo") to assertWithMessage("foo").that(foo). 2019-05-06 16:16:31 -04:00
GetTldCommandTest.java Remove unnecessary "throws" declarations 2018-06-18 18:17:56 -04:00
GhostrydeCommandTest.java Use Guava instead of Apache Commons for file ops in Ghostryde 2019-01-11 11:00:33 -05:00
GtechToolTest.java Cloned from CL 251456914 by 'g4 patch'. 2019-06-07 11:46:44 -04:00
ImportDatastoreCommandTest.java Replace deprecated Mockito Matchers class 2019-05-06 16:21:27 -04:00
LevelDbFileBuilder.java Implement compare_db_backups "main" 2017-09-20 10:27:17 -04:00
LevelDbFileBuilderTest.java Fix some statically detected code issues 2019-04-22 12:54:34 -04:00
LevelDbLogReaderTest.java Create an entity record accumulator 2017-09-12 15:51:50 -04:00
LevelDbUtil.java Clean up some code quality issues 2017-12-01 22:14:06 -05:00
ListCursorsCommandTest.java Add an auto update time field to the Cursor entity 2018-08-10 13:44:25 -04:00
ListDatastoreOperationsCommandTest.java Add a Nomulus command to list Datastore operations 2019-01-14 16:31:18 -05:00
ListDomainsCommandTest.java Replace deprecated Mockito Matchers class 2019-05-06 16:21:27 -04:00
ListHostsCommandTest.java Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
ListObjectsCommandTestCase.java Replace deprecated Mockito Matchers class 2019-05-06 16:21:27 -04:00
ListPremiumListsCommandTest.java Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
ListRegistrarsCommandTest.java Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
ListReservedListsCommandTest.java Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
ListTldsCommandTest.java Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
LoadTestCommandTest.java Replace deprecated Mockito Matchers class 2019-05-06 16:21:27 -04:00
LockDomainCommandTest.java Merge DomainResource into DomainBase 2019-01-28 15:57:10 -05:00
MutatingCommandTest.java Delete entity synchronously in test method setup 2019-01-17 19:15:57 -05:00
MutatingEppToolCommandTest.java Don't prompt to confirm non-mutating nomulus EPP tool commands 2018-04-10 16:53:18 -04:00
NonMutatingEppToolCommandTest.java Don't prompt to confirm non-mutating nomulus EPP tool commands 2018-04-10 16:53:18 -04:00
RecordAccumulatorTest.java Remove more unused Truth8.assertThat() static imports in tests 2017-11-07 17:22:56 -05:00
RegistrarContactCommandTest.java Automated g4 rollback of changelist 240574585. 2019-03-29 16:23:59 -04:00
RegistryToolEnvironmentTest.java Restore original System Properties after tests 2018-11-14 11:57:23 -05:00
RegistryToolTest.java Cloned from CL 251456914 by 'g4 patch'. 2019-06-07 11:46:44 -04:00
RenewDomainCommandTest.java Add a nomulus renew_domain command 2018-06-06 15:16:09 -04:00
RequestFactoryModuleTest.java Restore global config after tests 2019-01-10 16:23:35 -05:00
ResaveEntitiesCommandTest.java Remove more unused Truth8.assertThat() static imports in tests 2017-11-07 17:22:56 -05:00
ResaveEnvironmentEntitiesCommandTest.java Remove more unused Truth8.assertThat() static imports in tests 2017-11-07 17:22:56 -05:00
ResaveEppResourcesCommandTest.java Remove more unused Truth8.assertThat() static imports in tests 2017-11-07 17:22:56 -05:00
SetNumInstancesCommandTest.java Make some quality of life improvements to set_num_instances command 2019-01-14 16:29:45 -05:00
SetupOteCommandTest.java Rationalize OT&E client ID validation rules 2019-01-14 16:28:12 -05:00
ShellCommandTest.java Restore original System Properties after tests 2018-11-14 11:57:23 -05:00
UniformRapidSuspensionCommandTest.java Merge DomainResource into DomainBase 2019-01-28 15:57:10 -05:00
UnlockDomainCommandTest.java Merge DomainResource into DomainBase 2019-01-28 15:57:10 -05:00
UnrenewDomainCommandTest.java Merge DomainResource into DomainBase 2019-01-28 15:57:10 -05:00
UpdateAllocationTokensCommandTest.java Modify DeleteAllocationTokensCommand to have the same input structure as UpdateATC 2019-05-30 12:52:21 -04:00
UpdateCursorsCommandTest.java Remove unnecessary "throws" declarations 2018-06-18 18:17:56 -04:00
UpdateDomainCommandTest.java Merge DomainResource into DomainBase 2019-01-28 15:57:10 -05:00
UpdatePremiumListCommandTest.java Replace deprecated Mockito Matchers class 2019-05-06 16:21:27 -04:00
UpdateRegistrarCommandTest.java Automated g4 rollback of changelist 240574585. 2019-03-29 16:23:59 -04:00
UpdateReservedListCommandTest.java Remove unnecessary "throws" declarations 2018-06-18 18:17:56 -04:00
UpdateServerLocksCommandTest.java Remove unnecessary "throws" declarations 2018-06-18 18:17:56 -04:00
UpdateTldCommandTest.java Remove per-domain nameserver restrictions in reserved lists 2019-04-16 14:09:27 -04:00
UploadClaimsListCommandTest.java Remove unnecessary "throws" declarations 2018-06-18 18:17:56 -04:00
ValidateEscrowDepositCommandTest.java Merge JUnitBackport's expectThrows into assertThrows 2018-03-06 18:56:15 -05:00
ValidateLoginCredentialsCommandTest.java Allow registrars to be completely DISABLED 2019-03-21 15:03:33 -04:00
VerifyOteCommandTest.java Replace deprecated Mockito Matchers class 2019-05-06 16:21:27 -04:00