google-nomulus/javatests/google/registry/testing
mountford ac822053cc Change behavior when searching contacts by name
We no longer find contacts by name if the request is not authorized to see the name.

Several changes cascade from this. Previously, the code assumed that deleted contacts might still have full names, and therefore be searchable. This is not possible in all cases, because Datastore doesn't have the right index to find deleted contacts by name with a matching registrar. However, luckily, this situation can never occur, because contacts always have their name fields nulled out when they are deleted.

So instead, we simply ignore deleted records when searching by name, knowing that none can ever match.

The tests were then changed so that deleted records look the way the really will, meaning devoid of personal information.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=172776926
2017-10-24 16:53:47 -04:00
..
mapreduce Switch from Guava Optionals to Java 8 Optionals 2017-10-24 16:53:47 -04:00
sftp Remove an unused exception 2017-02-02 17:06:50 -05:00
testdata Refactor RdeKeyringModule into FakeKeyringModule 2017-03-21 14:53:25 -04:00
AbstractDomainBaseSubject.java Remove the ofy().load() inside of HostResource.cloneProjectedAtTime 2017-03-13 11:22:55 -04:00
AbstractEppResourceSubject.java Switch from Guava Optionals to Java 8 Optionals 2017-10-24 16:53:47 -04:00
AppEngineRule.java Remove all vestiges of memcache 2017-06-14 10:28:24 -04:00
BouncyCastleProviderRule.java Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
BUILD Switch from Guava Optionals to Java 8 Optionals 2017-10-24 16:53:47 -04:00
CertificateSamples.java Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
ContactResourceSubject.java Change transfer flow tests to assert on entire TransferData contents 2017-10-05 11:44:46 -04:00
DatastoreHelper.java Switch from Guava Optionals to Java 8 Optionals 2017-10-24 16:53:47 -04:00
default_premium_list_testdata.csv Don't allow duplicates in premium/reserved lists 2017-02-27 11:17:58 -05:00
DeterministicStringGenerator.java Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
DomainApplicationSubject.java Switch from Guava Optionals to Java 8 Optionals 2017-10-24 16:53:47 -04:00
DomainResourceSubject.java Change transfer flow tests to assert on entire TransferData contents 2017-10-05 11:44:46 -04:00
EppExceptionSubject.java Switch from Guava Optionals to Java 8 Optionals 2017-10-24 16:53:47 -04:00
EppLoader.java Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
EppMetricSubject.java Switch from Guava Optionals to Java 8 Optionals 2017-10-24 16:53:47 -04:00
ExceptionRule.java Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
FailAnswer.java Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
FakeClock.java Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
FakeHttpSession.java Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
FakeJsonResponse.java Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
FakeKeyringModule.java Refactor RdeKeyringModule into FakeKeyringModule 2017-03-21 14:53:25 -04:00
FakeLockHandler.java Create an injectable LockHandler 2017-09-12 15:51:50 -04:00
FakeOAuthService.java Add more tests to new authentication framework 2017-02-27 11:19:27 -05:00
FakeResponse.java Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
FakeServletInputStream.java Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
FakeServletOutputStream.java Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
FakeSleeper.java Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
FakeURLFetchService.java Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
FakeUserService.java Daggerize XsrfTokenManager 2017-02-22 11:43:10 -05:00
ForwardingURLFetchService.java Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
FullFieldsTestEntityHelper.java Change behavior when searching contacts by name 2017-10-24 16:53:47 -04:00
GcsTestingUtils.java Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
GenericEppResourceSubject.java Migrate from old *Verb* classes to new *SubjectBuilder* classes 2017-09-12 15:51:58 -04:00
GoldenFileTestHelper.java Add golden files for request component routing maps 2017-06-05 18:17:09 -04:00
GpgSystemCommandRule.java Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
HistoryEntrySubject.java Switch from Guava Optionals to Java 8 Optionals 2017-10-24 16:53:47 -04:00
HostResourceSubject.java Migrate from old *Verb* classes to new *SubjectBuilder* classes 2017-09-12 15:51:58 -04:00
InjectRule.java Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
IoSpyRule.java Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
Lazies.java Make JSch injection lazy 2017-05-17 11:22:53 -04:00
logging.properties Rename Java packages to use the .google TLD 2016-05-13 20:04:42 -04:00
LogsSubject.java Switch from Guava Optionals to Java 8 Optionals 2017-10-24 16:53:47 -04:00
package-info.java Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
Providers.java Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
ReflectiveFieldExtractor.java Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
ReflectiveSubjectFactory.java Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
ShardableTestCase.java Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
SlurpAnswer.java Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
SystemInfo.java Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
SystemPropertyRule.java Switch from Guava Optionals to Java 8 Optionals 2017-10-24 16:53:47 -04:00
TaskQueueHelper.java Switch from Guava Optionals to Java 8 Optionals 2017-10-24 16:53:47 -04:00
TestDataHelper.java Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
TestLogHandlerUtils.java Run automatic Java 8 conversion over codebase 2017-10-10 12:09:41 -04:00
TestObject.java Add @VirtualEntity checking to Ofy's deleteWithoutBackup() 2017-02-08 17:31:07 -05:00
TruthChainer.java Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
UriParameters.java Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
UserInfo.java Update copyright year on all license headers 2017-02-02 16:27:22 -05:00