mirror of
https://github.com/google/nomulus.git
synced 2025-04-30 12:07:51 +02:00
6bcd40f18a
"keepTasks" is a flag that prevents ReadDnsQueueAction from removing dns-update tasks from the dns-pull queue, while still launching PublishDnsUpdates tasks to update the DNS (meaning these tasks will be updated again in the next ReadDnsQueueAction). I'm not sure what's the purpose of this flag, but given we now allow multiple writers (meaning we can already publish the same DNS multiple times) and given that we can now recover from a bad writer (if a writer doesn't belong to a TLD, we put the dns-updates queued for that writer back into the dns-pull queue) - I suspect we don't need it anymore. Alternative considered: changing this to a "dryRun" flag that won't actually launch PublishDnsUpdates tasks, but will log which tasks it would have launched. Decided against it because we will still need to "own" any task for a significant amount of time if there are many (tens of thousands) tasks in the queue. Hence a "dryRun" will still affect any actual runs for some time. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=183997187
88 lines
2.9 KiB
Java
88 lines
2.9 KiB
Java
// Copyright 2017 The Nomulus Authors. All Rights Reserved.
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package google.registry.dns;
|
|
|
|
import static google.registry.dns.DnsConstants.DNS_PUBLISH_PUSH_QUEUE_NAME;
|
|
import static google.registry.dns.DnsConstants.DNS_PULL_QUEUE_NAME;
|
|
import static google.registry.dns.PublishDnsUpdatesAction.PARAM_DNS_WRITER;
|
|
import static google.registry.dns.PublishDnsUpdatesAction.PARAM_DOMAINS;
|
|
import static google.registry.dns.PublishDnsUpdatesAction.PARAM_HOSTS;
|
|
import static google.registry.request.RequestParameters.extractEnumParameter;
|
|
import static google.registry.request.RequestParameters.extractRequiredParameter;
|
|
import static google.registry.request.RequestParameters.extractSetOfParameters;
|
|
|
|
import com.google.appengine.api.taskqueue.Queue;
|
|
import com.google.appengine.api.taskqueue.QueueFactory;
|
|
import dagger.Binds;
|
|
import dagger.Module;
|
|
import dagger.Provides;
|
|
import google.registry.dns.DnsConstants.TargetType;
|
|
import google.registry.dns.writer.DnsWriterZone;
|
|
import google.registry.request.Parameter;
|
|
import google.registry.request.RequestParameters;
|
|
import java.util.Set;
|
|
import javax.inject.Named;
|
|
import javax.servlet.http.HttpServletRequest;
|
|
|
|
/** Dagger module for the dns package. */
|
|
@Module
|
|
public abstract class DnsModule {
|
|
|
|
@Binds
|
|
@DnsWriterZone
|
|
abstract String provideZoneName(@Parameter(RequestParameters.PARAM_TLD) String tld);
|
|
|
|
@Provides
|
|
@Named(DNS_PULL_QUEUE_NAME)
|
|
static Queue provideDnsPullQueue() {
|
|
return QueueFactory.getQueue(DNS_PULL_QUEUE_NAME);
|
|
}
|
|
|
|
@Provides
|
|
@Named(DNS_PUBLISH_PUSH_QUEUE_NAME)
|
|
static Queue provideDnsUpdatePushQueue() {
|
|
return QueueFactory.getQueue(DNS_PUBLISH_PUSH_QUEUE_NAME);
|
|
}
|
|
|
|
@Provides
|
|
@Parameter(PARAM_DNS_WRITER)
|
|
static String provideDnsWriter(HttpServletRequest req) {
|
|
return extractRequiredParameter(req, PARAM_DNS_WRITER);
|
|
}
|
|
|
|
@Provides
|
|
@Parameter(PARAM_DOMAINS)
|
|
static Set<String> provideDomains(HttpServletRequest req) {
|
|
return extractSetOfParameters(req, PARAM_DOMAINS);
|
|
}
|
|
|
|
@Provides
|
|
@Parameter(PARAM_HOSTS)
|
|
static Set<String> provideHosts(HttpServletRequest req) {
|
|
return extractSetOfParameters(req, PARAM_HOSTS);
|
|
}
|
|
|
|
@Provides
|
|
@Parameter("domainOrHostName")
|
|
static String provideName(HttpServletRequest req) {
|
|
return extractRequiredParameter(req, "name");
|
|
}
|
|
|
|
@Provides
|
|
@Parameter("type")
|
|
static TargetType provideType(HttpServletRequest req) {
|
|
return extractEnumParameter(req, TargetType.class, "type");
|
|
}
|
|
}
|