google-nomulus/javatests/google/registry
ctingue 1f5a8d5542 Fix off-by-one issue in SheetSynchronizer
This doesn't change the end result of a successful run, though this is what a typical flow looks like prior to this fix:

Consider a sheet with 10 data rows (+ 1 header row = 11). A 10-row data set will call worksheet.setRowCount(10), which truncates the last row of the existing sheet. This row will eventually be added again in the last for loop, but if the synchronizer fails mid-sync, this last row will remain dropped. This fix will prevent this last row from being dropped.

This doesn't fix the broader issue of SheetSynchronizer not behaving transactionally -- that's a different can of worms.

See the linked bug for an instance where the synchronizer failed mid-run and dropped a data row as a result.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=136398109
2016-10-17 18:06:43 -04:00
..
backup Preserve test logs and test summary output for Kokoro CI runs 2016-10-14 16:57:43 -04:00
batch Clean up billing MR work 2016-10-14 17:47:46 -04:00
bigquery Preserve test logs and test summary output for Kokoro CI runs 2016-10-14 16:57:43 -04:00
builddefs Preserve test logs and test summary output for Kokoro CI runs 2016-10-14 16:57:43 -04:00
config Preserve test logs and test summary output for Kokoro CI runs 2016-10-14 16:57:43 -04:00
cron Preserve test logs and test summary output for Kokoro CI runs 2016-10-14 16:57:43 -04:00
dns Migrate writeLockTimeout field out of DnsQueue 2016-10-14 17:00:33 -04:00
export Fix off-by-one issue in SheetSynchronizer 2016-10-17 18:06:43 -04:00
flows Assert that LORDN tasks were correctly enqueued in tests 2016-10-17 17:56:19 -04:00
groups Preserve test logs and test summary output for Kokoro CI runs 2016-10-14 16:57:43 -04:00
mapreduce/inputs Preserve test logs and test summary output for Kokoro CI runs 2016-10-14 16:57:43 -04:00
model Switch over to non-ReferenceUnion fields on DomainBase 2016-10-17 18:02:29 -04:00
module Preserve test logs and test summary output for Kokoro CI runs 2016-10-14 16:57:43 -04:00
monitoring Preserve test logs and test summary output for Kokoro CI runs 2016-10-14 16:57:43 -04:00
pricing Preserve test logs and test summary output for Kokoro CI runs 2016-10-14 16:57:43 -04:00
rdap Fix RDAP quirks uncovered during documentation 2016-10-17 17:53:18 -04:00
rde Fix a few incorrect mentions of Nomulus 2016-10-14 17:00:32 -04:00
request Preserve test logs and test summary output for Kokoro CI runs 2016-10-14 16:57:43 -04:00
security Preserve test logs and test summary output for Kokoro CI runs 2016-10-14 16:57:43 -04:00
server Change all references to Domain Registry to Nomulus 2016-10-14 16:58:07 -04:00
storage/drive Preserve test logs and test summary output for Kokoro CI runs 2016-10-14 16:57:43 -04:00
testing Assert that LORDN tasks were correctly enqueued in tests 2016-10-17 17:56:19 -04:00
tldconfig/idn Preserve test logs and test summary output for Kokoro CI runs 2016-10-14 16:57:43 -04:00
tmch Preserve test logs and test summary output for Kokoro CI runs 2016-10-14 16:57:43 -04:00
tools Remove deprecated Reason.ERROR in test 2016-10-14 17:00:33 -04:00
ui Use params from epp_session.js 2016-10-17 17:59:28 -04:00
util Preserve test logs and test summary output for Kokoro CI runs 2016-10-14 16:57:43 -04:00
whois Preserve test logs and test summary output for Kokoro CI runs 2016-10-14 16:57:43 -04:00
xjc Preserve test logs and test summary output for Kokoro CI runs 2016-10-14 16:57:43 -04:00
xml Preserve test logs and test summary output for Kokoro CI runs 2016-10-14 16:57:43 -04:00