mirror of
https://github.com/google/nomulus.git
synced 2025-05-02 13:07:50 +02:00
5a31be12ba
Up to now, our search wildcard rules have been that there must be an initial string of at least two characters. If a wildcard is present after that, it can optionally be followed by a suffix specifying the TLD (for domains) or domain (for nameservers). So domain queries can look like: example.tld ex* ex*.tld and nameserver queries can look like: ns1.example.tld ns*.example.tld ns* But you can't do a domain query for *.tld, nor a nameserver query for *.example.tld. It would be nice to support such queries, and the presence of a valid TLD or domain makes them relatively efficient. This CL relaxes the restrictions to allow wildcards with no initial string if the suffix is present. For nameservers, the suffix must be a valid domain in the system, to avoid having to loop through all nameservers. A side effect of the changes is to fix a shortcoming in the logic which caused wildcard nameserver searches to fail if the specified domain suffix referred to an external domain. Entity searches are not affected, since they do not support suffixes. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=159856563
106 lines
3.8 KiB
Java
106 lines
3.8 KiB
Java
// Copyright 2017 The Nomulus Authors. All Rights Reserved.
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package google.registry.rdap;
|
|
|
|
import static com.google.common.truth.Truth.assertThat;
|
|
|
|
import google.registry.request.HttpException.UnprocessableEntityException;
|
|
import google.registry.testing.ExceptionRule;
|
|
import org.junit.Rule;
|
|
import org.junit.Test;
|
|
import org.junit.runner.RunWith;
|
|
import org.junit.runners.JUnit4;
|
|
|
|
/** Unit tests for {@link RdapSearchPattern}. */
|
|
@RunWith(JUnit4.class)
|
|
public class RdapSearchPatternTest {
|
|
|
|
@Rule
|
|
public final ExceptionRule thrown = new ExceptionRule();
|
|
|
|
@Test
|
|
public void testNoWildcards_ok() throws Exception {
|
|
RdapSearchPattern rdapSearchPattern = RdapSearchPattern.create("example.lol", true);
|
|
assertThat(rdapSearchPattern.getInitialString()).isEqualTo("example.lol");
|
|
assertThat(rdapSearchPattern.getHasWildcard()).isFalse();
|
|
assertThat(rdapSearchPattern.getSuffix()).isNull();
|
|
}
|
|
|
|
@Test
|
|
public void testWildcardNoTld_ok() throws Exception {
|
|
RdapSearchPattern rdapSearchPattern = RdapSearchPattern.create("exam*", true);
|
|
assertThat(rdapSearchPattern.getInitialString()).isEqualTo("exam");
|
|
assertThat(rdapSearchPattern.getHasWildcard()).isTrue();
|
|
assertThat(rdapSearchPattern.getSuffix()).isNull();
|
|
}
|
|
|
|
@Test
|
|
public void testWildcardTld_ok() throws Exception {
|
|
RdapSearchPattern rdapSearchPattern = RdapSearchPattern.create("exam*.lol", true);
|
|
assertThat(rdapSearchPattern.getInitialString()).isEqualTo("exam");
|
|
assertThat(rdapSearchPattern.getHasWildcard()).isTrue();
|
|
assertThat(rdapSearchPattern.getSuffix()).isEqualTo("lol");
|
|
}
|
|
|
|
@Test
|
|
public void testMultipleWildcards_unprocessable() throws Exception {
|
|
thrown.expect(UnprocessableEntityException.class);
|
|
RdapSearchPattern.create("ex*am*.lol", true);
|
|
}
|
|
|
|
@Test
|
|
public void testWildcardNotAtEnd_unprocessable() throws Exception {
|
|
thrown.expect(UnprocessableEntityException.class);
|
|
RdapSearchPattern.create("ex*am", true);
|
|
}
|
|
|
|
@Test
|
|
public void testWildcardNotAtEndWithTld_unprocessable() throws Exception {
|
|
thrown.expect(UnprocessableEntityException.class);
|
|
RdapSearchPattern.create("ex*am.lol", true);
|
|
}
|
|
|
|
@Test
|
|
public void testShortString_ok() throws Exception {
|
|
RdapSearchPattern rdapSearchPattern = RdapSearchPattern.create("e", true);
|
|
assertThat(rdapSearchPattern.getInitialString()).isEqualTo("e");
|
|
assertThat(rdapSearchPattern.getHasWildcard()).isFalse();
|
|
assertThat(rdapSearchPattern.getSuffix()).isNull();
|
|
}
|
|
|
|
@Test
|
|
public void testZeroLengthSuffix_unprocessable() throws Exception {
|
|
thrown.expect(UnprocessableEntityException.class);
|
|
RdapSearchPattern.create("exam*.", true);
|
|
}
|
|
|
|
@Test
|
|
public void testDisallowedSuffix_unprocessable() throws Exception {
|
|
thrown.expect(UnprocessableEntityException.class);
|
|
RdapSearchPattern.create("exam*.lol", false);
|
|
}
|
|
|
|
@Test
|
|
public void testNextInitialString_alpha() throws Exception {
|
|
RdapSearchPattern rdapSearchPattern = RdapSearchPattern.create("exam*.lol", true);
|
|
assertThat(rdapSearchPattern.getNextInitialString()).isEqualTo("exan");
|
|
}
|
|
|
|
@Test
|
|
public void testNextInitialString_unicode() throws Exception {
|
|
RdapSearchPattern rdapSearchPattern = RdapSearchPattern.create("cat.みんな", true);
|
|
assertThat(rdapSearchPattern.getNextInitialString()).isEqualTo("cat.みんに");
|
|
}
|
|
}
|