zydronium/google-nomulus
1
0
Fork 0
mirror of https://github.com/google/nomulus.git synced 2025-05-02 04:57:51 +02:00
Code Issues Projects Releases Packages Wiki Activity
google-nomulus/java/google/registry/rde
History
guyben aee4f7acc2 Remove queueing from Lock 
It was buggy (didn't work) and was never actually used.

Why never actually used: for it to be used executeWithLock has to be called
with different requesters on the same lockId. That never happend in the code.

How it was buggy: Logically, the queue is deleted on release of the lock (meaning it was
meaningless the only time it mattered - when the lock isn't taken). In
addition, a different bug meant that having items in the queue prevented the
lock from being released forcing all other tasks to have to wait for lock
timeout even if the task that acquired the lock is long done.

Alternative: fix the queue. This would mean we don't want to delete the lock on release (since we want to keep the queue). Instead, we resave the same lock with expiration date being START_OF_TIME. In addition - we need to fix the .equals used to determine if the lock the same as the acquired lock - instead use some isSame function that ignores the queue.

Note: the queue is dangerous! An item (calling class / action) in the first place of a queue means no other calling class can get that lock. Everything is waiting for the first calling class to be re-run - but that might take a long time (depending on that action's rerun policy) and even might never happen (if for some reason that action decided it was no longer needed without acquiring the lock) - causing all other actions to stall forever!

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=163705463
2017-08-01 17:06:20 -04:00
..
imports Make Registrar load methods return Optionals instead of Nullables 2017-08-01 16:58:59 -04:00
BrdaCopyAction.java Change @Auth to an AutoValue, and created a set of predefined Auths 2017-08-01 16:33:10 -04:00
BUILD Change @Auth to an AutoValue, and created a set of predefined Auths 2017-08-01 16:33:10 -04:00
ContactResourceToXjcConverter.java Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
DepositFragment.java Refer to Datastore everywhere correctly by its capitalized form 2017-02-17 12:12:12 -05:00
DomainResourceToXjcConverter.java Remove obsolete TransferData.extendedRegistrationYears 2017-03-21 15:35:00 -04:00
EscrowTaskRunner.java Remove queueing from Lock 2017-08-01 17:06:20 -04:00
Ghostryde.java Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
HostResourceToXjcConverter.java Remove the ofy().load() inside of HostResource.cloneProjectedAtTime 2017-03-13 11:22:55 -04:00
JSchModule.java Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
JSchSftpChannel.java Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
JSchSshSession.java Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
package-info.java Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
PendingDeposit.java Allow RdeStagingAction to be invoked manually 2017-04-10 13:47:51 -04:00
PendingDepositChecker.java Refer to Datastore everywhere correctly by its capitalized form 2017-02-17 12:12:12 -05:00
RdeAdapter.java Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
RdeCounter.java Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
RdeMarshaller.java Add the ability to generate RDE deposits in lenient mode 2017-05-17 12:22:49 -04:00
RdeModule.java Add the ability to generate RDE deposits in lenient mode 2017-05-17 12:22:49 -04:00
RdeReportAction.java Change @Auth to an AutoValue, and created a set of predefined Auths 2017-08-01 16:33:10 -04:00
RdeReporter.java Remove an unused exception 2017-02-02 17:04:06 -05:00
RdeResourceType.java Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
RdeStagingAction.java Change @Auth to an AutoValue, and created a set of predefined Auths 2017-08-01 16:33:10 -04:00
RdeStagingMapper.java Cache Registrars in memory 2017-05-17 12:26:11 -04:00
RdeStagingReducer.java Remove queueing from Lock 2017-08-01 17:06:20 -04:00
RdeUploadAction.java Change @Auth to an AutoValue, and created a set of predefined Auths 2017-08-01 16:33:10 -04:00
RdeUploadUrl.java Use Immutable types for static final fields 2017-03-07 13:50:53 -05:00
RdeUtil.java Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
RegistrarToXjcConverter.java Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
RydePgpCompressionOutputStream.java Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
RydePgpEncryptionOutputStream.java Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
RydePgpFileOutputStream.java Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
RydePgpSigningOutputStream.java Update copyright year on all license headers 2017-02-02 16:27:22 -05:00
RydeTarOutputStream.java Update copyright year on all license headers 2017-02-02 16:27:22 -05:00