mirror of
https://github.com/google/nomulus.git
synced 2025-05-01 12:37:52 +02:00
ceb5c2117e
This disentangles GaeUserCredentials and UserService, which lets us remove a bunch of hacky and brittle code from LoginFlowViaConsoleTest. Previously, GaeUserCredentials was constructed for a user, but then was still directly calling UserService to check if the user was an admin. UserService can be adjusted in tests (via AppEngineRule / LocalServiceTestHelper) but it's a pain, especially to do dynamically within a single test file. The hacky code in LoginFlowViaConsoleTest was working around that restriction. With this CL, you can pass into GaeUserCredentials whether the user is an admin or not (for testing) or construct one directly from a UserService object (for production, and for convenience in tests using an AppEngineRule user). Note that I also changed EppConsoleAction to @Inject UserService. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=132696391
68 lines
2.6 KiB
Java
68 lines
2.6 KiB
Java
// Copyright 2016 The Domain Registry Authors. All Rights Reserved.
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
|
|
package google.registry.flows;
|
|
import static com.google.appengine.api.users.UserServiceFactory.getUserService;
|
|
import static com.google.common.truth.Truth.assertThat;
|
|
import static java.nio.charset.StandardCharsets.UTF_8;
|
|
import static org.mockito.Matchers.eq;
|
|
import static org.mockito.Mockito.mock;
|
|
import static org.mockito.Mockito.verify;
|
|
|
|
import google.registry.testing.AppEngineRule;
|
|
import google.registry.testing.FakeHttpSession;
|
|
import google.registry.testing.ShardableTestCase;
|
|
import google.registry.testing.UserInfo;
|
|
import org.junit.Rule;
|
|
import org.junit.Test;
|
|
import org.junit.runner.RunWith;
|
|
import org.junit.runners.JUnit4;
|
|
import org.mockito.ArgumentCaptor;
|
|
|
|
/** Tests for {@link EppConsoleAction}. */
|
|
@RunWith(JUnit4.class)
|
|
public class EppConsoleActionTest extends ShardableTestCase {
|
|
|
|
private static final byte[] INPUT_XML_BYTES = "<xml>".getBytes(UTF_8);
|
|
|
|
@Rule
|
|
public final AppEngineRule appEngine = AppEngineRule.builder()
|
|
.withUserService(UserInfo.create("person@example.com", "12345"))
|
|
.build();
|
|
|
|
@Test
|
|
public void testAction() {
|
|
EppConsoleAction action = new EppConsoleAction();
|
|
action.inputXmlBytes = INPUT_XML_BYTES;
|
|
action.session = new FakeHttpSession();
|
|
action.session.setAttribute("CLIENT_ID", "ClientIdentifier");
|
|
action.eppRequestHandler = mock(EppRequestHandler.class);
|
|
action.userService = getUserService();
|
|
action.run();
|
|
ArgumentCaptor<TransportCredentials> credentialsCaptor =
|
|
ArgumentCaptor.forClass(TransportCredentials.class);
|
|
ArgumentCaptor<SessionMetadata> metadataCaptor = ArgumentCaptor.forClass(SessionMetadata.class);
|
|
verify(action.eppRequestHandler).executeEpp(
|
|
metadataCaptor.capture(),
|
|
credentialsCaptor.capture(),
|
|
eq(EppRequestSource.CONSOLE),
|
|
eq(false),
|
|
eq(false),
|
|
eq(INPUT_XML_BYTES));
|
|
assertThat(((GaeUserCredentials) credentialsCaptor.getValue()).getUser().getEmail())
|
|
.isEqualTo("person@example.com");
|
|
assertThat(metadataCaptor.getValue().getClientId()).isEqualTo("ClientIdentifier");
|
|
}
|
|
}
|