mirror of
https://github.com/google/nomulus.git
synced 2025-05-07 15:28:22 +02:00
8f456bcf64
You don't want to use the cache when loading them for the purposes of updating them, but you definitely do still want to use the cache when checking the price of individual domains. In [] the cache clearing of premium lists on update was removed. This is a good thing in aggregate because the cache is per-instance and thus misleading, but it also caused us to not be able to update the same premium list twice within an hour because the second update would hit a "PremiumList was concurrently edited" exception, owing to first loading the stale version from the cache for the purposes of updating it. Now we bypass the cache for that purpose. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=197768142
72 lines
3.1 KiB
Java
72 lines
3.1 KiB
Java
// Copyright 2017 The Nomulus Authors. All Rights Reserved.
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package google.registry.tools;
|
|
|
|
import static com.google.common.truth.Truth.assertThat;
|
|
import static com.google.common.truth.Truth8.assertThat;
|
|
import static google.registry.model.ofy.ObjectifyService.ofy;
|
|
import static google.registry.testing.DatastoreHelper.createTld;
|
|
import static google.registry.testing.DatastoreHelper.loadPremiumListEntries;
|
|
import static google.registry.testing.DatastoreHelper.persistPremiumList;
|
|
import static google.registry.testing.DatastoreHelper.persistResource;
|
|
import static google.registry.testing.JUnitBackports.assertThrows;
|
|
|
|
import google.registry.model.registry.Registry;
|
|
import google.registry.model.registry.label.PremiumList;
|
|
import google.registry.model.registry.label.PremiumList.PremiumListEntry;
|
|
import org.junit.Test;
|
|
|
|
/** Unit tests for {@link DeletePremiumListCommand}. */
|
|
public class DeletePremiumListCommandTest extends CommandTestCase<DeletePremiumListCommand> {
|
|
|
|
@Test
|
|
public void testSuccess() throws Exception {
|
|
PremiumList premiumList = persistPremiumList("xn--q9jyb4c", "blah,USD 100");
|
|
assertThat(loadPremiumListEntries(premiumList)).hasSize(1);
|
|
runCommand("--force", "--name=xn--q9jyb4c");
|
|
assertThat(PremiumList.getUncached("xn--q9jyb4c")).isEmpty();
|
|
|
|
// Ensure that the Datastore premium list entry entities were deleted correctly.
|
|
assertThat(ofy().load()
|
|
.type(PremiumListEntry.class)
|
|
.ancestor(premiumList.getRevisionKey())
|
|
.keys())
|
|
.isEmpty();
|
|
}
|
|
|
|
@Test
|
|
public void testFailure_whenPremiumListDoesNotExist() throws Exception {
|
|
IllegalArgumentException thrown =
|
|
assertThrows(IllegalArgumentException.class, () -> runCommandForced("--name=foo"));
|
|
assertThat(thrown)
|
|
.hasMessageThat()
|
|
.contains("Cannot delete the premium list foo because it doesn't exist.");
|
|
}
|
|
|
|
@Test
|
|
public void testFailure_whenPremiumListIsInUse() throws Exception {
|
|
PremiumList premiumList = persistPremiumList("xn--q9jyb4c", "blah,USD 100");
|
|
createTld("xn--q9jyb4c");
|
|
persistResource(Registry.get("xn--q9jyb4c").asBuilder().setPremiumList(premiumList).build());
|
|
IllegalArgumentException thrown =
|
|
assertThrows(
|
|
IllegalArgumentException.class,
|
|
() -> runCommandForced("--name=" + premiumList.getName()));
|
|
assertThat(PremiumList.getUncached(premiumList.getName())).isPresent();
|
|
assertThat(thrown)
|
|
.hasMessageThat()
|
|
.isEqualTo("Cannot delete premium list because it is used on these tld(s): xn--q9jyb4c");
|
|
}
|
|
}
|