mirror of
https://github.com/google/nomulus.git
synced 2025-04-30 12:07:51 +02:00
I'm actually surprised that we had this in our code, as it seems like a huge oversight, but we were individually loading each and every referenced contact and host during domain/application create/update/allocate flows. Loading them all as a single batch should reduce round trips to Datastore by a good deal, thus improving performance. We aren't giving up any transactional consistency in doing so and the only potential downside I can think of is that we're always loading all contacts/ hosts instead of only some of them, in the rare case that one of the earlier contacts/hosts is actually in pending delete (which allowed short-circuiting). However, the gains from only making one round-trip should swamp the potential losses in occasionally loading more data than is strictly necessary. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=186656118 |
||
---|---|---|
.. | ||
com/google/testing/builddefs | ||
google/registry |