mirror of
https://github.com/google/nomulus.git
synced 2025-05-02 04:57:51 +02:00
3d5a6b808c
We can easily end up enlisting too many entity groups (separate DomainApplications) in a TransactionalFlow when loading all applications tracked by the DomainApplicationIndex. This makes the load operation transactionless, to avoid overenlisting. Potential problems: 1. We fail to prevent landrush applications, if a single sunrise application exists. This is likely fine, except for a brief moment in Sunrush when a sunrise application is made immediately prior to a landrush application. The result is we accept an invalid application- which can be mediated manually. 2. We fail to prevent a domain create for a domain with an open application. This is a little more sinister, but also unlikely unless someone submits an application immediately before someone tries to create the same domain (sans application?) 3. We return an invalid DomainCheck response (instead of 'pending allocation'). Not the worst outcome. 4. We reduce the AuctionStatusCommand and GetApplicationIdsCommand to eventual consistency. Since they're internal tools, that's not too big a deal. A better solution: DomainApplications really should just be normalized under a virtualEntityGroup by fullyQualifiedDomainName, or a hash-bucket like EppResources are. The DomainApplication -> DomainBase -> EppResource hierarchy seems to be purely for code reuse, at the cost of Datastore consistency. This would, however, require quite some refactoring, and a custom resave operation across all DomainApplications. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=169395586 |
||
|---|---|---|
| .. | ||
| annotations | ||
| billing | ||
| common | ||
| contact | ||
| domain | ||
| eppcommon | ||
| eppinput | ||
| eppoutput | ||
| host | ||
| index | ||
| mark | ||
| ofy | ||
| poll | ||
| pricing | ||
| rde | ||
| registrar | ||
| registry | ||
| reporting | ||
| server | ||
| smd | ||
| tmch | ||
| transfer | ||
| translators | ||
| BackupGroupRoot.java | ||
| BUILD | ||
| Buildable.java | ||
| CacheUtils.java | ||
| CreateAutoTimestamp.java | ||
| EntityClasses.java | ||
| EppResource.java | ||
| EppResourceUtils.java | ||
| ImmutableObject.java | ||
| Jsonifiable.java | ||
| JsonMapBuilder.java | ||
| ModelUtils.java | ||
| package-info.java | ||
| SchemaVersion.java | ||
| UpdateAutoTimestamp.java | ||